{"id":2196842,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196842/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-47-e676662e4514@redhat.com>","date":"2026-02-16T11:15:36","name":"[47/85] audio/oss: convert to QOM lifecycle methods","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"baca6054273fd7310860ef1bb7fa01bea9428d42","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-47-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196842/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JrSvBeQm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0ng4Wjgz1xwF\n\tfor ; Mon, 16 Feb 2026 22:25:43 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfG-0005EL-4D; Mon, 16 Feb 2026 06:21:18 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwc5-0006Ol-2v\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:04 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwc1-00089Q-Q8\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:00 -0500","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-xBxOfUlKOMW5imetpbPsyw-1; Mon,\n 16 Feb 2026 06:17:52 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 3AB731800367; Mon, 16 Feb 2026 11:17:50 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 44DED30001A5; Mon, 16 Feb 2026 11:17:49 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240675;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=FEm66eRxFketQFIgeZBzb+TUChBafUGfeNq/IMh5ojk=;\n b=JrSvBeQmc6eU6zJa+kzPxRizcsgyKPL9P0kByv1wD9455qpiuTRyEgjb3i8hEMmEpbt4g+\n Z+uz5dzV7foteG1EsuEj+9IllMb/D7iPXTuc6CRUtjuINj4uAXyrUbcvpiHF0cAynIYhgY\n Qj6HPyZwvdxxUTwR+t2zdss97c3L3H0=","X-MC-Unique":"xBxOfUlKOMW5imetpbPsyw-1","X-Mimecast-MFC-AGG-ID":"xBxOfUlKOMW5imetpbPsyw_1771240670","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:36 +0100","Subject":"[PATCH 47/85] audio/oss: convert to QOM lifecycle methods","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-47-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4118;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=WSaswajA4EH4bQvF1yrHLLnXVV/md1CQHXeFT1moIKg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQCWIyFxILKTEM9E5I8G/E+JA2cKon2GziR\n 0mw2ZgO4GSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5ZVrD/0aE3LDDMhOs8tIc36loNx326609rrLev+SeQjQ0OvkE4fitDeY+ZFjvSOBJeldk0Ejgub\n I9HpvWfasNhPnn+bqhx85dWEYPgtBsGilDfAtXxUfqbr4+aowcYk9hBdgLGexX2MrxkYuSe3Rj7\n jfEMvY9j3+49VHu9Om6Xg78NmpRK973xo/J9DSqOrx4EYegsQ5uOqVJmkSErSMJy/CiS3sFYJNG\n CGz5h5dQbONyMNtEdt4ipcRvjeWbr2MS1UvzC9EE455qO/2iD8WtgXENaLaZuXFw/DVmvokB/vu\n d9RoFfLmd3zUbYmIqY+8JahHoLYZzJjFTKu63jlTmdzkq92QWLmJXm++yDDPGg1wAFc/lrlXYIf\n EYuOtGM4VG7JYV2z0lwyxsR0wvIvIHcZY4xarj8LDzCigFfR7VxA2WGWqHyMC0fSdv/kFgWaiIN\n 6PEUG9CBh2H7JT+IJBhr2TcSUWgk+gcjdW5LYOuQb1n+KjiJT/bW1Bwusc0zhMh2HMDqal2aIzZ\n kx6psFeNh4ykZjNyCDxircAghw8RfNq5QUbssv1zWtcyz2LoY0n+r7ubnnyqvADJc7bBOOHh3Ry\n jjgSM2MmyV4y7BWVhvZ1+CIY8VrGZLHFR+JbYoXAw7MC62i90qgTFnXPOzSwLBrCT9/aHmDqQxv\n M+pD4POPkumPXNw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Migrate the OSS audio backend from the legacy driver init/fini\ncallbacks to proper QOM realize method.\n\nThe oss_audio_init() function is replaced with audio_oss_realize(),\nwhich performs the same device accessibility check before delegating\nto the parent class realize method. The empty oss_audio_fini() is\nremoved.\n\nAccess to the Audiodev is now through hw->s->dev instead of the\ndrv_opaque pointer.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/ossaudio.c | 41 +++++++++++++++++++++++------------------\n 1 file changed, 23 insertions(+), 18 deletions(-)","diff":"diff --git a/audio/ossaudio.c b/audio/ossaudio.c\nindex f64c564e345..fedd2bbd722 100644\n--- a/audio/ossaudio.c\n+++ b/audio/ossaudio.c\n@@ -23,6 +23,7 @@\n */\n \n #include \"qemu/osdep.h\"\n+#include \"qapi-types-audio.h\"\n #include \n #include \n #include \"qemu/main-loop.h\"\n@@ -39,19 +40,14 @@\n #define TYPE_AUDIO_OSS \"audio-oss\"\n OBJECT_DECLARE_SIMPLE_TYPE(AudioOss, AUDIO_OSS)\n \n+static AudioBackendClass *audio_oss_parent_class;\n+\n struct AudioOss {\n AudioMixengBackend parent_obj;\n };\n \n static struct audio_driver oss_audio_driver;\n \n-static void audio_oss_class_init(ObjectClass *klass, const void *data)\n-{\n- AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n-\n- k->driver = &oss_audio_driver;\n-}\n-\n #if defined OSS_GETVERSION && defined SNDCTL_DSP_POLICY\n #define USE_DSP_POLICY\n #endif\n@@ -505,7 +501,7 @@ static int oss_init_out(HWVoiceOut *hw, struct audsettings *as,\n int err;\n int fd;\n struct audsettings obt_as;\n- Audiodev *dev = drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n AudiodevOssOptions *oopts = &dev->u.oss;\n \n oss->fd = -1;\n@@ -636,7 +632,7 @@ static int oss_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque)\n int err;\n int fd;\n struct audsettings obt_as;\n- Audiodev *dev = drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n \n oss->fd = -1;\n \n@@ -737,7 +733,8 @@ static void oss_init_per_direction(AudiodevOssPerDirectionOptions *opdo)\n }\n }\n \n-static void *oss_audio_init(Audiodev *dev, Error **errp)\n+static bool\n+audio_oss_realize(AudioBackend *abe, Audiodev *dev, Error **errp)\n {\n AudiodevOssOptions *oopts;\n assert(dev->driver == AUDIODEV_DRIVER_OSS);\n@@ -748,17 +745,16 @@ static void *oss_audio_init(Audiodev *dev, Error **errp)\n \n if (access(oopts->in->dev ?: \"/dev/dsp\", R_OK | W_OK) < 0) {\n error_setg_errno(errp, errno, \"%s not accessible\", oopts->in->dev ?: \"/dev/dsp\");\n- return NULL;\n+ qapi_free_Audiodev(dev);\n+ return false;\n }\n if (access(oopts->out->dev ?: \"/dev/dsp\", R_OK | W_OK) < 0) {\n error_setg_errno(errp, errno, \"%s not accessible\", oopts->out->dev ?: \"/dev/dsp\");\n- return NULL;\n+ qapi_free_Audiodev(dev);\n+ return false;\n }\n- return dev;\n-}\n \n-static void oss_audio_fini (void *opaque)\n-{\n+ return audio_oss_parent_class->realize(abe, dev, errp);\n }\n \n static struct audio_pcm_ops oss_pcm_ops = {\n@@ -780,8 +776,6 @@ static struct audio_pcm_ops oss_pcm_ops = {\n \n static struct audio_driver oss_audio_driver = {\n .name = \"oss\",\n- .init = oss_audio_init,\n- .fini = oss_audio_fini,\n .pcm_ops = &oss_pcm_ops,\n .max_voices_out = INT_MAX,\n .max_voices_in = INT_MAX,\n@@ -789,6 +783,17 @@ static struct audio_driver oss_audio_driver = {\n .voice_size_in = sizeof (OSSVoiceIn)\n };\n \n+static void audio_oss_class_init(ObjectClass *klass, const void *data)\n+{\n+ AudioBackendClass *b = AUDIO_BACKEND_CLASS(klass);\n+ AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n+\n+ audio_oss_parent_class = AUDIO_BACKEND_CLASS(object_class_get_parent(klass));\n+\n+ b->realize = audio_oss_realize;\n+ k->driver = &oss_audio_driver;\n+}\n+\n static const TypeInfo audio_types[] = {\n {\n .name = TYPE_AUDIO_OSS,\n","prefixes":["47/85"]}