{"id":2196839,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196839/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-58-e676662e4514@redhat.com>","date":"2026-02-16T11:15:47","name":"[58/85] audio: constify some add_capture() arguments","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"444f61d06cc16a553da711df5c7c887914ec0fba","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-58-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196839/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DwePrjy0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0lr3Rg4z1xpY\n\tfor ; Mon, 16 Feb 2026 22:24:08 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfR-00078N-PL; Mon, 16 Feb 2026 06:21:29 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwcc-0006rw-Ot\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:37 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwcY-0008FY-Fy\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:32 -0500","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-4Mdc60m7N4qGHae_LRbnYA-1; Mon,\n 16 Feb 2026 06:18:24 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 14DB918003F5; Mon, 16 Feb 2026 11:18:22 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id CACD719560AD; Mon, 16 Feb 2026 11:18:20 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240707;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=YN4DJG0Py/cRgpapumSpUdL2yVxH+gWGCGJxHSN+2zE=;\n b=DwePrjy01C/PcMXtUg2VqyWV8sGTQDoiihw9zElUNYc1jCW7F1B0ZVDB47rIdQWJnEsd8r\n xnxiR/dhFxkvaUYBStkTKQCPR+IiqBD4I10rvxEWYZyl4GyrtCetvy3jPmddVBfbRoJsbj\n 3B6/zZ0385dY6FR9gmrSd+inPPpcZqc=","X-MC-Unique":"4Mdc60m7N4qGHae_LRbnYA-1","X-Mimecast-MFC-AGG-ID":"4Mdc60m7N4qGHae_LRbnYA_1771240702","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:47 +0100","Subject":"[PATCH 58/85] audio: constify some add_capture() arguments","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-58-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3590;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=2WNGqq2fzWN/830O7ChQYzY+xt6tqSyBcFbWMnGS2jY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxR7PS+Liz5OHdTZgYxmGunCMhPI1sIv7R83\n 2gdpHSlZyWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UQAKCRDa6OEJdZac\n 5ZArEACI8UXpWfYt6lXaTLbKyhcdsQuvBXmmFu01HPZByLx2siMY2TlqLfT9E+TReN+4UcmrUGp\n k5v9RZqDTOAN3HTf05sN8RD5KuEjxFL47DU+lVLc725MD3Q18niFkz3pu5aQlZ/glEobjGuKYdl\n Cpij8jPqjfhY/g4mJaXcSerdEjAfJoop/jEtjicYw69SuWQuN3w1iDL8DbFpjzWwz2+CUrOyUCe\n AKxB4CYC6WDT1ZI3uoVfmf3zY/cVekQYhwbxugghgpbquUEFjlMTFfTYmcwwAhLsFuP7zD2Jcsp\n Avi4wOSyizumftwoYEpWqtqyi5F3grTAAgAIOtfs0A9ea8g+bB9H0QJj1lVlFN8c54lhZtcbYu1\n eB+usxnAeMUL0TRWaIyCVF/yu4WBsW3cL4tpSqNhJcwTmVAOpr7kYv7e609DVa6oEBf++I9VPnE\n 9OaMYdPSqLMFU4pRhuyoXhhRNhWmwxTU52sHo/mZ9r5H9Ss91yaf0jm2jvUZrqBKKZDLI8yG1kX\n BPZ57e027Fc8wxeYqopZMnAYr+WcAdUipfXgAVSHMSrliOlL4QfsA0WDJuBTeeQXXNhWpOa2IEs\n hrGCYEil/B7jjCV7tQV7y61ODdazEjuyY6j/CApH1fHA6tTscMVyYjeASkIBpDiua2uAO7EEpNP\n XmY2cNhK9RL/GAQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n include/qemu/audio-capture.h | 4 ++--\n include/qemu/audio.h | 4 ++--\n audio/audio-be.c | 4 ++--\n audio/audio-mixeng-be.c | 10 +++++-----\n 4 files changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/include/qemu/audio-capture.h b/include/qemu/audio-capture.h\nindex d7998232243..f1319c90020 100644\n--- a/include/qemu/audio-capture.h\n+++ b/include/qemu/audio-capture.h\n@@ -21,8 +21,8 @@ typedef struct CaptureState {\n \n CaptureVoiceOut *audio_be_add_capture(\n AudioBackend *be,\n- struct audsettings *as,\n- struct audio_capture_ops *ops,\n+ const struct audsettings *as,\n+ const struct audio_capture_ops *ops,\n void *opaque);\n \n void audio_be_del_capture(\ndiff --git a/include/qemu/audio.h b/include/qemu/audio.h\nindex dfe247ab8c4..b6b6ee9b560 100644\n--- a/include/qemu/audio.h\n+++ b/include/qemu/audio.h\n@@ -96,8 +96,8 @@ typedef struct AudioBackendClass {\n size_t (*read)(AudioBackend *be, SWVoiceIn *sw, void *buf, size_t size);\n int (*get_buffer_size_out)(AudioBackend *be, SWVoiceOut *sw);\n CaptureVoiceOut *(*add_capture)(AudioBackend *be,\n- struct audsettings *as,\n- struct audio_capture_ops *ops,\n+ const struct audsettings *as,\n+ const struct audio_capture_ops *ops,\n void *cb_opaque);\n void (*del_capture)(AudioBackend *be, CaptureVoiceOut *cap, void *cb_opaque);\n \ndiff --git a/audio/audio-be.c b/audio/audio-be.c\nindex 8094a3196c7..ee065fa4968 100644\n--- a/audio/audio-be.c\n+++ b/audio/audio-be.c\n@@ -182,8 +182,8 @@ void audio_be_set_volume_in(AudioBackend *be, SWVoiceIn *sw, Volume *vol)\n \n CaptureVoiceOut *audio_be_add_capture(\n AudioBackend *be,\n- struct audsettings *as,\n- struct audio_capture_ops *ops,\n+ const struct audsettings *as,\n+ const struct audio_capture_ops *ops,\n void *cb_opaque)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\ndiff --git a/audio/audio-mixeng-be.c b/audio/audio-mixeng-be.c\nindex 17301ec80e7..d02cfe3c509 100644\n--- a/audio/audio-mixeng-be.c\n+++ b/audio/audio-mixeng-be.c\n@@ -314,7 +314,7 @@ void audio_pcm_info_clear_buf (struct audio_pcm_info *info, void *buf, int len)\n * Capture\n */\n static CaptureVoiceOut *audio_pcm_capture_find_specific(AudioMixengBackend *s,\n- struct audsettings *as)\n+ const struct audsettings *as)\n {\n CaptureVoiceOut *cap;\n \n@@ -1585,8 +1585,8 @@ static const char *audio_mixeng_backend_get_id(AudioBackend *be)\n \n static CaptureVoiceOut *audio_mixeng_backend_add_capture(\n AudioBackend *be,\n- struct audsettings *as,\n- struct audio_capture_ops *ops,\n+ const struct audsettings *as,\n+ const struct audio_capture_ops *ops,\n void *cb_opaque);\n \n static void audio_mixeng_backend_del_capture(\n@@ -1710,8 +1710,8 @@ static const VMStateDescription vmstate_audio = {\n \n static CaptureVoiceOut *audio_mixeng_backend_add_capture(\n AudioBackend *be,\n- struct audsettings *as,\n- struct audio_capture_ops *ops,\n+ const struct audsettings *as,\n+ const struct audio_capture_ops *ops,\n void *cb_opaque)\n {\n AudioMixengBackend *s = AUDIO_MIXENG_BACKEND(be);\n","prefixes":["58/85"]}