{"id":2196831,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196831/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-30-e676662e4514@redhat.com>","date":"2026-02-16T11:15:19","name":"[30/85] audio: keep a strong reference on the backend","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7953b7f9eab759ff3d886c0b0e98dc3481660ce9","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-30-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196831/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=URwOuUP2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0lJ5Kbcz1xpY\n\tfor ; Mon, 16 Feb 2026 22:23:40 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrweE-0002iT-TF; Mon, 16 Feb 2026 06:20:14 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwbR-0005ep-Nk\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:24 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwbL-0007jM-J3\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:18 -0500","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-m-MpTFXUMRe-ryKWk1KUUg-1; Mon,\n 16 Feb 2026 06:17:03 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AC38A1955D80; Mon, 16 Feb 2026 11:17:01 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0E8AC30001B9; Mon, 16 Feb 2026 11:17:00 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240627;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DqjVCvkYq0CnOFlMb4lk6iKs2Q8rG2tOtpRbxTNBD88=;\n b=URwOuUP23y3wuQTVphFC+p0HTL4Rj5pvBkQcZYb9TBcOsmBV80PlPMz5OA4hZsUTrNIbv7\n w8KWNeZHqCtzKI0T/QT6X0e036RmnTu9NWK3VYXR3tY4X86uO94M7d1vsTrE2gkUNQ77Vu\n DnMJkl+aVJ7k1tWE/JbsXJnAymqsyqA=","X-MC-Unique":"m-MpTFXUMRe-ryKWk1KUUg-1","X-Mimecast-MFC-AGG-ID":"m-MpTFXUMRe-ryKWk1KUUg_1771240621","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:19 +0100","Subject":"[PATCH 30/85] audio: keep a strong reference on the backend","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-30-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2152;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=j2F0g3ta9yfDCkXiVp5Fmy/cGNEHqdhYISO5JqmAXcg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxPIK7Ptx6NOV4c/yjxXVCio1QtyWaBS06Mx\n 6Fnq6zEKoaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TwAKCRDa6OEJdZac\n 5fcNEACKgcbXrWgakQ8Z15q72T7ophiX9Uu7+hd2m/Xe96tMLXScVS/lDaVNIe9SKlvh8XMPArb\n 2ugRGKYmA/Sq+IWgTcR1k+NOZiRluMTWTDtt2bTAqB+fB+1qP4mgb0agGWEJvR8MMh/KpY12Ja3\n I0Wx+EJr1GKPZiJmZgkljA2/VQ7x3PMp5TNiiXmc/UAnuSxN1GFLafY82pLfF9Bcic2rr/s4kMN\n cjuaVlfSYCY0JH8DGZkc1+nqyfDOe0UOi0QQmQlC/p42JiblOYWYEMKCuPBaTMpJhJqvRkMVsfA\n D0FJAnNvoGT21iNZ2KUjg3+/LtUIC7RTjUdxNsGURXvGynBZpZRpvMp3lW0Zi2FxE1uLLDyTSf5\n 8WDXUQKuunIWyfOewQoB3qbvaAis+I0sOPODzh80zHY8xrS+9hus+Oo3gaMrQiOETVOGVasT9Nk\n D4UaqO7o7o7zQ1paL+LXTQPPhmHymdIIVpSCmpys2LjcU4bFVkeM/rXehKHw2sl6d7/GVKpQZf4\n iZ5IM51clSsBwYP6100G4Rm7d0p7U85QOCE2jWrcCE3bXbsHhT44bYnTOEOHzVzAPN/OhbMoiBB\n yP1SelUi7ra37Ox2AEg6VKO5hKJXN8H/s0qRX4VxLxyU0jl5x5cRjt/nO0gWupXNm2SLBev4EUL\n Gt0LWtDg6B3gIgw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Since we are going to convert audio_driver-based backends, we need to\nproperly handle reference counting to allow for a different order of\nclass finalization (for example, pulse class before base driver class).\n\nSigned-off-by: Marc-André Lureau \n---\n audio/audio_template.h | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/audio/audio_template.h b/audio/audio_template.h\nindex a1f78d8748b..512abbfe22f 100644\n--- a/audio/audio_template.h\n+++ b/audio/audio_template.h\n@@ -231,6 +231,7 @@ static void glue (audio_pcm_hw_gc_, TYPE) (HW **hwp)\n glue(hw->pcm_ops->fini_, TYPE) (hw);\n glue(s->nb_hw_voices_, TYPE) += 1;\n glue(audio_pcm_hw_free_resources_ , TYPE) (hw);\n+ object_unref(hw->s);\n g_free(hw);\n *hwp = NULL;\n }\n@@ -287,7 +288,7 @@ static HW *glue(audio_pcm_hw_add_new_, TYPE)(AudioMixengBackend *s,\n * is guaranteed to be != 0. See the audio_init_nb_voices_* functions.\n */\n hw = g_malloc0(glue(drv->voice_size_, TYPE));\n- hw->s = s;\n+ hw->s = AUDIO_MIXENG_BACKEND(object_ref(s));\n hw->pcm_ops = drv->pcm_ops;\n \n QLIST_INIT (&hw->sw_head);\n@@ -335,6 +336,7 @@ static HW *glue(audio_pcm_hw_add_new_, TYPE)(AudioMixengBackend *s,\n err1:\n glue (hw->pcm_ops->fini_, TYPE) (hw);\n err0:\n+ object_unref(hw->s);\n g_free (hw);\n return NULL;\n }\n@@ -441,7 +443,7 @@ static SW *glue(audio_pcm_create_voice_pair_, TYPE)(\n }\n \n sw = g_new0(SW, 1);\n- sw->s = s;\n+ sw->s = AUDIO_MIXENG_BACKEND(object_ref(s));\n \n hw = glue(audio_pcm_hw_add_, TYPE)(s, &hw_as);\n if (!hw) {\n@@ -461,6 +463,7 @@ err2:\n glue (audio_pcm_hw_del_sw_, TYPE) (sw);\n glue (audio_pcm_hw_gc_, TYPE) (&hw);\n err1:\n+ object_unref(sw->s);\n g_free(sw);\n return NULL;\n }\n@@ -470,6 +473,8 @@ static void glue (audio_close_, TYPE) (SW *sw)\n glue (audio_pcm_sw_fini_, TYPE) (sw);\n glue (audio_pcm_hw_del_sw_, TYPE) (sw);\n glue (audio_pcm_hw_gc_, TYPE) (&sw->hw);\n+\n+ object_unref(sw->s);\n g_free (sw);\n }\n \n","prefixes":["30/85"]}