{"id":2196825,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196825/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-41-e676662e4514@redhat.com>","date":"2026-02-16T11:15:30","name":"[41/85] audio: make audio_driver init() & fini() optional","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6cdf5aedc92c79544b2bc3d7a1ca7afb907c72bb","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-41-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196825/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fewvYkhq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0kF4fbQz1xpY\n\tfor ; Mon, 16 Feb 2026 22:22:45 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrweE-0002hq-8Z; Mon, 16 Feb 2026 06:20:14 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwbu-0006B2-Dz\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:51 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwbo-00085t-9s\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:49 -0500","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-OyzgE7IpMM2b6tCvuj9R3Q-1; Mon,\n 16 Feb 2026 06:17:35 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 21D4A19560AA; Mon, 16 Feb 2026 11:17:33 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7902030001A5; Mon, 16 Feb 2026 11:17:32 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240658;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=WtzBFPtZnBgBep7PFOTmKmy8bJLlcZgL5VlJnM7+pJ0=;\n b=fewvYkhqYEDmCI7gNbUUPvfaoMZlrQYlhcKXTlyFdaxUAUrzibHraL821YbzcLSp8Y+8bF\n cvaweGlFnzw+4QpwMl5xpIivZkj8cpGv1qYYs2z1eFokmhF2ClfpKwbzjChynYE7wOYwrp\n /cHgeyoI0Y3HcEE3WBW48eLNA+L+IRk=","X-MC-Unique":"OyzgE7IpMM2b6tCvuj9R3Q-1","X-Mimecast-MFC-AGG-ID":"OyzgE7IpMM2b6tCvuj9R3Q_1771240653","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:30 +0100","Subject":"[PATCH 41/85] audio: make audio_driver init() & fini() optional","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-41-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1273;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=XQa2aioA9AFhg3/Oy50D65dq2g48xqh2ie7D90kz/0Q=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQcgsxG/QPT1xwp6eTSva+fkwZaMPVgDQ5s\n tdKRSBWNNuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5RrbEAC6nuwwg50L+LZw27hDN+5qNR4U4jwGL9q6Dg0pxY1loNf3ojd3vqw8UrE51gQPdQpEX12\n WfA2XEoSjxZ4qvwU8Q6CcvMXM03QGeRuDkYZpRy9ynry6jx1e+5+0/dMIzzd/IybXsRQnrADoDX\n 9IbM243vhrMwoUUmlL9Er/+VM2764zELP3e2fsym3lXGOwGKyYt1ddmv6Jm0i8CKqVxlTwbRtRN\n XHF1MQATkyWwnhHFXMH5o22Y/y0sLCqFxyyd8YGYykG6j53OvvIB/tBF9XGo9rVZiDDFMnrKywB\n xYf8TBdBU7xEJeccI/nMyNgDrcWHK1XaZF/6aWPUY4cXYVz2z4n8vtpXxwE3aKPlk2i68EfaxNY\n pD4u3r0XF5f6kYpdCHAVUl1GDoFpU7oOFmM16ViX05+wx2udhBdD0uqEK/iLraVQy+iuVBcrU/2\n 6SVVPRbdDmX9EOGuRqIdGP2eNyLjzHI4X57LHB8DNb++KjAI8hA8CN1mPl5htrWFnsv1q28iAGD\n B57bJXSc8kvN+JcDRH3Xgb+Srkn987dEYWP4jooaqLQ5t0S5DLUOIhIHNxatH0I4fpvkkQ5XlKz\n EH23S0CKio0QEk0+6+PzJAXwycG8iNqut9ReKKDcJfFnCsJ4HA8zFBejrP0oD/J9fpl34Q+YmIG\n GuvJIamUvPR7qPA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The next patches are going to remove usage of the driver callbacks in\nfavor of QOM realize/finalize.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/audio-mixeng-be.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)","diff":"diff --git a/audio/audio-mixeng-be.c b/audio/audio-mixeng-be.c\nindex f906c84bf7c..45873646b3c 100644\n--- a/audio/audio-mixeng-be.c\n+++ b/audio/audio-mixeng-be.c\n@@ -1521,9 +1521,11 @@ static bool audio_mixeng_backend_realize(AudioBackend *abe,\n audio_driver *drv = AUDIO_MIXENG_BACKEND_GET_CLASS(be)->driver;\n \n be->dev = dev;\n- be->drv_opaque = drv->init(be->dev, errp);\n- if (!be->drv_opaque) {\n- return false;\n+ if (drv->init != NULL) {\n+ be->drv_opaque = drv->init(be->dev, errp);\n+ if (!be->drv_opaque) {\n+ return false;\n+ }\n }\n \n if (!drv->pcm_ops->get_buffer_in) {\n@@ -1664,7 +1666,9 @@ static void audio_mixeng_backend_finalize(Object *obj)\n }\n \n if (s->drv) {\n- s->drv->fini (s->drv_opaque);\n+ if (s->drv->fini) {\n+ s->drv->fini (s->drv_opaque);\n+ }\n s->drv = NULL;\n }\n \n","prefixes":["41/85"]}