{"id":2196820,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196820/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-23-e676662e4514@redhat.com>","date":"2026-02-16T11:15:12","name":"[23/85] audio: move object creation to audio_driver_init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c95101c8f9783f2c698acfbdfb02adaf50b5d9cb","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-23-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196820/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Yqd6QqBN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0jN5tn3z1xpY\n\tfor ; Mon, 16 Feb 2026 22:22:00 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrweC-0002O6-MZ; Mon, 16 Feb 2026 06:20:12 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwb3-0005Or-M3\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:05 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwav-0007Uc-P8\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:16:52 -0500","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-85-Nwu4VdMTOmqNas4xj5svkg-1; Mon,\n 16 Feb 2026 06:16:44 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D11D81800282; Mon, 16 Feb 2026 11:16:42 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1B64718004BB; Mon, 16 Feb 2026 11:16:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240609;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AA3lxWDKN6fj8RCvjWJJC53DLJ6ppqmB5kXOtPh2bPM=;\n b=Yqd6QqBN8MQsZ6CB0Lzufw10WvVUJd/025CDNKqQmJ6MRTnvX6SnZ9XlUpVNF2Kq09b5jp\n TAYUSODpKw0Efh1PHU2KRmw2OWBPPBIezB84+Qj9BGZ/Ky2vSQcex5xnpECBL9iZXm5uXP\n jtZEGmsOQ3hflewHQnpwD7xUi8e85gE=","X-MC-Unique":"Nwu4VdMTOmqNas4xj5svkg-1","X-Mimecast-MFC-AGG-ID":"Nwu4VdMTOmqNas4xj5svkg_1771240602","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:12 +0100","Subject":"[PATCH 23/85] audio: move object creation to audio_driver_init()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-23-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4342;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=HTKMvSjc/4XPdb/4s6NCPW0/EkVuqOhfHJStjWnzcjk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxPz5VW5lOSxGEpnZlvzF17vfUyl74FC18X3\n +VLKiVQzC2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TwAKCRDa6OEJdZac\n 5UUOD/wMJoiMr4h2D7BQYAYyb7p4mQFUp/eg70XYwexnJNOmGP0h5u4eWXj65EmxkfwHHLhKabf\n Kg6HmXS8OI6/mOE55RQkROZ2zFyxxBWs7paMIanQ1RHPERtR4Vtv7ITkeAC1Nl2pZmcrvKbHdGd\n gcP+X3+Kj1/EofghbhUa9nrOnL2tVx4dTEAa7IaZXQqnbItEiU/kz6vq2HrKFNRctVhOtqBvwcN\n br4/3Xb8aiZ//72NqTEwZCT9W6tylwcordwAC3PDT6b/869jm7NEdFDFu1XhihZMP0eq6UymagE\n EKrzIc8C1xXzOccsVLY/UGKhOyDeT2+vg/tA/SX3/4uDZl5eBy8c08AcRDTodrroR31/dLhZtTg\n R3Pw+6O31wEuwA5CnjaMJh4rbYjoUqNNkb1oD4utSoyANP1zk3yzAGMPHQ2mNvEmP9U6Z9c5LFw\n xKGOIyeZr8N+RM4wndfOHmnT7FcJ0Y6CTWorlnMbHbWbzR7g4keDo7efU8uqTrJ65lF1Dtf50tv\n 52C+ZM36adHJJbV30rOAurXNC9sR/Eo1QjjL7l3KWZE5Yg9MEswVjQIZ/xSSUlPvmBsSli0xkgz\n ElzgWl2xxvvhH2ex1DUrRHVw9LKU/1HDx3c+FSUifMsbMLEZMboC5Rjj5vScbjkZNFH1sD2a4CT\n s1iXasmM8sT6G0w==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"As we will allow other kind of AudioBackend objects to be instantiated,\nmove the object allocation to a audio_driver_init() and rename it\naudio_be_new().\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/audio.c | 65 +++++++++++++++++++++++++++++++----------------------------\n 1 file changed, 34 insertions(+), 31 deletions(-)","diff":"diff --git a/audio/audio.c b/audio/audio.c\nindex 10e32bcbb1a..3e1cd988852 100644\n--- a/audio/audio.c\n+++ b/audio/audio.c\n@@ -1562,19 +1562,24 @@ size_t audio_generic_read(HWVoiceIn *hw, void *buf, size_t size)\n return total;\n }\n \n-static bool audio_driver_do_init(AudioMixengBackend *d, Error **errp)\n+static AudioBackend *audio_be_new(Audiodev *dev, Error **errp)\n {\n- const char *drvname = AudiodevDriver_str(d->dev->driver);\n+ const char *drvname = AudiodevDriver_str(dev->driver);\n struct audio_driver *drv = audio_driver_lookup(drvname);\n \n if (!drv) {\n error_setg(errp, \"Unknown audio driver `%s'\", drvname);\n- return false;\n+ qapi_free_Audiodev(dev);\n+ return NULL;\n }\n \n- d->drv_opaque = drv->init(d->dev, errp);\n- if (!d->drv_opaque) {\n- return false;\n+ AudioMixengBackend *be = AUDIO_MIXENG_BACKEND(object_new(TYPE_AUDIO_MIXENG_BACKEND));\n+ be->dev = dev;\n+\n+ be->drv_opaque = drv->init(be->dev, errp);\n+ if (!be->drv_opaque) {\n+ object_unref(OBJECT(be));\n+ return NULL;\n }\n \n if (!drv->pcm_ops->get_buffer_in) {\n@@ -1586,17 +1591,17 @@ static bool audio_driver_do_init(AudioMixengBackend *d, Error **errp)\n drv->pcm_ops->put_buffer_out = audio_generic_put_buffer_out;\n }\n \n- audio_init_nb_voices_out(d, drv, 1);\n- audio_init_nb_voices_in(d, drv, 0);\n- d->drv = drv;\n+ audio_init_nb_voices_out(be, drv, 1);\n+ audio_init_nb_voices_in(be, drv, 0);\n+ be->drv = drv;\n \n- if (d->dev->timer_period <= 0) {\n- d->period_ticks = 1;\n+ if (be->dev->timer_period <= 0) {\n+ be->period_ticks = 1;\n } else {\n- d->period_ticks = d->dev->timer_period * (int64_t)SCALE_US;\n+ be->period_ticks = be->dev->timer_period * (int64_t)SCALE_US;\n }\n \n- return true;\n+ return AUDIO_BACKEND(be);\n }\n \n static void audio_vm_change_state_handler (void *opaque, bool running,\n@@ -1793,41 +1798,39 @@ void audio_create_default_audiodevs(void)\n */\n static AudioBackend *audio_init(Audiodev *dev, Error **errp)\n {\n- AudioMixengBackend *d;\n+ AudioBackend *be;\n \n- d = AUDIO_MIXENG_BACKEND(object_new(TYPE_AUDIO_MIXENG_BACKEND));\n- d->dev = dev;\n- if (d->dev) {\n- if (!audio_driver_do_init(d, errp)) {\n- goto out;\n+ if (dev) {\n+ be = audio_be_new(dev, errp);\n+ if (!be) {\n+ return NULL;\n }\n } else {\n assert(!default_audio_be);\n for (;;) {\n AudiodevListEntry *e = QSIMPLEQ_FIRST(&default_audiodevs);\n+\n if (!e) {\n error_setg(errp, \"no default audio driver available\");\n- goto out;\n+ return NULL;\n }\n- d->dev = e->dev;\n+ dev = e->dev;\n QSIMPLEQ_REMOVE_HEAD(&default_audiodevs, next);\n g_free(e);\n- if (audio_driver_do_init(d, NULL)) {\n+ be = audio_be_new(dev, NULL);\n+ if (be) {\n break;\n }\n }\n }\n \n if (!object_property_try_add_child(get_audiodevs_root(),\n- d->dev->id, OBJECT(d), errp)) {\n- goto out;\n+ audio_be_get_id(be), OBJECT(be), errp)) {\n+ object_unref(be);\n+ return NULL;\n }\n- object_unref(d);\n- return AUDIO_BACKEND(d);\n-\n-out:\n- object_unref(d);\n- return NULL;\n+ object_unref(be);\n+ return be;\n }\n \n AudioBackend *audio_get_default_audio_be(Error **errp)\n@@ -2183,7 +2186,7 @@ void audio_init_audiodevs(void)\n AudiodevListEntry *e;\n \n QSIMPLEQ_FOREACH(e, &audiodevs, next) {\n- audio_init(e->dev, &error_fatal);\n+ audio_init(QAPI_CLONE(Audiodev, e->dev), &error_fatal);\n }\n }\n \n","prefixes":["23/85"]}