{"id":2196816,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196816/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-69-e676662e4514@redhat.com>","date":"2026-02-16T11:15:58","name":"[69/85] audio/sndio: replace custom logging with error_report","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cdb8f0dc461b4c591833b2273765118719449853","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-69-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196816/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bY3/3rUo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0hw28Y9z1xpY\n\tfor ; Mon, 16 Feb 2026 22:21:36 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfV-0007aW-7J; Mon, 16 Feb 2026 06:21:33 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwd3-0007Sp-UF\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:06 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwd1-0008Pv-62\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:01 -0500","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-8W2w716eMz2pe1Ymxx73KA-1; Mon,\n 16 Feb 2026 06:18:54 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DD35C1956089; Mon, 16 Feb 2026 11:18:51 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 546601800464; Mon, 16 Feb 2026 11:18:51 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240738;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=zZPwP50pYxUr6MP+yYvCFJCeqAndqgUmshxGKnX4ZHc=;\n b=bY3/3rUoUuvd6WdNtEbpT3v9Z8APV4CV782cX9cOIuLcjkb5OkP2zcRUmU1L6alq7GnLxV\n MGjMFqr5XoRLRqgqJA8/7I16hXkvWArvzsZ2R9EWjvOHsL+kcbkeGpIQtfIkH8oQ2ZOPP/\n Z+ThBY1Wq7J60/Ss3UhEm4SDN/Bwe64=","X-MC-Unique":"8W2w716eMz2pe1Ymxx73KA-1","X-Mimecast-MFC-AGG-ID":"8W2w716eMz2pe1Ymxx73KA_1771240732","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:58 +0100","Subject":"[PATCH 69/85] audio/sndio: replace custom logging with\n error_report","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-69-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Thomas Huth ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3292;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=8yW9wJ3mIfAWUvsc6PEfigNiDWoTGEQkRlzr3mI/fbs=;\n b=kA0DAAoB2ujhCXWWnOUByyZiAGmS/FGj/RWAwCaalX3Sad3mihLN/7gHO9AimlvuTKXg6QHZW\n IkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJpkvxRAAoJENro4Ql1lpzlf+AP/0Hf\n 9dfWzN4T09rWtuvAlg1E/wN4VBXt0eI3AatGe5dpxfHfpDTW8Gf1zggK5Qx7mNMyI2KMJUJJwDM\n UTXQ5P7Y1Ic6ZXnEpfdCb/DIJl1Pf4YrGcItguC5V5aOoi6PpjZEwfDnotJRPyJkJDNYJEnYpdR\n zfkd7dVkVSrWfN3NU91ql4qSJgp/0p1qvHeUeLCtzdqux6NUiyT8QQqLfHnuRlf+hKXDP3qeLoS\n H/jylL1pNwpj86uuWs/d6zo2+SzI/X+ZV+tk7rzB1h5g7xiBYY//U7iKMsOf5JD/R/URdsKG74C\n kUavivCFGwenRs38C5IdjZA14Ux520EYvlipOUd3D77am1d5fmsZk7VWCfwMZF0b121LJ/ubwSw\n dovC0BR2Xzu1tigP7BYQQDg38dCLxtuhXICuOFeraMJrFRI0jRJiB/DJdgMEEI1D4lT8EiXu9Vo\n raL2REVIggU7YvUbB3aDVdFObTivxJhssArngKrEvUeKRPiBT2ZcJoAxgNyCJktyqir1hwkMECW\n QViUnBOFVaoQM+dhnK9XO9bIKTGS1NyXSbK9dNJsoolFyJxjLuRDat5U9DawIKfxrEfMuLsJV9A\n tEQq8fWxNIhZBtdRnSOPAiSxCgExnHzhM+ZtloJ6Ya8IELrwEcQrij7HcUyjD5CqQg9DXM41f3b\n U0XhE","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Replace the custom audio logging infrastructure (dolog macro) with\nstandard QEMU error reporting (error_report).\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Thomas Huth \nReviewed-by: Mark Cave-Ayland \n---\n audio/sndioaudio.c | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/audio/sndioaudio.c b/audio/sndioaudio.c\nindex 21f43836fd1..766eceeeefe 100644\n--- a/audio/sndioaudio.c\n+++ b/audio/sndioaudio.c\n@@ -18,12 +18,12 @@\n #include \n #include \n #include \"qemu/main-loop.h\"\n+#include \"qemu/error-report.h\"\n #include \"qemu/audio.h\"\n-#include \"trace.h\"\n #include \"qom/object.h\"\n \n-#define AUDIO_CAP \"sndio\"\n #include \"audio_int.h\"\n+#include \"trace.h\"\n \n #define TYPE_AUDIO_SNDIO \"audio-sndio\"\n OBJECT_DECLARE_SIMPLE_TYPE(AudioSndio, AUDIO_SNDIO)\n@@ -348,7 +348,7 @@ static int sndio_init(SndioVoice *self,\n /* open the device in non-blocking mode */\n self->hdl = sio_open(dev_name, mode, 1);\n if (self->hdl == NULL) {\n- dolog(\"failed to open device\\n\");\n+ error_report(\"sndio: failed to open device\");\n return -1;\n }\n \n@@ -382,7 +382,7 @@ static int sndio_init(SndioVoice *self,\n req.sig = 0;\n break;\n default:\n- dolog(\"unknown audio sample format\\n\");\n+ error_report(\"sndio: unknown audio sample format\");\n return -1;\n }\n \n@@ -401,12 +401,12 @@ static int sndio_init(SndioVoice *self,\n req.appbufsz = req.rate * latency / 1000000;\n \n if (!sio_setpar(self->hdl, &req)) {\n- dolog(\"failed set audio params\\n\");\n+ error_report(\"sndio: failed to set audio params\");\n goto fail;\n }\n \n if (!sio_getpar(self->hdl, &self->par)) {\n- dolog(\"failed get audio params\\n\");\n+ error_report(\"sndio: failed to get audio params\");\n goto fail;\n }\n \n@@ -419,7 +419,7 @@ static int sndio_init(SndioVoice *self,\n if (self->par.bits != req.bits || self->par.bps != req.bits / 8 ||\n self->par.sig != req.sig || (req.bits > 8 && self->par.le != req.le) ||\n self->par.rate != as->freq || nch != as->nchannels) {\n- dolog(\"unsupported audio params\\n\");\n+ error_report(\"sndio: unsupported audio params\");\n goto fail;\n }\n \n@@ -431,7 +431,7 @@ static int sndio_init(SndioVoice *self,\n \n self->buf = g_malloc(self->buf_size);\n if (self->buf == NULL) {\n- dolog(\"failed to allocate audio buffer\\n\");\n+ error_report(\"sndio: failed to allocate audio buffer\");\n goto fail;\n }\n \n@@ -439,13 +439,13 @@ static int sndio_init(SndioVoice *self,\n \n self->pfds = g_malloc_n(nfds, sizeof(struct pollfd));\n if (self->pfds == NULL) {\n- dolog(\"failed to allocate pollfd structures\\n\");\n+ error_report(\"sndio: failed to allocate pollfd structures\");\n goto fail;\n }\n \n self->pindexes = g_malloc_n(nfds, sizeof(struct pollindex));\n if (self->pindexes == NULL) {\n- dolog(\"failed to allocate pollindex structures\\n\");\n+ error_report(\"sndio: failed to allocate pollindex structures\");\n goto fail;\n }\n \n","prefixes":["69/85"]}