{"id":2196810,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196810/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-25-e676662e4514@redhat.com>","date":"2026-02-16T11:15:14","name":"[25/85] audio: remove set_dbus_server from audio_driver","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"03586c184efa557fdfd367abf656dd84233c8941","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-25-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196810/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WHU0Vmpp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0gv02YCz1xpY\n\tfor ; Mon, 16 Feb 2026 22:20:43 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwda-0000oT-GG; Mon, 16 Feb 2026 06:19:36 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwb7-0005Pd-Qk\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:08 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwb4-0007Vn-5M\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:01 -0500","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-Rsf5jSByM_aMDxAiFpTD6Q-1; Mon,\n 16 Feb 2026 06:16:50 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 460DD1956094; Mon, 16 Feb 2026 11:16:48 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 526E130001A5; Mon, 16 Feb 2026 11:16:47 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240614;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=MUsBjBksReZ1gaFRLPZuGSgyXvz6SSrNa1EyYK/h58o=;\n b=WHU0VmppVc2vxgYE76nQqeqAKMTl1zGBkIuTMv7WaK17Tc7PZxlpQFuBpzLXzlCHcx/5Rv\n +U4/gWW2LYTrlcqk2mpzShxwo4C1BpD25zohxNMQENY9z3ujb2jRAEqL1mUjroSOxfsLRZ\n RmAtccfBiIEK6IFy9PsyvGj0uRcxxHc=","X-MC-Unique":"Rsf5jSByM_aMDxAiFpTD6Q-1","X-Mimecast-MFC-AGG-ID":"Rsf5jSByM_aMDxAiFpTD6Q_1771240608","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:14 +0100","Subject":"[PATCH 25/85] audio: remove set_dbus_server from audio_driver","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-25-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4292;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=dbOONFCzI/swxM9VY+S6bbCkaSc4yZrxA86hh54hOys=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxPfP2bXM3hb4gPF8nqfgGOjVTVptgrC2Mqj\n KZK0TbdxwKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TwAKCRDa6OEJdZac\n 5d0RD/9hN+Gu4T9upe7I8RRO1rWs7WdRBo1JGUlaVLYfcEOaFzfAuyNqlxd9STApGJ4UTKy5I6g\n zl+1ytMpxE/nCZLTTgMi/xCZhwmnVwlRAEvR/5+sMXBYFbPkgoEQCKI+b6mCqQYCT70townLztb\n vKWqgBUhQ5b/0iyvVkQ67ni1//OyK5W90oZJABWGIiQbr+WHlVwK9JRhRFH9mw7fk/42JGS/aei\n w3TCpFhfU8D4SGsxLG818oQnqZWzuCq8/ZaTOH1xV+cckTgxc/2fGmNHKVW0LlvmRxXAnrL9owm\n T7VWbo6xnSrJ1RhToHjA5VPxmT3YBT+KrRcL5TulamHQ23laoAXdJZz4MEggmzeoTUOlFHT+Tm6\n 5L1cmBRmPV2arkLZ7Od5qwLUwevbUcQHwU8pPo0R4Ox7hMp+YggIwiIZFlvXO3LHuB2MYKMWP3q\n yMUgG/jFpMcCNDPGouS7zzWsNabxtyPjQtrnVkPqQqJgLWnmnf8MjurtA9mtCnr7BUGcFikey8N\n vnHSBTKCzYD14lfP9yJc1hxnERWvSo31fNaUQpNmwLdI3aMziQgKHnPQYjjVGpNbMSN3hE44RNB\n rdyFBUDQYzf7Sf3gMYZ8x2wy6XitImVk9GnvwAN2jahXkyIEcnN6icj1plhWMueucHBT0H+So3F\n uYvxZ33u1O1NaTA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use the QOM class vtable only instead.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/audio_int.h | 10 ----------\n audio/audio.c | 29 +++--------------------------\n audio/dbusaudio.c | 17 +++++++++--------\n 3 files changed, 12 insertions(+), 44 deletions(-)","diff":"diff --git a/audio/audio_int.h b/audio/audio_int.h\nindex 29f5864be69..0b97c8edee3 100644\n--- a/audio/audio_int.h\n+++ b/audio/audio_int.h\n@@ -33,10 +33,6 @@\n #include \"qemu/audio-capture.h\"\n #include \"mixeng.h\"\n \n-#ifdef CONFIG_GIO\n-#include \n-#endif\n-\n void G_GNUC_PRINTF(2, 0)\n AUD_vlog(const char *cap, const char *fmt, va_list ap);\n \n@@ -145,12 +141,6 @@ struct audio_driver {\n const char *name;\n void *(*init) (Audiodev *, Error **);\n void (*fini) (void *);\n-#ifdef CONFIG_GIO\n- bool (*set_dbus_server)(AudioBackend *be,\n- GDBusObjectManagerServer *manager,\n- bool p2p,\n- Error **errp);\n-#endif\n struct audio_pcm_ops *pcm_ops;\n int max_voices_out;\n int max_voices_in;\ndiff --git a/audio/audio.c b/audio/audio.c\nindex 3e1cd988852..5d0f5ad2145 100644\n--- a/audio/audio.c\n+++ b/audio/audio.c\n@@ -1640,31 +1640,11 @@ static const char *audio_mixeng_backend_get_id(AudioBackend *be)\n return AUDIO_MIXENG_BACKEND(be)->dev->id;\n }\n \n-#ifdef CONFIG_GIO\n-static bool audio_mixeng_backend_set_dbus_server(AudioBackend *be,\n- GDBusObjectManagerServer *manager,\n- bool p2p,\n- Error **errp)\n-{\n- AudioMixengBackend *d = AUDIO_MIXENG_BACKEND(be);\n-\n- if (!d->drv->set_dbus_server) {\n- return false;\n- }\n-\n- return d->drv->set_dbus_server(be, manager, p2p, errp);\n-}\n-\n-#endif\n-\n static void audio_mixeng_backend_class_init(ObjectClass *klass, const void *data)\n {\n AudioBackendClass *be = AUDIO_BACKEND_CLASS(klass);\n \n be->get_id = audio_mixeng_backend_get_id;\n-#ifdef CONFIG_GIO\n- be->set_dbus_server = audio_mixeng_backend_set_dbus_server;\n-#endif\n }\n \n static void audio_mixeng_backend_init(Object *obj)\n@@ -2264,12 +2244,9 @@ AudioBackend *audio_be_by_name(const char *name, Error **errp)\n #ifdef CONFIG_GIO\n bool audio_be_can_set_dbus_server(AudioBackend *be)\n {\n- /*\n- * TODO:\n- * AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n- * return klass->set_dbus_server != NULL;\n- */\n- return AUDIO_MIXENG_BACKEND(be)->drv->set_dbus_server != NULL;\n+ AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n+\n+ return klass->set_dbus_server != NULL;\n }\n \n bool audio_be_set_dbus_server(AudioBackend *be,\ndiff --git a/audio/dbusaudio.c b/audio/dbusaudio.c\nindex 4d62de6d72c..5a5752b8f33 100644\n--- a/audio/dbusaudio.c\n+++ b/audio/dbusaudio.c\n@@ -54,13 +54,6 @@ struct AudioDbus {\n \n static struct audio_driver dbus_audio_driver;\n \n-static void audio_dbus_class_init(ObjectClass *klass, const void *data)\n-{\n- AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n-\n- k->driver = &dbus_audio_driver;\n-}\n-\n typedef struct DBusAudio {\n Audiodev *dev;\n GDBusObjectManagerServer *server;\n@@ -720,7 +713,6 @@ static struct audio_driver dbus_audio_driver = {\n .name = \"dbus\",\n .init = dbus_audio_init,\n .fini = dbus_audio_fini,\n- .set_dbus_server = dbus_audio_set_server,\n .pcm_ops = &dbus_pcm_ops,\n .max_voices_out = INT_MAX,\n .max_voices_in = INT_MAX,\n@@ -728,6 +720,15 @@ static struct audio_driver dbus_audio_driver = {\n .voice_size_in = sizeof(DBusVoiceIn)\n };\n \n+static void audio_dbus_class_init(ObjectClass *klass, const void *data)\n+{\n+ AudioBackendClass *b = AUDIO_BACKEND_CLASS(klass);\n+ AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n+\n+ b->set_dbus_server = dbus_audio_set_server;\n+ k->driver = &dbus_audio_driver;\n+}\n+\n static const TypeInfo audio_dbus_info = {\n .name = TYPE_AUDIO_DBUS,\n .parent = TYPE_AUDIO_MIXENG_BACKEND,\n","prefixes":["25/85"]}