{"id":2196808,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196808/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-32-e676662e4514@redhat.com>","date":"2026-02-16T11:15:21","name":"[32/85] audio: make create_pdos() private","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"04cf642caabca9cc2b7953f0c0dba4035547fd70","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-32-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196808/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WFTGT8B6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0gd5Xkzz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:20:29 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrweK-0003Mw-81; Mon, 16 Feb 2026 06:20:20 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwbR-0005eu-PU\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:28 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwbM-0007pX-Hc\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:19 -0500","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-xSmBGvwFON2yAcO6V4PJ5A-1; Mon,\n 16 Feb 2026 06:17:08 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E24CB1955DDF; Mon, 16 Feb 2026 11:17:06 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 44C5E30001A5; Mon, 16 Feb 2026 11:17:06 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240633;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fFl76fF+LZJe4gLSTLwCv0jScavNDWDyMsNrvmMBYlo=;\n b=WFTGT8B6PednQw/+2kKVekQ6GFVni349nYnoX69JrO/uB4X3N/2PyWzMMKkICTbOwBgiRx\n +/U4yQOufkVJ+OxOvrJ3bqSdlxKYRxafpX7F2DihzcjeWgyx9m1Sr+oWNzfMCLDNzSVw/3\n uQ+H/hRdzHLwJyj4XIlmpNbU3vtpojc=","X-MC-Unique":"xSmBGvwFON2yAcO6V4PJ5A-1","X-Mimecast-MFC-AGG-ID":"xSmBGvwFON2yAcO6V4PJ5A_1771240627","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","Date":"Mon, 16 Feb 2026 12:15:21 +0100","Subject":"[PATCH 32/85] audio: make create_pdos() private","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-32-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann <kraxel@redhat.com>,  Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n  John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n  Christian Schoenebeck <qemu_oss@crudebyte.com>,\n  Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n  Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n  Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n  Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n  Alistair Francis <alistair@alistair23.me>,\n  \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n  Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n  Mark Cave-Ayland <mark.caveayland@nutanix.com>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1126;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=18BzEdvVM6Wo1L4EnoV0PhPLC4dtiCH9jACEhFQvbdg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxPV8PiDGBHjO+tvxDUJ106QEznKRJTxxFt5\n cEhFV1drwuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TwAKCRDa6OEJdZac\n 5Y2JD/9Tap+sJcU1pGCa9TcegcUnv4Q9P8rlu5iZ4L6xNHDK81NKAQfFc/KiKs+bCv48xwRmdNF\n 3sWx41Ch1t0XS+7KPPKwvd3uBCJbU0XvgFSxvqdK3YURfa2HVR7Ov8NCZ02x3qLXQY8/CWEWNoE\n iz7l8OSrujuFznuJULt3LX3BC4U4o7ON/fQPkXNJubNI+n9HaGYF8z/pM/hXrBX2+sjqGhoFCw+\n sV2eek0jlBNI77QbSzFzfxVnSzc0ruShzX5KEZVqWk0noJMr2237XsNtXML7cAZwtjqAAekVXna\n QcV3L3pftPBgoWNo0br9snRQBN8kbW43pkznjcET8pnL6kNHVXwq6zUNkB6IaTjZd9s65CSo5ij\n GrMpRcbDCXGLZ/ci15TU6jaM2TOPwY81kxD93sgAihpEmyhyXc0G9b4gZ4WktpTvftfOUZV3SdC\n LU4+zkTrJUIZsi01icjzCvrtiMfzU9owvc8TSGtgwIoXw2hdrcB763VpyXjIVKC6yK6yVNUH94H\n c051BYdwK29/r0qiMEAFQOtRzXvBKQP9SvSZ1WszM0NUm6Qt1OW6Uv/UXbyuQGz393gA1gAOwzl\n 3dnCZemZb9S0h8L8SfvfvknvwfqGSYlhM0rNIJlnXM+TDuu6LgHvMA7DwmFf79jEyE8u68rNCqw\n EFbvjSTZnXYS8EA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Clean up.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio_int.h | 1 -\n audio/audio.c     | 2 +-\n 2 files changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/audio/audio_int.h b/audio/audio_int.h\nindex 08d07b17557..e1f9fa333ba 100644\n--- a/audio/audio_int.h\n+++ b/audio/audio_int.h\n@@ -306,7 +306,6 @@ static inline size_t audio_ring_posb(size_t pos, size_t dist, size_t len)\n #define ldebug(fmt, ...) (void)0\n #endif\n \n-void audio_create_pdos(Audiodev *dev);\n AudiodevPerDirectionOptions *audio_get_pdo_in(Audiodev *dev);\n AudiodevPerDirectionOptions *audio_get_pdo_out(Audiodev *dev);\n \ndiff --git a/audio/audio.c b/audio/audio.c\nindex d8a54548274..1fa63ee0421 100644\n--- a/audio/audio.c\n+++ b/audio/audio.c\n@@ -1990,7 +1990,7 @@ void AUD_set_volume_in(SWVoiceIn *sw, Volume *vol)\n     }\n }\n \n-void audio_create_pdos(Audiodev *dev)\n+static void audio_create_pdos(Audiodev *dev)\n {\n     switch (dev->driver) {\n #define CASE(DRIVER, driver, pdo_name)                              \\\n","prefixes":["32/85"]}