{"id":2196806,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196806/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-19-e676662e4514@redhat.com>","date":"2026-02-16T11:15:08","name":"[19/85] audio: constify audsettings argument","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a5171efbc20a428ee3361aa6c84389c8f86b2baa","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-19-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196806/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=e9hP0KOE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0gX1cz6z1xpY\n\tfor ; Mon, 16 Feb 2026 22:20:24 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwdV-0000AO-VZ; Mon, 16 Feb 2026 06:19:30 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwar-0005JQ-Ow\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:04 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwak-0007Sg-9P\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:16:40 -0500","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-orSCkSvbOhS5awcRN2Gnyw-1; Mon,\n 16 Feb 2026 06:16:33 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 125B9180047F; Mon, 16 Feb 2026 11:16:31 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 37C5E18003F5; Mon, 16 Feb 2026 11:16:29 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240597;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=owCMqtDAeefUA/PLyaaNUJQAaFbI+2RUQ1YruU0M5ag=;\n b=e9hP0KOEYS3kdc5XO/hHAWBgBRyTeUyS7SLDd4cJv33yxQuytGwTjeZzQHihwgCxIbju2j\n /QoPAjYUE8grb/j6I6XeYXOU11msMJr7YkvYqMVHEOkS0H/7nPLdSBxAlg/bbqlmSmFpKS\n t11AcV0IP1gRqCYmW6KuehkjHI0zs8M=","X-MC-Unique":"orSCkSvbOhS5awcRN2Gnyw-1","X-Mimecast-MFC-AGG-ID":"orSCkSvbOhS5awcRN2Gnyw_1771240591","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:08 +0100","Subject":"[PATCH 19/85] audio: constify audsettings argument","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-19-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4072;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=H6n2uw6uj550TicI/7n5wOdjySxspRP/33lyJ5l2eig=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxOMws7WNYm/ZuK05nJjbuIFb6UOyEwrRK2m\n IvOqgGlWKWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TgAKCRDa6OEJdZac\n 5cfnEACA51/pvVdJhl5JbUBKtvX4vKk4LjULhzf9QOViMuTHEXT8QLpZNsJRGr+ZLSOaoW3w7m6\n Fgc5se7RSlN7CcwoAZOVdfjEuAxB6Plr8ZOOjNkatHOMSowPZEWgrebqnMgEecroyt8SS6rJdOv\n bAQWKcTNqFKt5ihtCItzVYPG9F3ASSOA1HgUDvSrz8ptAJJY5WspvTZb7KId0Vd5ZG+OwmB3Qv/\n d+4DGBhOc5eL+mYao06G1Fl88fa49MLvqA2Fz9tChwgieiuCsnC+EMUPLCXssCaURul2/xumaKE\n iqRLyRJP+qR/3agfcS9e/JT3dCqYP6/VcROQgWRl6mebTcNFDPIJh4/NvG5/Y7P0rkBRQWFjZTQ\n jaU4wPhaijevwEUD58g3yzNG7U65s9uAQODrWCIiF7fF0XIXBEoM09XUJlfQi2HVwhzWGSoUYuU\n bM2tIfyjRZ+lBuZRPACIbkMV21mtzzDPQYwc3R1YYTJKE+rpaRHrJYWCjaXrY2zGfv7q426HXaA\n bY5b9RLRf1UfzFpkwvA2g+vG3lTnoLw/Ej5WLFbjHp5X9LaCDzirBMkzt0BAJpt2HFdMo7tB+KW\n vVFeybKBcRwli39MaUiTcKAanSLyoN+RhZy1EP4KgXaD7lUZJYgeJCPftZifYI/Zq8DRKA3Jo6y\n THMl1IyipPeVmDQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"It shouldn't be modified by the audio functions.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/audio_int.h | 2 +-\n audio/audio_template.h | 6 +++---\n include/qemu/audio.h | 4 ++--\n audio/audio.c | 8 ++++----\n 4 files changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/audio/audio_int.h b/audio/audio_int.h\nindex 25de0e3f9cf..a6276375887 100644\n--- a/audio/audio_int.h\n+++ b/audio/audio_int.h\n@@ -265,7 +265,7 @@ extern const char *audio_prio_list[];\n \n void audio_driver_register(audio_driver *drv);\n \n-void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as);\n+void audio_pcm_init_info (struct audio_pcm_info *info, const struct audsettings *as);\n void audio_pcm_info_clear_buf (struct audio_pcm_info *info, void *buf, int len);\n \n int audio_bug (const char *funcname, int cond);\ndiff --git a/audio/audio_template.h b/audio/audio_template.h\nindex 1ab3c47fd76..e69e6e74570 100644\n--- a/audio/audio_template.h\n+++ b/audio/audio_template.h\n@@ -159,7 +159,7 @@ static int glue (audio_pcm_sw_init_, TYPE) (\n SW *sw,\n HW *hw,\n const char *name,\n- struct audsettings *as\n+ const struct audsettings *as\n )\n {\n int err;\n@@ -426,7 +426,7 @@ static HW *glue(audio_pcm_hw_add_, TYPE)(AudioBackend *s, struct audsettings *as\n static SW *glue(audio_pcm_create_voice_pair_, TYPE)(\n AudioBackend *s,\n const char *sw_name,\n- struct audsettings *as\n+ const struct audsettings *as\n )\n {\n SW *sw;\n@@ -491,7 +491,7 @@ SW *glue (AUD_open_, TYPE) (\n const char *name,\n void *callback_opaque ,\n audio_callback_fn callback_fn,\n- struct audsettings *as\n+ const struct audsettings *as\n )\n {\n AudioBackend *s = be;\ndiff --git a/include/qemu/audio.h b/include/qemu/audio.h\nindex a1a64ad340d..370e993f080 100644\n--- a/include/qemu/audio.h\n+++ b/include/qemu/audio.h\n@@ -58,7 +58,7 @@ SWVoiceOut *AUD_open_out (\n const char *name,\n void *callback_opaque,\n audio_callback_fn callback_fn,\n- struct audsettings *settings\n+ const struct audsettings *settings\n );\n \n void AUD_close_out (AudioBackend *be, SWVoiceOut *sw);\n@@ -97,7 +97,7 @@ SWVoiceIn *AUD_open_in(\n const char *name,\n void *callback_opaque,\n audio_callback_fn callback_fn,\n- struct audsettings *settings\n+ const struct audsettings *settings\n );\n \n void AUD_close_in(AudioBackend *be, SWVoiceIn *sw);\ndiff --git a/audio/audio.c b/audio/audio.c\nindex 68698b13e15..5dccb9b0a36 100644\n--- a/audio/audio.c\n+++ b/audio/audio.c\n@@ -170,7 +170,7 @@ void AUD_log (const char *cap, const char *fmt, ...)\n va_end (ap);\n }\n \n-static void audio_print_settings (struct audsettings *as)\n+static void audio_print_settings (const struct audsettings *as)\n {\n dolog (\"frequency=%d nchannels=%d fmt=\", as->freq, as->nchannels);\n \n@@ -216,7 +216,7 @@ static void audio_print_settings (struct audsettings *as)\n AUD_log (NULL, \"\\n\");\n }\n \n-static int audio_validate_settings (struct audsettings *as)\n+static int audio_validate_settings (const struct audsettings *as)\n {\n int invalid;\n \n@@ -241,7 +241,7 @@ static int audio_validate_settings (struct audsettings *as)\n return invalid ? -1 : 0;\n }\n \n-static int audio_pcm_info_eq (struct audio_pcm_info *info, struct audsettings *as)\n+static int audio_pcm_info_eq (struct audio_pcm_info *info, const struct audsettings *as)\n {\n int bits = 8;\n bool is_signed = false, is_float = false;\n@@ -281,7 +281,7 @@ static int audio_pcm_info_eq (struct audio_pcm_info *info, struct audsettings *a\n && info->swap_endianness == (as->endianness != HOST_BIG_ENDIAN);\n }\n \n-void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as)\n+void audio_pcm_init_info (struct audio_pcm_info *info, const struct audsettings *as)\n {\n int bits = 8, mul;\n bool is_signed = false, is_float = false;\n","prefixes":["19/85"]}