{"id":2196802,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196802/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-14-e676662e4514@redhat.com>","date":"2026-02-16T11:15:03","name":"[14/85] scripts/modinfo: use argparse","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2918f5ab6583d9bb1e992757baf2e3fffbb5e0f5","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-14-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196802/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aKQ9r3t2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0fr1Fz9z1xtN\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:19:48 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwcV-0006gk-Iz; Mon, 16 Feb 2026 06:18:34 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwaa-0005CS-VP\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:16:31 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwaY-0007OU-98\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:16:28 -0500","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-dW163pPLN9qyjDaw4h8kVg-1; Mon,\n 16 Feb 2026 06:16:20 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5CC8918004BB; Mon, 16 Feb 2026 11:16:18 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B648719560AD; Mon, 16 Feb 2026 11:16:17 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240583;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=lTkiQYWm5xuq4+X2pL9s+wlSjm2scNT6GBeBn7FnNBE=;\n b=aKQ9r3t2t9zMY9orV2cUDS6XgIv2FSNRNoBfOMPGT7ZuBELTx77+qSi+WIu6ooQ358HH4I\n C9NgR89P490zCLmIgVP1NYXqow24U04PNfNzbVFLU1vToriAK8IWU1P0ATivN7z1UxracG\n 0NgJBOPaus4HlG4z7aoezPI+OaJywdU=","X-MC-Unique":"dW163pPLN9qyjDaw4h8kVg-1","X-Mimecast-MFC-AGG-ID":"dW163pPLN9qyjDaw4h8kVg_1771240578","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","Date":"Mon, 16 Feb 2026 12:15:03 +0100","Subject":"[PATCH 14/85] scripts/modinfo: use argparse","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-14-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann <kraxel@redhat.com>,  Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n  John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n  Christian Schoenebeck <qemu_oss@crudebyte.com>,\n  Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n  Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n  Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n  Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n  Alistair Francis <alistair@alistair23.me>,\n  \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n  Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n  Mark Cave-Ayland <mark.caveayland@nutanix.com>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2141;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=uHM8i5gf/zzsBO3Kh9KkNMm19zV45EUZ0obNueX90RM=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxOH/nUyiGANqnJl0lpVEmXIA13RQcePg0mV\n tRgOYRXje+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TgAKCRDa6OEJdZac\n 5ZuBD/4oN+R8DrwkF5AZJcF8hNM251PNwWLImR++7+b8SzneLnJpCIRzAOa32GfGjJRpz/Hgbs7\n bWLWdTlvjaA/sXAKTkODXEYCh8AdQry56n9TaZQ8JRI6yysHrVju5AlOlLoyeXTzyEfn/29r/aj\n uhOr2vd6tz56r37amNnHnLNJ9S6qvOCpla+fhunhQLp/qe91ouuxM3PRPyoOU9p/cKu2Lg/JV+h\n jOyczxjCYxEkxh3zF7Nb6P5zfKlp3UjyfcE8D2esa7xN1gVAwcKIy6VMFpsHDsKPNRvqz+CUSHi\n A2DCvVhCnhZs8NocXOPATLANNEWLr7m55w30EVvafH5MyblcqgCdUb4Jen5u6aT38TXknmZFn/b\n xqjCgRn37HRJFIf+o8pxhABay0dTDl04+vkbXxPI3ffcI7JP2rU69ayd4NhWtdOIpNOL1f/Firj\n iO3rlL+RNHQmNHulA2+8BJDZ7rrf0Zk8Xe83jJ/7e7FdqtIiib3DQGnQZj8X6bk7CG+z+VCS+v7\n rt6tqT85rZHmjX8LBVxn+JmF0TKdKcmlCz6ZXWFok64/apAY6SOW5LCYdJXhrBCVGoMODuyES88\n IKnNrdLr5r64fcyjPnQIZVGdla5VG2Vb1wW/nD6ikej48nGPC2I0jBQ6af7dK740gd6eMdhcPr5\n 6i95ORloydmdbdw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This will allow to tweak argument handling more easily next.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nAcked-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n scripts/modinfo-generate.py | 23 ++++++++++++++---------\n 1 file changed, 14 insertions(+), 9 deletions(-)","diff":"diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py\nindex 8011c842caf..777d419aa33 100644\n--- a/scripts/modinfo-generate.py\n+++ b/scripts/modinfo-generate.py\n@@ -1,5 +1,6 @@\n #!/usr/bin/env python3\n \n+import argparse\n import os\n import sys\n from typing import Optional\n@@ -79,24 +80,28 @@ def print_post() -> None:\n     print(\"    /* end of list */\")\n     print(\"}};\")\n \n-def main(args: list[str]) -> None:\n-    if len(args) < 3 or args[0] != '--devices':\n-        print('Expected: modinfo-generate.py --devices '\n-              'config-device.mak [modinfo files]', file=sys.stderr)\n-        exit(1)\n+def main() -> None:\n+    parser = argparse.ArgumentParser(\n+        description='Generate C code for QEMU module info'\n+    )\n+    parser.add_argument('--devices', required=True,\n+                        help='path to config-device.mak')\n+    parser.add_argument('modinfo', nargs='+',\n+                        help='modinfo files to process')\n+    args = parser.parse_args()\n \n     # get all devices enabled in kconfig, from *-config-device.mak\n     enabled = set()\n-    with open(args[1]) as file:\n+    with open(args.devices) as file:\n         for line in file.readlines():\n             config = line.split('=')\n             if config[1].rstrip() == 'y':\n-                enabled.add(config[0][7:]) # remove CONFIG_\n+                enabled.add(config[0][7:])  # remove CONFIG_\n \n     deps = set()\n     modules = set()\n     print_pre()\n-    for modinfo in args[2:]:\n+    for modinfo in args.modinfo:\n         with open(modinfo) as f:\n             lines = f.readlines()\n         print(f\"    /* {modinfo} */\")\n@@ -116,4 +121,4 @@ def main(args: list[str]) -> None:\n         exit(1)\n \n if __name__ == \"__main__\":\n-    main(sys.argv[1:])\n+    main()\n","prefixes":["14/85"]}