{"id":2196776,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196776/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-10-edcb25699381@redhat.com>","date":"2026-02-16T10:42:22","name":"[10/85] scripts/modinfo: add type annotations","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9a93659b5f8f073b56dcb9160d053dff87d15b20","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-10-edcb25699381@redhat.com/mbox/","series":[{"id":492288,"url":"http://patchwork.ozlabs.org/api/1.0/series/492288/?format=json","date":"2026-02-16T10:42:12","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492288/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196776/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=K24PffuZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDzt52k6pz1xwF\n\tfor ; Mon, 16 Feb 2026 21:44:29 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrw4i-00024K-I0; Mon, 16 Feb 2026 05:43:32 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrw4R-0001um-EP\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:43:15 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrw4O-000132-OH\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:43:14 -0500","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-gTGoC5E4Mc-mfZgRvSoqEw-1; Mon,\n 16 Feb 2026 05:43:09 -0500","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4E3CA1955BC4; Mon, 16 Feb 2026 10:43:07 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 81FE31800666; Mon, 16 Feb 2026 10:43:05 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771238592;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GBqAgB7LrCGMYNH0r4X9ORm6NR49Rz7X+bLJoA4G3bU=;\n b=K24PffuZCwHG2LtnyXOU0HimLlSXTvOJGiS50Wccm7cPV3CWFIyQQ3k6dg95iPpc9ucySM\n 9X770gwTcsQpmdfD7A0Mkx3UzIl59JbkH+URq8gSVetTlx2OIROfbVIdJmg9wt/QKWTG5I\n WL9W1EbeFnf1RsfxyXmjgLWzQjqXNwY=","X-MC-Unique":"gTGoC5E4Mc-mfZgRvSoqEw-1","X-Mimecast-MFC-AGG-ID":"gTGoC5E4Mc-mfZgRvSoqEw_1771238587","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 11:42:22 +0100","Subject":"[PATCH 10/85] scripts/modinfo: add type annotations","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-10-edcb25699381@redhat.com>","References":"<20260216-audio-v1-0-edcb25699381@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-edcb25699381@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Yodel Eldar ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2026;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=5Hl18YRrW30PKleJRGv7L/P5HPSsWojpXhI13YBVZFo=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvSTwlin873L8ysaRz/9YgYOMO+hNVnQ5PXGB\n Vp3GOAZ0u2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL0kwAKCRDa6OEJdZac\n 5QTuD/4l92yligO4d0AcgObUitj42VI4W/47zn4QqUOJrHW9yw9mSOv2MnWXMy8SMqU3V5Yp0Df\n EnO2y36Fgd4T7Wcrw8YmKq+8PqQHN5Gkv/fx9e6kfle2bWCme+1NbUGBx8e+cEWlQt5nOSINFQf\n Hu0cVI7yftZlVhBSBb7cvdnmaFCDFmw3ityWhH28W4It/NHBMmDarFsQnErWtNBRVp9cs3/2DLz\n Ykb0ZrMrNRatbaarzMJ6nCO08agVLFqXSfXpzvzBmVh67bVW9LsSsEgiSUE1RMPa7at4aOV5DeK\n SHdOlD0vu1+zqlcaWCplXWc6i253jdGPNriV80uIDpq4O8eQWYx6RrhQlX/SvCWtT3DhRc86+aj\n obODEpTzrdDSObVF7kGfKvUP78GYuEXWhKdJpimzJqojSZoFxz9e2dHCBrMhGDUkhAbtnv9NjtU\n XakDsbDXvfC60y2M1Q2M5kE8H1sYcjEjBJUXX1wBgcrYWxMDPrRLeyjJNY7Pg5x0tjkUKHHcSgk\n nCMRrVMLS2rLI5yUHF9K+JB6o2UF5lzYZQqdH/a+keMAKEX1WIpjEHJXOT5+u18pXhySsAXC3nN\n 8RklayJlw3L3fBtEDRXWLeqW/71UHsApNFHxXcYs9jEWtwMMND91kJZMLB4Ur0JAYPXh8CfDyKr\n 8i7KfH2qL/ZrXtg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Type annotations allow easier code reading, refactoring, checking etc.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Yodel Eldar \nTested-by: Yodel Eldar \nAcked-by: Mark Cave-Ayland \n---\n scripts/modinfo-generate.py | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)","diff":"diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py\nindex aaf23544c46..5a8abcae5d3 100644\n--- a/scripts/modinfo-generate.py\n+++ b/scripts/modinfo-generate.py\n@@ -2,14 +2,16 @@\n \n import os\n import sys\n+from typing import Optional\n \n-def print_array(name, values):\n+\n+def print_array(name: str, values: list[str]) -> None:\n if len(values) == 0:\n return\n list = \", \".join(values)\n print(\" .%s = ((const char*[]){ %s, NULL }),\" % (name, list))\n \n-def parse_line(line):\n+def parse_line(line: str) -> tuple[str, str]:\n kind = \"\"\n data = \"\"\n get_kind = False\n@@ -31,7 +33,7 @@ def parse_line(line):\n continue\n return (kind, data)\n \n-def generate(name, lines, enabled):\n+def generate(name: str, lines: list[str], enabled: set[str]) -> Optional[set[str]]:\n arch = \"\"\n objs = []\n deps = []\n@@ -68,17 +70,17 @@ def generate(name, lines, enabled):\n print(\"},{\")\n return {dep.strip('\" ') for dep in deps}\n \n-def print_pre():\n+def print_pre() -> None:\n print(\"/* generated by scripts/modinfo-generate.py */\")\n print(\"#include \\\"qemu/osdep.h\\\"\")\n print(\"#include \\\"qemu/module.h\\\"\")\n print(\"const QemuModinfo qemu_modinfo[] = {{\")\n \n-def print_post():\n+def print_post() -> None:\n print(\" /* end of list */\")\n print(\"}};\")\n \n-def main(args):\n+def main(args: list[str]) -> None:\n if len(args) < 3 or args[0] != '--devices':\n print('Expected: modinfo-generate.py --devices '\n 'config-device.mak [modinfo files]', file=sys.stderr)\n","prefixes":["10/85"]}