{"id":2196771,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196771/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-4-edcb25699381@redhat.com>","date":"2026-02-16T10:42:16","name":"[04/85] audio/dbus: make \"dbus\" the default backend when using -display dbus","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b1baabaf73c85991404b69e61d99c2b0bfbe5406","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-4-edcb25699381@redhat.com/mbox/","series":[{"id":492288,"url":"http://patchwork.ozlabs.org/api/1.0/series/492288/?format=json","date":"2026-02-16T10:42:12","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492288/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196771/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=crpxsER1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDzsR6SVKz1xwF\n\tfor ; Mon, 16 Feb 2026 21:43:55 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrw4W-0001yw-VE; Mon, 16 Feb 2026 05:43:24 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrw4F-0001rX-6e\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:43:03 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrw4B-00010D-4J\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:43:02 -0500","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-SXMw1KXdPc2cPPzGTl4RVA-1; Mon,\n 16 Feb 2026 05:42:52 -0500","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D81511955D8B; Mon, 16 Feb 2026 10:42:49 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9DA231800464; Mon, 16 Feb 2026 10:42:47 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771238576;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=TQTKsJe+H0JmAEbmIdQJvVw5lqnUUPR6AFifO+6umuY=;\n b=crpxsER1bFNPHN3zvZSGL7LO4T/ImhutjN8kvegPunx4NlKeuAoAWy0HwizmnSHEEwut9m\n TfHETPZ20dqtSQPUqVkFbeHqG5xJ4X33LQKgZ/vBEY02hfQfOldu6Hjh/PMCrD75v5MNPQ\n oDiUy/sQwXNnhoUtuar1uX9m7O1oFdA=","X-MC-Unique":"SXMw1KXdPc2cPPzGTl4RVA-1","X-Mimecast-MFC-AGG-ID":"SXMw1KXdPc2cPPzGTl4RVA_1771238570","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 11:42:16 +0100","Subject":"[PATCH 04/85] audio/dbus: make \"dbus\" the default backend when\n using -display dbus","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-4-edcb25699381@redhat.com>","References":"<20260216-audio-v1-0-edcb25699381@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-edcb25699381@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3368;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=i0hZV7AIfgA8SuFqO30DlmD20T1D7KstDiHR2TRDsyg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvSTDaBeOarKtQb/e+z8GAIX3xq6nru0YkWgv\n K8KfVYKKg6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL0kwAKCRDa6OEJdZac\n 5YvtD/9EYxYxrAw3wrbHnG1FN7/B+BYmBhU8F/1AgWo85WfTJonNupBc4z3teykE2YpwHNvQ32b\n el8efRcYavgibMitmy/ffURLDKvDVH2ctbJ5qql4prRjiZSKIrD5qLtTVFT23YHoy5vu/NpIFDu\n Rc7ZP/2omTe0veZVgYISZ3b+1yMFATawB727eo5/L8tPfkTeSa9gsQ08uM3N3Aw3Ykf/M2NEQEs\n iUCdfoQfd4Oiqyc55Lrn8FXfiZGtbPaUbj0zdPrZIT60LHj2CMtP622JYqNiJAitsrV11ugPv1n\n gtq0Y6U8ixeiuWZBXMuM8+OPWSRdfSTcq/+B3WiRmoGQZNFgqEl3NAuV5/L/6oo8L2Gr87rw/1d\n 3zBHS1LgvHKP538d3Ek5CUZT8/SS0A3c3TT12INxCjfA3ZJLCe5Gat3l1t2yJD0K0eWr/F5lLgP\n K/4DlRyjkaBJ+CuWC3xxwmtsiJM84tMTmHHX6ejqi5RnGHvstOP26+vzlX+H2cFh9IaJYE952y4\n lDO/OSrcUBFYndHmFzqmfHlM+OBHqTnXEYfDIi9cOUo73Kbfomkx+2AVtyjt1H5Pj+O3XKujmk+\n z3VtwzFPEXuF9yuc/IkvBbXPRJ5ChSO6P3CRxGse/r0qZU36yE74ksMs4dA3lwHATeKFDU7fuse\n 0a2TQC5mRZDLUAQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Set \"using_dbus_display\" during early_dbus_init(), so that we can try to\ncreate the \"dbus\" audio backend by default from audio_prio_list.\n\nThis makes dbus audio work by default when using an audio device,\nwithout having to setup and wire up the -audiodev manually.\n\nThe added FIXME is addressed in the following commits.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/audio.c | 3 +++\n audio/dbusaudio.c | 8 +++++++-\n ui/dbus.c | 22 +++++++++++++++++-----\n 3 files changed, 27 insertions(+), 6 deletions(-)","diff":"diff --git a/audio/audio.c b/audio/audio.c\nindex a218570a4f4..9563583cd1e 100644\n--- a/audio/audio.c\n+++ b/audio/audio.c\n@@ -58,6 +58,9 @@\n that we generate the list.\n */\n const char *audio_prio_list[] = {\n+#ifdef CONFIG_GIO\n+ \"dbus\",\n+#endif\n \"spice\",\n CONFIG_AUDIO_DRIVERS\n \"none\",\ndiff --git a/audio/dbusaudio.c b/audio/dbusaudio.c\nindex d729a810aa6..1fe7c4ed647 100644\n--- a/audio/dbusaudio.c\n+++ b/audio/dbusaudio.c\n@@ -32,6 +32,7 @@\n #endif\n \n #include \"ui/dbus.h\"\n+#include \"ui/dbus-display.h\"\n #include \"ui/dbus-display1.h\"\n \n #define AUDIO_CAP \"dbus\"\n@@ -408,8 +409,13 @@ dbus_enable_in(HWVoiceIn *hw, bool enable)\n static void *\n dbus_audio_init(Audiodev *dev, Error **errp)\n {\n- DBusAudio *da = g_new0(DBusAudio, 1);\n+ DBusAudio *da;\n \n+ if (!qemu_using_dbus_display(errp)) {\n+ return NULL;\n+ }\n+\n+ da = g_new0(DBusAudio, 1);\n da->dev = dev;\n da->out_listeners = g_hash_table_new_full(g_str_hash, g_str_equal,\n g_free, g_object_unref);\ndiff --git a/ui/dbus.c b/ui/dbus.c\nindex 31f6eb1189f..0be1931d208 100644\n--- a/ui/dbus.c\n+++ b/ui/dbus.c\n@@ -35,6 +35,7 @@\n #include \"ui/egl-context.h\"\n #endif\n #include \"qemu/audio.h\"\n+#include \"audio/audio_int.h\" /* FIXME: use QOM dynamic cast instead of drv->name */\n #include \"qapi/error.h\"\n #include \"trace.h\"\n \n@@ -218,9 +219,20 @@ dbus_display_complete(UserCreatable *uc, Error **errp)\n return;\n }\n \n- if (dd->audiodev && *dd->audiodev) {\n- AudioBackend *audio_be = audio_be_by_name(dd->audiodev, errp);\n- if (!audio_be || !audio_be_set_dbus_server(audio_be, dd->server, dd->p2p, errp)) {\n+ {\n+ AudioBackend *audio_be = audio_get_default_audio_be(NULL);\n+\n+ if (audio_be && !g_str_equal(audio_be->drv->name, \"dbus\")) {\n+ audio_be = NULL;\n+ }\n+ if (dd->audiodev && *dd->audiodev) {\n+ audio_be = audio_be_by_name(dd->audiodev, errp);\n+ if (!audio_be) {\n+ return;\n+ }\n+ }\n+ if (audio_be &&\n+ !audio_be_set_dbus_server(audio_be, dd->server, dd->p2p, errp)) {\n return;\n }\n }\n@@ -475,6 +487,8 @@ early_dbus_init(DisplayOptions *opts)\n #endif\n }\n \n+ using_dbus_display = 1;\n+\n type_register_static(&dbus_vc_type_info);\n }\n \n@@ -488,8 +502,6 @@ dbus_init(DisplayState *ds, DisplayOptions *opts)\n exit(1);\n }\n \n- using_dbus_display = 1;\n-\n object_new_with_props(TYPE_DBUS_DISPLAY,\n object_get_objects_root(),\n \"dbus-display\", &error_fatal,\n","prefixes":["04/85"]}