{"id":2196683,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196683/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216034432.23912-12-richard.henderson@linaro.org>","date":"2026-02-16T03:44:30","name":"[RFC,11/13] target/arm: Add have_ffr argument to kvm_arch_{get, put}_sve","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"37256ab7d1c0209cfb40f05025b0de1d802d710e","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.0/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216034432.23912-12-richard.henderson@linaro.org/mbox/","series":[{"id":492243,"url":"http://patchwork.ozlabs.org/api/1.0/series/492243/?format=json","date":"2026-02-16T03:44:19","name":"target/arm: Support SME for KVM","version":1,"mbox":"http://patchwork.ozlabs.org/series/492243/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196683/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kwi7nVc6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDpZW1853z1xpl\n\tfor ; Mon, 16 Feb 2026 14:45:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrpXs-0002jO-OQ; Sun, 15 Feb 2026 22:45:12 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrpXn-0002dQ-AQ\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 22:45:07 -0500","from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vrpXi-0002Sg-8V\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 22:45:05 -0500","by mail-pl1-x630.google.com with SMTP id\n d9443c01a7336-2a95bfdb31eso11641875ad.3\n for ; Sun, 15 Feb 2026 19:45:01 -0800 (PST)","from stoup.. ([2401:d002:dc0f:2100:4a1:428a:70f2:5844])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ad1aadca84sm53294155ad.70.2026.02.15.19.44.59\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 15 Feb 2026 19:45:00 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771213501; x=1771818301; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=z1G5iNA34KzEcs/mYmm8XYsWLt81ZFoJDv6FYs6NiaA=;\n b=kwi7nVc6QNCz+twvT7taGz94R89q21zSZ0wbr3R1uG0jN7BvRdf5vlSE8qC2DfKMXI\n OrwLnkcndNVlEvZno48kVk9sWYfkGipOMUeaHord0OWpfalA0bPe6fdM1cxf5SCq3b9E\n 362i9L00u6cbQxpY4ZLrwlYkrcecnYfzOI+sTSfhojIBloTQXyYFkY06QpIZ45Geuy8x\n Osl2Pj7I5s5sgWnMy61qiICf+mTziDKOUY7Rc7f5gUkgNW6wvlYaqwE4LjEJwZ3M77/s\n JhjmCRWSbSEmGi82UdDQPRHo2SBKUGmfMPRCoxb3idAQD00bJDFWqeLNIKee6VUNJlUW\n lxvg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771213501; x=1771818301;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=z1G5iNA34KzEcs/mYmm8XYsWLt81ZFoJDv6FYs6NiaA=;\n b=eR6Cd59swfcYhe2g+JLfBWM3e64vK8nsbB6BWDFuhrNN8MFbmCEH99QpaSU4Qbvqa2\n W2Pb0vD32N83o0xsgEkV0qHbTZLJu+5tDyqkwe1lcOP3xMwKv5velAZHrDruVFx92Pa4\n Jz2QOFrCC7ui5rV64GBlecNU83tmKsZfM30vF4rb+Dzs10nia+9bKe/jX+GRhl3i49o/\n jCx5c1w97dIyQ5CgMduyUJwCnvwBxg3BnNRfWr4jQsbhXe3NcnIIj7KVjouaxWu/GXTE\n LSiz5OnX8jCLtSoTyXjFA6AweCZv8sUJ1ZXk/sANl/W1xXknoaDlFB64DKkVJ/ZRibnc\n WFTg==","X-Gm-Message-State":"AOJu0Yzyi6G40P96tyriI0LvSRHPu7lHo7VxUZSXF83QednRl4xSWeuJ\n D85ZR1MsakUraYhllT5ToaRNATNB+sW+szp7DlLjGn3xiRbDT/13aVxiHi4xBlye2SThslqFZl8\n X5p83hvw=","X-Gm-Gg":"AZuq6aKOmP+4mn72/f6Qog2fdHaTM2t/60DcMAAfDaPLRaiI0PmnwLbbsYd3/66IBP/\n H6/5Hw0/G64CNp6ZnS//aur1m1EsITxLJkXXvWf2JQESe3NxPh5zXsBf9po5hElB0kxDSkxKJW/\n 8hdpI29v08rjOdVg+rDSpnbZr4O7ycJm7q2EvruMKjRcaKvH+Ig+w6Op2uPgUFvaWSXYt2axcAn\n ZGlOKqeSCuJthVWUfZGcHAtmihAt/CvIPaWKTT56jsBITfL8R63ylwXQYoQHg+WtG/IjaP9W/mc\n 2fspiY9jKuHVGjFW6zi+u/RS4aYC5xHvo1oE6k7GC8D06T1mQxhD4pslhpmM0kwzeUusmcqGJDA\n zMoBME2znOERnXDPlQzdI2apX9QnvKuhgvfFqd5qEQImVKOgjD/kX+OeuRO7hvOga6V6QwhpI91\n XjwuW80TJmA6zacDoQf8K/W3L8vM0SmIt8","X-Received":"by 2002:a17:903:fb0:b0:2a9:4870:9606 with SMTP id\n d9443c01a7336-2ab505ca1b6mr81683365ad.42.1771213500789;\n Sun, 15 Feb 2026 19:45:00 -0800 (PST)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Subject":"[RFC PATCH 11/13] target/arm: Add have_ffr argument to kvm_arch_{get,\n put}_sve","Date":"Mon, 16 Feb 2026 13:44:30 +1000","Message-ID":"<20260216034432.23912-12-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260216034432.23912-1-richard.henderson@linaro.org>","References":"<20260216034432.23912-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::630;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Richard Henderson \n---\n target/arm/kvm.c | 32 ++++++++++++++++++--------------\n 1 file changed, 18 insertions(+), 14 deletions(-)","diff":"diff --git a/target/arm/kvm.c b/target/arm/kvm.c\nindex f6bab562a0..d05ad1d7e1 100644\n--- a/target/arm/kvm.c\n+++ b/target/arm/kvm.c\n@@ -2122,7 +2122,7 @@ static int kvm_arch_put_fpsimd(CPUState *cs)\n * code the slice index to zero for now as it's unlikely we'll need more than\n * one slice for quite some time.\n */\n-static int kvm_arch_put_sve(CPUState *cs, uint32_t vq)\n+static int kvm_arch_put_sve(CPUState *cs, uint32_t vq, bool have_ffr)\n {\n CPUARMState *env = cpu_env(cs);\n uint64_t tmp[ARM_MAX_VQ * 2];\n@@ -2145,11 +2145,13 @@ static int kvm_arch_put_sve(CPUState *cs, uint32_t vq)\n }\n }\n \n- r = sve_bswap64(tmp, &env->vfp.pregs[FFR_PRED_NUM].p[0],\n- DIV_ROUND_UP(vq * 2, 8));\n- ret = kvm_set_one_reg(cs, KVM_REG_ARM64_SVE_FFR(0), r);\n- if (ret) {\n- return ret;\n+ if (have_ffr) {\n+ r = sve_bswap64(tmp, &env->vfp.pregs[FFR_PRED_NUM].p[0],\n+ DIV_ROUND_UP(vq * 2, 8));\n+ ret = kvm_set_one_reg(cs, KVM_REG_ARM64_SVE_FFR(0), r);\n+ if (ret) {\n+ return ret;\n+ }\n }\n \n return 0;\n@@ -2238,7 +2240,7 @@ int kvm_arch_put_registers(CPUState *cs, KvmPutState level, Error **errp)\n }\n \n if (cpu_isar_feature(aa64_sve, cpu)) {\n- ret = kvm_arch_put_sve(cs, cpu->sve_max_vq);\n+ ret = kvm_arch_put_sve(cs, cpu->sve_max_vq, true);\n } else {\n ret = kvm_arch_put_fpsimd(cs);\n }\n@@ -2304,7 +2306,7 @@ static int kvm_arch_get_fpsimd(CPUState *cs)\n * code the slice index to zero for now as it's unlikely we'll need more than\n * one slice for quite some time.\n */\n-static int kvm_arch_get_sve(CPUState *cs, uint32_t vq)\n+static int kvm_arch_get_sve(CPUState *cs, uint32_t vq, bool have_ffr)\n {\n CPUARMState *env = cpu_env(cs);\n uint64_t *r;\n@@ -2328,12 +2330,14 @@ static int kvm_arch_get_sve(CPUState *cs, uint32_t vq)\n sve_bswap64(r, r, DIV_ROUND_UP(vq * 2, 8));\n }\n \n- r = &env->vfp.pregs[FFR_PRED_NUM].p[0];\n- ret = kvm_get_one_reg(cs, KVM_REG_ARM64_SVE_FFR(0), r);\n- if (ret) {\n- return ret;\n+ if (have_ffr) {\n+ r = &env->vfp.pregs[FFR_PRED_NUM].p[0];\n+ ret = kvm_get_one_reg(cs, KVM_REG_ARM64_SVE_FFR(0), r);\n+ if (ret) {\n+ return ret;\n+ }\n+ sve_bswap64(r, r, DIV_ROUND_UP(vq * 2, 8));\n }\n- sve_bswap64(r, r, DIV_ROUND_UP(vq * 2, 8));\n \n return 0;\n }\n@@ -2421,7 +2425,7 @@ int kvm_arch_get_registers(CPUState *cs, Error **errp)\n }\n \n if (cpu_isar_feature(aa64_sve, cpu)) {\n- ret = kvm_arch_get_sve(cs, cpu->sve_max_vq);\n+ ret = kvm_arch_get_sve(cs, cpu->sve_max_vq, true);\n } else {\n ret = kvm_arch_get_fpsimd(cs);\n }\n","prefixes":["RFC","11/13"]}