{"id":2196650,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196650/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260215220422.212249-6-ltaylorsimpson@gmail.com>","date":"2026-02-15T22:04:19","name":"[v2,5/8] Hexagon (target/hexagon) Check each opcode against current CPU version","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"448eab6498c14330f57cbcab6ba2edc18b01de01","submitter":{"id":86757,"url":"http://patchwork.ozlabs.org/api/1.0/people/86757/?format=json","name":"Taylor Simpson","email":"ltaylorsimpson@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260215220422.212249-6-ltaylorsimpson@gmail.com/mbox/","series":[{"id":492234,"url":"http://patchwork.ozlabs.org/api/1.0/series/492234/?format=json","date":"2026-02-15T22:04:17","name":"Hexagon (target/hexagon) Check opcodes versions","version":2,"mbox":"http://patchwork.ozlabs.org/series/492234/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196650/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=h4XHvTwK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDg223t7Wz1xpY\n\tfor ; Mon, 16 Feb 2026 09:05:13 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrkEM-0005YC-WC; Sun, 15 Feb 2026 17:04:43 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrkEG-0005W1-Hk\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 17:04:37 -0500","from mail-oa1-x30.google.com ([2001:4860:4864:20::30])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vrkEE-00052I-Pj\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 17:04:36 -0500","by mail-oa1-x30.google.com with SMTP id\n 586e51a60fabf-40970f97638so1663270fac.3\n for ; Sun, 15 Feb 2026 14:04:33 -0800 (PST)","from taylor-ubuntu.. (c-67-172-136-152.hsd1.co.comcast.net.\n [67.172.136.152]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-40eaf101db0sm13556664fac.12.2026.02.15.14.04.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 15 Feb 2026 14:04:31 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771193072; x=1771797872; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kXEJCL5cVLliSmY30ZH77XTZKe2cKnewsMO5lSHXqmY=;\n b=h4XHvTwK7lL/tjXRdT/M94rc/k8mCC6BNeIvw+jrCikRd+q0Ypl635W+hIwFW9DTFa\n HnCaGG8Qgfh7Dx3u1pQPwAzYrRHKFR1jKvhCfmqUh4lkzkxdwLBwAGGXS9TqdyuIXMlT\n groblfYMX/yBxpACeJvXjXUvcCohqXpQMCC+tOLU72ZE9vm7ySLXAdPQS440FWhjmROK\n b1AfDJVfikhG0Dk3u4nAInFomJMERHfWTJkGGUSA37b+qzty2JDD62lCsPiIeyJALbyC\n LoYplffqDCmtVnSvoVL4DJI/Vskd3yyFRdVkwQ/lGZEXofuv6OpKE7pY5Co7+4hGl1w9\n V+OA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771193072; x=1771797872;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=kXEJCL5cVLliSmY30ZH77XTZKe2cKnewsMO5lSHXqmY=;\n b=k814Sx6r9eFhBa4FyUSMzNnyoB8zpYL09oIy35gKipO1DBhtV+TNt2CsFohFaIDtT/\n Qqb6VHow4DbLGGy/3+qB+DdAM7MaSa6s2uL68DiqfLI8QhEnJVGqlRBGk6uNJPASI0jK\n CyMBpA84n7ihUZOESuhFrC6z8pw8endj1pXIVRQzfj8mW4pKs4YjPzRjiW5Aq5ENylTq\n qBaDJnoHBLPO9qTQBqOhlGo78F56d66By0Bdv9meB4VRs0g62O49eXDvKQmXeg3xymwn\n O/CPc3zFfzbNB9ZbDtpG866YHVwEVPAGJ9SJDTvaJXcVX9BIDyiNyvr2ef7+YJ+fA52O\n fu2g==","X-Gm-Message-State":"AOJu0YxBmTNnFGR3eFCpVoY1Y5mn9ti1JNvY3QiLUWdmH9eSyyw6YAAY\n 9Kzie1db+6rAtdNogVe2OkE5RKom9D9mEvYatBnOWXjG4QxErF55/NxkjwVDxA==","X-Gm-Gg":"AZuq6aIXGHwWGknJQmO0V+olr0WdMk+NJYrkr2fcuz0JHO9cb/Xgr0GYIc2k0+lI4aM\n bben7y2oAtD/YT+OzgfXArqbaFmmbrwhobjCKqUaqpGx0yw46+tXI/66yyRNPKmEANxn3aGALuy\n n0UA4plMuS6FqqLJSpzwnqqU+bWQuVGE7drmsP+XFInoqK0/YSUTBbbLAJ/gz/PA/cF2SMthncs\n /tBaeNHIy8GPOc4hgY1TORXHzP/KqEFT6wmEepV6tI3MiEtXre5oDsXk4CPWQvTAlwSXB438wD9\n 1wSzPTFCBf1Cp+mNeiLNIpfnh9bok5QbQrHV4MVutWP3H3o2XN1KXm94QF/f5ab2pFtwvQ4NgKQ\n 4ymiU8/gpAnbrOZUuRGWyuVnVsea08K9wBJrrtqoT62LCJClesAAIaSZjyZFcT4QYj9YBQ2bcim\n YsO6t5rK7HOBR5KFWHCcCgJjEHZ8w3gNP38VITH8KHuhh6E4WwmIEJPBOGDItwPzzO5Xp+7UhQm\n YvqRvc9PDJee+qm","X-Received":"by 2002:a05:6870:6494:b0:409:74c7:1cbb with SMTP id\n 586e51a60fabf-40ef3bab1e0mr4953045fac.7.1771193072463;\n Sun, 15 Feb 2026 14:04:32 -0800 (PST)","From":"Taylor Simpson ","To":"qemu-devel@nongnu.org","Cc":"brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com,\n sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng,\n ltaylorsimpson@gmail.com","Subject":"[PATCH v2 5/8] Hexagon (target/hexagon) Check each opcode against\n current CPU version","Date":"Sun, 15 Feb 2026 15:04:19 -0700","Message-ID":"<20260215220422.212249-6-ltaylorsimpson@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260215220422.212249-1-ltaylorsimpson@gmail.com>","References":"<20260215220422.212249-1-ltaylorsimpson@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2001:4860:4864:20::30;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-oa1-x30.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"During decoding, check that the opcode is supported in the current\nHexagon CPU version\n\nCo-authored-by: Matheus Tavares Bernardino \nCo-authored-by: Brian Cain \nSigned-off-by: Taylor Simpson \n---\n target/hexagon/decode.h | 2 ++\n target/hexagon/decode.c | 26 ++++++++++++++++++++++++++\n 2 files changed, 28 insertions(+)","diff":"diff --git a/target/hexagon/decode.h b/target/hexagon/decode.h\nindex 3f3012b978..44fea2b37c 100644\n--- a/target/hexagon/decode.h\n+++ b/target/hexagon/decode.h\n@@ -30,4 +30,6 @@ void decode_send_insn_to(Packet *packet, int start, int newloc);\n int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n Packet *pkt, bool disas_only);\n \n+bool opcode_supported(uint16_t opcode, HexagonVersion hex_version);\n+\n #endif\ndiff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex dbc9c630e8..b02a402dfa 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -647,6 +647,21 @@ decode_set_slot_number(Packet *pkt)\n return has_valid_slot_assignment(pkt);\n }\n \n+bool opcode_supported(uint16_t opcode, HexagonVersion hex_version)\n+{\n+#include \"tag_rev_info.c.inc\"\n+\n+ struct tag_rev_info info = tag_rev_info[opcode];\n+ if (hex_version == HEX_VER_ANY) {\n+ return true;\n+ }\n+ if ((info.introduced != HEX_VER_NONE && hex_version < info.introduced) ||\n+ (info.removed != HEX_VER_NONE && hex_version >= info.removed)) {\n+ return false;\n+ }\n+ return true;\n+}\n+\n /*\n * Check for GPR write conflicts in the packet.\n * A conflict exists when a register is written by more than one instruction\n@@ -746,6 +761,17 @@ int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n /* Ran out of words! */\n return 0;\n }\n+\n+ /*\n+ * Check that all the opcodes are supported in this Hexagon version\n+ * If not, return decode error\n+ */\n+ for (i = 0; i < num_insns; i++) {\n+ if (!opcode_supported(pkt->insn[i].opcode, ctx->hex_version)) {\n+ return 0;\n+ }\n+ }\n+\n pkt->encod_pkt_size_in_bytes = words_read * 4;\n pkt->pkt_has_hvx = false;\n for (i = 0; i < num_insns; i++) {\n","prefixes":["v2","5/8"]}