{"id":2196572,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196572/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260215052225.22513-4-mohamed@unpredictable.fr>","date":"2026-02-15T05:22:14","name":"[v3,03/14] target/i386/emulate/x86_decode: Actually use stream in decode_instruction_stream()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"618c4fc9a5befdd72b0c76792e2b6d1f676047d5","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.0/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260215052225.22513-4-mohamed@unpredictable.fr/mbox/","series":[{"id":492201,"url":"http://patchwork.ozlabs.org/api/1.0/series/492201/?format=json","date":"2026-02-15T05:22:12","name":"whpx: x86 updates (2026-02)","version":3,"mbox":"http://patchwork.ozlabs.org/series/492201/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196572/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=f8YthMz0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDDqv5G8Qz1xwj\n\tfor ; Sun, 15 Feb 2026 16:24:59 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrUat-0000K2-2O; Sun, 15 Feb 2026 00:22:55 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrUan-0000HP-6z\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 00:22:49 -0500","from p-west2-cluster2-host4-snip4-10.eps.apple.com ([57.103.68.163]\n helo=outbound.mr.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrUal-0004r7-QF\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 00:22:48 -0500","from outbound.mr.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-1 (Postfix) with ESMTPS id\n 1EBDD18001A2; Sun, 15 Feb 2026 05:22:42 +0000 (UTC)","from localhost.localdomain (unknown [17.57.152.38])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-1 (Postfix) with ESMTPSA id\n 8343C180012A; Sun, 15 Feb 2026 05:22:39 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1771132965; x=1773724965;\n bh=TBcGIKmuSULMyOi4UlYOjKB/stF+pgu+MSF/fkSj9a8=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=f8YthMz0o4giU9OOIekHnZoZIoz4mcZHFc1W519a9V+A7msvWhhuzdDTgTf/xElK/BESQhK/V/4Q/Bchdq5lRZNBK+NSxSK3QYJPn0qAl9EOqB/42KIoUbOW7CKQSGFoUJBpGXVHG8pDxTPN4p8XjKvmOhCgshYSIYGsYZ09mhZ3fvf+7f8xPrVYTAmhKoteDnrQ/84gt11347PjZYML3GO/HKcpFhrBdgtteiuAWWt182l2uyllWJ2y8F95g0Ce5f7dPaCmibwfilj8tTq51LgBecF1E/GshKN/kN5H3BRZHrP8qe1hIfFJN2rI3FEStm/7lei2XAEPt5hdxPxJjQ==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Phil Dennis-Jordan ,\n Bernhard Beschow , Cameron Esfahani ,\n Magnus Kulke , qemu-arm@nongnu.org,\n Peter Maydell ,\n Roman Bolshakov , Paolo Bonzini ,\n Mohamed Mediouni ,\n Pedro Barbuda ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc?=\n\t=?utf-8?q?-Andr=C3=A9_Lureau?= ,\n Magnus Kulke , =?utf-8?q?Philippe_Mathieu?=\n\t=?utf-8?q?-Daud=C3=A9?= , Wei Liu ,\n Zhao Liu ","Subject":"[PATCH v3 03/14] target/i386/emulate/x86_decode: Actually use stream\n in decode_instruction_stream()","Date":"Sun, 15 Feb 2026 06:22:14 +0100","Message-ID":"<20260215052225.22513-4-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260215052225.22513-1-mohamed@unpredictable.fr>","References":"<20260215052225.22513-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-GUID":"b_jBMdWMEkb_6g2HHMyv-q3N5RNHxAce","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjE1MDAzNiBTYWx0ZWRfX7mXjxeSdnX+C\n yS9Mn/juMUpbpzN+61XByqUVIRAUW6vO8kfmny15AOVSyDySlocRgFBe5OvTWHD1lUjfiBRDmpI\n tJkZ8FBOUGR98BhQ/ygxQ2WYbletNNOwAK+UunKKhEQx7lmIRB2fk1hof/1T5/ws72S9W9fKNl+\n xetAYkCEXJSSOg7TAh8oqz78pnB6E2lQfGKAibnBH1BNi1esKhczgXCBef1gPtuLj80eHZiu4CI\n UKoZxbZ4J40TlzqBjZ6Ob7iz6b9sU+iwudMZ1lh1oZ9V6quZXrHfyI+cS5k2gIg5w8Dti4lBoZk\n MvhUbsu/MckbRug8mgcyY88Kv5jRhOuNJVG6WMgTXMKXMJ9cSLCyMCMETug9pE=","X-Proofpoint-ORIG-GUID":"b_jBMdWMEkb_6g2HHMyv-q3N5RNHxAce","X-Authority-Info-Out":"v=2.4 cv=SPxPlevH c=1 sm=1 tr=0 ts=69915824\n cx=c_apl:c_apl_out:c_pps a=9OgfyREA4BUYbbCgc0Y0oA==:117\n a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=pGLkceISAAAA:8\n a=s2ha6HylF4ed1T9rlyMA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-15_02,2026-02-13_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 phishscore=0\n suspectscore=0 bulkscore=0 malwarescore=0 mlxlogscore=761 spamscore=0\n lowpriorityscore=0 adultscore=0 mlxscore=0 clxscore=1030 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602150036","X-JNJ":"\n AAAAAAABlnaTh9ysUGhu40BYHDKldA01gyoWpgBGLdMq9ZawTbEsOZ2o28fC5LDYS075yMBI73195JQ1GaPg2IRLQrkNUxir5j2xGm+NV++UHopT7wnleM+St7bz5SM2ZXd8C0wkeJKQig/BGxh/qcLhp2+IoNkFPaYKQNyL3v8C2PbIB6Cy5QdXAuIQ24ohvr2sE1fL0LduQ9UlekKGmeRiEjyTPC7/WOqXjlVTLYvg51HLUCukDjCaxpyj5Eqzn6xkW/y3hink63hKQ7WxXu89kykwVTXrZjoXKO9Y88xE1/w+IXy8bXoHol5wTH/CsRLSQBjPVoRHX1w3SDj7gfl6HSfQsw/RO6URViQFTMyH2c6m0hG5/oGdKPJ+0ewmYlcB2RzTEezHo2mgORGNyyfJQAo1u2FcT9LcgpucQ6BAXlApZKkY5nW1DdFi6eJDmuJsPrukACecgHKJbau8Q0f+Sd7lGVEI8jxgJDiLK1kaYkw9TyqDUWVHv9VtvGSB/xa0eDwI9Jpn4SqZVpQDwYNGQ/9IAsmfGhsQZKmBMXCx3BVDC89zTKFMjAz9g2dwyzIoeC3oqFYmu0xI0X01TSkigXJTzvkxWCqk7GhfN3O0ezeGxyYqiqmtp294d5tqr/46zkbkWtBVka17LZbPYPQ99YwjDEgUWK69ACU46iNmuFxUK71fO7WCM18gj3T/5PJZCNwgYeB0zg+7J9OwNvTqP05F768jucZBJQqnTjWi0KGYkmrNQjc1gBr6fPCGR9ePLArl7r+5gzG5zNioBZyD9gIZ5o+DCpRkqrYNqDfx0CVaCXyE34xp0siwkq8=","Received-SPF":"pass client-ip=57.103.68.163;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Bernhard Beschow \n\nCompared to decode_instruction(), decode_instruction_stream() has an additional\nstream parameter which avoids some guest memory accesses during instruction\ndecoding. Both functions defer the actual work to decode_opcode() which would\nset the stream pointer to zero such that decode_instruction_stream() essentially\nbehaved like decode_instruction(). Given that all callers of\ndecode_instruction_stream() properly zero-initialize the decode parameter, the\nmemset() call can be moved into decode_instruction() which is the only other\nuser of decode_opcode(). This preserves the non-zero stream pointer which\navoids extra guest memory accesses.\n\nFixes: 1e25327b244a (\"target/i386/emulate: Allow instruction decoding from stream\")\ncc: qemu-stable\nSigned-off-by: Bernhard Beschow \nReviewed-by: Mohamed Mediouni \n---\n target/i386/emulate/x86_decode.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/target/i386/emulate/x86_decode.c b/target/i386/emulate/x86_decode.c\nindex 6ad03b71b0..7bbcd2a9a2 100644\n--- a/target/i386/emulate/x86_decode.c\n+++ b/target/i386/emulate/x86_decode.c\n@@ -2088,8 +2088,6 @@ static void decode_opcodes(CPUX86State *env, struct x86_decode *decode)\n \n static uint32_t decode_opcode(CPUX86State *env, struct x86_decode *decode)\n {\n- memset(decode, 0, sizeof(*decode));\n-\n decode_prefix(env, decode);\n set_addressing_size(env, decode);\n set_operand_size(env, decode);\n@@ -2101,6 +2099,8 @@ static uint32_t decode_opcode(CPUX86State *env, struct x86_decode *decode)\n \n uint32_t decode_instruction(CPUX86State *env, struct x86_decode *decode)\n {\n+ memset(decode, 0, sizeof(*decode));\n+\n return decode_opcode(env, decode);\n }\n \n","prefixes":["v3","03/14"]}