{"id":2196570,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196570/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260215052225.22513-6-mohamed@unpredictable.fr>","date":"2026-02-15T05:22:16","name":"[v3,05/14] whpx: i386: re-enable guest debug support","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f276bb3abeb58a991cd0c045aa799bfc0505c75e","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.0/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260215052225.22513-6-mohamed@unpredictable.fr/mbox/","series":[{"id":492201,"url":"http://patchwork.ozlabs.org/api/1.0/series/492201/?format=json","date":"2026-02-15T05:22:12","name":"whpx: x86 updates (2026-02)","version":3,"mbox":"http://patchwork.ozlabs.org/series/492201/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196570/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=XAhNxkPv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDDqX2JHcz1xwj\n\tfor ; Sun, 15 Feb 2026 16:24:40 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrUaw-0000MG-WB; Sun, 15 Feb 2026 00:22:59 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrUar-0000Ji-Gp\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 00:22:53 -0500","from p-west2-cluster2-host5-snip4-10.eps.apple.com ([57.103.68.233]\n helo=outbound.mr.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrUaq-0004rx-1c\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 00:22:53 -0500","from outbound.mr.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-1 (Postfix) with ESMTPS id\n D2FA818006A4; Sun, 15 Feb 2026 05:22:49 +0000 (UTC)","from localhost.localdomain (unknown [17.57.152.38])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-1 (Postfix) with ESMTPSA id\n 5B86A1800139; Sun, 15 Feb 2026 05:22:46 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1771132971; x=1773724971;\n bh=g4l1jVkhlHtyjTxoP0r17Oazu+fhT089N6+xSJMvRqw=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme;\n b=XAhNxkPveYSk0Fn3vUn6r+n8a3yELLak2Tuj8Kb5FCkFWdHV/i2ZmWnLCbXVFIVG0KxjRWaL936A2UD9MgIszDLPpXdd+kuTuvzqfGbid9VDzQlU01oK5wL3ZVVl1InS17PQDBDZdqRK35AAFu67HhFYGYXl/zIL0JRZ/OW3q/gtGTGZP6XqY6njqOPz2XaXUB4doxMEfKoTU0pucd1K8GKMGURrKV1Y9FaR1BB4uoI0fw/3SV+IjrUEcCvNd839uOKylv+pkcbhD/KDrNYQIFRMbGmDDYxGH/7q0ZctPl2VdOb29/kJB5z0r0GuEiVPEPyb2wif7GWoRTdNv5nFYg==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Phil Dennis-Jordan ,\n Bernhard Beschow , Cameron Esfahani ,\n Magnus Kulke , qemu-arm@nongnu.org,\n Peter Maydell ,\n Roman Bolshakov , Paolo Bonzini ,\n Mohamed Mediouni ,\n Pedro Barbuda ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc?=\n\t=?utf-8?q?-Andr=C3=A9_Lureau?= ,\n Magnus Kulke , =?utf-8?q?Philippe_Mathieu?=\n\t=?utf-8?q?-Daud=C3=A9?= , Wei Liu ,\n Zhao Liu ","Subject":"[PATCH v3 05/14] whpx: i386: re-enable guest debug support","Date":"Sun, 15 Feb 2026 06:22:16 +0100","Message-ID":"<20260215052225.22513-6-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260215052225.22513-1-mohamed@unpredictable.fr>","References":"<20260215052225.22513-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Proofpoint-GUID":"XiaA0KN2AdxkcZLlcoKsPDlDaWX24kWB","X-Proofpoint-ORIG-GUID":"XiaA0KN2AdxkcZLlcoKsPDlDaWX24kWB","X-Authority-Info-Out":"v=2.4 cv=bIEb4f+Z c=1 sm=1 tr=0 ts=6991582a\n cx=c_apl:c_apl_out:c_pps a=9OgfyREA4BUYbbCgc0Y0oA==:117\n a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=KKAkSRfTAAAA:8 a=VEyhEb3DslDlV8q9E0oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjE1MDAzNiBTYWx0ZWRfXxVMNMWmAw4wL\n WNV0WwhtjBWrqg4o43rmsnuN1khRVRyDrADR4QZs7U1aUGdf3exkIqNxjriszRaa0nhljUFdVQr\n MVedGZSWlNv3yc9jnOUM3AnpWdbAsuGocSgMvan00do1trq+JBG/uNR038OJjmjG0KywcYpRZb+\n LU3rz8xYPkLB8p3Hk3RUUb8vTj67OAvHu7vOzRfcwt9lhVQxIRstwOzaW5cbnyYpEozactz+gLU\n UYe5MYutvCKSIPCZPI6FxKmduUv11RXiPaSkcEO/fr2ewqNJlr7lFxLBDQtqhMQaEjQKEZrUwWd\n DaqpX3j9hwYGXBWRgrPluXWYMGnCT5Y41OUJjz44jsc7FASKAOK+0W/qhO6gv4=","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-15_02,2026-02-13_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 mlxscore=0\n spamscore=0 clxscore=1030 adultscore=0 mlxlogscore=999 lowpriorityscore=0\n malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602150036","X-JNJ":"\n AAAAAAAB2Q1SF7T/eYbl7XszjmMKONTONKbrkuRT+NP3EtdzSIB6E9GHz3cJOn7HxxKcrUUEzveq6cIhuM2t5ZUO2HAzuZMSJIMp9Vy3yKPIqrYmsLLZiR3+gDjHD8IHfOTxtSAzzCJPNH/4bnwL+i3caCgYnUmoksU837VgccTZ1EVNiXtAyec/xUM8MFyGy0TS6vUNbzDgspm35Dv9Jy8qWLaqkZekEnNDb1ltbKhpaExJR4eJOP6EE0mqLyJgwx7UziWm39BIk8sq2lKOKpGWNFf1rl8H9ldBDmAVuuPCwjP4YuyOqqd90uo4J4J0m7peYE7dKs9SbNQR0XeySJP9IKlqfEvM+sPr74I/Kb6UbOBVwblJSG09vEbgHTz/L0P8P5glqZobesNINx7FgYXxhTmhwTBLKE6djO64xNiknbOOWfofPM4lUhXhIVU6mLBCpHAZtZOSfZUzh/3ngPHWmFotVvWEWpYhGhNTQjzHRXQaR7frN4DFDYFccB13Cy4u3xGn54OSUHzahz3bINEEhR/Bk21YuPDzDI3F0OqYqhYqgpj1O9DHWqa54tdbkiK4EtFsduIm5g7vix50vVnZwoq1X7tlqIVG6ywbYX7HbC21oNwi6ECv3C5BW1pPHCO00GQnvigu2KTV2y/zR/JKjs2egTJHDbuYrhyNA6qHxrgLfKd+zeFQb0tBZM+ZlI2mIPyYvMoHfmB43HqtvLbmV5VRIoFXD9i0TfDLx5d9Oi/bKV8ELbjpPI66Tc4XfG+92mLAoAEJ2CSEmX4P8COcdAhzPDFkLQXAc1N6ougAnAZIXeMTls7Q77e2vsI=","Received-SPF":"pass client-ip=57.103.68.233;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Fix what got broken several years ago by adding ops->supports_guest_debug\nsupport as an architecture-specific function.\n\narm64 WHP doesn't currently provide support needed for this.\n\nSigned-off-by: Mohamed Mediouni \nReviewed-by: Philippe Mathieu-Daudé \n---\n accel/whpx/whpx-accel-ops.c | 8 ++++++++\n include/system/whpx-all.h | 4 ++++\n target/arm/whpx/whpx-all.c | 5 +++++\n target/i386/whpx/whpx-all.c | 5 +++++\n 4 files changed, 22 insertions(+)","diff":"diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c\nindex 50fadea0fd..b8f41544cb 100644\n--- a/accel/whpx/whpx-accel-ops.c\n+++ b/accel/whpx/whpx-accel-ops.c\n@@ -17,6 +17,7 @@\n \n #include \"system/whpx.h\"\n #include \"system/whpx-internal.h\"\n+#include \"system/whpx-all.h\"\n #include \"system/whpx-accel-ops.h\"\n \n static void *whpx_cpu_thread_fn(void *arg)\n@@ -81,6 +82,12 @@ static bool whpx_vcpu_thread_is_idle(CPUState *cpu)\n return !whpx_irqchip_in_kernel();\n }\n \n+static bool whpx_supports_guest_debug(void)\n+{\n+ return whpx_arch_supports_guest_debug();\n+}\n+\n+\n static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data)\n {\n AccelOpsClass *ops = ACCEL_OPS_CLASS(oc);\n@@ -89,6 +96,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data)\n ops->kick_vcpu_thread = whpx_kick_vcpu_thread;\n ops->cpu_thread_is_idle = whpx_vcpu_thread_is_idle;\n ops->handle_interrupt = generic_handle_interrupt;\n+ ops->supports_guest_debug = whpx_supports_guest_debug;\n \n ops->synchronize_post_reset = whpx_cpu_synchronize_post_reset;\n ops->synchronize_post_init = whpx_cpu_synchronize_post_init;\ndiff --git a/include/system/whpx-all.h b/include/system/whpx-all.h\nindex f13cdf7f66..3db074c38c 100644\n--- a/include/system/whpx-all.h\n+++ b/include/system/whpx-all.h\n@@ -17,4 +17,8 @@ void whpx_translate_cpu_breakpoints(\n struct whpx_breakpoints *breakpoints,\n CPUState *cpu,\n int cpu_breakpoint_count);\n+\n+/* called by whpx-accel-ops */\n+bool whpx_arch_supports_guest_debug(void);\n+\n #endif\ndiff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c\nindex 36c5e30a03..8d0ca794af 100644\n--- a/target/arm/whpx/whpx-all.c\n+++ b/target/arm/whpx/whpx-all.c\n@@ -304,6 +304,11 @@ void whpx_translate_cpu_breakpoints(\n /* Breakpoints aren’t supported on this platform */\n }\n \n+bool whpx_arch_supports_guest_debug(void) \n+{\n+ return false;\n+}\n+\n static void whpx_get_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE* val)\n {\n struct whpx_state *whpx = &whpx_global;\ndiff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 8210250dc3..e1f0fa5e77 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -1272,6 +1272,11 @@ void whpx_apply_breakpoints(\n }\n }\n \n+bool whpx_arch_supports_guest_debug(void) \n+{\n+ return true;\n+}\n+\n /* Returns the address of the next instruction that is about to be executed. */\n static vaddr whpx_vcpu_get_pc(CPUState *cpu, bool exit_context_valid)\n {\n","prefixes":["v3","05/14"]}