{"id":2196542,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196542/?format=json","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/1.0/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260214155458.2475954-3-t.lamprecht@proxmox.com>","date":"2026-02-14T15:54:58","name":"[2/2] smb client: switch disable_work_sync with cancel_work_sync to fix backport","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ab85de10841a1a98a0744daadd561aca071202d9","submitter":{"id":67098,"url":"http://patchwork.ozlabs.org/api/1.0/people/67098/?format=json","name":"Thomas Lamprecht","email":"t.lamprecht@proxmox.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260214155458.2475954-3-t.lamprecht@proxmox.com/mbox/","series":[{"id":492184,"url":"http://patchwork.ozlabs.org/api/1.0/series/492184/?format=json","date":"2026-02-14T15:54:57","name":"adapt smb client backports to avoid compilation errors","version":1,"mbox":"http://patchwork.ozlabs.org/series/492184/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196542/checks/","tags":{},"headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)","Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCv3k0DXlz1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 15 Feb 2026 03:04:01 +1100 (AEDT)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1vrI7Z-0003NV-17; Sat, 14 Feb 2026 16:03:49 +0000","from proxmox-new.maurer-it.com ([94.136.29.106])\n by lists.ubuntu.com with esmtp (Exim 4.86_2)\n (envelope-from <t.lamprecht@proxmox.com>) id 1vrI7X-0003N8-JQ\n for kernel-team@lists.ubuntu.com; Sat, 14 Feb 2026 16:03:47 +0000","from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])\n by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9D41783774\n for <kernel-team@lists.ubuntu.com>; Sat, 14 Feb 2026 16:55:05 +0100 (CET)"],"From":"Thomas Lamprecht <t.lamprecht@proxmox.com>","To":"kernel-team@lists.ubuntu.com","Subject":"[PATCH 2/2] smb client: switch disable_work_sync with\n cancel_work_sync to fix backport","Date":"Sat, 14 Feb 2026 16:54:58 +0100","Message-Id":"<20260214155458.2475954-3-t.lamprecht@proxmox.com>","X-Mailer":"git-send-email 2.39.5","In-Reply-To":"<20260214155458.2475954-1-t.lamprecht@proxmox.com>","References":"<20260214155458.2475954-1-t.lamprecht@proxmox.com>","MIME-Version":"1.0","X-Bm-Milter-Handled":"55990f41-d878-4baa-be0a-ee34c49e34d2","X-Bm-Transport-Timestamp":"1771084499983","Received-SPF":"pass client-ip=94.136.29.106;\n envelope-from=t.lamprecht@proxmox.com; helo=proxmox-new.maurer-it.com","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"},"content":"The backport of upstream commit d9dcbbcf9145 (\"smb: client: let\nsmbd_destroy() call disable_work_sync(&info->post_send_credits_work)\")\nwas not adapted to the workqueue helpers available in 6.8, as the\ndisable_work_sync function was only added for v6.10. Swap it out with\nthe cancel_work_sync one available in 6.8, while the newer one would\nslightly be robuster, this should still fulfill what the backported\nfix wants to achieve.\n\nFixes: 070ee6e1f3fd (\"smb: client: let smbd_destroy() call disable_work_sync(&info->post_send_credits_work)\")\nSigned-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>\n---\n fs/smb/client/smbdirect.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c\nindex 6b5c133c1faa..581e86b7c119 100644\n--- a/fs/smb/client/smbdirect.c\n+++ b/fs/smb/client/smbdirect.c\n@@ -1302,7 +1302,7 @@ void smbd_destroy(struct TCP_Server_Info *server)\n \t}\n \n \tlog_rdma_event(INFO, \"cancelling post_send_credits_work\\n\");\n-\tdisable_work_sync(&info->post_send_credits_work);\n+\tcancel_work_sync(&info->post_send_credits_work);\n \n \tlog_rdma_event(INFO, \"destroying qp\\n\");\n \tib_drain_qp(sc->ib.qp);\n","prefixes":["2/2"]}