{"id":2196512,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196512/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260214131659.31378-3-shentey@gmail.com>","date":"2026-02-14T13:16:58","name":"[2/3] target/i386/hvf/x86_mmu: Fix compiler warning","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"23a703f07ae660ba4b8b782994d1f4c210380758","submitter":{"id":83251,"url":"http://patchwork.ozlabs.org/api/1.0/people/83251/?format=json","name":"Bernhard Beschow","email":"shentey@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260214131659.31378-3-shentey@gmail.com/mbox/","series":[{"id":492172,"url":"http://patchwork.ozlabs.org/api/1.0/series/492172/?format=json","date":"2026-02-14T13:16:58","name":"i386 emulate fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/492172/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196512/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=cBhAP0ib;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCqNh2Tz0z1xwj\n\tfor ; Sun, 15 Feb 2026 00:18:26 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrFWb-0005W7-1a; Sat, 14 Feb 2026 08:17:29 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vrFWW-0005U7-PD\n for qemu-devel@nongnu.org; Sat, 14 Feb 2026 08:17:26 -0500","from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vrFWU-0007v5-9J\n for qemu-devel@nongnu.org; Sat, 14 Feb 2026 08:17:24 -0500","by mail-wr1-x42b.google.com with SMTP id\n ffacd0b85a97d-4376c0bffc1so1305886f8f.0\n for ; Sat, 14 Feb 2026 05:17:21 -0800 (PST)","from archlinux (dynamic-092-224-176-164.92.224.pool.telefonica.de.\n [92.224.176.164]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796ac800esm13340471f8f.27.2026.02.14.05.17.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 14 Feb 2026 05:17:19 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771075040; x=1771679840; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yMv+L0cpevCd1h8t6bpXrKu22mF1AowIc+cuUvHrjXM=;\n b=cBhAP0ib91NMtUO1ZG3VQdb4buD3TpwkXdjxQwSHzNF5PmO6/0iAaUcCDa469eoPhp\n +x5Zp82LcPqBD+Ju+ab+tCV/nOJtaEo0pEs9XiBh0XZkOoFw09ylvV3XLEyRFIFCuw5Y\n 140wJn/0Pb0+8AKQSqOoHT24/zXw171+1fUYlqA/sclX9EFpiNo4KFdDEy6JFR1MXjWn\n H9GMouagdY0lZeCCeGBK2dar7Vl+0256rsAufaDzbaBDU5aZHluy/am7bzupCLYb0SsL\n 6nFNchtSDTIPugvmUz2+37D/jZA68mlcEf3Vv70cgL1dQpC4r9tnRUaimSOmIxYI/1Gg\n EVYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771075040; x=1771679840;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yMv+L0cpevCd1h8t6bpXrKu22mF1AowIc+cuUvHrjXM=;\n b=ZIK64/OPhQvinI8G4JgqB/qVdxEYTqh+F3QNkEUfwBycZRGGg4zEZoq/1DJPaK/KvB\n weuvmu+h1vdY9LTqNEQAXIYMrmvonYdKbdAB1+faDi52qIQQ1XL3NBd7HkRdn113vayX\n gGagZv0e1A+QlRiRXgylRXrbUYwc9w+44Z2WQ2uxYEcAwNIkRQtJ5qs+PuZXiiB4lz+I\n AF/fRJEtxd3BdbVb2l/wsaHeYyfkilIE23Yk9ha2/1DANtztqI2De98aGTRuoMpc8c/O\n xCD1QgPHb5Op/cMQyJ6ADhXk31Siwf+chff8oU6XFT355cmuOHQJy691mgC44nk9Gr1X\n HTzQ==","X-Gm-Message-State":"AOJu0YxbqGkfEh1IgTMZ52CNR0893AGWhRzrFrHKsWJ8CXoQ/ePsRNbO\n 3Ap9i4djSpNnek9yWRJFTTt27s94UVtLO3DXVUCcZia5apq4cjeFdu/524UJcw==","X-Gm-Gg":"AZuq6aLW0SGB8YB9AjbqmPTWrTZUUTyh6Atgvkj80fPxRtlUucYbFoTd6FiChWRDHli\n bHTG4DCIvT3JictkGiIY5g/BUQ1Vmnhxdks9Azxu9A2EL+uJi9FQ2tm8NSsl4qoa54AiXnXU4ES\n CVz6w0FMm/czHQcQxeGJuHRXAE16tY5bf9V0WoInvv/YeWXKAcvJs6JD7Hd/S7DUYlEJYV6ZYZo\n nnYsC/ejxLaaOx6HXy5AUWs2Dj7I4trctKjtirRwCWGJN4EpAEj/gHFbkylA6Yq+9O1c0MxPh1V\n f0WcvZjyiii1LGvXAR57AuqlhHNgsCItBGkukA4MXI/FVFqgFLAM4ZB7wo+3ARNV+qQTj98h/+o\n KTyxwAVjIRIa3/jKL83Jk8uQpjqy6R7v9qM/s82Hkqs8YXdMxK82oe77Dr1qC9ngzt9npy5tFxi\n 5TaUM5owj22CRqUHOUc6OY5d67j81ZOOj4InqVIJ50VPX4KIl3iLaesxQGQvb8GfsPVsPWUU6DS\n 5u09cmFaziylSaB","X-Received":"by 2002:a5d:5d06:0:b0:437:6f0c:2ed with SMTP id\n ffacd0b85a97d-4379790f0a9mr9220903f8f.34.1771075039750;\n Sat, 14 Feb 2026 05:17:19 -0800 (PST)","From":"Bernhard Beschow ","To":"qemu-devel@nongnu.org","Cc":"Cameron Esfahani ,\n Magnus Kulke ,\n Roman Bolshakov ,\n Phil Dennis-Jordan , Wei Liu ,\n Mohamed Mediouni ,\n Bernhard Beschow ","Subject":"[PATCH 2/3] target/i386/hvf/x86_mmu: Fix compiler warning","Date":"Sat, 14 Feb 2026 14:16:58 +0100","Message-ID":"<20260214131659.31378-3-shentey@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260214131659.31378-1-shentey@gmail.com>","References":"<20260214131659.31378-1-shentey@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42b;\n envelope-from=shentey@gmail.com; helo=mail-wr1-x42b.google.com","X-Spam_score_int":"-10","X-Spam_score":"-1.1","X-Spam_bar":"-","X-Spam_report":"(-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_GMAIL_RCVD=1,\n FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When reusing the code in WHPX, GCC emits the following warning when compiling\nfor i386-softmmu under MSYS2:\n\n In file included from ../src/target/i386/emulate/x86_mmu.c:20:\n ../src/target/i386/emulate/x86_mmu.c: In function 'vmx_write_mem':\n ../src/target/i386/emulate/x86_mmu.c:251:25: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'target_ulong' {aka 'unsigned int'} [-Werror=format=]\n 251 | VM_PANIC_EX(\"%s: mmu_gva_to_gpa %llx failed\\n\", __func__, gva);\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~\n | |\n | target_ulong {aka unsigned int}\n ../src/target/i386/emulate/panic.h:34:12: note: in definition of macro 'VM_PANIC_EX'\n 34 | printf(__VA_ARGS__); \\\n | ^~~~~~~~~~~\n ../src/target/i386/emulate/x86_mmu.c:251:48: note: format string is defined here\n 251 | VM_PANIC_EX(\"%s: mmu_gva_to_gpa %llx failed\\n\", __func__, gva);\n | ~~~^\n | |\n | long long unsigned int\n | %x\n\nFix the warning by reusing the target-specific macro TARGET_FMT_lx which exists\nfor this exact purpose.\n\nFixes: c97d6d2cdf97 (\"i386: hvf: add code base from Google's QEMU repository\")\ncc: qemu-stable\nSigned-off-by: Bernhard Beschow \n---\n target/i386/hvf/x86_mmu.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/target/i386/hvf/x86_mmu.c b/target/i386/hvf/x86_mmu.c\nindex afc5c17d5d..fe44d2edf4 100644\n--- a/target/i386/hvf/x86_mmu.c\n+++ b/target/i386/hvf/x86_mmu.c\n@@ -244,7 +244,8 @@ void vmx_write_mem(CPUState *cpu, target_ulong gva, void *data, int bytes)\n int copy = MIN(bytes, 0x1000 - (gva & 0xfff));\n \n if (!mmu_gva_to_gpa(cpu, gva, &gpa)) {\n- VM_PANIC_EX(\"%s: mmu_gva_to_gpa %llx failed\\n\", __func__, gva);\n+ VM_PANIC_EX(\"%s: mmu_gva_to_gpa \" TARGET_FMT_lx \" failed\\n\",\n+ __func__, gva);\n } else {\n address_space_write(&address_space_memory, gpa,\n MEMTXATTRS_UNSPECIFIED, data, copy);\n@@ -265,7 +266,8 @@ void vmx_read_mem(CPUState *cpu, void *data, target_ulong gva, int bytes)\n int copy = MIN(bytes, 0x1000 - (gva & 0xfff));\n \n if (!mmu_gva_to_gpa(cpu, gva, &gpa)) {\n- VM_PANIC_EX(\"%s: mmu_gva_to_gpa %llx failed\\n\", __func__, gva);\n+ VM_PANIC_EX(\"%s: mmu_gva_to_gpa \" TARGET_FMT_lx \" failed\\n\",\n+ __func__, gva);\n }\n address_space_read(&address_space_memory, gpa, MEMTXATTRS_UNSPECIFIED,\n data, copy);\n","prefixes":["2/3"]}