{"id":2196484,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196484/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260214034135.220413-5-zhenzhong.duan@intel.com>","date":"2026-02-14T03:41:24","name":"[RFCv2,04/13] intel_iommu: Create the nested hwpt with IOMMU_HWPT_ALLOC_PASID flag","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e2b5c674dd8b6f87748e5e2f5d4a4a048a244451","submitter":{"id":81636,"url":"http://patchwork.ozlabs.org/api/1.0/people/81636/?format=json","name":"Duan, Zhenzhong","email":"zhenzhong.duan@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260214034135.220413-5-zhenzhong.duan@intel.com/mbox/","series":[{"id":492156,"url":"http://patchwork.ozlabs.org/api/1.0/series/492156/?format=json","date":"2026-02-14T03:41:20","name":"intel_iommu: Enable PASID support for passthrough device","version":1,"mbox":"http://patchwork.ozlabs.org/series/492156/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196484/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=csV6RbBy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCZdb2bwtz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 14:43:47 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vr6Xm-00058x-7v; Fri, 13 Feb 2026 22:42:06 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhenzhong.duan@intel.com>)\n id 1vr6Xk-00058h-Ol\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 22:42:04 -0500","from mgamail.intel.com ([198.175.65.12])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhenzhong.duan@intel.com>)\n id 1vr6Xj-0008J1-6E\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 22:42:04 -0500","from orviesa009.jf.intel.com ([10.64.159.149])\n by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Feb 2026 19:42:02 -0800","from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229])\n by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Feb 2026 19:41:59 -0800"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771040523; x=1802576523;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=eonLPTLYxHldYtymxYRdcAgJia5SUfNkvhTZV0PxX1E=;\n b=csV6RbByZEgD2QV1dxHWq0RXsNyKJVcLr1N5T7Ajy3Rfr+k5cS9MfDkN\n mH15/CPcCPP3kTZayxb/rR6GIJBZ5saSuAp5RlKAWBOCVX7M1jHA0J8HW\n dNVJijbnV77nNUMBUl/46vb/QmxEsaw0DScC8maE8iML7zNQ6cKfcY4Kf\n OeeVSz/8/dskeVJhcTgh3ST2uOxbMx+BfOWaLNyD5Ihb6QdHLDKZsFLV/\n MphKujYiRVW64v2FiIgiq1X2fo42K7WnqVeYGucCtdEcDE3rdRfavprSm\n 4cNwXKCffwfPebBtPRLQRorxadgsBupS8o7osEutBZ6oJFbghSpG0kRMh w==;","X-CSE-ConnectionGUID":["MxeKY6pXSRm7Y9W4o+1QEg==","YDZSswRgTVmtNFukaC+csQ=="],"X-CSE-MsgGUID":["mjMckC+LRNazO1dxw0Q52g==","l0NYaZo1Tkquu7ZzjcdMsA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11700\"; a=\"83666820\"","E=Sophos;i=\"6.21,289,1763452800\"; d=\"scan'208\";a=\"83666820\"","E=Sophos;i=\"6.21,289,1763452800\"; d=\"scan'208\";a=\"212933004\""],"X-ExtLoop1":"1","From":"Zhenzhong Duan <zhenzhong.duan@intel.com>","To":"qemu-devel@nongnu.org","Cc":"alex@shazbot.org, clg@redhat.com, eric.auger@redhat.com, mst@redhat.com,\n jasowang@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com,\n skolothumtho@nvidia.com, joao.m.martins@oracle.com,\n clement.mathieu--drif@eviden.com, kevin.tian@intel.com, yi.l.liu@intel.com,\n xudong.hao@intel.com, Zhenzhong Duan <zhenzhong.duan@intel.com>","Subject":"[RFCv2 PATCH 04/13] intel_iommu: Create the nested hwpt with\n IOMMU_HWPT_ALLOC_PASID flag","Date":"Fri, 13 Feb 2026 22:41:24 -0500","Message-ID":"<20260214034135.220413-5-zhenzhong.duan@intel.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260214034135.220413-1-zhenzhong.duan@intel.com>","References":"<20260214034135.220413-1-zhenzhong.duan@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=198.175.65.12;\n envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When pasid is enabled, any hwpt attached to non-PASID or PASID should be\nIOMMU_HWPT_ALLOC_PASID flagged, or else attachment fails.\n\nChange vtd_destroy_old_fs_hwpt() to pass in 'VTDHostIOMMUDevice *' for\nnaming consistency.\n\nSigned-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>\n---\n hw/i386/intel_iommu_accel.c | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/i386/intel_iommu_accel.c b/hw/i386/intel_iommu_accel.c\nindex 45c08c8f6f..c2757f3bcd 100644\n--- a/hw/i386/intel_iommu_accel.c\n+++ b/hw/i386/intel_iommu_accel.c\n@@ -69,11 +69,13 @@ VTDHostIOMMUDevice *vtd_find_hiod_iommufd(VTDAddressSpace *as)\n     return NULL;\n }\n \n-static bool vtd_create_fs_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n+static bool vtd_create_fs_hwpt(VTDHostIOMMUDevice *vtd_hiod,\n                                VTDPASIDEntry *pe, uint32_t *fs_hwpt_id,\n                                Error **errp)\n {\n+    HostIOMMUDeviceIOMMUFD *idev = HOST_IOMMU_DEVICE_IOMMUFD(vtd_hiod->hiod);\n     struct iommu_hwpt_vtd_s1 vtd = {};\n+    uint32_t flags = vtd_hiod->iommu_state->pasid ? IOMMU_HWPT_ALLOC_PASID : 0;\n \n     vtd.flags = (VTD_SM_PASID_ENTRY_SRE(pe) ? IOMMU_VTD_S1_SRE : 0) |\n                 (VTD_SM_PASID_ENTRY_WPE(pe) ? IOMMU_VTD_S1_WPE : 0) |\n@@ -82,13 +84,15 @@ static bool vtd_create_fs_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n     vtd.pgtbl_addr = (uint64_t)vtd_pe_get_fspt_base(pe);\n \n     return iommufd_backend_alloc_hwpt(idev->iommufd, idev->devid, idev->hwpt_id,\n-                                      0, IOMMU_HWPT_DATA_VTD_S1, sizeof(vtd),\n-                                      &vtd, fs_hwpt_id, errp);\n+                                      flags, IOMMU_HWPT_DATA_VTD_S1,\n+                                      sizeof(vtd), &vtd, fs_hwpt_id, errp);\n }\n \n-static void vtd_destroy_old_fs_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n+static void vtd_destroy_old_fs_hwpt(VTDHostIOMMUDevice *vtd_hiod,\n                                     VTDAddressSpace *vtd_as)\n {\n+    HostIOMMUDeviceIOMMUFD *idev = HOST_IOMMU_DEVICE_IOMMUFD(vtd_hiod->hiod);\n+\n     if (!vtd_as->fs_hwpt_id) {\n         return;\n     }\n@@ -116,7 +120,7 @@ static bool vtd_device_attach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n     }\n \n     if (vtd_pe_pgtt_is_fst(pe)) {\n-        if (!vtd_create_fs_hwpt(idev, pe, &hwpt_id, errp)) {\n+        if (!vtd_create_fs_hwpt(vtd_hiod, pe, &hwpt_id, errp)) {\n             return false;\n         }\n     }\n@@ -126,7 +130,7 @@ static bool vtd_device_attach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n     trace_vtd_device_attach_hwpt(idev->devid, vtd_as->pasid, hwpt_id, ret);\n     if (ret) {\n         /* Destroy old fs_hwpt if it's a replacement */\n-        vtd_destroy_old_fs_hwpt(idev, vtd_as);\n+        vtd_destroy_old_fs_hwpt(vtd_hiod, vtd_as);\n         if (vtd_pe_pgtt_is_fst(pe)) {\n             vtd_as->fs_hwpt_id = hwpt_id;\n         }\n@@ -161,7 +165,7 @@ static bool vtd_device_detach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n     }\n \n     if (ret) {\n-        vtd_destroy_old_fs_hwpt(idev, vtd_as);\n+        vtd_destroy_old_fs_hwpt(vtd_hiod, vtd_as);\n     }\n \n     return ret;\n","prefixes":["RFCv2","04/13"]}