{"id":2196477,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196477/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260214034135.220413-3-zhenzhong.duan@intel.com>","date":"2026-02-14T03:41:22","name":"[RFCv2,02/13] iommufd: Extend attach/detach_hwpt callbacks to support pasid","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1bf3e959d6231f62b5ef34768825e1f3b400584e","submitter":{"id":81636,"url":"http://patchwork.ozlabs.org/api/1.0/people/81636/?format=json","name":"Duan, Zhenzhong","email":"zhenzhong.duan@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260214034135.220413-3-zhenzhong.duan@intel.com/mbox/","series":[{"id":492156,"url":"http://patchwork.ozlabs.org/api/1.0/series/492156/?format=json","date":"2026-02-14T03:41:20","name":"intel_iommu: Enable PASID support for passthrough device","version":1,"mbox":"http://patchwork.ozlabs.org/series/492156/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196477/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=mAsyMQFF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCZcx6Y7Cz1xpY\n\tfor ; Sat, 14 Feb 2026 14:43:13 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vr6Xf-00057P-JF; Fri, 13 Feb 2026 22:41:59 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vr6Xe-00057C-Ik; Fri, 13 Feb 2026 22:41:58 -0500","from mgamail.intel.com ([198.175.65.12])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vr6Xc-0008J1-MF; Fri, 13 Feb 2026 22:41:58 -0500","from orviesa009.jf.intel.com ([10.64.159.149])\n by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Feb 2026 19:41:55 -0800","from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229])\n by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Feb 2026 19:41:51 -0800"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771040517; x=1802576517;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=0CFY7/ec9WolJ0TC6427evSbm7/oQkZWjLHaiUI4x3g=;\n b=mAsyMQFF/TwWyG7XfchwMY0IAKo/p/8WqV2nJvy+/si3zHS2EMesJeeQ\n EKrXemFNRC8RTKcegXDXoNBYPnB1liaVdiSc0xzWUBfl+zjTXa5ZekSUf\n guJ7O0SwQj7l5VVtAQJ1QMZjukJ7G9jr6cTGGxVh9L5z2/Aaiw1w2Bxyp\n S8F+uIOJFegoyJNFSk4VxSoE3ApDW7BODKidFAabl6OYbVDbgQlrgF3fY\n 6XspU4IZMPT4sLYjqrJYg4lS32rnCknv8oe25tlbEPRHDsnw1N/Ubiuth\n XBAWtKkOE1EJ9eXxelKVXIeXHCI9n14iqIce+BjUxDXro4xiMXiOkA65O Q==;","X-CSE-ConnectionGUID":["+qVceJa/QBaaG1Yt/mj4lQ==","4VMdouigT7+3Wyc3EC2GCw=="],"X-CSE-MsgGUID":["YhlYKltXSGeYM5NchmSJnw==","UBD6mkS/S4KsdQyUgsnuQA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11700\"; a=\"83666805\"","E=Sophos;i=\"6.21,289,1763452800\"; d=\"scan'208\";a=\"83666805\"","E=Sophos;i=\"6.21,289,1763452800\"; d=\"scan'208\";a=\"212932941\""],"X-ExtLoop1":"1","From":"Zhenzhong Duan ","To":"qemu-devel@nongnu.org","Cc":"alex@shazbot.org, clg@redhat.com, eric.auger@redhat.com, mst@redhat.com,\n jasowang@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com,\n skolothumtho@nvidia.com, joao.m.martins@oracle.com,\n clement.mathieu--drif@eviden.com, kevin.tian@intel.com, yi.l.liu@intel.com,\n xudong.hao@intel.com, Zhenzhong Duan ,\n qemu-arm@nongnu.org","Subject":"[RFCv2 PATCH 02/13] iommufd: Extend attach/detach_hwpt callbacks to\n support pasid","Date":"Fri, 13 Feb 2026 22:41:22 -0500","Message-ID":"<20260214034135.220413-3-zhenzhong.duan@intel.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260214034135.220413-1-zhenzhong.duan@intel.com>","References":"<20260214034135.220413-1-zhenzhong.duan@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=198.175.65.12;\n envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Same for the two wrappers and their call sites.\n\nSuggested-by: Shameer Kolothum Thodi \nSuggested-by: Nicolin Chen \nSigned-off-by: Zhenzhong Duan \n---\n include/system/iommufd.h | 16 +++++++++++-----\n backends/iommufd.c | 9 +++++----\n hw/arm/smmuv3-accel.c | 12 ++++++++----\n hw/i386/intel_iommu_accel.c | 8 +++++---\n hw/vfio/iommufd.c | 10 +++++-----\n 5 files changed, 34 insertions(+), 21 deletions(-)","diff":"diff --git a/include/system/iommufd.h b/include/system/iommufd.h\nindex 80d72469a9..80c8423654 100644\n--- a/include/system/iommufd.h\n+++ b/include/system/iommufd.h\n@@ -124,14 +124,16 @@ struct HostIOMMUDeviceIOMMUFDClass {\n *\n * @idev: host IOMMU device backed by IOMMUFD backend.\n *\n+ * @pasid: pasid of host IOMMU device.\n+ *\n * @hwpt_id: ID of IOMMUFD hardware page table.\n *\n * @errp: pass an Error out when attachment fails.\n *\n * Returns: true on success, false on failure.\n */\n- bool (*attach_hwpt)(HostIOMMUDeviceIOMMUFD *idev, uint32_t hwpt_id,\n- Error **errp);\n+ bool (*attach_hwpt)(HostIOMMUDeviceIOMMUFD *idev, uint32_t pasid,\n+ uint32_t hwpt_id, Error **errp);\n /**\n * @detach_hwpt: detach host IOMMU device from IOMMUFD hardware page table.\n * VFIO and VDPA device can have different implementation.\n@@ -140,15 +142,19 @@ struct HostIOMMUDeviceIOMMUFDClass {\n *\n * @idev: host IOMMU device backed by IOMMUFD backend.\n *\n+ * @pasid: pasid of host IOMMU device.\n+ *\n * @errp: pass an Error out when attachment fails.\n *\n * Returns: true on success, false on failure.\n */\n- bool (*detach_hwpt)(HostIOMMUDeviceIOMMUFD *idev, Error **errp);\n+ bool (*detach_hwpt)(HostIOMMUDeviceIOMMUFD *idev, uint32_t pasid,\n+ Error **errp);\n };\n \n bool host_iommu_device_iommufd_attach_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n- uint32_t hwpt_id, Error **errp);\n-bool host_iommu_device_iommufd_detach_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n+ uint32_t pasid, uint32_t hwpt_id,\n Error **errp);\n+bool host_iommu_device_iommufd_detach_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n+ uint32_t pasid, Error **errp);\n #endif\ndiff --git a/backends/iommufd.c b/backends/iommufd.c\nindex 13822df82f..153edf4f79 100644\n--- a/backends/iommufd.c\n+++ b/backends/iommufd.c\n@@ -505,23 +505,24 @@ bool iommufd_backend_alloc_vdev(IOMMUFDBackend *be, uint32_t dev_id,\n }\n \n bool host_iommu_device_iommufd_attach_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n- uint32_t hwpt_id, Error **errp)\n+ uint32_t pasid, uint32_t hwpt_id,\n+ Error **errp)\n {\n HostIOMMUDeviceIOMMUFDClass *idevc =\n HOST_IOMMU_DEVICE_IOMMUFD_GET_CLASS(idev);\n \n g_assert(idevc->attach_hwpt);\n- return idevc->attach_hwpt(idev, hwpt_id, errp);\n+ return idevc->attach_hwpt(idev, pasid, hwpt_id, errp);\n }\n \n bool host_iommu_device_iommufd_detach_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n- Error **errp)\n+ uint32_t pasid, Error **errp)\n {\n HostIOMMUDeviceIOMMUFDClass *idevc =\n HOST_IOMMU_DEVICE_IOMMUFD_GET_CLASS(idev);\n \n g_assert(idevc->detach_hwpt);\n- return idevc->detach_hwpt(idev, errp);\n+ return idevc->detach_hwpt(idev, pasid, errp);\n }\n \n static int hiod_iommufd_get_cap(HostIOMMUDevice *hiod, int cap, Error **errp)\ndiff --git a/hw/arm/smmuv3-accel.c b/hw/arm/smmuv3-accel.c\nindex f5cd4df336..6b04344959 100644\n--- a/hw/arm/smmuv3-accel.c\n+++ b/hw/arm/smmuv3-accel.c\n@@ -294,7 +294,8 @@ bool smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\n return false;\n }\n \n- if (!host_iommu_device_iommufd_attach_hwpt(idev, hwpt_id, errp)) {\n+ if (!host_iommu_device_iommufd_attach_hwpt(idev, IOMMU_NO_PASID, hwpt_id,\n+ errp)) {\n if (s1_hwpt) {\n iommufd_backend_free_id(idev->iommufd, s1_hwpt->hwpt_id);\n g_free(s1_hwpt);\n@@ -436,7 +437,8 @@ smmuv3_accel_alloc_viommu(SMMUv3State *s, HostIOMMUDeviceIOMMUFD *idev,\n \n /* Attach a HWPT based on SMMUv3 GBPA.ABORT value */\n hwpt_id = smmuv3_accel_gbpa_hwpt(s, accel);\n- if (!host_iommu_device_iommufd_attach_hwpt(idev, hwpt_id, errp)) {\n+ if (!host_iommu_device_iommufd_attach_hwpt(idev, IOMMU_NO_PASID, hwpt_id,\n+ errp)) {\n goto free_bypass_hwpt;\n }\n accel->viommu = viommu;\n@@ -524,7 +526,8 @@ static void smmuv3_accel_unset_iommu_device(PCIBus *bus, void *opaque,\n idev = accel_dev->idev;\n accel = accel_dev->s_accel;\n /* Re-attach the default s2 hwpt id */\n- if (!host_iommu_device_iommufd_attach_hwpt(idev, idev->hwpt_id, NULL)) {\n+ if (!host_iommu_device_iommufd_attach_hwpt(idev, IOMMU_NO_PASID,\n+ idev->hwpt_id, NULL)) {\n error_report(\"Unable to attach the default HW pagetable: idev devid \"\n \"0x%x\", idev->devid);\n }\n@@ -720,7 +723,8 @@ bool smmuv3_accel_attach_gbpa_hwpt(SMMUv3State *s, Error **errp)\n \n hwpt_id = smmuv3_accel_gbpa_hwpt(s, accel);\n QLIST_FOREACH(accel_dev, &accel->device_list, next) {\n- if (!host_iommu_device_iommufd_attach_hwpt(accel_dev->idev, hwpt_id,\n+ if (!host_iommu_device_iommufd_attach_hwpt(accel_dev->idev,\n+ IOMMU_NO_PASID, hwpt_id,\n &local_err)) {\n error_append_hint(&local_err, \"Failed to attach GBPA hwpt %u for \"\n \"idev devid %u\", hwpt_id, accel_dev->idev->devid);\ndiff --git a/hw/i386/intel_iommu_accel.c b/hw/i386/intel_iommu_accel.c\nindex 67d54849f2..45c08c8f6f 100644\n--- a/hw/i386/intel_iommu_accel.c\n+++ b/hw/i386/intel_iommu_accel.c\n@@ -121,7 +121,8 @@ static bool vtd_device_attach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n }\n }\n \n- ret = host_iommu_device_iommufd_attach_hwpt(idev, hwpt_id, errp);\n+ ret = host_iommu_device_iommufd_attach_hwpt(idev, IOMMU_NO_PASID, hwpt_id,\n+ errp);\n trace_vtd_device_attach_hwpt(idev->devid, vtd_as->pasid, hwpt_id, ret);\n if (ret) {\n /* Destroy old fs_hwpt if it's a replacement */\n@@ -145,7 +146,7 @@ static bool vtd_device_detach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n bool ret;\n \n if (s->dmar_enabled && s->root_scalable) {\n- ret = host_iommu_device_iommufd_detach_hwpt(idev, errp);\n+ ret = host_iommu_device_iommufd_detach_hwpt(idev, IOMMU_NO_PASID, errp);\n trace_vtd_device_detach_hwpt(idev->devid, pasid, ret);\n } else {\n /*\n@@ -153,7 +154,8 @@ static bool vtd_device_detach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n * we fallback to the default HWPT which contains shadow page table.\n * So guest DMA could still work.\n */\n- ret = host_iommu_device_iommufd_attach_hwpt(idev, idev->hwpt_id, errp);\n+ ret = host_iommu_device_iommufd_attach_hwpt(idev, IOMMU_NO_PASID,\n+ idev->hwpt_id, errp);\n trace_vtd_device_reattach_def_hwpt(idev->devid, pasid, idev->hwpt_id,\n ret);\n }\ndiff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c\nindex b4c5e81b1d..005f97fe25 100644\n--- a/hw/vfio/iommufd.c\n+++ b/hw/vfio/iommufd.c\n@@ -924,21 +924,21 @@ static void vfio_iommu_iommufd_class_init(ObjectClass *klass, const void *data)\n \n static bool\n host_iommu_device_iommufd_vfio_attach_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n- uint32_t hwpt_id, Error **errp)\n+ uint32_t pasid, uint32_t hwpt_id,\n+ Error **errp)\n {\n VFIODevice *vbasedev = HOST_IOMMU_DEVICE(idev)->agent;\n \n- return !iommufd_cdev_pasid_attach_ioas_hwpt(vbasedev, IOMMU_NO_PASID,\n- hwpt_id, errp);\n+ return !iommufd_cdev_pasid_attach_ioas_hwpt(vbasedev, pasid, hwpt_id, errp);\n }\n \n static bool\n host_iommu_device_iommufd_vfio_detach_hwpt(HostIOMMUDeviceIOMMUFD *idev,\n- Error **errp)\n+ uint32_t pasid, Error **errp)\n {\n VFIODevice *vbasedev = HOST_IOMMU_DEVICE(idev)->agent;\n \n- return iommufd_cdev_pasid_detach_ioas_hwpt(vbasedev, IOMMU_NO_PASID, errp);\n+ return iommufd_cdev_pasid_detach_ioas_hwpt(vbasedev, pasid, errp);\n }\n \n static bool hiod_iommufd_vfio_realize(HostIOMMUDevice *hiod, void *opaque,\n","prefixes":["RFCv2","02/13"]}