{"id":2196458,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196458/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260214021240.58657-2-philmd@linaro.org>","date":"2026-02-14T02:12:32","name":"[1/8] hw/display/macfb: Constify macfb_sense_table[] array","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eb54afc2806a3b89ac6ff90744543683ab48a976","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260214021240.58657-2-philmd@linaro.org/mbox/","series":[{"id":492154,"url":"http://patchwork.ozlabs.org/api/1.0/series/492154/?format=json","date":"2026-02-14T02:12:35","name":"system: Absorb globals-target.c within common globals.c","version":1,"mbox":"http://patchwork.ozlabs.org/series/492154/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196458/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Ig0PCF4u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCXdx0wLfz1xpY\n\tfor ; Sat, 14 Feb 2026 13:13:57 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vr59U-0003dK-2v; Fri, 13 Feb 2026 21:12:56 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vr59R-0003bN-Pf\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 21:12:53 -0500","from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vr59Q-0004Vd-9r\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 21:12:53 -0500","by mail-wr1-x42e.google.com with SMTP id\n ffacd0b85a97d-4359228b7c6so1045999f8f.2\n for ; Fri, 13 Feb 2026 18:12:51 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796abc8b1sm9981348f8f.23.2026.02.13.18.12.49\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 13 Feb 2026 18:12:49 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771035170; x=1771639970; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UW54D3jaK4/hOnhFU88FxBB/FWP9ogaH9ApScZzAiAU=;\n b=Ig0PCF4uSz+14+C5YHx7ambnsPAt42wI9f9ergufYPT+gdaU5DwNWXt6W8kYd4M5bH\n M+o7sn5ClZCFeV3MNTvQNm/EHuauf+7SQk26sAI8FT+KjXF/CLUn1IrhIfugQLZvadaD\n GTloQIyr2t7dIMncFG3EvDQ14M3VWYvO/DZQOBB8WVMg+bAsHnpPh/cuqxh4u7ytKON3\n M3XgMb0FcPGTeflqfw3msXcDu8r852JrUoMbRErLkcV24LR83WMh2NE4s2y2HpkCHhU8\n XARqOt4mA+mwm8ppH1xellVhHC4HEnXulXVZiYNxmN2mV8JEgwgDCne27SW/kVD4qi3s\n 8pgg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771035170; x=1771639970;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=UW54D3jaK4/hOnhFU88FxBB/FWP9ogaH9ApScZzAiAU=;\n b=HzLrPdiZAdb6ITeBj81GF+RTT7wiY0CB1WzesoTgYmtWDn5NW66bTUite1ZRY0IhWG\n pLn/XHzZeaKOK3oJJ8u0H1r41Ztha7Tr40zz7wJ6XslOEk9q356p4u7wcJtggR0UCCbn\n oAp34HSjQlYVqi9uEXtS4/Pu3IJ0HbydaEQygYplT9hYJ23KwikJstf+sKSF8pHx9roT\n WW+xjdGZ0+wXhLJO3nsG5yOe1Zjw3dPpn1jSvd/AuomxtDz1x5blRq8ezZFXZNhpy54i\n xAi0DC4SaA83dGZZmsaLVNvp/euEaNkUasY0+TLJldwt83er3Jh1MLS0zYXOJ+p3Bv+3\n 8LiA==","X-Gm-Message-State":"AOJu0YzCQDUY6JFuxWW+bLwFn00DB3CBfPdtYVat2babDhwqsrh8/K5F\n tJIgo80qFUrw2dZcrAufP4LxWLHrUGIJiZ4aHz0PqxCLT02EYftnLjmkCcEt+PbmS+A5nQOxwav\n CdABvkG0=","X-Gm-Gg":"AZuq6aLHisCaa45OdrRFCL9V3mfGnruMYuepO+FKiFN0/MpkgfDipIMYyzVXZ4o4ZnP\n T6g3zK8D5Y6/83UJeNoG/theFGw9TlTbb/1WQkCIbNKY85SI2C441B6dDtFBqhi/91yALnVwIF2\n rplQ1meVE+PPpcXk1STivZHoQu/NolqpSmMJkNXbVqHVqHF9VRZs5bLgKQrgVTd74D+CYcNWXfa\n OqwwigomCGD8UfA+wqwvTo+7/R+cqVov0lFCdDh9qWzkUClhg47McVcE4S2NoyHfFhruSxqMj2o\n s2IBt3JlD9ULpekYhniod10w7DRtE5XPi5QU6EaszLb294+oMCyZ6TW/MNnFmFkIXU0SyhA8pbd\n 8fhMob+uazKR4IHQ/tRkBCfeYerTHdxMwS+C5swuexwjGoCiZTPP/N/iuosdmW2p/qzyHrf0ist\n 9BwnsTxBzL6dNNxDFo2CRBUYG4LIqLOO4GeUVRNMVop/ZXHuPXSPGfjUj3TazmTbarDxofCnvtJ\n 2vfps2HxbY=","X-Received":"by 2002:a05:6000:2dc6:b0:436:145a:e54f with SMTP id\n ffacd0b85a97d-4379db66af5mr2632969f8f.24.1771035170355;\n Fri, 13 Feb 2026 18:12:50 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Chinmay Rath ,\n =?utf-8?q?Herv=C3=A9_Poussineau?= ,\n Harsh Prateek Bora ,\n Nicholas Piggin , Artyom Tarasenko ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n Mark Cave-Ayland ,\n Laurent Vivier ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH 1/8] hw/display/macfb: Constify macfb_sense_table[] array","Date":"Sat, 14 Feb 2026 03:12:32 +0100","Message-ID":"<20260214021240.58657-2-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260214021240.58657-1-philmd@linaro.org>","References":"<20260214021240.58657-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42e;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"macfb_sense_table[] is only read, never updated, so can be const.\n\nUpdate the single call site, macfb_sense_read().\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/display/macfb.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/display/macfb.c b/hw/display/macfb.c\nindex 388f8de5070..57ad8ad5587 100644\n--- a/hw/display/macfb.c\n+++ b/hw/display/macfb.c\n@@ -82,7 +82,7 @@ typedef struct MacFbSense {\n uint8_t ext_sense;\n } MacFbSense;\n \n-static MacFbSense macfb_sense_table[] = {\n+static const MacFbSense macfb_sense_table[] = {\n { MACFB_DISPLAY_APPLE_21_COLOR, 0x0, 0 },\n { MACFB_DISPLAY_APPLE_PORTRAIT, 0x1, 0 },\n { MACFB_DISPLAY_APPLE_12_RGB, 0x2, 0 },\n@@ -342,7 +342,7 @@ static void macfb_invalidate_display(void *opaque)\n \n static uint32_t macfb_sense_read(MacfbState *s)\n {\n- MacFbSense *macfb_sense;\n+ const MacFbSense *macfb_sense;\n uint8_t sense;\n \n assert(s->type < ARRAY_SIZE(macfb_sense_table));\n","prefixes":["1/8"]}