{"id":2196455,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196455/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260214021240.58657-5-philmd@linaro.org>","date":"2026-02-14T02:12:35","name":"[4/8] hw/m68k/q800: Set MACFB_DISPLAY_APPLE_21_COLOR within MacFrameBuffer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e44d9749af01efa3e9e11bcb3599fde0385606f9","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260214021240.58657-5-philmd@linaro.org/mbox/","series":[{"id":492154,"url":"http://patchwork.ozlabs.org/api/1.0/series/492154/?format=json","date":"2026-02-14T02:12:35","name":"system: Absorb globals-target.c within common globals.c","version":1,"mbox":"http://patchwork.ozlabs.org/series/492154/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196455/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=waiB9u5a;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCXdw10F7z1xpY\n\tfor ; Sat, 14 Feb 2026 13:13:56 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vr59q-0003j6-CI; Fri, 13 Feb 2026 21:13:18 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vr59p-0003in-5Q\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 21:13:17 -0500","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vr59n-0004a5-Q7\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 21:13:16 -0500","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-48069a48629so13637965e9.0\n for ; Fri, 13 Feb 2026 18:13:15 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4837a5d562esm19158015e9.15.2026.02.13.18.13.12\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 13 Feb 2026 18:13:13 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771035194; x=1771639994; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=99tut9IOO9gtsFLHOORswTThLZP4XwALyE4UKZNWpNM=;\n b=waiB9u5acn0S6iOlk/SDtMHzk8LUGxYuzNiEZ7SUs0skTHPBLb9H+1dq5DsQQcx3Wk\n pYsSbQxvl1FVfDhvg4+TCz3D+w4OjBnf+RoxInAZ3b8cTqBV8YUkQBYB1Ar1j7jCjI2j\n JzsuFwYG+AC0qUfzh/q0P3EJ4NLj7nGZXAGGhRrhB8A0k4NoHQ9yyR5ue3brXhBTn81U\n fsi22fKASdSnKCiS6jX+fQP8mZoBk9eU9tk5wGPMVdNxLjjmRfXrMCv81QM95zy8WruM\n t0aCmKR9YVo2Dox+nEg7q1zkUn8l4lGrss3y8XBkPmUb9ZnJvNM+Hqs9vTtSDPyJL7tn\n zDOw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771035194; x=1771639994;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=99tut9IOO9gtsFLHOORswTThLZP4XwALyE4UKZNWpNM=;\n b=uRlLvYt3mRMNp/Ji3e3Dnn7FvC5ptI5XsCOzIkcburCTF/7pykdceEnAbEnNMssz8i\n C13NV78iOCBwA8GvtWCPyOgnHIAEx3ctcNi8lNI18CTwpnynvHiahZvEIPYygJUg1rKi\n oIUxPCBwNMUAGZ+bfTlz0YkhgE+R3h7iANOKMJeigjSxbvlOL0Y3LdhAxEGkPPJzF8Qp\n GR1DklrJL8BI/TEhhyvisS7warknhUhnS50FV9ILJrtgDX+ODSINUez3WnYCSRcNNlRg\n ODNCMPX6pdIxeW/NXAaY5dx4k9pUPNSr5rGDpzFSUYrEG6O+R04LaEhJZBg24ugVyYnw\n eIBg==","X-Gm-Message-State":"AOJu0Yz5p3vEBcyfMbNdItjDGSmFRqR3SEhGnehqbmSfHtmVXVzPDZNF\n wHnhaR/P3+VZM65HCO9QNKYrzTtun9A1Ljvrr4dOx1d7Xg/HoaCWRMhlqRo+YRluaVhO6iuco98\n mAsx+m6A=","X-Gm-Gg":"AZuq6aKgaY6NypMQmL0elISfV/p8s99lmjkg35XmXGbB/flJjL5uy1MV+tWZEINphXL\n 1//FMgx2ny+1Hz3z2QIvlNAYdwSttxZRXqDRfdSZ4GzENWVTgFcIF6arjFIwXGAgrF/magmtoPT\n zl1Jg+MWE0aAaG0qQNQ5GyAgx2jffVpUMDykRcA0RiKtPGa4TlWUFPbU9yc1EomlOyH/jDEH8yB\n HmTqpQlGjWy0pjgv6NhwjFvULQ5WiG3XGFSeY6y9C1JQIXl8iPT0kjOCM0CMiOJA2RsIQvwliV+\n H8yFKCjVp0WgD0xbi6Jqpfvs+T/r6aBrICAMGLItPVFuopXVWj9KJoC+T6JQ4RIGVyf4mfUgHXc\n r94Qtv1S2RF3ZHZkDnGNqOAZtIc8r16DVvL1+M/uhdIMDPqXAzdZtPR7Y6Jt8MB+UjIE3VAn+eV\n lm1dYOgwj5WWmcJjrwOKOdrhPK3oC6od1pn8fxRH8RYD9RePEg/5icqVwZBaVl0V6jPMxdnAg0s\n IXuhxdoMC4=","X-Received":"by 2002:a05:600c:3e87:b0:480:32da:f338 with SMTP id\n 5b1f17b1804b1-48373a0f961mr58292885e9.14.1771035193914;\n Fri, 13 Feb 2026 18:13:13 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Chinmay Rath ,\n =?utf-8?q?Herv=C3=A9_Poussineau?= ,\n Harsh Prateek Bora ,\n Nicholas Piggin , Artyom Tarasenko ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n Mark Cave-Ayland ,\n Laurent Vivier ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH 4/8] hw/m68k/q800: Set MACFB_DISPLAY_APPLE_21_COLOR within\n MacFrameBuffer","Date":"Sat, 14 Feb 2026 03:12:35 +0100","Message-ID":"<20260214021240.58657-5-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260214021240.58657-1-philmd@linaro.org>","References":"<20260214021240.58657-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The MACFB_DISPLAY_APPLE_21_COLOR mode is not specific to the Q800\nmachine. Check and set it once in the MacFB DeviceRealize handler.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/display/macfb.c | 4 ++++\n hw/m68k/q800.c | 5 -----\n 2 files changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/hw/display/macfb.c b/hw/display/macfb.c\nindex 8ef174dc6df..b8115c2be13 100644\n--- a/hw/display/macfb.c\n+++ b/hw/display/macfb.c\n@@ -645,6 +645,10 @@ static bool macfb_common_realize(DeviceState *dev, MacfbState *s, Error **errp)\n {\n DisplaySurface *surface;\n \n+ if (s->width == 1152 && s->height == 870) {\n+ s->type = MACFB_DISPLAY_APPLE_21_COLOR;\n+ }\n+\n s->mode = macfb_find_mode(s->type, s->width, s->height, s->depth);\n if (!s->mode) {\n gchar *list;\ndiff --git a/hw/m68k/q800.c b/hw/m68k/q800.c\nindex b55c03a90bf..ba32da2fa45 100644\n--- a/hw/m68k/q800.c\n+++ b/hw/m68k/q800.c\n@@ -563,11 +563,6 @@ static void q800_machine_init(MachineState *machine)\n qdev_prop_set_uint32(dev, \"width\", graphic_width);\n qdev_prop_set_uint32(dev, \"height\", graphic_height);\n qdev_prop_set_uint8(dev, \"depth\", graphic_depth);\n- if (graphic_width == 1152 && graphic_height == 870) {\n- qdev_prop_set_uint8(dev, \"display\", MACFB_DISPLAY_APPLE_21_COLOR);\n- } else {\n- qdev_prop_set_uint8(dev, \"display\", MACFB_DISPLAY_VGA);\n- }\n qdev_realize(dev, BUS(nubus), &error_fatal);\n \n macfb_mode = (NUBUS_MACFB(dev)->macfb).mode;\n","prefixes":["4/8"]}