{"id":2196407,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196407/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260213182713.44924-4-philmd@linaro.org>","date":"2026-02-13T18:27:11","name":"[3/5] page-vary: Use target_page_bits_vary in set_preferred_target_page_bits","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3e93bfcee43d5bc4dd88792bfb250f474268295f","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213182713.44924-4-philmd@linaro.org/mbox/","series":[{"id":492130,"url":"http://patchwork.ozlabs.org/api/1.0/series/492130/?format=json","date":"2026-02-13T18:27:09","name":"page-vary: Build set_preferred_target_page_bits() as common code","version":1,"mbox":"http://patchwork.ozlabs.org/series/492130/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196407/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=DkVWbNoR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCLJX55l9z1xxM\n\tfor ; Sat, 14 Feb 2026 05:28:12 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vqxtF-0007EZ-2a; Fri, 13 Feb 2026 13:27:41 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vqxtD-0007ED-Fs\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 13:27:39 -0500","from mail-wr1-x436.google.com ([2a00:1450:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vqxtC-000639-2L\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 13:27:39 -0500","by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-435f177a8f7so1323653f8f.1\n for ; Fri, 13 Feb 2026 10:27:37 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796abcda5sm8359465f8f.19.2026.02.13.10.27.34\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 13 Feb 2026 10:27:35 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771007256; x=1771612056; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yI+Mv4GQHxCw9O8vk7u+Ssd80Cd3/VBhYa0FvH/zNGU=;\n b=DkVWbNoR2qdjQktYZ3+uNLZEES0fSgDldV0n1oyyGm6yi8Y+zgFghVCm6xe8u4P7pd\n h0EahOe0W6t3sMjgsc42LjadCFQpjdhZud3K05pm8XpIoXJ0JxENln7l3VnxVVO6quvg\n Foy8O+KvhhpPymGyIUq7pZdtPSZjBF/lrnbxcaWgh/XvRtyI9OZu+odHiPlSTd2jnJu2\n 1WgtAMMK8ZOx9zBT/cEvi3RhoBXtE1FhOavIqliGWUIh90aeUU4n7xJeixPuklwUe6Ou\n NUS8I6VpgvdGR0HJssOoog7icu7+ic++4NTQwcyOYXswTgfQ9gGUoFDqGIIxURgdAW/A\n Z7gg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771007256; x=1771612056;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yI+Mv4GQHxCw9O8vk7u+Ssd80Cd3/VBhYa0FvH/zNGU=;\n b=Z3qcX4ThauLhDf1rlX+xmcm5M2tsQ4f5zxd1i4CwyKhGhc5ieeH+DTs2dxJHo9RAK6\n ZFW94iTVV9FsQYOoFCYlA9S8Kjqq2YGQ8zz9HIZQ8nrWj+GiX6nCFSeA+d3gBp7AZtQV\n ZjOMMNEjc+40rR/bFnasUmQUCV8OI2k3Ev7yJMq+Fpeu+1vWEZtusHoV2z0w2mwoBIwc\n kW3ULGYXcW2wagd5ztUtgZRcLBgwC3LJB6GCXxmwju+LallKJ8ecNV56ZpCce+g/I51I\n e0DjWWxKmnHdf89i6R4G0W+KUr5gCzW1lkNYjhunvZT9tUTcapPtfCdt5S1EI/KfsloE\n 3BlA==","X-Gm-Message-State":"AOJu0YwNS7KLe1vXYC5ebYwdWCLZKFxQ/mBdBcoTr7o4PA6qKnd7dDaV\n zc0pBkDhH+CHD6u/8EdPBFNmwFoF0Sj2w6gUKIbWuWQoiVrfi71KE5RuB/8RKo0B/daujwJZHYf\n 4laltVzc=","X-Gm-Gg":"AZuq6aKSTLsKUnG4OXxlLs+rLKzxNZknIVpCgvd9RLpFq6ROZXFzRJqYrft4OlP8akf\n Mn9TY0P59/OaVuTUSO13s9TJBYcVurkqjhLmAEmhRYJEuuya5XFp9XZTcNx4BxxxtyWcpdJCRw+\n jkQ7qLpwaOpdlT4NPYnI1QzRtDrPmywpm95J/j8uG01NT5xM4DLuTSq1AR++4ywVXDRxVYu7d+G\n 2Sy1hBAXywmqpF2+EYZ/dPhRHId+OMd8pxBpZbvYDaYobV/vGt94QZQflULjDx5WpSY5IxGko3M\n gL3Hl4NVpr2Pn37UntPKwGXz0uz2wQ0PIPdhkhtw10rNeEKI5cCbqgcHd60ro+t+T+vPxJBPzQ0\n VcqQwMyoxIftZ0+M2YffHw9JNqLNBEmBEhdbPql1Au6vXsiB2edWlEh3O9VXS8mcmJ9C+vZvF8X\n rfeNN3/goHDguURX08ZDFJitcOgkoQPQDgyfBhBmF7B4bkt+iRKGd2yTqxm8lmp871tdaDIaJG","X-Received":"by 2002:a05:6000:2406:b0:435:b776:304c with SMTP id\n ffacd0b85a97d-4379db9349dmr763757f8f.30.1771007255943;\n Fri, 13 Feb 2026 10:27:35 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-?=\n\t=?utf-8?q?Daud=C3=A9?= ,\n Paolo Bonzini ","Subject":"[PATCH 3/5] page-vary: Use target_page_bits_vary in\n set_preferred_target_page_bits","Date":"Fri, 13 Feb 2026 19:27:11 +0100","Message-ID":"<20260213182713.44924-4-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260213182713.44924-1-philmd@linaro.org>","References":"<20260213182713.44924-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::436;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rather checking whether the target uses variable page sizes\nat runtime calling target_page_bits_vary().\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n page-vary-target.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/page-vary-target.c b/page-vary-target.c\nindex ab92da4539d..5fb79eb5752 100644\n--- a/page-vary-target.c\n+++ b/page-vary-target.c\n@@ -20,6 +20,7 @@\n #define IN_PAGE_VARY 1\n \n #include \"qemu/osdep.h\"\n+#include \"qemu/target-info.h\"\n #include \"exec/page-vary.h\"\n #include \"exec/target_page.h\"\n \n@@ -46,11 +47,10 @@ int migration_legacy_page_bits(void)\n bool set_preferred_target_page_bits(int bits)\n {\n assert(bits >= TARGET_PAGE_BITS_MIN);\n-#ifdef TARGET_PAGE_BITS_VARY\n- return set_preferred_target_page_bits_common(bits);\n-#else\n+ if (target_page_bits_vary()) {\n+ return set_preferred_target_page_bits_common(bits);\n+ }\n return true;\n-#endif\n }\n \n void finalize_target_page_bits(void)\n","prefixes":["3/5"]}