{"id":2196406,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196406/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260213182713.44924-5-philmd@linaro.org>","date":"2026-02-13T18:27:12","name":"[4/5] page-vary: Build set_preferred_target_page_bits() as common code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"894d7f29cb32e66c7ba48b70513e802cc16f4f9a","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213182713.44924-5-philmd@linaro.org/mbox/","series":[{"id":492130,"url":"http://patchwork.ozlabs.org/api/1.0/series/492130/?format=json","date":"2026-02-13T18:27:09","name":"page-vary: Build set_preferred_target_page_bits() as common code","version":1,"mbox":"http://patchwork.ozlabs.org/series/492130/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196406/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Mqv73W2l;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCLJW6xd0z1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 05:28:11 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqxtL-0007F5-4I; Fri, 13 Feb 2026 13:27:47 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vqxtK-0007Ew-9O\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 13:27:46 -0500","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vqxtI-00063r-PG\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 13:27:46 -0500","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-4806ce0f97bso9620175e9.0\n for <qemu-devel@nongnu.org>; Fri, 13 Feb 2026 10:27:44 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4834d82a1c2sm410793915e9.9.2026.02.13.10.27.41\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 13 Feb 2026 10:27:42 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771007263; x=1771612063; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=H/K35hnw1YfjsQjH2gQ+ALFmPtNIwNBwDPgyu0NG3wY=;\n b=Mqv73W2lKeDtge7vVlWQ1uCtghmZbsMSdjoos0uGrriRS6b0SUzQKnvXUfzoztGBx7\n MH8sUNn6vGLD6D95YMEmbeO97n6pMi2BdpoHUc3JqRDFECuznSnVRRK2QwP/ZciQkozK\n 6DfVk7znhU/iIU6pCLrvQqcxYkCp4zub8QM4adU9qpod3Xlv3vY7eTpylUds91+i2R0B\n Gvbhx3VA4mzlSv6UUEHlwjeBMw6I4GuPaieYtkVQkENtIJaAknprLb8mM40yzCl2cf9f\n ipwQcde8BaaAFLzCC9aVQR4PWOYZKFcBmM3AUC4QjafsZInLpR+zcjRkgNi5kC3RGkJt\n wqLA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771007263; x=1771612063;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=H/K35hnw1YfjsQjH2gQ+ALFmPtNIwNBwDPgyu0NG3wY=;\n b=eZgWxo3sVFh7BjV5OTRtdR8RjKF/Tgp271vZ4eDlG2AGpKCHqLL8uBn1OKISmuqdTc\n aELQMBN0liyCtJEKhGmZhTV+h9laWT609xSJie3iSLUSQtvuvIshitxl2IiN8cKmNCHk\n IksZ2sn3CleO+nDJbhySWpzuo7JN6AIa6RCx5EUeGo2D/zz+I/WgNFKHgVORJAflkh/k\n fuhUGKUtcmOkubJ6MKjeVCCwYjLix5+4M0F4xOuhkqifkYZvrOSN9OuowEx7QXWpZNnR\n afqMdf0ss/lP1uXtyoKEb3AihnF4V+JopJ5qdvMeseU0uhNZgnM+MjMHzHIpuPxJCuuN\n uhnw==","X-Gm-Message-State":"AOJu0YwEXxmUC0gHDU7rjEZ0ngV01aQql5f/3CVX97oObvPMLrSdlhAI\n wZ4Ew47+3lmz+sivd9OS3+c9Qai4rYC6a5H+N+8KlSnJWkS8ol3hHUkd12zzlLKX+ZsQ5ZWLrf7\n M1qO2K1Y=","X-Gm-Gg":"AZuq6aKb9lWCC22eKWH45sWJgmKPUVfQApbZjHn6caHHMsXEpVTTvM+J6ZbLoV+JbV7\n jl/4O7lEyxvY4ymyCUXEdb8DZLwHvmqOhFRaSxe0L3Aui4o/op8KuQfKeppM5spq6Wq3gct4Zu0\n 4rbLFf6Kk9WplB2vFxaXrry4Oc6h1FsZL3/+BoYhabFY+x7VBIOLKy1+3PWJfmRrtjkfGT0adKx\n rSZrSxIgWS7rMVJQv5sRkkJbu7VFXdIUcOCv5y1Zfexw0tZFRq9vFwgLltmVSk9qRrQl4CgimKJ\n K7xvGwSNBJabL4ib/Kik4vS03/Ga/cxROXtyNRM1mnts2UA7QUaQq6L7c1nT3AlHFq0gNwu421Q\n 0sfiqAejURmKySsQCMnZ4wB6uNh7blWLY9WdcrWnoXRUD8Emvo2xO9ln3r0N9JEjLWr255jxDMV\n z85qeyTjOg/O3gjIHzmT7/yH4rhTVN9wMt2A9EiIEUokqzkKVvlvoVwRIg5lrY5gLLVbxQ6fwG","X-Received":"by 2002:a05:600c:1907:b0:479:3a86:dc1c with SMTP id\n 5b1f17b1804b1-48373a7a0eamr46674505e9.36.1771007262793;\n Fri, 13 Feb 2026 10:27:42 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson <richard.henderson@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, =?utf-8?q?Philippe_Mathieu-?=\n\t=?utf-8?q?Daud=C3=A9?= <philmd@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>","Subject":"[PATCH 4/5] page-vary: Build set_preferred_target_page_bits() as\n common code","Date":"Fri, 13 Feb 2026 19:27:12 +0100","Message-ID":"<20260213182713.44924-5-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260213182713.44924-1-philmd@linaro.org>","References":"<20260213182713.44924-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"set_preferred_target_page_bits() doesn't have any\ntarget specific restriction anymore; move it to\nthe common counterpart.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n page-vary-common.c | 10 ++++++++++\n page-vary-target.c | 10 ----------\n 2 files changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/page-vary-common.c b/page-vary-common.c\nindex ab77672dd41..a2417354cc5 100644\n--- a/page-vary-common.c\n+++ b/page-vary-common.c\n@@ -20,6 +20,7 @@\n #define IN_PAGE_VARY 1\n \n #include \"qemu/osdep.h\"\n+#include \"qemu/target-info.h\"\n #include \"exec/page-vary.h\"\n \n /* WARNING: This file must *not* be complied with -flto. */\n@@ -43,6 +44,15 @@ bool set_preferred_target_page_bits_common(int bits)\n     return true;\n }\n \n+bool set_preferred_target_page_bits(int bits)\n+{\n+    assert(bits >= TARGET_PAGE_BITS_MIN);\n+    if (target_page_bits_vary()) {\n+        return set_preferred_target_page_bits_common(bits);\n+    }\n+    return true;\n+}\n+\n void finalize_target_page_bits_common(int min)\n {\n     if (target_page.bits == 0) {\ndiff --git a/page-vary-target.c b/page-vary-target.c\nindex 5fb79eb5752..a81c91410b3 100644\n--- a/page-vary-target.c\n+++ b/page-vary-target.c\n@@ -20,7 +20,6 @@\n #define IN_PAGE_VARY 1\n \n #include \"qemu/osdep.h\"\n-#include \"qemu/target-info.h\"\n #include \"exec/page-vary.h\"\n #include \"exec/target_page.h\"\n \n@@ -44,15 +43,6 @@ int migration_legacy_page_bits(void)\n }\n #endif\n \n-bool set_preferred_target_page_bits(int bits)\n-{\n-    assert(bits >= TARGET_PAGE_BITS_MIN);\n-    if (target_page_bits_vary()) {\n-        return set_preferred_target_page_bits_common(bits);\n-    }\n-    return true;\n-}\n-\n void finalize_target_page_bits(void)\n {\n #ifndef TARGET_PAGE_BITS_VARY\n","prefixes":["4/5"]}