{"id":2196245,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196245/?format=json","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.0/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260213092958.864411-3-tzungbi@kernel.org>","date":"2026-02-13T09:29:49","name":"[v3,02/11] gpio: Remove redundant check for struct gpio_chip","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9121eb1e8a72be800f0d523e71b379f48f33a8f2","submitter":{"id":83557,"url":"http://patchwork.ozlabs.org/api/1.0/people/83557/?format=json","name":"Tzung-Bi Shih","email":"tzungbi@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260213092958.864411-3-tzungbi@kernel.org/mbox/","series":[{"id":492068,"url":"http://patchwork.ozlabs.org/api/1.0/series/492068/?format=json","date":"2026-02-13T09:29:47","name":"gpio: Adopt revocable mechanism for UAF prevention","version":3,"mbox":"http://patchwork.ozlabs.org/series/492068/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196245/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=rOnY1kvt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-31659-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"rOnY1kvt\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6P4554Wz1xvQ\n\tfor ; Fri, 13 Feb 2026 20:31:20 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id D47A0300D4DA\n\tfor ; Fri, 13 Feb 2026 09:31:09 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 591A0288B1;\n\tFri, 13 Feb 2026 09:31:09 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ABB32405E1;\n\tFri, 13 Feb 2026 09:31:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 03780C116C6;\n\tFri, 13 Feb 2026 09:31:05 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770975069; cv=none;\n b=LHfO3YBhUGY9kh0usYJewAHX9La7HlxuwrM0efjKWHH573uCKTmTl1KEg5QgTLjczzKYjoU4qXFyHkWuSjHwC/c03Uo7ycBxmLjqur4eygiEN6ILZIoMd8RnGLIBWVI//LJA42rwYJ5/B2AQlTQcNcEYqdxUrN5GfAboNsrRKvo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770975069; c=relaxed/simple;\n\tbh=3yaZTDOU24FAmuSSempbk58vZlgrqTM2zntQtT1Ib4E=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=G+0IQKBUNMlVI5m8UOtWfnUhvv8+7Yq6YWAhy0GHi7IV6fvK+GvWnu82F6XI+AvVFujV+GmWPm3gCxTdhy6DpShf9qr9OfwwL4dg6cKi5g21Pxl4t/Dg6miSaxXSBrqzOgJR8oEvj3cbehuVT7qUzwGcKN4HtFQ+jECZWMfaqOM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=rOnY1kvt; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1770975068;\n\tbh=3yaZTDOU24FAmuSSempbk58vZlgrqTM2zntQtT1Ib4E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rOnY1kvtyzQdttQc8WZ7zlLqC0XJZb2WGgJU93EhUhrjx7vFftGlg0srUuv8tQPuz\n\t qwLWAiLVVEhtj8B3gM6l5jyGmK0wQA/S85CAUOHjVUuZ7kmqiISFcTvGpDtzsw9xfJ\n\t VY4/jdoYCkO6Jn2R8seaQcVxsqBrEKeyNkY+slousU/VPpVP6b05hXIL9UQo0B0b9F\n\t 5aYIunzOx4g3PLurZTlJef5RzTSOOT5yeH9Wl4eqaxkOtlnMlxLgSwTBpMblgp/BMA\n\t smehyXSLLWvA8MTSsmG2G3QgNvravfw0RTUzyXnb7oBhJHOf5VMOli1v7GTYfI3t62\n\t YnYJPKYtuFFXg==","From":"Tzung-Bi Shih ","To":"Bartosz Golaszewski ,\n\tLinus Walleij ","Cc":"Greg Kroah-Hartman ,\n\t\"Rafael J. Wysocki\" ,\n\tDanilo Krummrich ,\n\tJonathan Corbet ,\n\tShuah Khan ,\n\tLaurent Pinchart ,\n\tWolfram Sang ,\n\tJason Gunthorpe ,\n\tJohan Hovold ,\n\t\"Paul E . McKenney\" ,\n\tDan Williams ,\n\tchrome-platform@lists.linux.dev,\n\ttzungbi@kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kselftest@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v3 02/11] gpio: Remove redundant check for struct gpio_chip","Date":"Fri, 13 Feb 2026 09:29:49 +0000","Message-ID":"<20260213092958.864411-3-tzungbi@kernel.org>","X-Mailer":"git-send-email 2.53.0.310.g728cabbaf7-goog","In-Reply-To":"<20260213092958.864411-1-tzungbi@kernel.org>","References":"<20260213092958.864411-1-tzungbi@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"gpiolib_dbg_show() is only called by gpiolib_seq_show() which has\nensured the struct gpio_chip. Remove the redundant check in\ngpiolib_dbg_show().\n\nSigned-off-by: Tzung-Bi Shih \n---\nv3:\n- No changes.\n\nv2: https://lore.kernel.org/all/20260203061059.975605-3-tzungbi@kernel.org\n- No changes.\n\nv1: https://lore.kernel.org/all/20260116081036.352286-8-tzungbi@kernel.org\n\n drivers/gpio/gpiolib.c | 13 ++-----------\n 1 file changed, 2 insertions(+), 11 deletions(-)","diff":"diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c\nindex f4dad3e5b5a3..1a3fd7600835 100644\n--- a/drivers/gpio/gpiolib.c\n+++ b/drivers/gpio/gpiolib.c\n@@ -5313,23 +5313,14 @@ core_initcall(gpiolib_dev_init);\n \n #ifdef CONFIG_DEBUG_FS\n \n-static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev)\n+static void gpiolib_dbg_show(struct seq_file *s, struct gpio_chip *gc)\n {\n \tbool active_low, is_irq, is_out;\n \tstruct gpio_desc *desc;\n \tunsigned int gpio = 0;\n-\tstruct gpio_chip *gc;\n \tunsigned long flags;\n \tint value;\n \n-\tguard(srcu)(&gdev->srcu);\n-\n-\tgc = srcu_dereference(gdev->chip, &gdev->srcu);\n-\tif (!gc) {\n-\t\tseq_puts(s, \"Underlying GPIO chip is gone\\n\");\n-\t\treturn;\n-\t}\n-\n \tfor_each_gpio_desc(gc, desc) {\n \t\tguard(srcu)(&desc->gdev->desc_srcu);\n \t\tflags = READ_ONCE(desc->flags);\n@@ -5442,7 +5433,7 @@ static int gpiolib_seq_show(struct seq_file *s, void *v)\n \tif (gc->dbg_show)\n \t\tgc->dbg_show(s, gc);\n \telse\n-\t\tgpiolib_dbg_show(s, gdev);\n+\t\tgpiolib_dbg_show(s, gc);\n \n \treturn 0;\n }\n","prefixes":["v3","02/11"]}