{"id":2196191,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196191/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260213034556.13471-6-mohamed@unpredictable.fr>","date":"2026-02-13T03:45:48","name":"[v2,05/10] whpx: move whpx_get_reg/whpx_set_reg to generic code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7ba7748f97b104d3fc4d564b2cd1300fe9eee106","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.0/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213034556.13471-6-mohamed@unpredictable.fr/mbox/","series":[{"id":492055,"url":"http://patchwork.ozlabs.org/api/1.0/series/492055/?format=json","date":"2026-02-13T03:45:43","name":"whpx: x86 updates (2026-02)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492055/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196191/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=FKnzeCtp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBym04x7hz1xpY\n\tfor ; Fri, 13 Feb 2026 14:47:12 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vqk8R-0008H4-Kr; Thu, 12 Feb 2026 22:46:27 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vqk8Q-0008Gp-Ez\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 22:46:26 -0500","from p-west1-cluster4-host5-snip4-5.eps.apple.com ([57.103.65.236]\n helo=outbound.pv.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vqk8O-0005N3-Qm\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 22:46:26 -0500","from outbound.pv.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-1a-60-percent-11 (Postfix) with ESMTPS id\n 08C0218002D0; Fri, 13 Feb 2026 03:46:21 +0000 (UTC)","from localhost.localdomain (unknown [17.56.9.36])\n by p00-icloudmta-asmtp-us-west-1a-60-percent-11 (Postfix) with ESMTPSA id\n 8A20B180009E; Fri, 13 Feb 2026 03:46:18 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1770954383; x=1773546383;\n bh=be0nJ130zvvK9XI/bsScdXF1W7wGDBAIgGEUgggxqUo=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=FKnzeCtpexctX61PshjrHApKNvROlo7wBjBMGdEWUDtR8qPSCZCqON6Rw7MQhuZ3mk/6iitqyUmyXUoBytXO3/ClTcTcxYOU6tk+d+wNQvd77tYU9Gm3tw79mDBNFURlxX0xk6uj+6t2g+3Z7GkZlLjLflGtg1bqu8x8cQzmYgxU+5dijH8PiYzZ3X+RB29l4sMjROPsc9ouIy1WXQXKXZnoCJ1/YDE0h9uIL564QlIfmdaFH7plpf6FL38FABovJn7Ttid0a+SQorKvJHp/1+kTGFnvi7IT0QMGo8xPav/H8kvbngqRYjNtakMjm0fAH0bkT784uNJ3yp0U5clfbw==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Magnus Kulke , =?utf-8?q?Philippe_Mathieu-?=\n\t=?utf-8?q?Daud=C3=A9?= ,\n Bernhard Beschow , Paolo Bonzini ,\n Mohamed Mediouni , Wei Liu ,\n Pedro Barbuda , Cameron Esfahani ,\n Peter Maydell ,\n Phil Dennis-Jordan , Zhao Liu ,\n Roman Bolshakov ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH v2 05/10] whpx: move whpx_get_reg/whpx_set_reg to generic code","Date":"Fri, 13 Feb 2026 04:45:48 +0100","Message-ID":"<20260213034556.13471-6-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260213034556.13471-1-mohamed@unpredictable.fr>","References":"<20260213034556.13471-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"VBiiheajr493pI2umY_Ygn5mD8bRoSI-","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjEzMDAyNSBTYWx0ZWRfXzvqWZorHAYls\n NMsD3d5Sj6EeGWkhhn29nQeidsMsKaYxmZJqbpmFmPEcBFjO9QA9CEBcK23ER+ynCEVrk6MQIAs\n wNaRKMGBZx+UleeKtkP1uHJAnkAWSAGcVeGF6Xxy3u3OmOIZh90vRu2dFkhgz/bEYVbMMGz9kvq\n ebI2ryN1Z0czpc+44O9YbjKrLncaF0cupEwyk8c5PcnL1dL4PvQ8z5nPwkvt+4+HgnYnDYYnyA3\n nboOf/h4Ts8g4Ygt921eaRGAqaU/F4FMBfYS1NTgaRnK9NH+ohpF8jJXhJXADwRtAWxoQ57d1/T\n B9ZvT7B4XiLImZNNLoo707smoffeFvG0acRjr7pyPzLwdkHnx+VX4T7GnEWRAE=","X-Authority-Info-Out":"v=2.4 cv=Lv6fC3dc c=1 sm=1 tr=0 ts=698e9e8e\n cx=c_apl:c_apl_out:c_pps a=azHRBMxVc17uSn+fyuI/eg==:117\n a=azHRBMxVc17uSn+fyuI/eg==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=zEEq2qrNK1eH_SHa7C4A:9","X-Proofpoint-GUID":"VBiiheajr493pI2umY_Ygn5mD8bRoSI-","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 spamscore=0\n adultscore=0 bulkscore=0 clxscore=1030 lowpriorityscore=0 malwarescore=0\n mlxlogscore=990 phishscore=0 suspectscore=0 mlxscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602130025","X-JNJ":"\n AAAAAAAB6Muo0EbYD4eVr/seCyC9w85rfUxv3DHLbJwmpJQ0x1DmmoFgfz+zXbuDYMCFNfB6tYCdWMrz+X2eeC5BVlSh2lgKEfBMD9b2PB411ZsXVHCVpuyVFH2OQrR/Wotbwdue1nNbu9jhomU0CUJ0K+pMANoZfVfZ9UK1TXy2QO01Sl92lwtir6To+R3DnElg67JbqEndfzo8V6+daNGdaKZoFeWR1hP0QR4gyeTehrQltwtJG6VouCRvqDA2NlKoajDA3GAb72Xc+MJ9qrUpU3dgpGCmhJV+pmFPP3AqXkviIHifYjV4/bzbPbhxTpo5rvkam0BwjcAgYjlgnB1VF4hRnqKydtujYPllFVxzdVRvYx4GedS4gwXrtGO399rM/egNrllza1vh10M3Gd0evqLuP0hNJXmi0OqPjcuQ/aCYwlzBmwIMgqGEZ8Si3R+UZ/1ApTHLIJnrt6mWkzVqlm/QXmIjasnJgAS5J8LYyu6duqRObLg44+r1p0pZw2gkHA9VCZtpc84Rpw/4ehMrrAU/OjDZUlZhWTVzfmF3fubNjraU1UXMv4JCqyGPIKB8HypNpAddTvAWzbFiJJGt8iEpZ84uSNVHWB/y4Q1tvSgQTQCKP3Cjl4HUVnvZ12A+KisaK/dR8YuJ5nPMLM/S179WIwvDKd+7MUFPrALUMmIxNsRPoIlN4NK8hAEZWMuUYswEkHYbAbRe1X3UGfYGP7X8R/GD+N4AjBu+ma6Q3wS7qu5KO6mPAazuIzF7yLOy35/zQ3wvH9OWAw==","Received-SPF":"pass client-ip=57.103.65.236;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.pv.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"These will be used in the next commit on the x86_64 backend too.\nAlso move flush_cpu_state as it's used by get_reg/set_reg and the arm64 code.\n\nSigned-off-by: Mohamed Mediouni \n---\n accel/whpx/whpx-common.c | 35 +++++++++++++++++++++++++++++++++++\n include/system/whpx-common.h | 3 +++\n target/arm/whpx/whpx-all.c | 35 -----------------------------------\n 3 files changed, 38 insertions(+), 35 deletions(-)","diff":"diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c\nindex c57a0d3f0f..c2263c2496 100644\n--- a/accel/whpx/whpx-common.c\n+++ b/accel/whpx/whpx-common.c\n@@ -46,6 +46,41 @@ static HMODULE hWinHvEmulation;\n struct whpx_state whpx_global;\n struct WHPDispatch whp_dispatch;\n \n+void flush_cpu_state(CPUState *cpu)\n+{\n+ if (cpu->vcpu_dirty) {\n+ whpx_set_registers(cpu, WHPX_SET_RUNTIME_STATE);\n+ cpu->vcpu_dirty = false;\n+ }\n+}\n+\n+void whpx_get_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE* val)\n+{\n+ struct whpx_state *whpx = &whpx_global;\n+ HRESULT hr;\n+\n+ flush_cpu_state(cpu);\n+\n+ hr = whp_dispatch.WHvGetVirtualProcessorRegisters(whpx->partition, cpu->cpu_index,\n+ ®, 1, val);\n+\n+ if (FAILED(hr)) {\n+ error_report(\"WHPX: Failed to get register %08x, hr=%08lx\", reg, hr);\n+ }\n+}\n+\n+void whpx_set_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE val)\n+{\n+ struct whpx_state *whpx = &whpx_global;\n+ HRESULT hr;\n+ hr = whp_dispatch.WHvSetVirtualProcessorRegisters(whpx->partition, cpu->cpu_index,\n+ ®, 1, &val);\n+\n+ if (FAILED(hr)) {\n+ error_report(\"WHPX: Failed to set register %08x, hr=%08lx\", reg, hr);\n+ }\n+}\n+\n /* Tries to find a breakpoint at the specified address. */\n struct whpx_breakpoint *whpx_lookup_breakpoint_by_addr(uint64_t address)\n {\ndiff --git a/include/system/whpx-common.h b/include/system/whpx-common.h\nindex b86fe9db6e..5bce33e336 100644\n--- a/include/system/whpx-common.h\n+++ b/include/system/whpx-common.h\n@@ -20,6 +20,9 @@ int whpx_first_vcpu_starting(CPUState *cpu);\n int whpx_last_vcpu_stopping(CPUState *cpu);\n void whpx_memory_init(void);\n struct whpx_breakpoint *whpx_lookup_breakpoint_by_addr(uint64_t address);\n+void flush_cpu_state(CPUState *cpu);\n+void whpx_get_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE* val);\n+void whpx_set_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE val);\n \n /* On x64: same as WHvX64ExceptionTypeDebugTrapOrFault */\n #define WHPX_INTERCEPT_DEBUG_TRAPS 1\ndiff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c\nindex d52580a082..c8d71a252e 100644\n--- a/target/arm/whpx/whpx-all.c\n+++ b/target/arm/whpx/whpx-all.c\n@@ -274,14 +274,6 @@ static struct whpx_sreg_match whpx_sreg_match[] = {\n { WHvArm64RegisterSpEl1, ENCODE_AA64_CP_REG(4, 1, 3, 4, 0) },\n };\n \n-static void flush_cpu_state(CPUState *cpu)\n-{\n- if (cpu->vcpu_dirty) {\n- whpx_set_registers(cpu, WHPX_SET_RUNTIME_STATE);\n- cpu->vcpu_dirty = false;\n- }\n-}\n-\n HRESULT whpx_set_exception_exit_bitmap(UINT64 exceptions)\n {\n if (exceptions != 0) {\n@@ -314,33 +306,6 @@ void whpx_arch_destroy_vcpu(CPUState *cpu)\n /* currently empty on Arm */\n }\n \n-static void whpx_get_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE* val)\n-{\n- struct whpx_state *whpx = &whpx_global;\n- HRESULT hr;\n-\n- flush_cpu_state(cpu);\n-\n- hr = whp_dispatch.WHvGetVirtualProcessorRegisters(whpx->partition, cpu->cpu_index,\n- ®, 1, val);\n-\n- if (FAILED(hr)) {\n- error_report(\"WHPX: Failed to get register %08x, hr=%08lx\", reg, hr);\n- }\n-}\n-\n-static void whpx_set_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE val)\n-{\n- struct whpx_state *whpx = &whpx_global;\n- HRESULT hr;\n- hr = whp_dispatch.WHvSetVirtualProcessorRegisters(whpx->partition, cpu->cpu_index,\n- ®, 1, &val);\n-\n- if (FAILED(hr)) {\n- error_report(\"WHPX: Failed to set register %08x, hr=%08lx\", reg, hr);\n- }\n-}\n-\n static void whpx_get_global_reg(WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE *val)\n {\n struct whpx_state *whpx = &whpx_global;\n","prefixes":["v2","05/10"]}