{"id":2196190,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196190/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260213034556.13471-3-mohamed@unpredictable.fr>","date":"2026-02-13T03:45:45","name":"[v2,02/10] whpx: re-enable guest debug support on x86","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f276bb3abeb58a991cd0c045aa799bfc0505c75e","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.0/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213034556.13471-3-mohamed@unpredictable.fr/mbox/","series":[{"id":492055,"url":"http://patchwork.ozlabs.org/api/1.0/series/492055/?format=json","date":"2026-02-13T03:45:43","name":"whpx: x86 updates (2026-02)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492055/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196190/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=JJEwWWSq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fByld339dz1xxM\n\tfor ; Fri, 13 Feb 2026 14:46:53 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vqk8I-0008FH-H7; Thu, 12 Feb 2026 22:46:18 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vqk8G-0008ET-89\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 22:46:16 -0500","from p-west1-cluster5-host6-snip4-10.eps.apple.com ([57.103.66.151]\n helo=outbound.pv.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vqk8E-0005AL-FR\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 22:46:16 -0500","from outbound.pv.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-1a-60-percent-11 (Postfix) with ESMTPS id\n 6AB5A1800104; Fri, 13 Feb 2026 03:46:11 +0000 (UTC)","from localhost.localdomain (unknown [17.56.9.36])\n by p00-icloudmta-asmtp-us-west-1a-60-percent-11 (Postfix) with ESMTPSA id\n E49CB1800135; Fri, 13 Feb 2026 03:46:07 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1770954373; x=1773546373;\n bh=mOYNtTveKjr+KZigxP71eIiTh5kyqDuwACrDmj+VmsE=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme;\n b=JJEwWWSq3syIFgK4RBQlhXt+Dh73qUMuQwwF7DKU/w7CWAvXLKMZGJmGHbgQ5fku7ehyWtfvP0rc596Brg1zSivShkqA0b9dg0CkFKaDJL6KsZorbwp9ZTBnp0M2jgcLEf4z9W9McnhlIsKJugnKhufVuo+CxYUHR3aJuwgwUBnsXskkUmxpfPaShdb5w6WKWHk4F9pUZxf6SBsu0V/RVidt7h6tHeiz5tQ2dY8BEd/fC++Aqg/yxNdEfCot/fQPm7hBxqHk6QfUJ25gHoA4w3atzYIr4EGNYSiw50+2SgyQu+XzF9mGpKfFV+AkOmvSR0Txl1rQb0ImEiN+Pxo5KQ==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Magnus Kulke , =?utf-8?q?Philippe_Mathieu-?=\n\t=?utf-8?q?Daud=C3=A9?= ,\n Bernhard Beschow , Paolo Bonzini ,\n Mohamed Mediouni , Wei Liu ,\n Pedro Barbuda , Cameron Esfahani ,\n Peter Maydell ,\n Phil Dennis-Jordan , Zhao Liu ,\n Roman Bolshakov ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH v2 02/10] whpx: re-enable guest debug support on x86","Date":"Fri, 13 Feb 2026 04:45:45 +0100","Message-ID":"<20260213034556.13471-3-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260213034556.13471-1-mohamed@unpredictable.fr>","References":"<20260213034556.13471-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"7Bdch6XXe5ToAIUFipNn4Igp9tqsiPzX","X-Proofpoint-GUID":"7Bdch6XXe5ToAIUFipNn4Igp9tqsiPzX","X-Authority-Info-Out":"v=2.4 cv=BtSQAIX5 c=1 sm=1 tr=0 ts=698e9e84\n cx=c_apl:c_apl_out:c_pps a=azHRBMxVc17uSn+fyuI/eg==:117\n a=azHRBMxVc17uSn+fyuI/eg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=TBIg4pHv79D69QLdSdkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjEzMDAyNSBTYWx0ZWRfX7GynOkYCn4nP\n sddzfRnREd7/3oDZr5iyfNNcM1gQmTHsdnNVNO5NCa4UlufT5mifmSYl9xiTF9P6uYxnLcYxGwm\n etyWq0LGVn39ya57VrE9MiOL/Z+ZvMsoFYkNO/s6voGqeqjeq5VW1/bK9gOGhKBFRiG6wbkLPia\n xo0EgG1mfnT24y3NbFZOpF6O/Nmp+AIjwpU69iGC/uW6TcgIYm68A+6wEqDm9mPAoKlNwi8OXHM\n CMt5jH/tPdGwtHEKsoZAxD0ZUyjxXpZWsMghBg5pSPNPWgDE0HNAcrj0Xz80VeDiac5tsRYv6/o\n mWBo1zr7/YAzX3DC2klCdSSK0kgA2JuimvCnjlasgHM0JSe1uZkoNKpbQ97uys=","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 mlxlogscore=999\n suspectscore=0 mlxscore=0 clxscore=1030\n malwarescore=0 phishscore=0\n bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602130025","X-JNJ":"\n AAAAAAAB6nTUR1xGXANIy01QQin19GDRyc/xZhL1XDkr1YdJn9EOeHeg16kNLA8k42hHtByUtGC58jvfMZlBsWS7YzO5YTqaH1NWI37eR4I6/9udijsTrx/3UfqLwlu0CmW6MD7+LTJsZNp2XGxLt4JQel8pwORES1g8wbwS31w7NI/yA9Onoeo91cXpQr2GyVCsmfsaAzQPY3N7og0/muhdYARnxvWsr72nnRipARzmixHLLbM5dlMOFiCoPxd2vDUvtNXiTQrkEM5Uo3gPVQQ5czM8Wb/vpxx6StQPXW6nVLH0NYF9l8tA4ihEccIdTXVlnyBM8MZ00RBr7BE2CkvGJ5teE9Wq+M+A+Ub9GUOWQH8KHEIMDbQ7eRUpUA8PvNBj6slpy8AxDldoH+P1MKeFgKOZLemJz7FaBnP3h5ESVsHmRHa/YrAibMYdWiVPnVqUWJ9RT4J7S8fYRANHAJHNMM+0fLvHoT1o5GZWFvHwGa6ZSoE5HsYNRcGF/RMcz9yjb1jqLS3gZQn6Agmqh6p8brhgPygDFZsLl0lPJovyd7Q9d/ckZd9jB2tW6vEFs3RVVQLwFk4TOeRWhSZGfwqQ79UES/lSSOseE8LpiAjT4K4l095uho4cjwi2i0ftQKKAlyZaXA+9ayjwxLJMWUD4qY4C0Jc9KOLJ4spD1rW+nvgkBgFRVK887en2OYt4YxToeWQ+uRR9ui9RyPmM0N1mZma7V/yjz+5L4JsuuPTlEpy3Ws2Cv9lnuw8cz3wb+4DVbMS9FQabxbWCCk02leZ9mXhggWMfu05dkdva/bJVtqJH6w==","Received-SPF":"pass client-ip=57.103.66.151;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.pv.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Fix what got broken several years ago by adding ops->supports_guest_debug\nsupport as an architecture-specific function.\n\narm64 WHP doesn't currently provide support needed for this.\n\nSigned-off-by: Mohamed Mediouni \n---\n accel/whpx/whpx-accel-ops.c | 8 ++++++++\n include/system/whpx-all.h | 4 ++++\n target/arm/whpx/whpx-all.c | 5 +++++\n target/i386/whpx/whpx-all.c | 5 +++++\n 4 files changed, 22 insertions(+)","diff":"diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c\nindex 50fadea0fd..b8f41544cb 100644\n--- a/accel/whpx/whpx-accel-ops.c\n+++ b/accel/whpx/whpx-accel-ops.c\n@@ -17,6 +17,7 @@\n \n #include \"system/whpx.h\"\n #include \"system/whpx-internal.h\"\n+#include \"system/whpx-all.h\"\n #include \"system/whpx-accel-ops.h\"\n \n static void *whpx_cpu_thread_fn(void *arg)\n@@ -81,6 +82,12 @@ static bool whpx_vcpu_thread_is_idle(CPUState *cpu)\n return !whpx_irqchip_in_kernel();\n }\n \n+static bool whpx_supports_guest_debug(void)\n+{\n+ return whpx_arch_supports_guest_debug();\n+}\n+\n+\n static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data)\n {\n AccelOpsClass *ops = ACCEL_OPS_CLASS(oc);\n@@ -89,6 +96,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data)\n ops->kick_vcpu_thread = whpx_kick_vcpu_thread;\n ops->cpu_thread_is_idle = whpx_vcpu_thread_is_idle;\n ops->handle_interrupt = generic_handle_interrupt;\n+ ops->supports_guest_debug = whpx_supports_guest_debug;\n \n ops->synchronize_post_reset = whpx_cpu_synchronize_post_reset;\n ops->synchronize_post_init = whpx_cpu_synchronize_post_init;\ndiff --git a/include/system/whpx-all.h b/include/system/whpx-all.h\nindex f13cdf7f66..3db074c38c 100644\n--- a/include/system/whpx-all.h\n+++ b/include/system/whpx-all.h\n@@ -17,4 +17,8 @@ void whpx_translate_cpu_breakpoints(\n struct whpx_breakpoints *breakpoints,\n CPUState *cpu,\n int cpu_breakpoint_count);\n+\n+/* called by whpx-accel-ops */\n+bool whpx_arch_supports_guest_debug(void);\n+\n #endif\ndiff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c\nindex 36c5e30a03..8d0ca794af 100644\n--- a/target/arm/whpx/whpx-all.c\n+++ b/target/arm/whpx/whpx-all.c\n@@ -304,6 +304,11 @@ void whpx_translate_cpu_breakpoints(\n /* Breakpoints aren’t supported on this platform */\n }\n \n+bool whpx_arch_supports_guest_debug(void) \n+{\n+ return false;\n+}\n+\n static void whpx_get_reg(CPUState *cpu, WHV_REGISTER_NAME reg, WHV_REGISTER_VALUE* val)\n {\n struct whpx_state *whpx = &whpx_global;\ndiff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 8210250dc3..e1f0fa5e77 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -1272,6 +1272,11 @@ void whpx_apply_breakpoints(\n }\n }\n \n+bool whpx_arch_supports_guest_debug(void) \n+{\n+ return true;\n+}\n+\n /* Returns the address of the next instruction that is about to be executed. */\n static vaddr whpx_vcpu_get_pc(CPUState *cpu, bool exit_context_valid)\n {\n","prefixes":["v2","02/10"]}