{"id":2175792,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175792/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20251218225936.2016920-2-judge.packham@gmail.com>","date":"2025-12-18T22:59:34","name":"[v3,1/3] mtd: nand: pxa3xx: Pass valid dev to dev_err()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"08685629b034a3abbf32d347ca0cfb8cfecde52f","submitter":{"id":6125,"url":"http://patchwork.ozlabs.org/api/1.0/people/6125/?format=json","name":"Chris Packham","email":"judge.packham@gmail.com"},"delegate":{"id":1696,"url":"http://patchwork.ozlabs.org/api/1.0/users/1696/?format=json","username":"stroese","first_name":"Stefan","last_name":"Roese","email":"sr@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251218225936.2016920-2-judge.packham@gmail.com/mbox/","series":[{"id":485928,"url":"http://patchwork.ozlabs.org/api/1.0/series/485928/?format=json","date":"2025-12-18T22:59:33","name":"arm: mvebu: Updates for xcat3","version":3,"mbox":"http://patchwork.ozlabs.org/series/485928/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175792/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=mo74kVwY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"mo74kVwY\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=judge.packham@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXR2S3yd6z1y3t\n\tfor ; Fri, 19 Dec 2025 10:00:00 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8C163805D7;\n\tThu, 18 Dec 2025 23:59:52 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id B78EE8042F; Thu, 18 Dec 2025 23:59:51 +0100 (CET)","from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com\n [IPv6:2607:f8b0:4864:20::1044])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id CA0918003E\n for ; Thu, 18 Dec 2025 23:59:48 +0100 (CET)","by mail-pj1-x1044.google.com with SMTP id\n 98e67ed59e1d1-34c3259da34so1150643a91.2\n for ; Thu, 18 Dec 2025 14:59:48 -0800 (PST)","from chrisp-dl.atlnz.lc ([2001:df5:b000:22:dc63:c226:257b:b4c4])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-34e70d6565esm3431356a91.6.2025.12.18.14.59.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 18 Dec 2025 14:59:46 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1766098787; x=1766703587; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UQQPrVcQuKGWRqkwPqURQu4DB0GctoNWsomn5vC8N7w=;\n b=mo74kVwYP3/2FVJOUYHmgGtoO2kcBJgGNEIu4jc9DyKqMOv0IwKQWfDat78qFK3Apc\n reej4HC9pbcp57c+4jdyDWeG7ZRlvejAFpeVz+dI+ik8yEKRlmHPdEoLvZ1PIJpHcAbY\n T9s7g/+q+4NyOqVy0hxOMFY+5MX/aAtMRe4TQgKhD4VM58/mFsw1JPYHM0unMc2kzJ6/\n eTwv8zmnpNOIYWWfgWR9jgJKN0ilMUrTa23GQDPVmfl3YFb6SMyH6k+QCtZ0shVokCSp\n 4MFFVNsVjBn+kZxpVBwFxXxke2shIwBQhuJLN6jicOQIW0hEE4xjS0d2PUNf/D7BtNmH\n vfgA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766098787; x=1766703587;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=UQQPrVcQuKGWRqkwPqURQu4DB0GctoNWsomn5vC8N7w=;\n b=HDlCmeNsSaTBZ1jIKf1oJZJCJsPsEUCssO5HSSfqWx9iArgh4iPLVOXUbVV5bAIDN+\n akyD4dkkCaB47ODqVbi6a2vprucx6g3ldn51ERe52cDvBpCAiR0dRk6YUHxwtJx0XAPu\n cXM+76MuQs3e5e3RPNFfxi/cblL/hs22jEh0L35IHh5rJr1QFsKplUw9WHbufzT7Z1RS\n 9j6IIwX5H2JTT+bxZicrEfbU0sBbxJ88Vth2Px+LuKNofHhFLZdvBkv5YW7LZlAjIUr0\n +zL16wYaBw3J4EdPp+whVoXQoQhAbrVYZIhSVPU3G7hdgulis84YdavxFAmtp4KEcM3T\n Z3xQ==","X-Gm-Message-State":"AOJu0Yzr+9nK9q3/H/fKPAtBCgi5fG4ZMfkfy34JRp83Dgopu2Yz4rfp\n WjlvZpFiWKKLFLbEyQT++uX9/oZLzwcX3p3OR0xIp6rDhr3IXnVcyoCm","X-Gm-Gg":"AY/fxX5Kq7pW0w4Voly4iHDBNfIN9IDNlxMKtqY6p0ypx2xzF+fDkDBtzYV4pYskBJN\n jkH4hCLGTLwT+UVbnMatYYbIrXKGQ0ny686s2j1NWBsjlFoJy4aVYaRO5SZPjx30Wv41LWzL/r2\n rdWGa8LoQ/u/FrKtTszsHphm/P8JotSuOoKnTJVmvbqD4vI4gr/+Bp/FlLOoNMwFWlhXWBjvE3s\n M849F36fxvN46jAw87Vu2Z98qmukEr7zz6Ti0nt69HRu1gzluxWpJY6EakJ6Z0STpIhkPuELYov\n VtZivuQDdCAXGzVivqDLqtViIU+O0oEG0ZXISCVkGpGw++6az9kT5HRPD35QcaLxfdAE9E4vf7O\n iXSXdiWl+6/ozJB5PwnUrzOUh7FuJki+IclWOZZnm7xpoNZxwJ/ZCgXCzypulpVi9rr4CnNFUca\n 5zUWg5ViOaMY9EmZNKw1zpfdK4","X-Google-Smtp-Source":"\n AGHT+IEYdrI2QzdSIfp2lpDQKfnKjv+g6wWJ5qABd/vr8XolRwydwTkMpP7tr4h0KQo8IbnA/H5W7w==","X-Received":"by 2002:a17:90b:3145:b0:32d:d5f1:fe7f with SMTP id\n 98e67ed59e1d1-34e92142cb5mr850620a91.15.1766098787293;\n Thu, 18 Dec 2025 14:59:47 -0800 (PST)","From":"Chris Packham ","To":"trini@konsulko.com,\n\tstefan.roese@mailbox.org","Cc":"u-boot@lists.denx.de, Chris Packham ,\n Sean Anderson ","Subject":"[PATCH v3 1/3] mtd: nand: pxa3xx: Pass valid dev to dev_err()","Date":"Fri, 19 Dec 2025 11:59:34 +1300","Message-ID":"<20251218225936.2016920-2-judge.packham@gmail.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251218225936.2016920-1-judge.packham@gmail.com>","References":"<20251218225936.2016920-1-judge.packham@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"info->controller.active is not initialised so the dev_err() call ends up\ndereferencing a null pointer causing a crash instead of outputting the\nerror. Add a dev member to struct pxa3xx_nand_info and use that instead\nof info->controller.active->mtd.dev.\n\nFixes: 661c98121d49 (\"mtd: nand: pxa3xx: Fix not calling dev_xxx with a device\")\nSigned-off-by: Chris Packham \n---\nCc: Sean Anderson \n\nNotes:\n Changes in v2:\n - Add a dev member to pxa3xx_nand_info so we can keep using dev_err()\n\n drivers/mtd/nand/raw/pxa3xx_nand.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/mtd/nand/raw/pxa3xx_nand.c b/drivers/mtd/nand/raw/pxa3xx_nand.c\nindex 7bf54fa46540..a5293563a9fd 100644\n--- a/drivers/mtd/nand/raw/pxa3xx_nand.c\n+++ b/drivers/mtd/nand/raw/pxa3xx_nand.c\n@@ -187,6 +187,7 @@ struct pxa3xx_nand_host {\n struct pxa3xx_nand_info {\n \tstruct nand_hw_control\tcontroller;\n \tstruct pxa3xx_nand_platform_data *pdata;\n+\tstruct udevice *dev;\n \n \tstruct clk\t\t*clk;\n \tvoid __iomem\t\t*mmio_base;\n@@ -588,8 +589,7 @@ static void drain_fifo(struct pxa3xx_nand_info *info, void *data, int len)\n \t\t\tts = get_timer(0);\n \t\t\twhile (!(nand_readl(info, NDSR) & NDSR_RDDREQ)) {\n \t\t\t\tif (get_timer(ts) > TIMEOUT_DRAIN_FIFO) {\n-\t\t\t\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\t\t\t\"Timeout on RDDREQ while draining the FIFO\\n\");\n+\t\t\t\t\tdev_err(info->dev, \"Timeout on RDDREQ while draining the FIFO\\n\");\n \t\t\t\t\treturn;\n \t\t\t\t}\n \t\t\t}\n@@ -641,8 +641,7 @@ static void handle_data_pio(struct pxa3xx_nand_info *info)\n \t\t\t\t DIV_ROUND_UP(info->step_spare_size, 4));\n \t\tbreak;\n \tdefault:\n-\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\"%s: invalid state %d\\n\", __func__, info->state);\n+\t\tdev_err(info->dev, \"%s: invalid state %d\\n\", __func__, info->state);\n \t\tBUG();\n \t}\n \n@@ -1560,8 +1559,7 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info,\n \t\tecc->size = 512;\n \n \tif (ecc_stepsize != 512 || !(nfc_layouts[i].strength)) {\n-\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\"ECC strength %d at page size %d is not supported\\n\",\n+\t\tdev_err(info->dev, \"ECC strength %d at page size %d is not supported\\n\",\n \t\t\tstrength, page_size);\n \t\treturn -ENODEV;\n \t}\n@@ -1802,6 +1800,7 @@ static int pxa3xx_nand_probe(struct udevice *dev)\n \tif (ret)\n \t\treturn ret;\n \n+\tinfo->dev = dev;\n \tpdata = info->pdata;\n \n \tret = alloc_nand_resource(dev, info);\n","prefixes":["v3","1/3"]}