{"id":2175748,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175748/?format=json","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.0/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<3036574.e9J7NaK4W3@rafael.j.wysocki>","date":"2025-12-18T20:35:27","name":"[v1,2/8] ACPI: bus: Rework printing debug messages on _OSC errors","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"010d83486e8cecafce6b1835854d055c42799432","submitter":{"id":64267,"url":"http://patchwork.ozlabs.org/api/1.0/people/64267/?format=json","name":"Rafael J. Wysocki","email":"rafael@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/3036574.e9J7NaK4W3@rafael.j.wysocki/mbox/","series":[{"id":485914,"url":"http://patchwork.ozlabs.org/api/1.0/series/485914/?format=json","date":"2025-12-18T20:37:36","name":"ACPI: bus: Rework of the \\_SB._OSC handling","version":1,"mbox":"http://patchwork.ozlabs.org/series/485914/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175748/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=OSaPX/Zv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-43333-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"OSaPX/Zv\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXNKq5D8bz1y2r\n\tfor ; Fri, 19 Dec 2025 07:58:07 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A625C3046391\n\tfor ; Thu, 18 Dec 2025 20:52:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 07EAE34AB1D;\n\tThu, 18 Dec 2025 20:43:30 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CBBAC34AB14;\n\tThu, 18 Dec 2025 20:43:29 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 379FAC4CEFB;\n\tThu, 18 Dec 2025 20:43:28 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1766090609; cv=none;\n b=Av7k8mqPCrBXE9q+yiUjdsGMGujqYatf3yWViG+ZSdYE27711kWHeHVFMPOVlcW1rKcCBYTTW6w7zWzvPEDNz6eWlHuvLclQRJq7EsFbLIx7Jgz1ffeLrLSj4GiYnNwU3aoA0PRukGgridWW8DU5xFqvLrBsABA72eBkYoHWhYc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1766090609; c=relaxed/simple;\n\tbh=F83hFCO2otBSiK8w3nqcSd+WXOlzEZ7ZQ5/sUZMF5Pk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=Uwi69N2QDr+xubI59IB2hvCHhV/92aT1VzZcp/YCNrcxDhv+TGLBFyRd1qiMPHYALY4wod7QaMRayP0ezOlY0Lm6Luwok045+Pf4JUEgkANGeOOaY93O01cS0Yq/Qs86zA9/wO6zmZ4GVxaxpl9XBkff5pvX3L1FcK3POQiixtk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=OSaPX/Zv; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1766090609;\n\tbh=F83hFCO2otBSiK8w3nqcSd+WXOlzEZ7ZQ5/sUZMF5Pk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OSaPX/Zvt7QNQe9v+pxojVJ3KzplvaxBj3SKsbRHEQHi/Ie9uqfPbyOxPNhX8snZv\n\t StCvMHQeQR9pF2O7SNupHMQ90F3n/z21vbZ0WUJKkgMNDdqXcHSpIdPVFBabXyRZb/\n\t 6btbzI8apdPqBh7ofPdCzQ+Sfv2N8DJkBRUiskG821ulmfc3JCOoKJRarAM7AXECSX\n\t qjf5J1WupcPKQ89/gMk54oZf33p2lNzXP7aJgDBsmlwrqNHvqkpSxriOkQtWqZ2zgd\n\t 7TqYyGJWw21Z8BQU1Se2a87KzWUQW0jLKj2htSwwOlXpVlp3iwLwXghUXZtT09v+vx\n\t WOosOiyRSEwkg==","From":"\"Rafael J. Wysocki\" ","To":"Linux ACPI ","Cc":"LKML ,\n Linux PCI , Bjorn Helgaas ,\n Srinivas Pandruvada ,\n Hans de Goede ,\n Mario Limonciello ","Subject":"\n [PATCH v1 2/8] ACPI: bus: Rework printing debug messages on _OSC errors","Date":"Thu, 18 Dec 2025 21:35:27 +0100","Message-ID":"<3036574.e9J7NaK4W3@rafael.j.wysocki>","Organization":"Linux Kernel Development","In-Reply-To":"<5049211.GXAFRqVoOG@rafael.j.wysocki>","References":"<5049211.GXAFRqVoOG@rafael.j.wysocki>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"UTF-8\""},"content":"From: Rafael J. Wysocki \n\nInstead of using one function, acpi_print_osc_error(), for printing a\ndebug message and dumping the _OSC request data in one go, use\nacpi_handle_debug() directly for printing messages and a separate\nfunction called acpi_dump_osc_data() for dumping the _OSC request data\nafter printing one or more of them.\n\nThis allows the message printing in the _OSC handling code to be\norganized so that the messages printed by it are easier to parse.\n\nAlso, use %pUL for UUID printing instead of printing UUIDs as strings\nand include the revision number into the dumped _OSC request data.\n\nSigned-off-by: Rafael J. Wysocki \n---\n drivers/acpi/bus.c | 35 ++++++++++++++++-------------------\n 1 file changed, 16 insertions(+), 19 deletions(-)","diff":"--- a/drivers/acpi/bus.c\n+++ b/drivers/acpi/bus.c\n@@ -180,18 +180,15 @@ void acpi_bus_detach_private_data(acpi_h\n }\n EXPORT_SYMBOL_GPL(acpi_bus_detach_private_data);\n \n-static void acpi_print_osc_error(acpi_handle handle,\n-\t\t\t\t struct acpi_osc_context *context, char *error)\n+static void acpi_dump_osc_data(acpi_handle handle, const guid_t *guid, int rev,\n+\t\t\t struct acpi_buffer *cap)\n {\n+\tu32 *capbuf = cap->pointer;\n \tint i;\n \n-\tacpi_handle_debug(handle, \"(%s): %s\\n\", context->uuid_str, error);\n-\n-\tpr_debug(\"_OSC request data:\");\n-\tfor (i = 0; i < context->cap.length; i += sizeof(u32))\n-\t\tpr_debug(\" %x\", *((u32 *)(context->cap.pointer + i)));\n-\n-\tpr_debug(\"\\n\");\n+\tfor (i = 0; i < cap->length / sizeof(u32); i++)\n+\t\tacpi_handle_debug(handle, \"(%pUL, %d): capabilities DWORD %i: [%08x]\\n\",\n+\t\t\t\t guid, rev, i, capbuf[i]);\n }\n \n #define OSC_ERROR_MASK \t(OSC_REQUEST_ERROR | OSC_INVALID_UUID_ERROR | \\\n@@ -239,8 +236,8 @@ acpi_status acpi_run_osc(acpi_handle han\n \tout_obj = output.pointer;\n \tif (out_obj->type != ACPI_TYPE_BUFFER\n \t\t|| out_obj->buffer.length != context->cap.length) {\n-\t\tacpi_print_osc_error(handle, context,\n-\t\t\t\"_OSC evaluation returned wrong type\");\n+\t\tacpi_handle_debug(handle, \"_OSC evaluation returned wrong type\");\n+\t\tacpi_dump_osc_data(handle, &guid, context->rev, &context->cap);\n \t\tstatus = AE_TYPE;\n \t\tgoto out_kfree;\n \t}\n@@ -252,18 +249,18 @@ acpi_status acpi_run_osc(acpi_handle han\n \n \tif (errors) {\n \t\tif (errors & OSC_REQUEST_ERROR)\n-\t\t\tacpi_print_osc_error(handle, context,\n-\t\t\t\t\"_OSC request failed\");\n+\t\t\tacpi_handle_debug(handle, \"_OSC request failed\");\n+\n \t\tif (errors & OSC_INVALID_UUID_ERROR)\n-\t\t\tacpi_print_osc_error(handle, context,\n-\t\t\t\t\"_OSC invalid UUID\");\n+\t\t\tacpi_handle_debug(handle, \"_OSC invalid UUID\");\n+\n \t\tif (errors & OSC_INVALID_REVISION_ERROR)\n-\t\t\tacpi_print_osc_error(handle, context,\n-\t\t\t\t\"_OSC invalid revision\");\n+\t\t\tacpi_handle_debug(handle, \"_OSC invalid revision\");\n+\n \t\tif (errors & OSC_CAPABILITIES_MASK_ERROR)\n-\t\t\tacpi_print_osc_error(handle, context,\n-\t\t\t\t\"_OSC capability bits masked\");\n+\t\t\tacpi_handle_debug(handle, \"_OSC capability bits masked\");\n \n+\t\tacpi_dump_osc_data(handle, &guid, context->rev, &context->cap);\n \t\tstatus = AE_ERROR;\n \t\tgoto out_kfree;\n \t}\n","prefixes":["v1","2/8"]}