{"id":2175734,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175734/?format=json","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.0/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251218200353.301866-5-calebs@linux.ibm.com>","date":"2025-12-18T20:03:53","name":"[4/4] ppc/pnv: Add OCC FLAG registers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9de0d04b118ea53f7b2f234192c82cd1d365c7be","submitter":{"id":90855,"url":"http://patchwork.ozlabs.org/api/1.0/people/90855/?format=json","name":"Caleb Schlossin","email":"calebs@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20251218200353.301866-5-calebs@linux.ibm.com/mbox/","series":[{"id":485909,"url":"http://patchwork.ozlabs.org/api/1.0/series/485909/?format=json","date":"2025-12-18T20:03:52","name":"Power10 PowerVM bringup fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/485909/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175734/checks/","tags":{},"headers":{"Return-Path":"<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Mx0YuxQG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXM8v53DJz1xty\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 19 Dec 2025 07:05:19 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1vWKEk-0005TX-Iv; Thu, 18 Dec 2025 15:04:34 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <calebs@linux.ibm.com>)\n id 1vWKEM-0005O5-Mg; Thu, 18 Dec 2025 15:04:10 -0500","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <calebs@linux.ibm.com>)\n id 1vWKEL-00084m-3f; Thu, 18 Dec 2025 15:04:10 -0500","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n 5BIJmTED013835;\n Thu, 18 Dec 2025 20:04:07 GMT","from pps.reinject (localhost [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b4r3d02tg-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 18 Dec 2025 20:04:07 +0000 (GMT)","from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1])\n by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BIK468c013865;\n Thu, 18 Dec 2025 20:04:07 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b4r3d02tc-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 18 Dec 2025 20:04:06 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 5BIJXtig029544;\n Thu, 18 Dec 2025 20:04:06 GMT","from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4b4qvqr4nd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 18 Dec 2025 20:04:05 +0000","from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com\n [10.241.53.105])\n by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 5BIK44xf18809464\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 18 Dec 2025 20:04:04 GMT","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 17DC658055;\n Thu, 18 Dec 2025 20:04:04 +0000 (GMT)","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id ACE2758043;\n Thu, 18 Dec 2025 20:04:03 +0000 (GMT)","from gfwr532.rchland.ibm.com (unknown [9.10.239.133])\n by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 18 Dec 2025 20:04:03 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=MFD3WOaxWcOQcNyMi\n MydX6i0nQ0MTp12mG8yxLmezf0=; b=Mx0YuxQGokNpsM0tXVFd1wT1317sxVU2U\n r/3oFacgIjNcEHD2SPUbPkIa8eclwEKWKcLlh9uN6X+BlQ/WasahUp0fDlFy6EQO\n xhd+UCv5LWgEyqyP++Ez0ghIDVh9q3Tq6/cCoSL5fSMgomakNcdATqoCcMrck3fI\n LSSNOsPJWC1Adae8EI32r24yesBije8RRdYu/U3KEuYxLDWwD5zAbKuuwCRtNd1s\n oZh1mzALKgH4Aef6pfH9dhnmUYvwP7D4RVwgs6PWLG+UynYkVE4ByTQrEgUo4A9w\n fcGfOzzYXypsyAupeKOF6tdjQtyvCQ8K/4ZTCOsomAiY2iNufBuog==","From":"Caleb Schlossin <calebs@linux.ibm.com>","To":"qemu-devel@nongnu.org","Cc":"qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com,\n milesg@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com","Subject":"[PATCH 4/4] ppc/pnv: Add OCC FLAG registers","Date":"Thu, 18 Dec 2025 14:03:53 -0600","Message-ID":"<20251218200353.301866-5-calebs@linux.ibm.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20251218200353.301866-1-calebs@linux.ibm.com>","References":"<20251218200353.301866-1-calebs@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=WYkBqkhX c=1 sm=1 tr=0 ts=69445e37 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8\n a=C6aVSkDANSdmHkZ1WT0A:9","X-Proofpoint-GUID":"uBhkv_ehkZOhH3M6BkNQTRDxduOu7sw7","X-Proofpoint-ORIG-GUID":"8L7A2eHLtH8hvvkYOBspBYGAX1LAcz0o","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjUxMjE4MDE2NCBTYWx0ZWRfX7gvaX2o8Y76T\n /rci6LKvWokVF8Wgc2BY4UeZdvahDjfZhF7dkWgyjMOQd2OeFYqjFj2AE9Vu3irbIpKLwwRos1c\n hMG5Gf94bdsGZyaLis9p1hFZ5LutCuwsmlOEi1FJnsJoChsdzHTOYDeXiVFjD0KmZWd/pyGT4sZ\n UZwY9bZwMR1Ick5gx1ZN3jO6Zz0uxMlBxdLvHSyzNSIm9eozR3TCK0h1mG349qzRB0C+oaPNWIJ\n cyS/HxgKYQCefeXgnhshGax5YUNmgST7BHAiLSHmDIMTQD4Q4BiU76BNarE2LPluUk+KkBZ74vP\n +/4TtGSponEgnsNpMtVGI4lRzPE9818qsZsTiX7SrIjVs7jEyM25NLsHb6ASYXDRxkb/fOLMceC\n vg160qIFFfT0Q1BnvkxgnqiHzPNBmVjzd4oVOHq0sWAYJToqfPEiYIQ0PT7I1hwz4CAPr/xvhRS\n P6+/0ogXyOxQ2zdqfDQ==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49\n definitions=2025-12-18_03,2025-12-17_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 adultscore=0 impostorscore=0 priorityscore=1501\n bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015\n suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000\n definitions=main-2512180164","Received-SPF":"pass client-ip=148.163.156.1;\n envelope-from=calebs@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-ppc.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-ppc>","List-Post":"<mailto:qemu-ppc@nongnu.org>","List-Help":"<mailto:qemu-ppc-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"OCCFLG are scratch registers that can be shared with OCC firmware.\nLog reads and writes to the registers as a reminder when we run\ninto more OCC code.\n\nAdd RW, WO_CLEAR and WO_OR SCOM Type enums in pnv_occ.c\n\nSigned-off-by: Chalapathi V <chalapathi.v@linux.ibm.com>\nSigned-off-by: Caleb Schlossin <calebs@linux.ibm.com>\n---\n hw/ppc/pnv_occ.c         | 55 +++++++++++++++++++++++++++++++++++++---\n include/hw/ppc/pnv_occ.h |  4 +++\n 2 files changed, 56 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/ppc/pnv_occ.c b/hw/ppc/pnv_occ.c\nindex 24b789c191..e605ae0fbc 100644\n--- a/hw/ppc/pnv_occ.c\n+++ b/hw/ppc/pnv_occ.c\n@@ -195,6 +195,49 @@ static const TypeInfo pnv_occ_power8_type_info = {\n #define P9_OCB_OCI_OCCMISC_CLEAR        0x6081\n #define P9_OCB_OCI_OCCMISC_OR           0x6082\n \n+/* OCC scratch registers for flag setting */\n+#define P9_OCCFLG0                      0x60ac\n+#define P9_OCCFLG7_OR                   0x60c3\n+\n+enum ScomType {\n+    SCOM_TYPE_RW          = 0,\n+    SCOM_TYPE_WO_CLEAR    = 1,\n+    SCOM_TYPE_WO_OR       = 2,\n+};\n+\n+static void rw_occ_flag_regs(PnvOCC *occ, uint32_t offset, bool read,\n+        uint64_t *val)\n+{\n+    int flag_num;\n+    int flag_type;\n+\n+    /*\n+     * Each OCCFLG register has SCOM0 - RW, SCOM1 - WO_CLEAR, SCOM2 - WO_OR\n+     * hence devide by 3 to get flag index and mod 3 to get SCOM type.\n+     */\n+    flag_num = (offset - P9_OCCFLG0) / 3;\n+    flag_type = (offset - P9_OCCFLG0) % 3;\n+\n+    if (read) {\n+        if (flag_type) {\n+            qemu_log_mask(LOG_GUEST_ERROR, \"OCC: Write only register: Ox%\"\n+                      PRIx32 \"\\n\", offset);\n+            return;\n+        }\n+        *val = occ->occflags[flag_num];\n+    } else {\n+        switch (flag_type) {\n+        case SCOM_TYPE_RW:\n+            occ->occflags[flag_num] = *val;\n+            break;\n+        case SCOM_TYPE_WO_CLEAR:\n+            occ->occflags[flag_num] &= ~(*val);\n+            break;\n+        case SCOM_TYPE_WO_OR:\n+            occ->occflags[flag_num] |= *val;\n+        }\n+    }\n+}\n \n static uint64_t pnv_occ_power9_xscom_read(void *opaque, hwaddr addr,\n                                           unsigned size)\n@@ -207,8 +250,11 @@ static uint64_t pnv_occ_power9_xscom_read(void *opaque, hwaddr addr,\n     case P9_OCB_OCI_OCCMISC:\n         val = occ->occmisc;\n         break;\n+    case P9_OCCFLG0 ... P9_OCCFLG7_OR:\n+        rw_occ_flag_regs(occ, offset, 1, &val);\n+        break;\n     default:\n-        qemu_log_mask(LOG_UNIMP, \"OCC Unimplemented register: Ox%\"\n+        qemu_log_mask(LOG_UNIMP, \"OCC Unimplemented register read: Ox%\"\n                       HWADDR_PRIx \"\\n\", addr >> 3);\n     }\n     return val;\n@@ -229,9 +275,12 @@ static void pnv_occ_power9_xscom_write(void *opaque, hwaddr addr,\n         break;\n     case P9_OCB_OCI_OCCMISC:\n         pnv_occ_set_misc(occ, val);\n-       break;\n+        break;\n+    case P9_OCCFLG0 ... P9_OCCFLG7_OR:\n+        rw_occ_flag_regs(occ, offset, 0, &val);\n+        break;\n     default:\n-        qemu_log_mask(LOG_UNIMP, \"OCC Unimplemented register: Ox%\"\n+        qemu_log_mask(LOG_UNIMP, \"OCC Unimplemented register write: Ox%\"\n                       HWADDR_PRIx \"\\n\", addr >> 3);\n     }\n }\ndiff --git a/include/hw/ppc/pnv_occ.h b/include/hw/ppc/pnv_occ.h\nindex 013ea2e53e..8c9f1416eb 100644\n--- a/include/hw/ppc/pnv_occ.h\n+++ b/include/hw/ppc/pnv_occ.h\n@@ -47,6 +47,10 @@ struct PnvOCC {\n     /* OCC Misc interrupt */\n     uint64_t occmisc;\n \n+    /* OCC Flags */\n+#define NR_FLAG_REGS 8\n+    uint32_t occflags[NR_FLAG_REGS];\n+\n     qemu_irq psi_irq;\n \n     /* OCCs operate on regions of HOMER memory */\n","prefixes":["4/4"]}