{"id":2175674,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175674/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20251218-sqqs-v5-2-9c7e2466b797@foss.st.com>","date":"2025-12-18T17:27:02","name":"[v5,2/3] clk: scmi: Fix priv initialization in scmi_clk_gate()","commit_ref":"0e9055b1488fe3c7d4c5143bc7bb7669af7f9cd1","pull_url":null,"state":"accepted","archived":false,"hash":"646abaf59889d131d7a628d78a44198d1b80dff7","submitter":{"id":80709,"url":"http://patchwork.ozlabs.org/api/1.0/people/80709/?format=json","name":"Patrice Chotard","email":"patrice.chotard@foss.st.com"},"delegate":{"id":55230,"url":"http://patchwork.ozlabs.org/api/1.0/users/55230/?format=json","username":"freenix","first_name":"Peng","last_name":"Fan","email":"van.freenix@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251218-sqqs-v5-2-9c7e2466b797@foss.st.com/mbox/","series":[{"id":485890,"url":"http://patchwork.ozlabs.org/api/1.0/series/485890/?format=json","date":"2025-12-18T17:27:03","name":"clk: scmi: various fixes","version":5,"mbox":"http://patchwork.ozlabs.org/series/485890/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175674/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=mUoCD9YG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.b=\"mUoCD9YG\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","phobos.denx.de;\n spf=pass smtp.mailfrom=patrice.chotard@foss.st.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXHgN5bDxz1y2F\n\tfor ; Fri, 19 Dec 2025 04:28:00 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8BE3C838CE;\n\tThu, 18 Dec 2025 18:27:29 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id C418A80050; Thu, 18 Dec 2025 18:27:27 +0100 (CET)","from AS8PR04CU009.outbound.protection.outlook.com\n (mail-westeuropeazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id CD68B82BF2\n for ; Thu, 18 Dec 2025 18:27:25 +0100 (CET)","from AS4PR09CA0023.eurprd09.prod.outlook.com (2603:10a6:20b:5d4::13)\n by AS2PR10MB7045.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:597::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.8; Thu, 18 Dec\n 2025 17:27:21 +0000","from AMS0EPF0000019C.eurprd05.prod.outlook.com\n (2603:10a6:20b:5d4:cafe::f2) by AS4PR09CA0023.outlook.office365.com\n (2603:10a6:20b:5d4::13) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.8 via Frontend Transport; Thu,\n 18 Dec 2025 17:27:18 +0000","from smtpO365.st.com (164.130.1.60) by\n AMS0EPF0000019C.mail.protection.outlook.com (10.167.16.248) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9434.6 via Frontend Transport; Thu, 18 Dec 2025 17:27:21 +0000","from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com\n (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 18 Dec\n 2025 18:27:52 +0100","from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 18 Dec\n 2025 18:27:06 +0100"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS\n autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=EmV75yvyaOByh0s4/eNCxIVFSL2SIiRKb+GftYkLitlT3bN4C0GbGbFuhkEwjVvAm8wKliprMhWNwb2LhMxNjYkApm3dkb98F+bymbbf5T8P6wGZW2M59g1u/iGatVpAlju7+ViVTagP1NPvyBKz7gpkP/IUT17sJG24+OOWRLChwH0VNP9SvUx6jL/+Jr/hYGtfoyTugJTjL7USVd+QffvaTQjlLIaU4NfChIkZbjAujrPXCyfkUHEOPVpiqI6gmKVKxvacxsVWJFtOXTi5irJ9R27nipPu0z6Jn/n8ubEtQafVqwHtORZ579aycc63K3c5BkpL2Ryg9bHn/ZNimA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=txb4qt47PHDCIcpGPiby5h5ZtPI9y/j3hiOeDWupVsg=;\n b=iWSN59ODcXhwhaEqtsr3v9Px8nPUGp9gTFyhYDQiFDIvfk5Sko9N+KRIbAZZCjaprjZc+LWv6+j2xm4KQSvfCl6xocbDgSgHHQeFPy0C+Vt3NOtBiK6EkHbIoCmEU0AOCbeoIqMm/PALYz6Wo+VUnBv27hl1t73AY+QtmLcBdHyXeioqI0gze1TxkkrIEjMz0PfszLCmnf20RWjSbFXME6GrmkOZY9CEstxXLPn7WnWggIqNahY7lb2oFel60zKDx9UvTAWy8fkGVlVdW8BuAm8Aj2F7MBGmGtoUs+RDXCibREEO36r4GsJY+3F7PFeeXgkT3DfSsMt3x+ZafV1DIA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 164.130.1.60) smtp.rcpttodomain=renesas.com smtp.mailfrom=foss.st.com;\n dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=txb4qt47PHDCIcpGPiby5h5ZtPI9y/j3hiOeDWupVsg=;\n b=mUoCD9YG4LkCSKpZaRXmU2T+m4wgvWTmyP9wBQJB0Jt7DXvYzvqJUMsvcakb9Uy0z3E7jQSb+lQYqZOZN2l1Q2GbliGvpqrkUoqd7/UVHjPGAWqzJMpSA9amWbXW7Wv/8TdEYmKlVeiUcsQw3AbEVSvJj75uKaCQvAvcEC0Ji4AA9vHi/Njfyy+QH5fOZ+3+l2yE+Qoyo3JfzWTLXpJf5RRbJ7RgYk5/TDUnsLOKYtdd+ogE/zFX+cdUNkqFSQKnIXhT9bfemho1YpaTWsSB5lt0OmDQudRAM5PusASBVXyQZZwk25ckdLVbeRvLt0SMzCFZlN8cgA449Uev+tiuYA==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 164.130.1.60)\n smtp.mailfrom=foss.st.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=none header.from=foss.st.com;","Received-SPF":"Fail (protection.outlook.com: domain of foss.st.com does not\n designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com;\n client-ip=164.130.1.60; helo=smtpO365.st.com;","From":"Patrice Chotard ","Date":"Thu, 18 Dec 2025 18:27:02 +0100","Subject":"[PATCH v5 2/3] clk: scmi: Fix priv initialization in scmi_clk_gate()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-ID":"<20251218-sqqs-v5-2-9c7e2466b797@foss.st.com>","References":"<20251218-sqqs-v5-0-9c7e2466b797@foss.st.com>","In-Reply-To":"<20251218-sqqs-v5-0-9c7e2466b797@foss.st.com>","To":"Vinh Nguyen , ","CC":"Lukasz Majewski , Sean Anderson , \"Peng\n Fan\" , Tom Rini , Marek Vasut\n , Alice Guo , \"Patrick\n Delaunay\" , Valentin Caron\n , Kamlesh Gurudasani , \"Patrice\n Chotard\" ","X-Mailer":"b4 0.14.3","X-Originating-IP":"[10.48.87.93]","X-ClientProxiedBy":"ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com\n (10.75.128.132)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AMS0EPF0000019C:EE_|AS2PR10MB7045:EE_","X-MS-Office365-Filtering-Correlation-Id":"e6ffec56-342d-4a95-f331-08de3e5ab369","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700013|376014|82310400026|1800799024|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?vRjUikWCGVfzbAfl/9HDt288+FcMdzu?=\n\t=?utf-8?q?MWZOG3SOTtpVfTXmaei3V0qlEA0v8XoDju1C+yWT1O6ymeXln/oh6cw8Qvsg30ACt?=\n\t=?utf-8?q?AtsThKejAspNawtnUT23iyhFr0oA4Jf7gukHO99+e4U+CSv9vQ0+YTTz/lGzzTHjo?=\n\t=?utf-8?q?CjK46NX13uShDPeGBufeUYIVDjEthPupbqihWuPgS8i3UFyVIHvHkxKniXM9YG+BA?=\n\t=?utf-8?q?JvMOyg/TGWeRmwe5hGzcXdShfx3iVeEyGNwAmVVgWWp16LnofDchdCY0t2brN1JF3?=\n\t=?utf-8?q?98pYSyYo30+MuC+YSQCbTlKxmPfB14jWwtkp2gssj09mniXc23/eJBfz2VmgeEFKg?=\n\t=?utf-8?q?00hjyGBCi8qNcE0kO+tKE8NprZuJHToTRdC50C8xXy4dVTvKJxme2/yr9sH5Qs4J6?=\n\t=?utf-8?q?JlrOz8JqnNoW9nFSZ14KU3PCt8+97UvdqmY5QOMiW0ZXVw5pH+HYOQg75hEceQ1IC?=\n\t=?utf-8?q?8ZqW2ANt7IWSxfjGurF6gJGaxIXihg/YksSLgLsboViqLNQC9hSsPHbIiqeT3gYLn?=\n\t=?utf-8?q?YrlhgqQdm6O64mhGV60qpNQe1UslBSVnxq8XnuRKZgMaYilQTjfH3jU9cAg+MX5l4?=\n\t=?utf-8?q?U5hCH0EWCGCUnjC8QaXnwLuoawiLoXoYADQHXe7yzOAHjZqfPxYfWnI5BbU0AS0pF?=\n\t=?utf-8?q?frbFbcwagZtLC/NGVOn08dhkpHSQxMngIjqgV5uRzK60fQWAYeX/hJyfoRqyChnCu?=\n\t=?utf-8?q?p6lxAHr5BQD0IvwzTXVJn0bTiEmL0siJcoLCg9J0hUmltZlOWsxZm/wV5Eco6dc0T?=\n\t=?utf-8?q?U8uol0hfjjTJr3v4pA0G//+w4QwubZmIDZ/wK+/l/8EVPCwPnIi1vY5goiKH/1Wua?=\n\t=?utf-8?q?BMfrNB9NfyN0fPSnlwJzbC1iN6c30FHPIaUw+CkqT3xdz2H9gA2nHtCduTXrPsfZ3?=\n\t=?utf-8?q?Mrth6d03Ui5ztO+qERUwtb+m2A4x2sTkdpkqaZgTX2VQPWsumJE33P2TjWW4Moad/?=\n\t=?utf-8?q?oW24/+o+NU97w0ynYipNv06VG/SedA+VQr0sAArPoYUcDG8DD8kmhbBVDGX8EnWtW?=\n\t=?utf-8?q?2Zz152G6uHa76PZIKchvJGg2hgUz9Zi7qXHqNplb316Nnv6vwSL13TNI++hTa0xym?=\n\t=?utf-8?q?s3lUBioKqOfcehLe50y5Fzz5m+Jpa9TSKUx5GLHkb1uzu6vRKnaiZd02I7Nj6ONIa?=\n\t=?utf-8?q?X/NM1bFdlNJqBjQ9DFKc2QqALFoLUgO9UqEx6k3FOyWum+SLVyCe/HKr78yEE9+F6?=\n\t=?utf-8?q?CUeJ599mky2XNQprjjhah0lLrLz17trlVkGrwTFO2zb/cTPKJYsIjaNH3QoEGX5tz?=\n\t=?utf-8?q?jpjwxOhZczdXWqOdfR+tpYthClpZLrWoVfDqgxrUgrnlF69LgE6CET3JYbtxcA1J5?=\n\t=?utf-8?q?j+XCEqCXlOIA0v0WxxHHqm/lfP36AgccM1ckOp8fq8K47/W3vaxHhH8HFD/ZVOsa5?=\n\t=?utf-8?q?iKodurC4AZ+TtWAPoU8sBGIogWPOdE6iEX+SXtmQ5VjBo791eDFSxL2ef63EqLFa0?=\n\t=?utf-8?q?oPMgfsIztobK9YwFXzUPk7ES721tNuqeyHd5Z2aczf06gGCgyi07I=3D?=","X-Forefront-Antispam-Report":"CIP:164.130.1.60; CTRY:IT; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7053199007);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0":"\n VPybI7rE5k2pEzqvcmWeJCE27geurJTwNAos7eX+KJqHlob8h7kGUu5mizGSIub41hNDRqUG7q3iJCBXLnSbdg1eKd92X9iUsgv1RE6VAtHCcw25AUYO46YvTiNezFHXyYypXAEH8OWs8CKrK9Gdin28kUbiS9lpDLY52hNH7SzJt6kvdoactYJN68R40GxwQgPd4zzF1dEW2Fi/taz2E1IIIaUb/VHpeBeqYBLNZrjsBXIci3IuxNHvER6S64knr8ECyLSVPKzmr1TX4zqSOe7jPT7eQ8SuMIw16M5toPyJn8aQ/7ONELAyKARdtx2hxQV07S2A647m2Ocz+rziaZ6jzNmFg1kvBBciAOlt1praTTdNnCUQkmcKkoHcA+th1hcN7HgTQFeY64mxSuTjIXaW6v/K09Cz9jD0A9gvKWWfmx1JUt68uBkbGSlbCJ5ymQaqjeQLAso2V91E3iHASup/4ReJ8G2lgFLjXdksE8UZyZdtA3prD+iPx+G3VrDFQYopruSstUBxgK+iOCv4+TJr2QVVHUO2SQxU1f63A/aFfMstNqNt5ZCAE+b5PlGjssRVe+eVU04qWdKFL8kspOaOtsmWuRUtIo9VhP35gKtUWIDulcbY3Fm8zluk1q69QHu8sV31s9s47dMQkZpYu0wNRT5sxvkUx6KReJC/qp/XZ0Ja9TNdyO96nOsB2aoo/GGNLhhMFGAiy4P9A5fw/g==","X-OriginatorOrg":"foss.st.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"18 Dec 2025 17:27:21.0376 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n e6ffec56-342d-4a95-f331-08de3e5ab369","X-MS-Exchange-CrossTenant-Id":"75e027c9-20d5-47d5-b82f-77d7cd041e8f","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; Ip=[164.130.1.60];\n Helo=[smtpO365.st.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n AMS0EPF0000019C.eurprd05.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS2PR10MB7045","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"In scmi_clk_probe(), in case of CLK_CCF is not enabled, parent private\ndata is not set, so in scmi_clk_gate(), an uninitialized priv struct is\nretrieved.\n\nSCMI request is performed either using scmi_clk_state_in_v1 or\nscmi_clk_state_in_v2 struct depending of the unpredictable value of\npriv->version which leads to error during SCMI clock enable.\n\nIssue detected on STM32MP157C-DK2 board using the SCMI device tree\nstm32mp157c-dk2-scmi.dts.\n\nFixes: 0619cb32030b (\"firmware: scmi: Add clock v3.2 CONFIG_SET support\")\nReviewed-by: Peng Fan \nReviewed-by: Marek Vasut \nSigned-off-by: Patrice Chotard \n---\nCc: Alice Guo \nCc: Marek Vasut \nCc: Patrick Delaunay \nCc: Peng Fan \nCc: Sean Anderson \nCc: Tom Rini \nCc: Valentin Caron \nCc: Vinh Nguyen \nCc: u-boot@lists.denx.de\n---\n drivers/clk/clk_scmi.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/clk/clk_scmi.c b/drivers/clk/clk_scmi.c\nindex f6132178205..a4fc4f8da89 100644\n--- a/drivers/clk/clk_scmi.c\n+++ b/drivers/clk/clk_scmi.c\n@@ -137,7 +137,7 @@ static int scmi_clk_get_attribute(struct udevice *dev, int clkid, char *name,\n \n static int scmi_clk_gate(struct clk *clk, int enable)\n {\n-\tstruct scmi_clock_priv *priv = dev_get_parent_priv(clk->dev);\n+\tstruct scmi_clock_priv *priv;\n \tstruct scmi_clk_state_in_v1 in_v1 = {\n \t\t.clock_id = clk_get_id(clk),\n \t\t.attributes = enable,\n@@ -156,6 +156,16 @@ static int scmi_clk_gate(struct clk *clk, int enable)\n \t\t\t\t\t in_v2, out);\n \tint ret;\n \n+\t/*\n+\t * In scmi_clk_probe(), in case of CLK_CCF is set, SCMI clock\n+\t * version is set in dev's parent priv struct. Otherwise\n+\t * SCMI clock version is set in dev priv struct.\n+\t */\n+\tif (CONFIG_IS_ENABLED(CLK_CCF))\n+\t\tpriv = dev_get_parent_priv(clk->dev);\n+\telse\n+\t\tpriv = dev_get_priv(clk->dev);\n+\n \tret = devm_scmi_process_msg(clk->dev,\n \t\t\t\t (priv->version < CLOCK_PROTOCOL_VERSION_2_1) ?\n \t\t\t\t &msg_v1 : &msg_v2);\n","prefixes":["v5","2/3"]}