{"id":2175662,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175662/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20251218-clk-mtk-improvements-v1-7-72db131ba148@baylibre.com>","date":"2025-12-18T17:17:05","name":"[7/8] clk: mediatek: mt7623: set unmapped IDs to -1","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"db49fe4eaeaff397ca6665b369b13c3ea2c970d3","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/1.0/people/87228/?format=json","name":"David Lechner","email":"dlechner@baylibre.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.0/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251218-clk-mtk-improvements-v1-7-72db131ba148@baylibre.com/mbox/","series":[{"id":485889,"url":"http://patchwork.ozlabs.org/api/1.0/series/485889/?format=json","date":"2025-12-18T17:16:58","name":"clk: mediatek: implement of_xlate and dump","version":1,"mbox":"http://patchwork.ozlabs.org/series/485889/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175662/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=iYGYqxWJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.b=\"iYGYqxWJ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXHVB0rT7z1y2f\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 19 Dec 2025 04:20:02 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4490983979;\n\tThu, 18 Dec 2025 18:18:43 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 6354D83642; Thu, 18 Dec 2025 18:18:13 +0100 (CET)","from mail-oa1-x29.google.com (mail-oa1-x29.google.com\n [IPv6:2001:4860:4864:20::29])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4658282BF2\n for <u-boot@lists.denx.de>; Thu, 18 Dec 2025 18:18:11 +0100 (CET)","by mail-oa1-x29.google.com with SMTP id\n 586e51a60fabf-3f5c9275b31so549724fac.0\n for <u-boot@lists.denx.de>; Thu, 18 Dec 2025 09:18:11 -0800 (PST)","from [127.0.1.1] ([2600:8803:e7e4:500:e5ea:76dc:e589:2d5e])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-65cff214d66sm1316372eaf.9.2025.12.18.09.18.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 18 Dec 2025 09:18:09 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1766078290;\n x=1766683090;\n darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=gD3JTAQUAdeki81bMKB4j4lbcNXdfEQPQdZtM+Jleis=;\n b=iYGYqxWJZ9CuVoslnr3Aqsz4XmF8WcEPUDxELJBufZ5Q8ZvHz8jAIJDgSr1KOFlHTw\n iNP3ZSU0ts2+ZJ/3+yOlDme0emCtdQYsy+kaxD8mfSkAHqQrhC5tfcU3adUaePus+TFa\n bskFriWf+s2PJSMgDIlWY0uPIdh68dokUKW+53zRnq1CWUc1nTHQ/jg8W9LPkAlSWhmY\n 3DsIMMsCmHEf2V/+gJzM7Jc8MIJKGT4C3athDTDDOkaxOvzHRkOcLv5YXRw+sXQFBg2A\n 8jzv0OH5gZ1MHyXF0D2Bt3kvkQSWfB1iRbnmcfNWsuZUPpJCjtObBdQ03mG5If3j3ABy\n Vfpg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766078290; x=1766683090;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=gD3JTAQUAdeki81bMKB4j4lbcNXdfEQPQdZtM+Jleis=;\n b=s21EsDhKc5HzWp5kJShSbAdV6rIrsra+Id+nuRgVTLASoMOHHQW8p4Vx8Za6VXDAN5\n xh3smdw+pK06fI6DonJAXMaYKXaD6No0GUw4WkarQ9EkxPeANwTfEw/pS+C1T9LP7a4+\n 60uWnjJgPv7iOQywN60oIp+QbJGrXvhGHTpYIRxiqf+kQMnKThk5N/skwKITFa6JrkLl\n rs4/UAz/pckzJlHVUiQd0HoedTOIGjy17fifnsU+0X3BxkMc9zrrn+YRgpMzcp9Un2hb\n V4zWLEmL0yfGU1M0wRj7dMrUaRFYA0/Yi2bdzGqhCWamQCTaA5frYk3X0STqeP4WbZ8s\n 8eKA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWCuVgCrhcUE6XCUl1ppg0kj0C2RFL+NeV3SUO2V2uzrAwpmAxwYnpY3WXVN2LSIkhn9uRd1K0=@lists.denx.de","X-Gm-Message-State":"AOJu0YwLm2RcsY+VdtdNYNcHwfL4bFr8Hkl04bc8ioaMaUIpATJ/TPAj\n m+EDVOh8c3qOAahUYqZw24vCjIQDlmTHcXM266Ojqu4n0+RRc002f4m0jHXiSLg0sc0=","X-Gm-Gg":"AY/fxX7tXTIFaN39TS6HwV16XQ76pDfWDEhCRMHi8OMDAup926QL/UjK6ndnQgi5Ndm\n lbmAeALDe4jKuZ44a6ooTFRIxKUoQOofAxhThSoxTbNvkv33gCdjhpympTd70Hu4lPdiF+84vy2\n ZTGKd5YQwfmWzG5WKuOhQW6BHqVOmWRKzUVLC7e7A3+YocN+LwKbe1qhz0lp11wgh/gzcbkZ2hR\n Lyfs5s/fDoj+cSSnNDDIYpJMe68wGeefAXrFQj33hthFhiNKxmm5gV96uXsQRWmjO3nVVaLij/Z\n Pr+P03p3MCD95SmLF053uacabJRpRJMwElmJkUGP25+sw6tNqMAayZSjSp9kXN0SuqLztJXGmVR\n qqesvc2PIekBn4FQirVjvv3XRvaCWPUhb8cAL/rU7fhtNOSZ4ngiEhoQTv4MqoJRX+XdGpVod/f\n mLJUH7A+uhgZVKxMs=","X-Google-Smtp-Source":"\n AGHT+IFSK+qMj1UhPCf2gARpS4imCEPAVXABENNA5MHo8k0I1C25U34qXlJejO2Thn2rskBfmW5qGQ==","X-Received":"by 2002:a05:6820:8307:b0:65c:fe5b:9f5c with SMTP id\n 006d021491bc7-65d0eb6de1fmr52435eaf.56.1766078290005;\n Thu, 18 Dec 2025 09:18:10 -0800 (PST)","From":"David Lechner <dlechner@baylibre.com>","Date":"Thu, 18 Dec 2025 11:17:05 -0600","Subject":"[PATCH 7/8] clk: mediatek: mt7623: set unmapped IDs to -1","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20251218-clk-mtk-improvements-v1-7-72db131ba148@baylibre.com>","References":"<20251218-clk-mtk-improvements-v1-0-72db131ba148@baylibre.com>","In-Reply-To":"<20251218-clk-mtk-improvements-v1-0-72db131ba148@baylibre.com>","To":"Lukasz Majewski <lukma@denx.de>, Ryder Lee <ryder.lee@mediatek.com>,\n Weijie Gao <weijie.gao@mediatek.com>,\n Chunfeng Yun <chunfeng.yun@mediatek.com>,\n Igor Belwon <igor.belwon@mentallysanemainliners.org>,\n GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,\n Tom Rini <trini@konsulko.com>","Cc":"Julien Stephan <jstephan@baylibre.com>, u-boot@lists.denx.de,\n David Lechner <dlechner@baylibre.com>","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1624; i=dlechner@baylibre.com;\n h=from:subject:message-id;\n bh=gfpOIod3WRv7xKKVBcV5wEw/YKY2k9KWceHRU+LE58U=;\n b=owEBhAF7/pANAwAKAcLMIAH/AY/AAcsmYgBpRDc+MOphJGl7wnBTYvsLnKIpgPJzTyFKnO/t6\n ddGldl8Lf2JAUoEAAEKADQWIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaUQ3PhYcZGxlY2huZXJA\n YmF5bGlicmUuY29tAAoJEMLMIAH/AY/AHdcH/0Na4ulH25ByjlCh6/VMB05MD3vsH5IWcaG6kop\n hOyRS8FpCkOdQEirS0l2UV5iFPlG8rj5D/Jd383Swibld2EOznwki+BRlgajoOkes5IC16w9y7h\n shhaNuor2rM10TZHaMLsWxK7pQBz2Ep6FEjOlnX8BvE1dehcTQxLL39/OTQD4vfRfxLUWnHUdfk\n iBV6ucuK1TxOYMhsf13Hs1XYVh8DZP4pD5C+N6z0NfIJyTepHj8yNZ0YStvsRQWvz9R8CbOp8iQ\n Sed3QokbihVWH6Bw/jUaB+iaPtNZZHj4KzSWa6V8iXG7k48U3aI4Xong4hoFgi6B6uH0Ec77yyA\n FJeQ=","X-Developer-Key":"i=dlechner@baylibre.com; a=openpgp;\n fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03","X-Mailman-Approved-At":"Thu, 18 Dec 2025 18:18:40 +0100","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Add range initializers to the id_offs_map arrays in the mt7623 clk\ndriver to set unmapped IDs to -1. This prevents accidental usage of\nunmapped IDs that would otherwise map to 0.\n\nmtk_common_clk_of_xlate() checks these values for < 0 and returns\n-ENOENT in that case.\n\nA range initializer covering the entire array is used since it is less\nerror-prone than manually looking up the value of each macro in the\nexisting initializers and checking for gaps. It is placed first so that\nthe specific initializers override it.\n\nSigned-off-by: David Lechner <dlechner@baylibre.com>\n---\n drivers/clk/mediatek/clk-mt7623.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/clk/mediatek/clk-mt7623.c b/drivers/clk/mediatek/clk-mt7623.c\nindex eca8352d8e6..6ce1d729736 100644\n--- a/drivers/clk/mediatek/clk-mt7623.c\n+++ b/drivers/clk/mediatek/clk-mt7623.c\n@@ -26,6 +26,7 @@\n \n /* apmixedsys */\n static const int pll_id_offs_map[] = {\n+\t[0 ... CLK_APMIXED_NR - 1]\t\t= -1,\n \t[CLK_APMIXED_ARMPLL]\t\t\t= 0,\n \t[CLK_APMIXED_MAINPLL]\t\t\t= 1,\n \t[CLK_APMIXED_UNIVPLL]\t\t\t= 2,\n@@ -92,6 +93,7 @@ static const struct mtk_pll_data apmixed_plls[] = {\n #define CLK_TOP_HDMITX_CLKDIG_CTS\t\tCLK_TOP_NR\n \n static const int top_id_offs_map[CLK_TOP_NR + 1] = {\n+\t[0 ... CLK_TOP_NR]\t\t\t= -1,\n \t/* Fixed CLK */\n \t[CLK_TOP_DPI]\t\t\t\t= 0,\n \t[CLK_TOP_DMPLL]\t\t\t\t= 1,\n@@ -808,6 +810,7 @@ static const struct mtk_gate infra_cgs[] = {\n \n /* pericfg */\n static const int peri_id_offs_map[] = {\n+\t[0 ... CLK_PERI_NR - 1]\t\t\t= -1,\n \t/* MUX CLK */\n \t[CLK_PERI_UART0_SEL]\t\t\t= 1,\n \t[CLK_PERI_UART1_SEL]\t\t\t= 2,\n","prefixes":["7/8"]}