{"id":2175601,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175601/?format=json","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.0/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251218151509.361617-2-heikki.krogerus@linux.intel.com>","date":"2025-12-18T15:15:00","name":"[v2,1/6] i2c: designware: Remove useless driver specific option for I2C target","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bb07427f334ab000ff4e418523d29993b3d96cee","submitter":{"id":23674,"url":"http://patchwork.ozlabs.org/api/1.0/people/23674/?format=json","name":"Heikki Krogerus","email":"heikki.krogerus@linux.intel.com"},"delegate":{"id":149066,"url":"http://patchwork.ozlabs.org/api/1.0/users/149066/?format=json","username":"cazzacarna","first_name":"Andi","last_name":"Shyti","email":"andi.shyti@kernel.org"},"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20251218151509.361617-2-heikki.krogerus@linux.intel.com/mbox/","series":[{"id":485867,"url":"http://patchwork.ozlabs.org/api/1.0/series/485867/?format=json","date":"2025-12-18T15:14:59","name":"i2c: designware: Enable mode swapping","version":2,"mbox":"http://patchwork.ozlabs.org/series/485867/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175601/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=NICkP0e8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-14643-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"NICkP0e8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.9","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXDnD6nQNz1y2F\n\tfor ; Fri, 19 Dec 2025 02:17:52 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 02C4D305A14A\n\tfor ; Thu, 18 Dec 2025 15:15:29 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DD22B29AAF3;\n\tThu, 18 Dec 2025 15:15:26 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE992FE07F;\n\tThu, 18 Dec 2025 15:15:16 +0000 (UTC)","from orviesa010.jf.intel.com ([10.64.159.150])\n by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Dec 2025 07:15:14 -0800","from black.igk.intel.com ([10.91.253.5])\n by orviesa010.jf.intel.com with ESMTP; 18 Dec 2025 07:15:13 -0800"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1766070921; cv=none;\n b=g7vtl35rMN9gsR6evVpHnBszQVNX1KbXCb82WMBL4k45fKoyZLmdREKvCC0amopWqrhJ6qHNrORstrfTYSBZ6THlifTy2p5UGjE9XUPx/FGtf1TeduJgIbDY+mG5WGWoE3TOO3eDF9p8a9jykD++0FQxpsEMuW7W17JUZyUYT5Q=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1766070921; c=relaxed/simple;\n\tbh=Smckrg7+KnbhrTERu00VP73ZnleaknC3grp6RThlXuY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=S2QXSoeeMLyWdB2mXmkQSHyeC3lZULnbdgWYSgJ7rO/O0pp9n9l9AH5IMyFUrPLcaTWy8j4VtLb2671/BPra5ZAl6ZUOAMPYk8gacqMed7MhI9sWvGJOFFpM+cV8BwKb8s5/itV5xsZsjydvr9gNzCoeSabriHbiDOgidisvQGM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=NICkP0e8; arc=none smtp.client-ip=192.198.163.9","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1766070918; x=1797606918;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Smckrg7+KnbhrTERu00VP73ZnleaknC3grp6RThlXuY=;\n b=NICkP0e81rJqgx60IMYb3UV5so1NKPJ7Hy8NO05j91ljeoOcHzzZrPY5\n RXaDA7JEc2tmT81hiPpOaCGsp68euR26kuqhPfgP/NB4eGzwRxGFqnzze\n t08X2FpKl3U9deH0LZaA4dj3vniyqGf9jM91vnsoqSW5zNVcCOpnv29f0\n uWaWxxRiY6hV2EEMfIQl37hIiMYWdx5gVbBBh/jiA5bNBoTBp1JfkgNYe\n dWJcLZR4q827Hp2cHYr2wIRaiJNBEmlbw274a+JU0M3U8DnijlpJ+axx1\n +hRtNaDxLCP1jvDN949r6Pt3J9XKv9G/cReceunK+cg8zvoRxcGvpven8\n Q==;","X-CSE-ConnectionGUID":["22tLWWmzQ/W9kPC4IaLZYw==","iRsxyoQvScS0jzXGhQDb+g=="],"X-CSE-MsgGUID":["xpZ8jvY2TaKkz2PGMhRH3g==","GOlqyDczQ1uRAdst+VM4Yg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11646\"; a=\"78739517\"","E=Sophos;i=\"6.21,158,1763452800\";\n d=\"scan'208\";a=\"78739517\"","E=Sophos;i=\"6.21,158,1763452800\";\n d=\"scan'208\";a=\"197857486\""],"X-ExtLoop1":"1","From":"Heikki Krogerus ","To":"Andi Shyti ,\n\tMika Westerberg ","Cc":"Andy Shevchenko ,\n\tJan Dabros ,\n\tRaag Jadav ,\n\tlinux-i2c@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v2 1/6] i2c: designware: Remove useless driver specific option\n for I2C target","Date":"Thu, 18 Dec 2025 16:15:00 +0100","Message-ID":"<20251218151509.361617-2-heikki.krogerus@linux.intel.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20251218151509.361617-1-heikki.krogerus@linux.intel.com>","References":"<20251218151509.361617-1-heikki.krogerus@linux.intel.com>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"The generic option for I2C target is already user selectable,\nwhich makes the DesignWare specific option completely\nunnecessary. The DesignWare option also silently selected\nI2C_SLAVE instead of depending on it without any real need\nfor it.\n\nReviewed-by: Andy Shevchenko \nSigned-off-by: Heikki Krogerus \n---\n drivers/i2c/busses/Kconfig | 10 ++--------\n drivers/i2c/busses/Makefile | 2 +-\n drivers/i2c/busses/i2c-designware-core.h | 2 +-\n 3 files changed, 4 insertions(+), 10 deletions(-)","diff":"diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig\nindex 09ba55bae1fa..860812e224a0 100644\n--- a/drivers/i2c/busses/Kconfig\n+++ b/drivers/i2c/busses/Kconfig\n@@ -569,20 +569,14 @@ config I2C_DESIGNWARE_CORE\n \thelp\n \t This option enables support for the Synopsys DesignWare I2C adapter.\n \t This driver includes support for the I2C host on the Synopsys\n-\t Designware I2C adapter.\n+\t Designware I2C adapter, and the I2C slave when enabled (select\n+\t I2C_SLAVE).\n \n \t To compile the driver as a module, choose M here: the module will be\n \t called i2c-designware-core.\n \n if I2C_DESIGNWARE_CORE\n \n-config I2C_DESIGNWARE_SLAVE\n-\tbool \"Synopsys DesignWare Slave\"\n-\tselect I2C_SLAVE\n-\thelp\n-\t If you say yes to this option, support will be included for the\n-\t Synopsys DesignWare I2C slave adapter.\n-\n config I2C_DESIGNWARE_PLATFORM\n \ttristate \"Synopsys DesignWare Platform driver\"\n \tdepends on (ACPI && COMMON_CLK) || !ACPI\ndiff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile\nindex fb985769f5ff..547123ab351f 100644\n--- a/drivers/i2c/busses/Makefile\n+++ b/drivers/i2c/busses/Makefile\n@@ -53,7 +53,7 @@ obj-$(CONFIG_I2C_DAVINCI)\t+= i2c-davinci.o\n obj-$(CONFIG_I2C_DESIGNWARE_CORE)\t\t\t+= i2c-designware-core.o\n i2c-designware-core-y\t\t\t\t\t:= i2c-designware-common.o\n i2c-designware-core-y\t\t\t\t\t+= i2c-designware-master.o\n-i2c-designware-core-$(CONFIG_I2C_DESIGNWARE_SLAVE) \t+= i2c-designware-slave.o\n+i2c-designware-core-$(CONFIG_I2C_SLAVE) \t\t+= i2c-designware-slave.o\n obj-$(CONFIG_I2C_DESIGNWARE_PLATFORM)\t\t\t+= i2c-designware-platform.o\n i2c-designware-platform-y \t\t\t\t:= i2c-designware-platdrv.o\n i2c-designware-platform-$(CONFIG_I2C_DESIGNWARE_AMDPSP)\t+= i2c-designware-amdpsp.o\ndiff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h\nindex bb5ce0a382f9..2a7decc24931 100644\n--- a/drivers/i2c/busses/i2c-designware-core.h\n+++ b/drivers/i2c/busses/i2c-designware-core.h\n@@ -386,7 +386,7 @@ void i2c_dw_disable(struct dw_i2c_dev *dev);\n extern void i2c_dw_configure_master(struct dw_i2c_dev *dev);\n extern int i2c_dw_probe_master(struct dw_i2c_dev *dev);\n \n-#if IS_ENABLED(CONFIG_I2C_DESIGNWARE_SLAVE)\n+#if IS_ENABLED(CONFIG_I2C_SLAVE)\n extern void i2c_dw_configure_slave(struct dw_i2c_dev *dev);\n extern int i2c_dw_probe_slave(struct dw_i2c_dev *dev);\n #else\n","prefixes":["v2","1/6"]}