{"id":2175540,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175540/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20251218083326.644326-6-brian.ruley@gehealthcare.com>","date":"2025-12-18T08:33:24","name":"[v1,5/7] video: imx: ipuv3: add names to clk function identifiers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a46c97b95358239ff94d6a741c27a40bcec6d733","submitter":{"id":89422,"url":"http://patchwork.ozlabs.org/api/1.0/people/89422/?format=json","name":"Brian Ruley","email":"brian.ruley@gehealthcare.com"},"delegate":{"id":151988,"url":"http://patchwork.ozlabs.org/api/1.0/users/151988/?format=json","username":"festevam","first_name":"Fabio","last_name":"Estevam","email":"festevam@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251218083326.644326-6-brian.ruley@gehealthcare.com/mbox/","series":[{"id":485836,"url":"http://patchwork.ozlabs.org/api/1.0/series/485836/?format=json","date":"2025-12-18T08:33:20","name":"Refactor i.MX IPU driver","version":1,"mbox":"http://patchwork.ozlabs.org/series/485836/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175540/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gehealthcare.com header.i=@gehealthcare.com\n header.a=rsa-sha256 header.s=selector1 header.b=i6c7ySEi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gehealthcare.com header.i=@gehealthcare.com\n header.b=\"i6c7ySEi\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=gehealthcare.com","phobos.denx.de;\n spf=pass smtp.mailfrom=Brian.Ruley@gehealthcare.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dX8jN3tMBz1y2f\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 23:14:16 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 26C4083DEE;\n\tThu, 18 Dec 2025 13:13:47 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id A24B583DA6; Thu, 18 Dec 2025 09:33:41 +0100 (CET)","from CY3PR05CU001.outbound.protection.outlook.com\n (mail-westcentralusazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c112::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 62AEE83D3C\n for <u-boot@lists.denx.de>; Thu, 18 Dec 2025 09:33:39 +0100 (CET)","from BYAPR06CA0065.namprd06.prod.outlook.com (2603:10b6:a03:14b::42)\n by EA2PR22MB5067.namprd22.prod.outlook.com (2603:10b6:303:257::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Thu, 18 Dec\n 2025 08:33:34 +0000","from MWH0EPF000971E2.namprd02.prod.outlook.com\n (2603:10b6:a03:14b:cafe::5) by BYAPR06CA0065.outlook.office365.com\n (2603:10b6:a03:14b::42) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.6 via Frontend Transport; Thu,\n 18 Dec 2025 08:33:34 +0000","from mkerelay2.compute.ge-healthcare.net (165.85.157.49) by\n MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9412.4 via Frontend Transport; Thu, 18 Dec 2025 08:33:34 +0000","from zoo11.fihel.lab.ge-healthcare.net\n (zoo11.fihel.lab.ge-healthcare.net [10.168.174.93])\n by builder1.fihel.lab.ge-healthcare.net (Postfix) with ESMTP id B09B4F047F;\n Thu, 18 Dec 2025 10:33:31 +0200 (EET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=P/I9QywsQ/9nfK8gxcyGI/RPVNZdG0CE1HvZvJUobTYwcvzJqhBOtviUG113nXCX5dUlAJKFvCSgIrKOMMqxH4lTmjsIS2tfUrYiEYJlp1JXMEtdyp0Cd6+Yf2FR3o/lLApia2GsN9HmJCujG689AJ+szIAedbJ0eUWV6yHGzciGhF2M7l2YUN5L6FdOd7deb4ncKAvEt/oy++wcyFJNlAkltiCQxHUM5N2DcYJxEKbChp4U4hu5j5QnVdl2SmvlEwQ6XxhY4S6dtu/31aqM5F81fuB99R82nmMMb2GDemsy1bVjNP1D7ggwL2d7v2TFGuiCnBok46yWa6OHTf4L4A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=gBrZUE4pxB0MgXMugbDme0d69TlT13NKc9z+rfL4hVE=;\n b=uPTTwFbyA4CgsUT1Uu3sdgZxSVExCdYiLwJp0iGnR5yRaICSEEDx+wT91uQ8MHflIYXAJJlfi40ojfk4xdw/hFuYS6w8NmsArNOwAIEa6qLOcBlzjIivNy+OZ7Zrwv66p57Oi3q8Jnf3iixIi/Jy6aOlcFQbpc3y+HAu47YK8d56BIpPxKFx4UQWStU666EXvK1PLNfdX/h3TTcVvCdt6WBCKrHzyMolq6XytJ7AOKAnNlXGA05HImYduGQqLB2S98kK+QF2vlWpFKAhownIIKMFKXEz9+JOdUcwcnNh4J9HXjihiupcz8Of0mfAkovnm7B2m1aCYZfqLOE/ZDzKYg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 165.85.157.49) smtp.rcpttodomain=lists.denx.de\n smtp.mailfrom=gehealthcare.com; dmarc=fail (p=quarantine sp=quarantine\n pct=100) action=quarantine header.from=gehealthcare.com; dkim=none (message\n not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gehealthcare.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=gBrZUE4pxB0MgXMugbDme0d69TlT13NKc9z+rfL4hVE=;\n b=i6c7ySEitWBAhwaCYkSpsvipf0zJ/Eh0zOwaSVrGEt4h/E3ONIL60VOX1h+2uzl6bmukeheDfNq952arYi1AYbK5/fa8n+rU9soz4B7leOG1Q3XgwfDosUyCZAoCv7g+hch7kmP/SBIMJMeHcmlUZQimgxmVPoIpiti1aHuqPXhYeSfw17Oa8ZIk6SdJnpUjR7VsWz71WXwsj44M99wZvcPxf5a58NsqFYIt92qHDu0iawcv86ZPdPUmswNMRD4PW4+eO1m0IZZ6IFk/2/vZp5aULyTzaPz2f9rT7ix1BXf5XwdhXjNVzbAl3YUrTB9sUJ6OwwUZNE99W+B9gjC3qg==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 165.85.157.49)\n smtp.mailfrom=gehealthcare.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=quarantine header.from=gehealthcare.com;","Received-SPF":"Fail (protection.outlook.com: domain of gehealthcare.com does\n not designate 165.85.157.49 as permitted sender)\n receiver=protection.outlook.com; client-ip=165.85.157.49;\n helo=mkerelay2.compute.ge-healthcare.net;","From":"Brian Ruley <brian.ruley@gehealthcare.com>","To":"u-boot@lists.denx.de, Anatolij Gustschin <ag.dev.uboot@gmail.com>,\n Tom Rini <trini@konsulko.com>","Cc":"Brian Ruley <brian.ruley@gehealthcare.com>,\n Stefano Babic <sbabic@nabladev.com>","Subject":"[PATCH v1 5/7] video: imx: ipuv3: add names to clk function\n identifiers","Date":"Thu, 18 Dec 2025 10:33:24 +0200","Message-Id":"<20251218083326.644326-6-brian.ruley@gehealthcare.com>","X-Mailer":"git-send-email 2.39.5","In-Reply-To":"<20251218083326.644326-1-brian.ruley@gehealthcare.com>","References":"<20251218083326.644326-1-brian.ruley@gehealthcare.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MWH0EPF000971E2:EE_|EA2PR22MB5067:EE_","Content-Type":"text/plain","X-MS-Office365-Filtering-Correlation-Id":"3a7e310b-f59e-4358-9bde-08de3e10220a","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700013|376014|82310400026|1800799024;","X-Microsoft-Antispam-Message-Info":"\n mUzbHQN0jCNe9ouxqDJjIeWTgRYymiZGN26B7ZHVWi4F/A1+GF8gPO2ibk5/is/VqRIo/82CQo2yPGYovOzL/7qLDMSAwHQhYYk5xNnZKoD1tDdlx059U8PmkMyvYFrgHfoxdIg5SKa+R8g47XvIPOh7Ummr4WTU607MZM96JldudCcpGjuvvOFGxpEI7bcL1zz4OBuEU//A1C3gbQbQYyiULSWPKk8DtiwoY2l6VjsHY8lU4i0zaL13diNaWlhgnmjW8pSHsp44pcbxThJnhp3s526jXIpkXs/yKcT6SFDPfegaGodODB7nIKNorWITGW+dvMlbPY1WAwUtRtjRzi7o+3S7LjdEbWoqtQp6Q/JmSef1Ar7Z4PEK+Mq9m0sa1zicdGte7gFy7kEs62KbIY5plEBLN8BBQj3K4rR6lf0IHiqj7kkCeqh2cM+vREFGDgfVN/yQqTtdMeS6XjEN6sM8AKhOzXKvmMhpfKjGx1N1FLlUDpBo/0rDnm28NcgfGnrAAb53brCT1LLXYVLV9ABkRfkGsgsWqfzfN62MFQMKERwIWjXbEutXiYTtcEpaPfTUoLjieJeP3UVEiMaTHhRNIsLKrO1f8x4B/cqkEtBXQzHLNmSc3Eaa/kxE8kn/ac3kQJbufIz9L2xYZdm14T05vXGbhAZlqkLxbCDztQx9KMAO2tCJOaeQuwH+yllTw3D0S7z4xXEEThYT4QPhbZSXxKWK3L0gGRldma30R6bfRdIdgBkzSXZjZf3auN0w0wiFs3ImTNTZHuaYl1Uh3KYrOjBpl9BVjAhfdIaZ9Fry7vPZsygEJ1MhWy6XaORGbj3DSpv9iANCRcHqUQc2hB7tRCgrt1hP9e0BbrL9i1YvOuhKi7vo09Om9e71W9Z79MyLcvMyjeCQvFe8mOQs0G3kG88IaoKtrPZvJhDCaquk5XO6Bl89lnVnFZ9N8fredeoZtQXYUt2RAre66n42GyxxsY3T+LaXY6YJCiPVT8ue6FkCGYCDbZQBZoJcUSly2kB/Kgun4bx3TLGBJhv6NF2+WLixBqzfvjohEm+x8PF16FIjEAbBcO8lQeL40tr4wG+2HgzMyUJBC6dH5NgbmYvUaffr4uU1IrufPLel1lp0Pnm3y2YSgQJeYfAZpsVdrNy/RWnj2+JEUlFgf/5p6/9y6zih6MkVV/Xt7QP/v34dMHfZiPz8YILS7uqgC3FoW+R3v2XhA+J8QecLEpPoJGPI7cSbYrGf+CWoWQ+QjROG5GOeGjeyU6dZWaprCYlYXXeWoJOHo/ERkeBu009l3YxJWQ+zrBhBziVm5uRdU+TRkdLv0gwh0zAG1Rq69vUYt2CXxI+OllrIW3njngNqMnHI2EN7KEccKSV3uFEW4z8JQTciePii61IgEJL7T6ct/IRWifRdv3XloNMFWYFoFOqHAG0pBK91UbN9lX3SoV9yGKEQ5pPvQIvDjvCzjMCNv6KXoQ1vB9n34jSm7V4nHjYBDbvhIUJaLJ8bKMHSNa6Lo421IqYq/DJ6DohpwIIMrklcgwv/htJzl20yO8ulpRLuodS3GpEsVdDyeGQRnDg=","X-Forefront-Antispam-Report":"CIP:165.85.157.49; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:mkerelay2.compute.ge-healthcare.net;\n PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT;\n SFP:1101;","X-OriginatorOrg":"gehealthcare.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"18 Dec 2025 08:33:34.2305 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 3a7e310b-f59e-4358-9bde-08de3e10220a","X-MS-Exchange-CrossTenant-Id":"9a309606-d6ec-4188-a28a-298812b4bbbf","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=9a309606-d6ec-4188-a28a-298812b4bbbf; Ip=[165.85.157.49];\n Helo=[mkerelay2.compute.ge-healthcare.net]","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"\n TreatMessagesAsInternal-MWH0EPF000971E2.namprd02.prod.outlook.com","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"EA2PR22MB5067","X-Mailman-Approved-At":"Thu, 18 Dec 2025 13:13:44 +0100","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The API should provide clear distinction in the order of parameters.\n\nSigned-off-by: Brian Ruley <brian.ruley@gehealthcare.com>\n---\n\n drivers/video/imx/ipu.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/video/imx/ipu.h b/drivers/video/imx/ipu.h\nindex 16e103cf541..f7d9d809529 100644\n--- a/drivers/video/imx/ipu.h\n+++ b/drivers/video/imx/ipu.h\n@@ -39,30 +39,30 @@ struct clk {\n \t * Function ptr to recalculate the clock's rate based on parent\n \t * clock's rate\n \t */\n-\tvoid (*recalc)(struct clk *);\n+\tvoid (*recalc)(struct clk *clk);\n \t/*\n \t * Function ptr to set the clock to a new rate. The rate must match a\n \t * supported rate returned from round_rate. Leave blank if clock is not\n \t* programmable\n \t */\n-\tint (*set_rate)(struct clk *, unsigned long);\n+\tint (*set_rate)(struct clk *clk, unsigned long rate);\n \t/*\n \t * Function ptr to round the requested clock rate to the nearest\n \t * supported rate that is less than or equal to the requested rate.\n \t */\n-\tunsigned long (*round_rate)(struct clk *, unsigned long);\n+\tunsigned long (*round_rate)(struct clk *clk, unsigned long rate);\n \t/*\n \t * Function ptr to enable the clock. Leave blank if clock can not\n \t * be gated.\n \t */\n-\tint (*enable)(struct clk *);\n+\tint (*enable)(struct clk *clk);\n \t/*\n \t * Function ptr to disable the clock. Leave blank if clock can not\n \t * be gated.\n \t */\n-\tvoid (*disable)(struct clk *);\n+\tvoid (*disable)(struct clk *clk);\n \t/* Function ptr to set the parent clock of the clock. */\n-\tint (*set_parent)(struct clk *, struct clk *);\n+\tint (*set_parent)(struct clk *clk, struct clk *parent);\n };\n \n /*\n","prefixes":["v1","5/7"]}