{"id":2175475,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175475/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251218085446.462827-3-phind.uet@gmail.com>","date":"2025-12-18T08:54:46","name":"[v2,2/2] util: Move qemu_ftruncate64 from block/file-win32.c to oslib-win32.c","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6e9bbcfec14afecae09b068dc8800e611029ce74","submitter":{"id":83910,"url":"http://patchwork.ozlabs.org/api/1.0/people/83910/?format=json","name":"NGUYEN DINH PHI","email":"phind.uet@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251218085446.462827-3-phind.uet@gmail.com/mbox/","series":[{"id":485804,"url":"http://patchwork.ozlabs.org/api/1.0/series/485804/?format=json","date":"2025-12-18T08:54:45","name":"Fix Windows build issues with newer MinGW","version":2,"mbox":"http://patchwork.ozlabs.org/series/485804/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175475/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=mEoKnPKz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dX4Jt5Q21z1xty\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 19:56:14 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vW9nI-0003sb-LK; Thu, 18 Dec 2025 03:55:32 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <phind.uet@gmail.com>)\n id 1vW9nG-0003rT-47\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 03:55:30 -0500","from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <phind.uet@gmail.com>)\n id 1vW9nE-000571-I5\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 03:55:29 -0500","by mail-pf1-x42d.google.com with SMTP id\n d2e1a72fcca58-7aae5f2633dso462695b3a.3\n for <qemu-devel@nongnu.org>; Thu, 18 Dec 2025 00:55:28 -0800 (PST)","from localhost.localdomain ([116.86.160.247])\n by smtp.googlemail.com with ESMTPSA id\n d2e1a72fcca58-7fe12128ea4sm1926218b3a.27.2025.12.18.00.55.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 18 Dec 2025 00:55:26 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1766048127; x=1766652927; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wBlyXOWb/KMcPwA7yvb0AbdJKytBhHprjnVY2HHlTkI=;\n b=mEoKnPKzLr/q9cWjl/S0KtOtutg/ih3i/av17N2LTSkVq4Z+1A+tMd+YDBMUNPzcd0\n e39vqcHGsljHNPNLVJnGJerXDfeSI2IzGF9ZY7/VTfzy4gLDBXtcVAIpir5YLXW1P35F\n 21uVdp+ES0DkK9imQcGQvfiOn0IJ367ehBZH9I4rZml/aoSwkgHMiXjM7OVC+KI74IC4\n Rz/GWa2gZ5wxYS0F0/g4DILSSdXFeZ8uoshuWY+dFIUZiSH7ZC4dmRUwaSWWBKU6eF3H\n uGddDxUBUfykqmM86+tSs4rwXq3dYnxx20XXIiGtp/Fn+GIDmNRv3dZliRZIR993Jdwf\n lMiA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766048127; x=1766652927;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=wBlyXOWb/KMcPwA7yvb0AbdJKytBhHprjnVY2HHlTkI=;\n b=VXrFXWYrgM3bsW415zxcSafegDe++rJJVoucMp/tfnCj1OzUT2OyvVgBW9L/Gsrdxg\n fS3BkqelriCRqcDVS2z0PAiI+HrdvzWVnNxVaDGENRVTHUS8MBpI3ZFoG5hFDeAJHhFI\n YjLj3Xv4BJpy2/SrcOXol3pXyP5NxZ+dKQOkJqj5k7vm6drgJDgFu6awT1QJceAvhEO9\n iuYnM6kKd7cBLt4JbXf3f8NI2XGAFFXtj1C5co7XjfAuqvAWwyewCN/yripfFNZgsGko\n boI2G5PwdGmOYk3rPb6yr8hybHIzHSyz+HbbPpP8VXj29ppvrbZuZjIbm7cAHmnpvrjK\n hRXQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXnOURPSDRwyiRkRcU7AkOeWlPyrY8IU/NJds62xMsMPquYdILRjJCzUT+3gT0+hQgx0PIsg/S5N6xS@nongnu.org","X-Gm-Message-State":"AOJu0Yz41SM1f+K1NTRzwA2MVZryasgG24LzL+2LwET5eZuSPKzDbA4m\n 9TiUQL4W/I95BN6tjrOepsQ1mzMbUDLyNJre2MltauPHVIwiltS2FyZW","X-Gm-Gg":"AY/fxX5fo1oL2nGbYVZnli7/aeJG6S3v4ylU6104ekHYa7iYKdSAA4rg+19cwEJJIbO\n CJMbHEBhg+Mv5abmD6iApN9G863qX6gATAKFQGf8XpcYaKWwmg3X6TaxhzDsHNcZFAbVDbX9484\n l25rQw+b/+J+klDjNcmlinYTNZTz1Ongj1HMn0gbtba05k5B51y777ES+qOukyeSrXsI+byoxfV\n iM0UdmI0I7+l+aNq8V0oKBLOMHq3Hi8B3bI/grIAezQNnllyIUkN1o9kdDqrJ9G/Jgsr7svrGFh\n eE7L3IsgcmRnxcxYHUVIBQ5yp8L+JcDclkn6tNbx+HtAg/4WqkqelDGdztZakGJfqDz/G8caHy4\n pmD6FX5F0cyGU/MvjJoN3ntobg2fP4+HCPzD/f8ZucOQCz82XUP/g2jQQ8Y6ohNH6bI4zkX6QIO\n PPvWLsksVOyll/O5+RqgmYR3g=","X-Google-Smtp-Source":"\n AGHT+IHbT9YOQdX3ThNpiyotAQ3FTMdosOz+gS66I7NiTVvEUG03SGviKHw3v/Vpa0AnOqMlOcJe/w==","X-Received":"by 2002:aa7:81c5:0:b0:7e8:450c:61b8 with SMTP id\n d2e1a72fcca58-7f67156b7ffmr13729050b3a.40.1766048126992;\n Thu, 18 Dec 2025 00:55:26 -0800 (PST)","From":"phind.uet@gmail.com","To":"Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,\n Stefan Weil <sw@weilnetz.de>","Cc":"Nguyen Dinh Phi <phind.uet@gmail.com>, qemu-block@nongnu.org,\n qemu-devel@nongnu.org","Subject":"[PATCH v2 2/2] util: Move qemu_ftruncate64 from block/file-win32.c to\n oslib-win32.c","Date":"Thu, 18 Dec 2025 16:54:46 +0800","Message-ID":"<20251218085446.462827-3-phind.uet@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251218085446.462827-1-phind.uet@gmail.com>","References":"<20251218085446.462827-1-phind.uet@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42d;\n envelope-from=phind.uet@gmail.com; helo=mail-pf1-x42d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Nguyen Dinh Phi <phind.uet@gmail.com>\n\nqemu_ftruncate64() is a general-purpose utility function that may be\nused outside of the block layer. Move it to util/oslib-win32.c where\nother Windows-specific utility functions reside.\n\nSigned-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>\n---\n block/file-win32.c | 32 --------------------------------\n util/oslib-win32.c | 34 ++++++++++++++++++++++++++++++++++\n 2 files changed, 34 insertions(+), 32 deletions(-)","diff":"diff --git a/block/file-win32.c b/block/file-win32.c\nindex af9aea631c..8a44853389 100644\n--- a/block/file-win32.c\n+++ b/block/file-win32.c\n@@ -170,38 +170,6 @@ static BlockAIOCB *paio_submit(BlockDriverState *bs, HANDLE hfile,\n     return thread_pool_submit_aio(aio_worker, acb, cb, opaque);\n }\n \n-int qemu_ftruncate64(int fd, int64_t length)\n-{\n-    LARGE_INTEGER li;\n-    DWORD dw;\n-    LONG high;\n-    HANDLE h;\n-    BOOL res;\n-\n-    if ((GetVersion() & 0x80000000UL) && (length >> 32) != 0)\n-        return -1;\n-\n-    h = (HANDLE)_get_osfhandle(fd);\n-\n-    /* get current position, ftruncate do not change position */\n-    li.HighPart = 0;\n-    li.LowPart = SetFilePointer (h, 0, &li.HighPart, FILE_CURRENT);\n-    if (li.LowPart == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) {\n-        return -1;\n-    }\n-\n-    high = length >> 32;\n-    dw = SetFilePointer(h, (DWORD) length, &high, FILE_BEGIN);\n-    if (dw == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) {\n-        return -1;\n-    }\n-    res = SetEndOfFile(h);\n-\n-    /* back to old position */\n-    SetFilePointer(h, li.LowPart, &li.HighPart, FILE_BEGIN);\n-    return res ? 0 : -1;\n-}\n-\n static int set_sparse(int fd)\n {\n     DWORD returned;\ndiff --git a/util/oslib-win32.c b/util/oslib-win32.c\nindex 839b8a4170..766c602172 100644\n--- a/util/oslib-win32.c\n+++ b/util/oslib-win32.c\n@@ -899,3 +899,37 @@ int qemu_shm_alloc(size_t size, Error **errp)\n     error_setg(errp, \"Shared memory is not supported.\");\n     return -1;\n }\n+\n+int qemu_ftruncate64(int fd, int64_t length)\n+{\n+    LARGE_INTEGER li;\n+    DWORD dw;\n+    LONG high;\n+    HANDLE h;\n+    BOOL res;\n+\n+    if ((GetVersion()&0x80000000UL) && (length >> 32) != 0) {\n+        return -1;\n+    }\n+\n+    h = (HANDLE)_get_osfhandle(fd);\n+\n+    /* get current position, ftruncate do not change position */\n+    li.HighPart = 0;\n+    li.LowPart = SetFilePointer (h, 0, &li.HighPart, FILE_CURRENT);\n+    if (li.LowPart == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) {\n+        return -1;\n+    }\n+\n+    high = length >> 32;\n+    dw = SetFilePointer(h, (DWORD) length, &high, FILE_BEGIN);\n+    if (dw == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) {\n+        return -1;\n+    }\n+    res = SetEndOfFile(h);\n+\n+    /* back to old position */\n+    SetFilePointer(h, li.LowPart, &li.HighPart, FILE_BEGIN);\n+    return res ? 0 : -1;\n+}\n+\n","prefixes":["v2","2/2"]}