{"id":2175473,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175473/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251218085446.462827-2-phind.uet@gmail.com>","date":"2025-12-18T08:54:45","name":"[v2,1/2] qga/vss-win32: Fix ConvertStringToBSTR redefinition with newer MinGW","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"66bbafcc5052cc5c22386774d43873e7ec613320","submitter":{"id":83910,"url":"http://patchwork.ozlabs.org/api/1.0/people/83910/?format=json","name":"NGUYEN DINH PHI","email":"phind.uet@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251218085446.462827-2-phind.uet@gmail.com/mbox/","series":[{"id":485804,"url":"http://patchwork.ozlabs.org/api/1.0/series/485804/?format=json","date":"2025-12-18T08:54:45","name":"Fix Windows build issues with newer MinGW","version":2,"mbox":"http://patchwork.ozlabs.org/series/485804/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175473/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=ELdYtPII;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dX4JS01PBz1xty\n\tfor ; Thu, 18 Dec 2025 19:55:51 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vW9nF-0003q5-B6; Thu, 18 Dec 2025 03:55:29 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vW9n9-0003no-TT\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 03:55:23 -0500","from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vW9n8-0004vX-4q\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 03:55:23 -0500","by mail-pf1-x433.google.com with SMTP id\n d2e1a72fcca58-7b9c17dd591so362613b3a.3\n for ; Thu, 18 Dec 2025 00:55:21 -0800 (PST)","from localhost.localdomain ([116.86.160.247])\n by smtp.googlemail.com with ESMTPSA id\n d2e1a72fcca58-7fe12128ea4sm1926218b3a.27.2025.12.18.00.55.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 18 Dec 2025 00:55:20 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1766048120; x=1766652920; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IbCZM5/yo0/xTboRWK9DLsnxsWBmAYOPq/HX6Y7FFcM=;\n b=ELdYtPII6TngSJcVuu44eZfT7LS7GononvMqtku/kJK9JW7hqpghM4eWW3JLR2Kzud\n DrWViMjAzieXftTNDr3e9QgZVnruD1MOoVPw31allONWDt2mIRUfTkyfQgxFAsYL0PYh\n 4fLJ5IyP2me0Qho8m1fKoiQ322rsn3y3FnSz2sZ8uyrPxHJN+1ZjL4nMMQdiZoFPdR0/\n xV56Reft79nn0BExNyF/YI3mx0guD+p4ojMt3sRjDqkX7MrueUsR1Tgb+sFYMCbEI96u\n BJkkPu38Nl215Nc5XztLPQ1KXeMG+f5N/cgzkCBe4Ze4h+Q22c27BY0wWDPwTwEYPKNM\n alJA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766048120; x=1766652920;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=IbCZM5/yo0/xTboRWK9DLsnxsWBmAYOPq/HX6Y7FFcM=;\n b=OD+9EeVJapM6VUkbEpDUPpBvcYRLNRaP1VB/fGmPDIoE0lt4tq2IkCqJX3EslSUaee\n HePYG0OgYG5GJlzS5LvtWekDvP+22CnRTxkvIoBFPLBQHInAR7gtIiwNuZdcSKO0ArZv\n fSCguq8N/lGjUj6Ia/cm4JNEpayBwr7wY/edNfkIsXVsKSzZ8oq4Y8S/shNhF90fMq6A\n PHQe4ZopEQxMUh58hfGUJ+wcz8RLK1o8g+YrACPPZhWnIX2qBOJ2TyF4zgdZRYURd3he\n J5mCuK1tWqVdXTdVgURQH4hI+RnCNgXQzp1nb3aVXyMPLlr+qhgJ6xU0sastYYWGH31a\n cidQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX8tXgKR0gJtLYTgW9nVTvO2OPORtyOpLNygKFvPQCwFQ6+W0ApRrbTbaDkN82cDSj6c3cTEIJs1+qd@nongnu.org","X-Gm-Message-State":"AOJu0YxekBPW2xqHj9VjumSqP6OhPXHoucacat+HMQVKplGAPq+M5aRv\n GYCGQpO3D9dFVxBaFjhd7SNEOeMKA5wD/W5Ai4T67TcdMQ3M9aWfoX/P+UDCKQ==","X-Gm-Gg":"AY/fxX7yUULw2N/wWwTKhJY+GgAMupnpatW8SdO1bz5QHnBNrVkV+HRwIqPvBaw/lS2\n Zjuqm0SXpdO+g0rNzgdSpen9h2RBPNDee5w0EH2uuCZe0GD0yKW7l/KPcIXi+u+bfXuEXty/OBl\n hr69hENUl0F7Y/nwu/HUSveFDAuxVmw8sglTNWM/4pTGyo9sd7oFQbFqiymhjsAxysBRV7YgiR5\n kV4xs2VQvYCJpJrgvfoDMrcZihFvL2LCjDcMeehHDspIIR8nD6G+MG0K6Gc1wONPJDU6AOlF+yj\n ClpGR+OqB2WezioOSkSB5hfqbeVGvtdq9oX9niD567EId4xvpsZt1CVnNOfvC7kAbEU2EQ6JTM3\n ZZsVzGSkYiuk+DEVNKA6lK5QEFtb576HAtXi94r7CY0KFaHtNxmIoEsPORl8DUOyuWUpPzl/IrU\n r5EFVdAnEc4w9NDeQAyCvT8ZzIIGVs4BNOYg==","X-Google-Smtp-Source":"\n AGHT+IEhj72ITgxNK5M7rvRlDqQUxPqtFgxXUB4uDdwfkrHzmWmm778xrmh2iRJ2vPmbx3Eb90TX1Q==","X-Received":"by 2002:a05:6a00:1bcd:b0:7e8:4587:e8ca with SMTP id\n d2e1a72fcca58-7f669d83f78mr18430291b3a.61.1766048120516;\n Thu, 18 Dec 2025 00:55:20 -0800 (PST)","From":"phind.uet@gmail.com","To":"Paolo Bonzini ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Kostiantyn Kostiuk , Michael Roth ","Cc":"Nguyen Dinh Phi ,\n Pierrick Bouvier , qemu-devel@nongnu.org","Subject":"[PATCH v2 1/2] qga/vss-win32: Fix ConvertStringToBSTR redefinition\n with newer MinGW","Date":"Thu, 18 Dec 2025 16:54:45 +0800","Message-ID":"<20251218085446.462827-2-phind.uet@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251218085446.462827-1-phind.uet@gmail.com>","References":"<20251218085446.462827-1-phind.uet@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::433;\n envelope-from=phind.uet@gmail.com; helo=mail-pf1-x433.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Nguyen Dinh Phi \n\nNewer versions of MinGW-w64 provide ConvertStringToBSTR() in the\n_com_util namespace via . This causes a redefinition\nerror when building qemu-ga on Windows with these toolchains.\n\nAdd a meson check to detect whether ConvertStringToBSTR is already\navailable, and conditionally compile our fallback implementation\nonly when the system does not provide one.\n\nSigned-off-by: Nguyen Dinh Phi \nSuggested-by: Pierrick Bouvier \n---\n meson.build | 12 ++++++++++++\n qga/vss-win32/install.cpp | 2 ++\n 2 files changed, 14 insertions(+)","diff":"diff --git a/meson.build b/meson.build\nindex c5710a6a47..5a0f407d6f 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -3299,6 +3299,18 @@ endif\n # Detect host pointer size for the target configuration loop.\n host_long_bits = cc.sizeof('void *') * 8\n \n+# Detect if ConvertStringToBSTR has been defined in _com_util namespace\n+if host_os == 'windows'\n+ has_convert_string_to_bstr = cxx.links('''\n+ #include \n+ int main() {\n+ BSTR b = _com_util::ConvertStringToBSTR(\"test\");\n+ return b ? 0 : 1;\n+ }\n+ ''')\n+ config_host_data.set('CONFIG_CONVERT_STRING_TO_BSTR', has_convert_string_to_bstr)\n+endif\n+\n ########################\n # Target configuration #\n ########################\ndiff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp\nindex 7b25d9098b..5b7a8e9bc5 100644\n--- a/qga/vss-win32/install.cpp\n+++ b/qga/vss-win32/install.cpp\n@@ -549,6 +549,7 @@ STDAPI DllUnregisterServer(void)\n \n \n /* Support function to convert ASCII string into BSTR (used in _bstr_t) */\n+#ifndef CONFIG_CONVERT_STRING_TO_BSTR\n namespace _com_util\n {\n BSTR WINAPI ConvertStringToBSTR(const char *ascii) {\n@@ -566,6 +567,7 @@ namespace _com_util\n return bstr;\n }\n }\n+#endif\n \n /* Stop QGA VSS provider service using Winsvc API */\n STDAPI StopService(void)\n","prefixes":["v2","1/2"]}