{"id":2175430,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175430/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251218062643.624796-2-zhenzhong.duan@intel.com>","date":"2025-12-18T06:26:22","name":"[v6,1/9] vfio/iommufd: Add framework code to support getting dirty bitmap before unmap","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e701e54a36d616ac2e591de873d0ea3f6be2f165","submitter":{"id":81636,"url":"http://patchwork.ozlabs.org/api/1.0/people/81636/?format=json","name":"Duan, Zhenzhong","email":"zhenzhong.duan@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251218062643.624796-2-zhenzhong.duan@intel.com/mbox/","series":[{"id":485789,"url":"http://patchwork.ozlabs.org/api/1.0/series/485789/?format=json","date":"2025-12-18T06:26:21","name":"vfio: relax the vIOMMU check","version":6,"mbox":"http://patchwork.ozlabs.org/series/485789/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175430/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=fakLYqLJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dX11r2Hdmz1xty\n\tfor ; Thu, 18 Dec 2025 17:28:00 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vW7Ty-0003Kx-LW; Thu, 18 Dec 2025 01:27:26 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vW7Tx-0003KW-6A\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 01:27:25 -0500","from mgamail.intel.com ([198.175.65.18])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vW7Tu-00015T-Ld\n for qemu-devel@nongnu.org; Thu, 18 Dec 2025 01:27:24 -0500","from orviesa005.jf.intel.com ([10.64.159.145])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2025 22:27:19 -0800","from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229])\n by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2025 22:27:17 -0800"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1766039242; x=1797575242;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=QdZ1ubBQIL/oXabO9On2Or1ttJr/IWvuDU6xXkUi2/c=;\n b=fakLYqLJ6McWm7+Zvj3vJAGoRJOkzFUNrIoniKyT7cG8ALoir6oNTGNI\n sNK2YlXs6BnfBqEKstHkgfwPPXgnNx7VhdOaLQrHddG/n3aw8hEl3SCr+\n UppmLldpgWDCXYbBw6ma6Zpt0F4sJlGMlDmdhpqaLP/6gF9BUL2Q+FxT3\n Tp176jR8g9IOGbytztnwC00nuviJg1+BfSl5cEmj0BOadxqmsFRgxiZKM\n XYYBfmvdw5lk5ikORctUjhY2l4HEbuL/qQ3ASlo6OppnHcwbK9Yumvbhr\n nsATVJb0zMzQ+f2VNaYDd78jEBrqvgbIrgpYkoTmKXMgfnURL0SA4Hqu+ Q==;","X-CSE-ConnectionGUID":["i9aX1W84SzSJTbEQy+a9ug==","cXArXbc+SiC75uqlxnMlpg=="],"X-CSE-MsgGUID":["ZsqwsqvnT9ypMw+5mPZHKQ==","/C2ySSYGSJ2hfn6gDv+L7Q=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11645\"; a=\"68028499\"","E=Sophos;i=\"6.21,156,1763452800\"; d=\"scan'208\";a=\"68028499\"","E=Sophos;i=\"6.21,156,1763452800\"; d=\"scan'208\";a=\"203569840\""],"X-ExtLoop1":"1","From":"Zhenzhong Duan ","To":"qemu-devel@nongnu.org","Cc":"alex@shazbot.org, clg@redhat.com, mst@redhat.com, jasowang@redhat.com,\n yi.l.liu@intel.com, clement.mathieu--drif@eviden.com,\n eric.auger@redhat.com, joao.m.martins@oracle.com, avihaih@nvidia.com,\n xudong.hao@intel.com, giovanni.cabiddu@intel.com, rohith.s.r@intel.com,\n mark.gross@intel.com, arjan.van.de.ven@intel.com,\n Zhenzhong Duan ","Subject":"[PATCH v6 1/9] vfio/iommufd: Add framework code to support getting\n dirty bitmap before unmap","Date":"Thu, 18 Dec 2025 01:26:22 -0500","Message-ID":"<20251218062643.624796-2-zhenzhong.duan@intel.com>","X-Mailer":"git-send-email 2.47.1","In-Reply-To":"<20251218062643.624796-1-zhenzhong.duan@intel.com>","References":"<20251218062643.624796-1-zhenzhong.duan@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=198.175.65.18;\n envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Currently we support device and iommu dirty tracking, device dirty tracking\nis preferred.\n\nAdd the framework code in iommufd_cdev_unmap() to choose either device or\niommu dirty tracking, just like vfio_legacy_dma_unmap_one().\n\nSigned-off-by: Zhenzhong Duan \nReviewed-by: Cédric Le Goater \nReviewed-by: Yi Liu \nTested-by: Xudong Hao \nTested-by: Giovannio Cabiddu \nTested-by: Rohith S R \n---\n hw/vfio/iommufd.c | 34 +++++++++++++++++++++++++++++++---\n 1 file changed, 31 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c\nindex ca8a6b7029..b527c7d1eb 100644\n--- a/hw/vfio/iommufd.c\n+++ b/hw/vfio/iommufd.c\n@@ -61,14 +61,42 @@ static int iommufd_cdev_unmap(const VFIOContainer *bcontainer,\n IOMMUTLBEntry *iotlb, bool unmap_all)\n {\n const VFIOIOMMUFDContainer *container = VFIO_IOMMU_IOMMUFD(bcontainer);\n+ IOMMUFDBackend *be = container->be;\n+ uint32_t ioas_id = container->ioas_id;\n+ bool need_dirty_sync = false;\n+ Error *local_err = NULL;\n+ int ret;\n \n if (unmap_all) {\n size = UINT64_MAX;\n }\n \n- /* TODO: Handle dma_unmap_bitmap with iotlb args (migration) */\n- return iommufd_backend_unmap_dma(container->be,\n- container->ioas_id, iova, size);\n+ if (iotlb && vfio_container_dirty_tracking_is_started(bcontainer)) {\n+ if (!vfio_container_devices_dirty_tracking_is_supported(bcontainer) &&\n+ bcontainer->dirty_pages_supported) {\n+ /* TODO: query dirty bitmap before DMA unmap */\n+ return iommufd_backend_unmap_dma(be, ioas_id, iova, size);\n+ }\n+\n+ need_dirty_sync = true;\n+ }\n+\n+ ret = iommufd_backend_unmap_dma(be, ioas_id, iova, size);\n+ if (ret) {\n+ return ret;\n+ }\n+\n+ if (need_dirty_sync) {\n+ ret = vfio_container_query_dirty_bitmap(bcontainer, iova, size,\n+ iotlb->translated_addr,\n+ &local_err);\n+ if (ret) {\n+ error_report_err(local_err);\n+ return ret;\n+ }\n+ }\n+\n+ return 0;\n }\n \n static bool iommufd_cdev_kvm_device_add(VFIODevice *vbasedev, Error **errp)\n","prefixes":["v6","1/9"]}