{"id":2175417,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175417/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20251218042244.1833380-2-judge.packham@gmail.com>","date":"2025-12-18T04:22:42","name":"[1/3] mtd: nand: pxa3xx: Use pr_err() in some places","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"ba3301b22fac3a885c3700a5c5a163918100be1f","submitter":{"id":6125,"url":"http://patchwork.ozlabs.org/api/1.0/people/6125/?format=json","name":"Chris Packham","email":"judge.packham@gmail.com"},"delegate":{"id":1696,"url":"http://patchwork.ozlabs.org/api/1.0/users/1696/?format=json","username":"stroese","first_name":"Stefan","last_name":"Roese","email":"sr@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251218042244.1833380-2-judge.packham@gmail.com/mbox/","series":[{"id":485785,"url":"http://patchwork.ozlabs.org/api/1.0/series/485785/?format=json","date":"2025-12-18T04:22:41","name":"arm: mvebu: Updates for xcat3","version":1,"mbox":"http://patchwork.ozlabs.org/series/485785/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175417/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=CbbdLIZL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"CbbdLIZL\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=judge.packham@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWyFz5646z1xpw\n\tfor ; Thu, 18 Dec 2025 15:23:19 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C9CC283C6E;\n\tThu, 18 Dec 2025 05:23:07 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 5F3B383B49; Thu, 18 Dec 2025 05:23:06 +0100 (CET)","from mail-pl1-x635.google.com (mail-pl1-x635.google.com\n [IPv6:2607:f8b0:4864:20::635])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 43A8F83C67\n for ; Thu, 18 Dec 2025 05:22:58 +0100 (CET)","by mail-pl1-x635.google.com with SMTP id\n d9443c01a7336-29f2676bb21so2514615ad.0\n for ; Wed, 17 Dec 2025 20:22:58 -0800 (PST)","from chrisp-dl.atlnz.lc ([2001:df5:b000:22:73ef:52b5:685b:7c64])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2a2d087d485sm9305655ad.16.2025.12.17.20.22.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 Dec 2025 20:22:56 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1766031777; x=1766636577; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ufVWzI2/mSqW8rtxrGSvMrBkIuFiaXM9e2tHnCm0C2U=;\n b=CbbdLIZLMcqoAlUGpy0F236YPbVG9wJ1Q7Z+dons6E1j5SSeGekPEOo78vg43ws7nz\n 3VjW5jEtnrdlHYDjaahI2RVV3KlA1zGlahrgidBp/g6g/KjdONJwBEMsTo1lAGTYsnxk\n IEGfBaYODUUyPND1bdjHRQcD3/uYjbfVyLHDIzhTWNsj5Ta88qYyVFswZiiGTkv+nsFw\n 9LH+zifgx+2vqyXMeQO8i9bxc7/ILOy6A/Rgt6vHqBE98LFCVktTFtK7V0mCLt4UtvnS\n EdeP8QYRdVEBEB+uTJy58Dbo8S/zEN5O+E7EsvwuJjyL+IVSQsjpA8eIN3vG09s6ZHmR\n v6eA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1766031777; x=1766636577;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ufVWzI2/mSqW8rtxrGSvMrBkIuFiaXM9e2tHnCm0C2U=;\n b=Ryncl2R9TfIHI5Ak6V60Qo7IBvjq3kn6fyvJYfU/jjjr7i5xv8NpqzZ5oeCAG9NnKC\n q2jI+5/b0RnP3+bdao4RRFWjmR2YJS6kig8B9AzqvFc5HMeUsOO4ZjF9ryKnmLApfbhR\n 6Nbe4Fg5fvYOXnY/yn4W9N0ImpIWZpliDTHlXLKNYIu3+SF6ID6UDOz3df4HXZ8VU8sX\n sKyjru5v1M2R8txP7YTDM1946awNBtqRiXDqOJLraujEGesio+QFUu9cORV+RVpw7WyB\n 1tGhcngTk6aNivlxRNShNSmzEH733cwki00EPVY8bn54sCMO0Av8DUeBFoYlsLXmS8JH\n 8GjQ==","X-Gm-Message-State":"AOJu0Yyobr7iJBoDml8jt7hYvb34MLo6SfHwMj/aby86uGI+W+Hn3ETQ\n qEqsl/wyUoiWKH432ZT0v93Z91q7UDYvRnOqJXxVU1TUuv2WiyjMA1zc","X-Gm-Gg":"AY/fxX5mdPhTg0ZeycLlj+JVcrg8UuG5S9kLiANNaeUDsunsI877AnB5dWNXDfmH2wV\n aCnzVgTHbP4ciYv1Q7OdGDWgYTAdhwxNajKgD7fybN6pq9Y6FJ2fOtgCQyAyORbOsIXSLXEM7As\n bA4/Tv24nmQZDLg6h+GqmvNaoVo0Qd++yR2mIfFrRvt40x3HIsQV1cEMBnWLKEBJ+xQqCAPqdsO\n +kFaZeqKy7Uqzsi2++E/LibZziJNj8x+lxu8NrsuxPwtSTqnCUENXG9Fzfo+UqfFk0DXs2Pg9HR\n ICUghz+T4Ws9sFjGCLE8hmvOthDTw7L5otd2/r9HyoGEWU6E/lX5h2OLWhHZRMLhT0eVbw8CB3G\n 4Tb45Qmf4TRMJf1+ouIyPECIAdDix/a6WIScJNqZ32cdiqc/H+Wf7FpmcQRgZWs4JL21TPXOnZd\n CYjQWLp2pWWOLCm/75ttydHjUZ","X-Google-Smtp-Source":"\n AGHT+IHokbSlswmwkCGkbKhosVu+QxClOyIeQiDnhI+hco4iiMnvmwCcueG9gBvEjhFDW2CkwURBxw==","X-Received":"by 2002:a17:903:240f:b0:2a0:a8c2:be5d with SMTP id\n d9443c01a7336-2a0a8c2c178mr174349315ad.5.1766031776686;\n Wed, 17 Dec 2025 20:22:56 -0800 (PST)","From":"Chris Packham ","To":"trini@konsulko.com,\n\tstefan.roese@mailbox.org,\n\tseanga2@gmail.com","Cc":"u-boot@lists.denx.de,\n\tChris Packham ","Subject":"[PATCH 1/3] mtd: nand: pxa3xx: Use pr_err() in some places","Date":"Thu, 18 Dec 2025 17:22:42 +1300","Message-ID":"<20251218042244.1833380-2-judge.packham@gmail.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251218042244.1833380-1-judge.packham@gmail.com>","References":"<20251218042244.1833380-1-judge.packham@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"info->controller.active is not initialised so the dev_err() call ends up\ndereferencing a null pointer causing a crash instead of outputting the\nerror. Use pr_err() instead as there isn't a convenient dev in the\nplaces info->controller.active->mtd.dev was being used.\n\nFixes: 661c98121d49 (\"mtd: nand: pxa3xx: Fix not calling dev_xxx with a device\")\nSigned-off-by: Chris Packham \n---\n drivers/mtd/nand/raw/pxa3xx_nand.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/mtd/nand/raw/pxa3xx_nand.c b/drivers/mtd/nand/raw/pxa3xx_nand.c\nindex 7bf54fa46540..e1d8515bd9b1 100644\n--- a/drivers/mtd/nand/raw/pxa3xx_nand.c\n+++ b/drivers/mtd/nand/raw/pxa3xx_nand.c\n@@ -588,8 +588,7 @@ static void drain_fifo(struct pxa3xx_nand_info *info, void *data, int len)\n \t\t\tts = get_timer(0);\n \t\t\twhile (!(nand_readl(info, NDSR) & NDSR_RDDREQ)) {\n \t\t\t\tif (get_timer(ts) > TIMEOUT_DRAIN_FIFO) {\n-\t\t\t\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\t\t\t\"Timeout on RDDREQ while draining the FIFO\\n\");\n+\t\t\t\t\tpr_err(\"Timeout on RDDREQ while draining the FIFO\\n\");\n \t\t\t\t\treturn;\n \t\t\t\t}\n \t\t\t}\n@@ -641,8 +640,7 @@ static void handle_data_pio(struct pxa3xx_nand_info *info)\n \t\t\t\t DIV_ROUND_UP(info->step_spare_size, 4));\n \t\tbreak;\n \tdefault:\n-\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\"%s: invalid state %d\\n\", __func__, info->state);\n+\t\tpr_err(\"%s: invalid state %d\\n\", __func__, info->state);\n \t\tBUG();\n \t}\n \n@@ -1560,9 +1558,8 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info,\n \t\tecc->size = 512;\n \n \tif (ecc_stepsize != 512 || !(nfc_layouts[i].strength)) {\n-\t\tdev_err(info->controller.active->mtd.dev,\n-\t\t\t\"ECC strength %d at page size %d is not supported\\n\",\n-\t\t\tstrength, page_size);\n+\t\tpr_err(\"ECC strength %d at page size %d is not supported\\n\",\n+\t\t strength, page_size);\n \t\treturn -ENODEV;\n \t}\n \n","prefixes":["1/3"]}