{"id":2175260,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175260/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20251217-sqqs-v3-2-f3405fb2ad1f@foss.st.com>","date":"2025-12-17T16:45:31","name":"[v3,2/3] clk: scmi: Fix priv initialization in scmi_clk_gate()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"806396aa7f1c6f5a82b95184b6ca8247623cdf79","submitter":{"id":80709,"url":"http://patchwork.ozlabs.org/api/1.0/people/80709/?format=json","name":"Patrice Chotard","email":"patrice.chotard@foss.st.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251217-sqqs-v3-2-f3405fb2ad1f@foss.st.com/mbox/","series":[{"id":485727,"url":"http://patchwork.ozlabs.org/api/1.0/series/485727/?format=json","date":"2025-12-17T16:45:30","name":"clk: scmi: various fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/485727/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175260/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=MP2aJJkT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.b=\"MP2aJJkT\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","phobos.denx.de;\n spf=pass smtp.mailfrom=patrice.chotard@foss.st.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWfnc1zqGz1xty\n\tfor ; Thu, 18 Dec 2025 03:46:12 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7796A83B55;\n\tWed, 17 Dec 2025 17:45:44 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 0537F83BF4; Wed, 17 Dec 2025 17:45:42 +0100 (CET)","from MRWPR03CU001.outbound.protection.outlook.com\n (mail-francesouthazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c207::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E97C183B32\n for ; Wed, 17 Dec 2025 17:45:39 +0100 (CET)","from DU7P250CA0012.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:54f::25)\n by VI1PR10MB7671.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:1c1::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Wed, 17 Dec\n 2025 16:45:35 +0000","from DU2PEPF00028D13.eurprd03.prod.outlook.com\n (2603:10a6:10:54f:cafe::8f) by DU7P250CA0012.outlook.office365.com\n (2603:10a6:10:54f::25) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.6 via Frontend Transport; Wed,\n 17 Dec 2025 16:45:34 +0000","from smtpO365.st.com (164.130.1.60) by\n DU2PEPF00028D13.mail.protection.outlook.com (10.167.242.27) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9434.6 via Frontend Transport; Wed, 17 Dec 2025 16:45:34 +0000","from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com\n (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 17 Dec\n 2025 17:46:18 +0100","from localhost (10.48.87.93) by STKDAG1NODE1.st.com (10.75.128.132)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 17 Dec\n 2025 17:45:33 +0100"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS\n autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=qcMH4nY84GS9o8gCvPH33HmNxglgexZVjX+tNz0rwz1/M/j61eQYb2vel0sJ+qDi8hF4mrQs4+CKsMFHJywRmJi366f2wXsaLKlmcf007ufQIz4BCgvIV7cqscitLoebwo7N7s7LDua+EwkARnvOfytg880NUZMYBiguIvxw3Z+yAotgFNiqEWva/qc5TtRe5iH/Urx49GBvwhW4Ef1sJ0sni8Xc7oskc1TToiHQcjbJpOCMYACZaLTbDVXwowLzAW6E1fgu66mvzawHtZNkFjdgHYM68+brtaT5KOypo8lmSvlecVYE6fdmeP+27MkqgyoVKDqidw8UkJx4dOW47g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Sn8bkK6LxUrM4BHth/c+HKAfD5GxTytUEYM6SIHjmEY=;\n b=RauvA54ZLnXvpQIe+YFndGOYH1NGAA/jsqxI+2qH9P/cRy52qkIbAMF3Zt4EYwh6bO5tJ371xVxk9JX0Fy09cEuxuOwu1FN+GT2hh2EEpOBJ4bIeKAIs/znIsPtINO+97Rbwt8erPA0poF3gnCjyHfuRgnipDnlQxXRjQbOnqcRVXH7/eI2WaZqn89nqYu5WYEUAxdqD6KErEu4SJv4kqurb0xzNTQiEM2UQNILSIXG/lWKMvUSAEkRMJGnleouVSvF0GJJ+/NGHzokFFslLNU6DLLqalxm/xnWpoueI/jTJLqfA0Z9Unxiq5Xg1Kse9DPbo0frCfmSpxv0BQqJ7+Q==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 164.130.1.60) smtp.rcpttodomain=mailbox.org smtp.mailfrom=foss.st.com;\n dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Sn8bkK6LxUrM4BHth/c+HKAfD5GxTytUEYM6SIHjmEY=;\n b=MP2aJJkTEnO0oi4TZ0I2+KpYpz/NaO9YmUSNICHURqZsXJz6qBibj8l9/ae6wch77tiiju/72yOlhdb76SoPxUUMXD/q1VPr7gl7OyFRmPcaAe/JD7PMA6Y+UNonsywMXt9E9KoxjluuHHReSnyfa3J9svGXQiYW9NPw8z4T1wk08oYC7/2xv7Z8nBwmLToUNHoSaojxqBdwaytgofVE/X9vjxJXPLpDoYqvMzf0TEpgN9GCscLMdC3n6tyCIIsCnBTXf8BmXkhPNheSmxI1GUy2kgX+S6mx3YFbKJeNJl7h5hCONlIasjqmZHaQU7GRDgJblFF1zqUv+B/cOkzfWQ==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 164.130.1.60)\n smtp.mailfrom=foss.st.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=none header.from=foss.st.com;","Received-SPF":"Fail (protection.outlook.com: domain of foss.st.com does not\n designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com;\n client-ip=164.130.1.60; helo=smtpO365.st.com;","From":"Patrice Chotard ","Date":"Wed, 17 Dec 2025 17:45:31 +0100","Subject":"[PATCH v3 2/3] clk: scmi: Fix priv initialization in scmi_clk_gate()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-ID":"<20251217-sqqs-v3-2-f3405fb2ad1f@foss.st.com>","References":"<20251217-sqqs-v3-0-f3405fb2ad1f@foss.st.com>","In-Reply-To":"<20251217-sqqs-v3-0-f3405fb2ad1f@foss.st.com>","To":"Vinh Nguyen , ","CC":"Lukasz Majewski , Sean Anderson , \"Peng\n Fan\" , Tom Rini , Marek Vasut\n , Alice Guo , \"Patrick\n Delaunay\" , Valentin Caron\n , Kamlesh Gurudasani , \"Patrice\n Chotard\" ","X-Mailer":"b4 0.14.3","X-Originating-IP":"[10.48.87.93]","X-ClientProxiedBy":"ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE1.st.com\n (10.75.128.132)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DU2PEPF00028D13:EE_|VI1PR10MB7671:EE_","X-MS-Office365-Filtering-Correlation-Id":"1a792499-b62c-4875-4ffb-08de3d8bb2ba","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700013|1800799024|376014|82310400026|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?md1/j9EJucttfOhmoYii8BoGLQQKRpX?=\n\t=?utf-8?q?Yy6E1tzb7fy9JS79MO+obRMAi58zUloKeTz7nVbXYa6m/wybnF5WC/ZluZnyd+pTO?=\n\t=?utf-8?q?5gH74715FPYYMcKPiUVZhYc1e3EVEhUgOQ1NiZRor46XimLqcPxHeFhbgLYPD0FJC?=\n\t=?utf-8?q?iuYOFz3Vx6F9HNF33wb7Vk+swNgCmqffwqQzYg8g/VQvC8/84CMHhfZhPmf27zWV3?=\n\t=?utf-8?q?KUSFh+f0XPgAx07tu7Dr1mj3ud5pnnPEvR6gjd1H7p4HFNUbaCMCy/eEatoySoXnU?=\n\t=?utf-8?q?s6LR3sHBB4+0Kt6vwvER3K29DIoPGkUFfzTcUQItEgJ9H0ByJq7I3x9heSVTTthWg?=\n\t=?utf-8?q?at2r/oN1NlGDVibp+Sw/9hwu8f2+yCTitom9pkZc7BcfiVjkRCY4fFlYouweekwmv?=\n\t=?utf-8?q?e/UQ/AtSbMVxnBmwVKb4yFMPxwwJQmu1fDA2wcVElBhzvb1BxE6W884uehJGY91UN?=\n\t=?utf-8?q?iYxngwst2mFYJS1zk8Sg3Qpgno5h2U+GxW/4Y6V92bdHVAfUfN3BJeVdNm+rgwuPA?=\n\t=?utf-8?q?pKoaehwlEMRoqbqdQ9IuKXZGbBwHRLssH53UqkAnuQLNOcwNgRgtZ7OJGN68JP0Vc?=\n\t=?utf-8?q?0hasd0ngP81C9HFt6Rme06tWGNqDqRs0UAScEse7QeRVjaDDp+wloCyEs1Z6smJuB?=\n\t=?utf-8?q?nnote09S/v3JUW9JurjYsOv8L1vJJSX1tVvbE6U+1hjZQXrYBKVpod+8GcXb/KRSF?=\n\t=?utf-8?q?nM2Qaqe5nHfWW6M1wfIaucbmWY5MOZOmebegrOd1hKjr0D1froWSJyJfvJ5+NRP/e?=\n\t=?utf-8?q?qKnoRwj4UGc+WA1WVdcmQ+Mi4grkt2fsHJ4dzVZeHIcVxWvnsm6BOFTLse7Q311A+?=\n\t=?utf-8?q?/gz0lDHWlzhfze2ogolQuEdjZQJGJ0NG4bl3DeChajoRR7eUc6mG7j1kQ1WEpZevi?=\n\t=?utf-8?q?V9+MMDJV/UN9m7kcCMMPeCBaxPpzff7XAAoka2wt52UvP+d47FAEnF9xxZASQQ7Q0?=\n\t=?utf-8?q?+BCTU5ORJWUPORngxTE8ImylKlRyZZ1/+AZO0vI4cpA5A38i1fmf0J/RcKLvUT7JO?=\n\t=?utf-8?q?a4z7l4BVKkSW48oLV7TP4INm/F0/s76eH0wy/Tln/Q5uMhrRVQNFVRvKOCbxeptzm?=\n\t=?utf-8?q?KOl7R+RW3DFx/ppuFkwjGyroZDx6dNily1QAGQM4RU5gxZriCBAk37S+AywIHF4rP?=\n\t=?utf-8?q?lneZ/K0sH0h6Ko8xzA3c5G66FdpPzHVw/ypnTAK2uSoIRlkEt+aiyzl1hFBnllzdt?=\n\t=?utf-8?q?xcP2c6SWg5TE1Frv9LFwqoyNPi9oxT/JrHYgapISgugJ+KE7wxxwY/6zzFS65yULd?=\n\t=?utf-8?q?Y6bHDTE6EZhjtpnfx/30Icm6IAf2iaL8Svu7Xyqf/OPoimu1bVRrKhdbR5bgV+eyE?=\n\t=?utf-8?q?pvVeRk8nnMXcJeRQr3YxE5kou2L9zKuEhbcbjrzYZaJWy9Zqm4MvB737d2voXgjtR?=\n\t=?utf-8?q?t505CvrOSjqwCgsJdi/oY6cV+HBfI/QZakf/pRKdPfF4dreGogOcUlUe48wXuzTXG?=\n\t=?utf-8?q?UvVWlno6z94lIdMAMHndzSDqXhZ1+wJdcH2nyrso/kGp/Ey/j88Ao=3D?=","X-Forefront-Antispam-Report":"CIP:164.130.1.60; CTRY:IT; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026)(7053199007);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0":"\n Jsuf4rmVSnc0i/8ItDeG0jmlKI6+OKFlk4K9E9zXsp8D+W0kE+9qRn+DT/PqTjOsv0Z+epd5sVR3rbUD08Ml3T/394fRRYBLhOdcfpdzILmIAZO1+crMyPj0+kmf1ADfs1ZJN9j6RpCi8cc66mqUCLYIVhsZpWFpUxBJnRmiDqdwvMNrH6kOQc4yeqcdtWZ+u9RokKH2BnpMRqXgZvNIDmVrJkU7eQ6nx0+5QGLnvk85+uulYzCI+Du7lOcM1x11YQkgZWGn/Hlgxmu2ocmOT9FyjWQdyVuTB7qLqWKVkSVm+aARVLrYpEAABcZuy7u/oqG3ysIhXKwVumWfreX5NT4yKr7V0CfKhnDITaXc/yELtG4L2DXsgK0x1cqF/GKriabsFy5oQ43VYulQm2RNvecD9wVxL590ZNAxPbGcCuJQnt4WAPQjGrvm4Tcm5RnN2OYrAaAX5GbShL/FVr4czZHN/shWL3WMKs+vcyF90ZsT/moFG6KTXZqpg36acLgjSyrfIO5j8KUiDVv8gsBj3L+rSvUd7o/mVkzMhOuDEXCRlsjxExopK92PHATHrovzwOJP3zTkR/7IBJA6za9aMS434sA/j24lxSu0326TRSe4G7/Uh23jDNjZ+bArKH97GOy7JoBvbo84O7D4B4yjv8P0Biy9Tzpps9beS87AjJBz2kyT+9NGL/aGk447dI2QQ3/kv8pD5NF2uWyM8pTVmw==","X-OriginatorOrg":"foss.st.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Dec 2025 16:45:34.0426 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 1a792499-b62c-4875-4ffb-08de3d8bb2ba","X-MS-Exchange-CrossTenant-Id":"75e027c9-20d5-47d5-b82f-77d7cd041e8f","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; Ip=[164.130.1.60];\n Helo=[smtpO365.st.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n DU2PEPF00028D13.eurprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR10MB7671","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"In scmi_clk_probe(), in case of CLK_CCF is not enabled, parent private\ndata is not set, so in scmi_clk_gate(), an uninitialized priv struct is\nretrieved.\n\nSCMI request is performed either using scmi_clk_state_in_v1 or\nscmi_clk_state_in_v2 struct depending of the unpredictable value of\npriv->version which leads to error during SCMI clock enable.\n\nIssue detected on STM32MP157C-DK2 board using the SCMI device tree\nstm32mp157c-dk2-scmi.dts.\n\nFixes: 0619cb32030b (\"firmware: scmi: Add clock v3.2 CONFIG_SET support\")\n\nSigned-off-by: Patrice Chotard \n\nCc: Alice Guo \nCc: Marek Vasut \nCc: Patrick Delaunay \nCc: Peng Fan \nCc: Sean Anderson \nCc: Tom Rini \nCc: Valentin Caron \nCc: Vinh Nguyen \nCc: u-boot@lists.denx.de\nReviewed-by: Peng Fan \n---\n drivers/clk/clk_scmi.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/clk/clk_scmi.c b/drivers/clk/clk_scmi.c\nindex f6132178205..3dcb18a7664 100644\n--- a/drivers/clk/clk_scmi.c\n+++ b/drivers/clk/clk_scmi.c\n@@ -137,7 +137,7 @@ static int scmi_clk_get_attribute(struct udevice *dev, int clkid, char *name,\n \n static int scmi_clk_gate(struct clk *clk, int enable)\n {\n-\tstruct scmi_clock_priv *priv = dev_get_parent_priv(clk->dev);\n+\tstruct scmi_clock_priv *priv;\n \tstruct scmi_clk_state_in_v1 in_v1 = {\n \t\t.clock_id = clk_get_id(clk),\n \t\t.attributes = enable,\n@@ -156,6 +156,15 @@ static int scmi_clk_gate(struct clk *clk, int enable)\n \t\t\t\t\t in_v2, out);\n \tint ret;\n \n+\t/*\n+\t * retrieve the correct priv which was set in scmi_clk_probe().\n+\t * in case CLK_CCF is set, priv was set in parent_priv\n+\t */\n+\tif (CONFIG_IS_ENABLED(CLK_CCF))\n+\t\tpriv = dev_get_parent_priv(clk->dev);\n+\telse\n+\t\tpriv = dev_get_priv(clk->dev);\n+\n \tret = devm_scmi_process_msg(clk->dev,\n \t\t\t\t (priv->version < CLOCK_PROTOCOL_VERSION_2_1) ?\n \t\t\t\t &msg_v1 : &msg_v2);\n","prefixes":["v3","2/3"]}