{"id":2175178,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175178/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251217143150.94463-6-philmd@linaro.org>","date":"2025-12-17T14:31:41","name":"[05/14] system/physmem: Inline and remove leul_to_cpu()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"be9de4ee804747e257ae85af144c94b519c7671b","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251217143150.94463-6-philmd@linaro.org/mbox/","series":[{"id":485701,"url":"http://patchwork.ozlabs.org/api/1.0/series/485701/?format=json","date":"2025-12-17T14:31:37","name":"system/memory: Clean ups around address_space_ldst() endian variants","version":1,"mbox":"http://patchwork.ozlabs.org/series/485701/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175178/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=VWkuVG6W;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWbsf5x5Dz1y0P\n\tfor ; Thu, 18 Dec 2025 01:34:30 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vVsaK-0001lg-MU; Wed, 17 Dec 2025 09:33:01 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vVsa0-0001cs-AM\n for qemu-devel@nongnu.org; Wed, 17 Dec 2025 09:32:45 -0500","from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vVsZu-00077C-83\n for qemu-devel@nongnu.org; Wed, 17 Dec 2025 09:32:37 -0500","by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-477a2ab455fso62288745e9.3\n for ; Wed, 17 Dec 2025 06:32:33 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-47bdc1d991fsm43795515e9.5.2025.12.17.06.32.29\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 17 Dec 2025 06:32:29 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1765981951; x=1766586751; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KntzN84E4rzQNF1VjNRRJJcnloDQTOOHWlgvhj9Q7tw=;\n b=VWkuVG6WKOP0u0MG2u5MISu6YYeCGVYrI3RCuYc3g1IYScwMVMpsQ742MasKzgItbH\n A+EAAJ6BYoK1RVf3VD9xxDHvA9whGzJG/XxznZGOwLLklFQHr9yQqTXlrUDZ+u5AH+KN\n WWewDqscsJK2fDgrK/K+DK44V+yL35bUpSKmTdwcYierTdy6uznFDRSUYD9ZuJopCPgO\n Y4qsoFmH4XE5WKYUK2iRgLdQJfZoTPia8AYiV7UyKpjxx6WzaPCpUH6wIxT5xUNU1ZYa\n U9R3/KIzZaeFbTcBUIO3fRZ3w4GKGkBUIFA6bM3PO5Loy+WUkylqACXRZFnYYpUwXF5N\n YJ8Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765981951; x=1766586751;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=KntzN84E4rzQNF1VjNRRJJcnloDQTOOHWlgvhj9Q7tw=;\n b=Y5Xm3I/BIsyrb6Af0PROAqa2o1P9zZzIeqo+5HyArPM8WdPWk+iAJkYS70DcS5xAFY\n MBTSFK4WtUXrKZqCOKG6nWodwX3K8wqSjIoIAfWpSr3yEDrXEIiFpqVC0zklW0UOVMdd\n JOSAO0IccEKTVgXR9m5bn+TabKN0zwNtu8LhXxbg9gL7hvWxd2EfLGPOqNN3W9UVoZwv\n /ePLES59GE25h+l9cwdtj18C4h8fcdGZNx8f0sYtgPu0Mt7BqaQ8KduMSWLsC3Bwqzah\n DC4KMPKp8ocROYIGp0+s7TLWW/KGGIDLTHQJuqocPgH9EdZGJoDqD4tOAwjCI/hwYc0+\n HqvQ==","X-Gm-Message-State":"AOJu0YzjQpjYKf16zIZBpC3Y4gD3RtFH+CBqr4I547w7QRd3FqDh7Xew\n nZtYs/eRbbS/L+k0t+ci2afO6T59LB2t/OWvHPCjHuckp2m7L5xd62gSXeHtogAZO8Luhs+UL3b\n 5E2l5qTbXZQ==","X-Gm-Gg":"AY/fxX5OP/s9RLnfWWBP1HnuAfLAG4+PGOyx7B9R9EIsSRR3GeKwnjuWaWvjhNLlO2f\n Bj8VYsWWo7zG4EYI73PYomVdHRKO9RYziD/wGUWrwQz83S+V0BJroDm6d4gqud01XBISxISKn6S\n x2BKwp6zqXeAVcZXONREZ6O6WLn5uQbyi284sPGabOYsOOA66wwpAzMFvuE/zKf4UjWN2L7JZ7J\n gVA9r0soAv+avxJhhZdaFbKrnChSLiDq4KeT8A3Yl8a0ENSfd6g4IpTJIDfgJgCFu7OV/h5NwoJ\n sNuYU3/PkBYYsYngzTCKyZlP06u8DDnwhXGiUlmg0Gfm48FJKf1VhWpqxFhQZXFQ2NAAuaH2bnf\n LL84bT5hkIPn81lXEgNjLodh486bH2osxhCcTuIcXbxvkvPCj/CyzB2qWmaZta+TWfC0b1wH8Ci\n yqKXxpWbfq8PelpJdiH8Y1UzF7i7194KWsYbV5totBU6omYuYCQFlRlNzrDXVK","X-Google-Smtp-Source":"\n AGHT+IHrmxo58cjk+Ja06ElhCpkbSBp2FLjbJkIVoKszjZU6CJuvhE8j6Kof7/fmcIJtOA46T/2vyw==","X-Received":"by 2002:a05:600c:4e09:b0:477:9976:9e1a with SMTP id\n 5b1f17b1804b1-47a8f89bc6cmr199436695e9.6.1765981951134;\n Wed, 17 Dec 2025 06:32:31 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Anton Johansson , qemu-arm@nongnu.org,\n Mark Cave-Ayland ,\n Paolo Bonzini , \"Michael S. Tsirkin\" ,\n Artyom Tarasenko ,\n Peter Maydell ,\n David Hildenbrand , Peter Xu ","Subject":"[PATCH 05/14] system/physmem: Inline and remove leul_to_cpu()","Date":"Wed, 17 Dec 2025 15:31:41 +0100","Message-ID":"<20251217143150.94463-6-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251217143150.94463-1-philmd@linaro.org>","References":"<20251217143150.94463-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::330;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"leul_to_cpu() is only used within physmem.c: inline it\nand remove.\nSince @bitmap is of 'unsigned long' type, use its size\nwith ldn_le_p() instead of using HOST_LONG_BITS.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n include/qemu/bswap.h | 11 -----------\n system/physmem.c | 5 +++--\n 2 files changed, 3 insertions(+), 13 deletions(-)","diff":"diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h\nindex 39ba64046a6..65a1b3634f4 100644\n--- a/include/qemu/bswap.h\n+++ b/include/qemu/bswap.h\n@@ -375,17 +375,6 @@ static inline void stq_be_p(void *ptr, uint64_t v)\n stq_he_p(ptr, be_bswap(v, 64));\n }\n \n-static inline unsigned long leul_to_cpu(unsigned long v)\n-{\n-#if HOST_LONG_BITS == 32\n- return le_bswap(v, 32);\n-#elif HOST_LONG_BITS == 64\n- return le_bswap(v, 64);\n-#else\n-# error Unknown sizeof long\n-#endif\n-}\n-\n /* Store v to p as a sz byte value in host order */\n #define DO_STN_LDN_P(END) \\\n static inline void stn_## END ## _p(void *ptr, int sz, uint64_t v) \\\ndiff --git a/system/physmem.c b/system/physmem.c\nindex c9869e4049f..1292f49095f 100644\n--- a/system/physmem.c\n+++ b/system/physmem.c\n@@ -1254,7 +1254,8 @@ uint64_t physical_memory_set_dirty_lebitmap(unsigned long *bitmap,\n \n for (k = 0; k < nr; k++) {\n if (bitmap[k]) {\n- unsigned long temp = leul_to_cpu(bitmap[k]);\n+ unsigned long temp = ldn_le_p(&bitmap[k],\n+ sizeof(bitmap[k]));\n \n nbits = ctpopl(temp);\n qatomic_or(&blocks[DIRTY_MEMORY_VGA][idx][offset], temp);\n@@ -1301,7 +1302,7 @@ uint64_t physical_memory_set_dirty_lebitmap(unsigned long *bitmap,\n */\n for (i = 0; i < len; i++) {\n if (bitmap[i] != 0) {\n- c = leul_to_cpu(bitmap[i]);\n+ c = ldn_le_p(&bitmap[i], sizeof(bitmap[i]));\n nbits = ctpopl(c);\n if (unlikely(global_dirty_tracking & GLOBAL_DIRTY_DIRTY_RATE)) {\n total_dirty_pages += nbits;\n","prefixes":["05/14"]}