{"id":2175096,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2175096/?format=json","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.0/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251217-s5m-alarm-v2-2-b7bff003e94c@linaro.org>","date":"2025-12-17T10:10:49","name":"[RESEND,v2,2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"052b7af1fdd36eac1cf5c26f6992100f19bde97e","submitter":{"id":87400,"url":"http://patchwork.ozlabs.org/api/1.0/people/87400/?format=json","name":"André Draszik","email":"andre.draszik@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20251217-s5m-alarm-v2-2-b7bff003e94c@linaro.org/mbox/","series":[{"id":485656,"url":"http://patchwork.ozlabs.org/api/1.0/series/485656/?format=json","date":"2025-12-17T10:10:50","name":"Samsung mfd/rtc driver alarm IRQ simplification","version":2,"mbox":"http://patchwork.ozlabs.org/series/485656/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2175096/checks/","tags":{},"headers":{"Return-Path":"\n <linux-rtc+bounces-5583-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZZCbCOny;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-5583-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=\"ZZCbCOny\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.218.42","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linaro.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWW5Z0PFLz1xpw\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 17 Dec 2025 21:59:30 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 1E6BA31E936E\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 17 Dec 2025 10:49:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3959D2DC792;\n\tWed, 17 Dec 2025 10:11:01 +0000 (UTC)","from mail-ej1-f42.google.com (mail-ej1-f42.google.com\n [209.85.218.42])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC3830F7F6\n\tfor <linux-rtc@vger.kernel.org>; Wed, 17 Dec 2025 10:10:57 +0000 (UTC)","by mail-ej1-f42.google.com with SMTP id\n a640c23a62f3a-b7cf4a975d2so956010566b.2\n        for <linux-rtc@vger.kernel.org>; Wed, 17 Dec 2025 02:10:57 -0800 (PST)","from puffmais2.c.googlers.com\n (244.175.141.34.bc.googleusercontent.com. [34.141.175.244])\n        by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-64b3f4f5a22sm2043811a12.9.2025.12.17.02.10.55\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Wed, 17 Dec 2025 02:10:55 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1765966261; cv=none;\n b=DbQ9BBLlr5jCxXXN80bTLc6hQCTZuHhwdexdiYYGQDQnL1P7GueNvzH/dNyyrqBHPAF7Ge0NB5PXJqKd1l9b/HMegumuJee3itQeKzOEzXDGp44U9Yj5Qow4tT05tt6BIzW80A54ittA1SZsfS9w9LL24XrBYpmS6lYT0K9nfyM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1765966261; c=relaxed/simple;\n\tbh=H6IMjnPI8ZwYq64P5YA/CKhuGWLFID4mb3NAeF/Wkyc=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=aDHjLobJlfIIee7/NgrCM7ShEi/fsM+f1gBT96fqODVzBrHELXL7/oJjkETeGpsz08Qfp4hFiT226ONJ+a1r4y7TmGcsakbhrHVQe9CAjkLk1oPAXVBAvGdroE/HFeQxz4O/XMLrkBSyS0G9DrjGaMErJQel21VMO1YT7Yo2lBk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org;\n spf=pass smtp.mailfrom=linaro.org;\n dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=ZZCbCOny; arc=none smtp.client-ip=209.85.218.42","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=linaro.org; s=google; t=1765966256; x=1766571056;\n darn=vger.kernel.org;\n        h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n         :reply-to;\n        bh=eXjtVLazU4FisU7iYDrCs/cvEQo0Kb5lMS6lWuXDtFU=;\n        b=ZZCbCOnyoob/cYwp4TjRRXMFpsBeO/8susIx1iu2K3LQO7UFhY/fyIMEdyzZzkE5xU\n         VU9X651P/DEne1HlKkZQOqfkhgK35p3r07lOLDkSyVmI2WsdXB4W0WLj9XCBGLDsIxFr\n         D02RrChZJr20pClz+h7E3bqNXSo3BCneelwF+Gtbt45JyiBC2QXdYVKaqxnxKnMAskY+\n         eMhEao0N2TpJrbElvQ0yxZkn1k2ZiNPUQu8dqv+vWsvE8fq4qPwwrFpht+rtNjma14tI\n         nfAmUYnvvYqsq3/amO/96wg/boz3t3abJUgn6RP2yT8Ir9xRNjG0ThD7R6KqB4QOUL5D\n         Dj3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20230601; t=1765966256; x=1766571056;\n        h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n         :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n         :cc:subject:date:message-id:reply-to;\n        bh=eXjtVLazU4FisU7iYDrCs/cvEQo0Kb5lMS6lWuXDtFU=;\n        b=oylUa8aAMYoRJTLuYiseF34tRhLu2vSmLYpkY08bpzGfBFet/Hb59/vWOxcefCters\n         SV4RYbvPZO+p/kEi7J+y/H1qV3zeEIoh2db3of0Gv4aB6dU6Xdt/XuQ6wUyyKmSZKOxg\n         LCeDdp5BlynhKXRr1mBc1kl/AffV1waBcs+0loD65KC8ycyAK1Ap0z50SmtC99AOjrVh\n         QsD4CTSR4C7OUcVWSZN+j96dhz9FTg+TD7Xrbm/km+TDgd3Y+eEc9z5JnED2HweyNSDy\n         xyOQhhANdBkoaU/omLQ6TwiL8DtPWDfDy4bIqsXhKle6lJMgrgFCvlG1R0gxDTzZ02b2\n         fjBQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXiNE75/AKiTK158W9u+44li1vbsSp6VqjYNUqtajNdKNfBPVvMfBpobyNfbzBibCw90rTL3HZd4Rk=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yxe+cYcNzlZnJ1THyJ2jMYrPQuH5dTsJoBfaIrpRQEZSXITj9jx\n\t8Rb9g1ZHoCejfq0pJua8Io8bFRYuZz5TBg8N6Yv9GR4s3j2EaDZtuW1+sB8OCoLPjpU=","X-Gm-Gg":"AY/fxX6JugutDCqhh6szaW6u8ze1/6/32JXBB3LPIWY+ELUJvveWQqV2/Adkv1nAN7T\n\tOMZJrgeKARr+lY0M+Mzhws8lVK1jYxZd2h74SBbNOnE3bQGbTxrQjDDMVRZ1zyZwoFcPUaPHfiY\n\t46T7tNId40jr0X7VBtWiduCA3ovuFrJDHrfh8tjSxRySkxtR8vpsdPZ9/M6LcryoJuHkhZP4GO0\n\tIeGNj/yrJnj2YDzgEGKc6bWEHhZGT0WRnM45IdI5vcAas+VsC9y5hVpMKmhFY3O8RQNOJoEAUii\n\t6tLrAeKEsL1EiTz51txmeLwyOKdwo5Ztc2OBAV7NK1hBpc//uzO5grUP1NBGBt7HCK6hzMwh0BH\n\t6mB2WUNaORdpKHQnaMGoEpu0ucMM0RTBcf/2MrBd7DoenDKbWP34z6Vp7y1BNoctIML4dj19KMT\n\tXFzJlHZAnUB5ngcNFwzJlPxtgnBGrnLn9rmD3ut1JKtPLnmQENpLZ5cUAR4TPFceyE0n7dxyOcU\n\tqgtdw==","X-Google-Smtp-Source":"\n AGHT+IHyMM6etwDYB06WTSrwaBUmwLHwdFRBAH3MZ0Riio860UC6heeeZnSPn7h1ka6K1Zx6Y3HXtw==","X-Received":"by 2002:a17:907:6d24:b0:b7a:1bde:1223 with SMTP id\n a640c23a62f3a-b7d23ad88e6mr1656378566b.64.1765966255551;\n        Wed, 17 Dec 2025 02:10:55 -0800 (PST)","From":"=?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>","Date":"Wed, 17 Dec 2025 10:10:49 +0000","Subject":"[PATCH RESEND v2 2/3] rtc: s5m: query platform device IRQ resource\n for alarm IRQ","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"<linux-rtc.vger.kernel.org>","List-Subscribe":"<mailto:linux-rtc+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-rtc+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20251217-s5m-alarm-v2-2-b7bff003e94c@linaro.org>","References":"<20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org>","In-Reply-To":"<20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org>","To":"Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,\n Alexandre Belloni <alexandre.belloni@bootlin.com>","Cc":"Peter Griffin <peter.griffin@linaro.org>,\n  Tudor Ambarus <tudor.ambarus@linaro.org>,\n  Will McVicker <willmcvicker@google.com>, Juan Yescas <jyescas@google.com>,\n  Douglas Anderson <dianders@chromium.org>, kernel-team@android.com,\n  Kaustabh Chakraborty <kauschluss@disroot.org>, linux-kernel@vger.kernel.org,\n  linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?An?=\n\t=?utf-8?q?dr=C3=A9_Draszik?= <andre.draszik@linaro.org>","X-Mailer":"b4 0.14.2"},"content":"The core driver now exposes the alarm IRQ as a resource, so we can drop\nthe lookup from here to simplify the code and make adding support for\nadditional variants easier in this driver.\n\nAcked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>\nSigned-off-by: André Draszik <andre.draszik@linaro.org>\n---\n drivers/rtc/rtc-s5m.c | 21 ++++++++-------------\n 1 file changed, 8 insertions(+), 13 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c\nindex a7220b4d0e8dd35786b060e2a4106e2a39fe743f..c6ed5a4ca8a0e4554b1c88c879b01fc384735007 100644\n--- a/drivers/rtc/rtc-s5m.c\n+++ b/drivers/rtc/rtc-s5m.c\n@@ -15,7 +15,6 @@\n #include <linux/rtc.h>\n #include <linux/platform_device.h>\n #include <linux/mfd/samsung/core.h>\n-#include <linux/mfd/samsung/irq.h>\n #include <linux/mfd/samsung/rtc.h>\n #include <linux/mfd/samsung/s2mps14.h>\n \n@@ -683,22 +682,18 @@ static int s5m_rtc_probe(struct platform_device *pdev)\n \t\tcase S2MPS15X:\n \t\t\tregmap_cfg = &s2mps14_rtc_regmap_config;\n \t\t\tinfo->regs = &s2mps15_rtc_regs;\n-\t\t\talarm_irq = S2MPS14_IRQ_RTCA0;\n \t\t\tbreak;\n \t\tcase S2MPS14X:\n \t\t\tregmap_cfg = &s2mps14_rtc_regmap_config;\n \t\t\tinfo->regs = &s2mps14_rtc_regs;\n-\t\t\talarm_irq = S2MPS14_IRQ_RTCA0;\n \t\t\tbreak;\n \t\tcase S2MPS13X:\n \t\t\tregmap_cfg = &s2mps14_rtc_regmap_config;\n \t\t\tinfo->regs = &s2mps13_rtc_regs;\n-\t\t\talarm_irq = S2MPS14_IRQ_RTCA0;\n \t\t\tbreak;\n \t\tcase S5M8767X:\n \t\t\tregmap_cfg = &s5m_rtc_regmap_config;\n \t\t\tinfo->regs = &s5m_rtc_regs;\n-\t\t\talarm_irq = S5M8767_IRQ_RTCA1;\n \t\t\tbreak;\n \t\tdefault:\n \t\t\treturn dev_err_probe(&pdev->dev, -ENODEV,\n@@ -719,7 +714,6 @@ static int s5m_rtc_probe(struct platform_device *pdev)\n \t\t\t\t\t     \"Failed to allocate regmap\\n\");\n \t} else if (device_type == S2MPG10) {\n \t\tinfo->regs = &s2mpg10_rtc_regs;\n-\t\talarm_irq = S2MPG10_IRQ_RTCA0;\n \t} else {\n \t\treturn dev_err_probe(&pdev->dev, -ENODEV,\n \t\t\t\t     \"Unsupported device type %d\\n\",\n@@ -730,13 +724,14 @@ static int s5m_rtc_probe(struct platform_device *pdev)\n \tinfo->s5m87xx = s5m87xx;\n \tinfo->device_type = device_type;\n \n-\tif (s5m87xx->irq_data) {\n-\t\tinfo->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq);\n-\t\tif (info->irq <= 0)\n-\t\t\treturn dev_err_probe(&pdev->dev, -EINVAL,\n-\t\t\t\t\t     \"Failed to get virtual IRQ %d\\n\",\n-\t\t\t\t\t     alarm_irq);\n-\t}\n+\talarm_irq = platform_get_irq_byname_optional(pdev, \"alarm\");\n+\tif (alarm_irq > 0)\n+\t\tinfo->irq = alarm_irq;\n+\telse if (alarm_irq == -ENXIO)\n+\t\tinfo->irq = 0;\n+\telse\n+\t\treturn dev_err_probe(&pdev->dev, alarm_irq ? : -EINVAL,\n+\t\t\t\t     \"IRQ 'alarm' not found\\n\");\n \n \tplatform_set_drvdata(pdev, info);\n \n","prefixes":["RESEND","v2","2/3"]}