{"id":195,"url":"http://patchwork.ozlabs.org/api/1.0/patches/195/?format=json","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.0/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1220847899-22189-1-git-send-email-gerickson@nuovations.com>","date":"2008-09-08T04:24:54","name":"nandwrite: Qualifier Clean-up","commit_ref":"85eac85a5bc3bdabf31f148c763ef720292d1e32","pull_url":null,"state":"accepted","archived":false,"hash":"22e3d7840ce97ec7a0a506bab2e1ccdd01ff346f","submitter":{"id":115,"url":"http://patchwork.ozlabs.org/api/1.0/people/115/?format=json","name":"Grant Erickson","email":"gerickson@nuovations.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1220847899-22189-1-git-send-email-gerickson@nuovations.com/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/195/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 42CC6DDDD4\n\tfor ; Mon, 8 Sep 2008 14:25:25 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcYJF-0006TJ-72; Mon, 08 Sep 2008 04:25:05 +0000","from relay00.pair.com ([209.68.5.9])\n\tby bombadil.infradead.org with smtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcYJC-0006Pb-Qv\n\tfor linux-mtd@lists.infradead.org; Mon, 08 Sep 2008 04:25:03 +0000","(qmail 35948 invoked by uid 0); 8 Sep 2008 04:25:00 -0000","from unknown (HELO localhost.localdomain) (unknown)\n\tby unknown with SMTP; 8 Sep 2008 04:25:00 -0000"],"X-pair-Authenticated":"66.134.71.115","From":"Grant Erickson ","To":"linux-mtd@lists.infradead.org","Subject":"[PATCH 1/6] [MTD-UTILS] nandwrite: Qualifier Clean-up","Date":"Sun, 7 Sep 2008 21:24:54 -0700","Message-Id":"<1220847899-22189-1-git-send-email-gerickson@nuovations.com>","X-Mailer":"git-send-email 1.6.0.1","Organization":"Nuovation System Designs, LLC","X-Spam-Score":"-1.0 (-)","X-Spam-Report":"SpamAssassin version 3.2.5 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.0 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [209.68.5.9 listed in list.dnswl.org]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"},"content":"Static-qualified all globals except 'main' because they have no use\nbeyond file scope.\nConstant-qualified MTD device and input positional parameter globals.\nConstant-qualified argv array.\n\nSigned-off-by: Grant Erickson ","diff":"diff --git a/nandwrite.c b/nandwrite.c\nindex e745fba..8e0609d 100644\n--- a/nandwrite.c\n+++ b/nandwrite.c\n@@ -45,32 +45,32 @@\n /*\n * Buffer array used for writing data\n */\n-unsigned char writebuf[MAX_PAGE_SIZE];\n-unsigned char oobbuf[MAX_OOB_SIZE];\n-unsigned char oobreadbuf[MAX_OOB_SIZE];\n+static unsigned char writebuf[MAX_PAGE_SIZE];\n+static unsigned char oobbuf[MAX_OOB_SIZE];\n+static unsigned char oobreadbuf[MAX_OOB_SIZE];\n \n // oob layouts to pass into the kernel as default\n-struct nand_oobinfo none_oobinfo = {\n+static struct nand_oobinfo none_oobinfo = {\n \t.useecc = MTD_NANDECC_OFF,\n };\n \n-struct nand_oobinfo jffs2_oobinfo = {\n+static struct nand_oobinfo jffs2_oobinfo = {\n \t.useecc = MTD_NANDECC_PLACE,\n \t.eccbytes = 6,\n \t.eccpos = { 0, 1, 2, 3, 6, 7 }\n };\n \n-struct nand_oobinfo yaffs_oobinfo = {\n+static struct nand_oobinfo yaffs_oobinfo = {\n \t.useecc = MTD_NANDECC_PLACE,\n \t.eccbytes = 6,\n \t.eccpos = { 8, 9, 10, 13, 14, 15}\n };\n \n-struct nand_oobinfo autoplace_oobinfo = {\n+static struct nand_oobinfo autoplace_oobinfo = {\n \t.useecc = MTD_NANDECC_AUTOPLACE\n };\n \n-void display_help (void)\n+static void display_help (void)\n {\n \tprintf(\"Usage: nandwrite [OPTION] MTD_DEVICE INPUTFILE\\n\"\n \t\t\t\"Writes to the specified MTD device.\\n\"\n@@ -91,7 +91,7 @@ void display_help (void)\n \texit(0);\n }\n \n-void display_version (void)\n+static void display_version (void)\n {\n \tprintf(PROGRAM \" \" VERSION \"\\n\"\n \t\t\t\"\\n\"\n@@ -106,20 +106,20 @@ void display_version (void)\n \texit(0);\n }\n \n-char\t*mtd_device, *img;\n-int\tmtdoffset = 0;\n-int\tquiet = 0;\n-int\twriteoob = 0;\n-int\tmarkbad = 0;\n-int\tautoplace = 0;\n-int\tforcejffs2 = 0;\n-int\tforceyaffs = 0;\n-int\tforcelegacy = 0;\n-int\tnoecc = 0;\n-int\tpad = 0;\n-int\tblockalign = 1; /*default to using 16K block size */\n-\n-void process_options (int argc, char *argv[])\n+static const char\t*mtd_device, *img;\n+static int\t\tmtdoffset = 0;\n+static int\t\tquiet = 0;\n+static int\t\twriteoob = 0;\n+static int\t\tmarkbad = 0;\n+static int\t\tautoplace = 0;\n+static int\t\tforcejffs2 = 0;\n+static int\t\tforceyaffs = 0;\n+static int\t\tforcelegacy = 0;\n+static int\t\tnoecc = 0;\n+static int\t\tpad = 0;\n+static int\t\tblockalign = 1; /*default to using 16K block size */\n+\n+static void process_options (int argc, char * const argv[])\n {\n \tint error = 0;\n \n@@ -209,7 +209,7 @@ void process_options (int argc, char *argv[])\n /*\n * Main program\n */\n-int main(int argc, char **argv)\n+int main(int argc, char * const argv[])\n {\n \tint cnt, fd, ifd, imglen = 0, pagelen, baderaseblock, blockstart = -1;\n \tstruct mtd_info_user meminfo;\n","prefixes":[]}