{"id":808639,"url":"http://patchwork.ozlabs.org/api/1.0/covers/808639/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901112829.2571-1-apahim@redhat.com>","date":"2017-09-01T11:28:16","name":"[v8,00/13] scripts/qemu.py fixes and cleanups","submitter":{"id":71999,"url":"http://patchwork.ozlabs.org/api/1.0/people/71999/?format=json","name":"Amador Pahim","email":"apahim@redhat.com"},"series":[{"id":1006,"url":"http://patchwork.ozlabs.org/api/1.0/series/1006/?format=json","date":"2017-09-01T11:28:16","name":"scripts/qemu.py fixes and cleanups","version":8,"mbox":"http://patchwork.ozlabs.org/series/1006/mbox/"}],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=apahim@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHCH5GRRz9sRV\n\tfor ;\n\tFri, 1 Sep 2017 21:32:10 +1000 (AEST)","from localhost ([::1]:36362 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnkBE-0000wf-23\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:32:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59550)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnkAY-0000vs-An\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnkAV-0006et-48\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:26 -0400","from mx1.redhat.com ([209.132.183.28]:35358)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnkAU-0006eW-Uf\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:23 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3C3AF4023B;\n\tFri, 1 Sep 2017 11:31:21 +0000 (UTC)","from t460p.pahim.org.com (ovpn-204-134.brq.redhat.com\n\t[10.40.204.134])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 16D577EBF0;\n\tFri, 1 Sep 2017 11:31:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3C3AF4023B","From":"Amador Pahim ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 13:28:16 +0200","Message-Id":"<20170901112829.2571-1-apahim@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 01 Sep 2017 11:31:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com,\n\tehabkost@redhat.com, \n\tstefanha@gmail.com, Amador Pahim ,\n\tarmbru@redhat.com, mreitz@redhat.com, crosa@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Changes v1->v2:\n - Style fixes to make checkpatch.pl happy.\n - Rebased.\nChanges v2->v3:\n - Fix typo in patch 3 (\"qemu.py: make 'args' public\") commit message.\nChanges v3->v4:\n - Squash the 2 first commits since they are co-dependant.\n - Cleanup launch() and shutdown().\n - Reorder the commits, putting the rename of self._args first.\n - Rebased.\nChanges v4->v5:\n - Break the cleanup commit into logical changes and include in the\n commit messages the rationale for making them.\nChanges v5->v6:\n - Remove the commit to rename self._args.\n - Fix is_running() return before first call to maunch().\n - Use python logging system.\n - Include the full command line on negative exit code error message.\n - Use os.path.null instead of /dev/null.\n - Improve the control over the created/deleted files.\nChanges v6->v7:\n - Split commits in self-contained/atomic changes.\n - Addressed the comments from previous version, basically improving the\n logging messages and the control over created files. See individual\n commit messages for details.\nChanges v7->v8:\n - Rebased.\n - Reorder commits to avoid break->fix sequence.\n - Split commits \"use poll() instead of 'returncode'\" and \"refactor\n launch()\".\n - Don't ignore errors in _load_io_log(). Instead, check if we created\n the file before reading it.\n - Use LOG.warn() instead of LOG.debug() for the negative exit code\n message.\n - Fix the exception name called in commits \"launch vm only if it's not\n running\" and \"don't launch again before shutdown()\".\n - Minor style fixes.\n\nAmador Pahim (13):\n qemu.py: fix is_running() return before first launch()\n qemu.py: avoid writing to stdout/stderr\n qemu.py: use os.path.null instead of /dev/null\n qemu.py: improve message on negative exit code\n qemu.py: include debug information on launch error\n qemu.py: make sure we only remove files we create\n qemu.py: close _qemu_log_path on cleanup\n qemu.py: refactor launch()\n qemu.py: always cleanup on shutdown()\n qemu.py: use poll() instead of 'returncode'\n qemu.py: cleanup redundant calls in launch()\n qemu.py: launch vm only if it's not running\n qemu.py: don't launch again before shutdown()\n\n scripts/qemu.py | 136 +++++++++++++++++++++++++++++++++++++++++---------------\n 1 file changed, 101 insertions(+), 35 deletions(-)"}