{"id":2221287,"url":"http://patchwork.ozlabs.org/api/1.0/covers/2221287/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","date":"2026-04-09T06:40:10","name":"[0/5] hw: Fix unit addresses of FDT CPU nodes","submitter":{"id":91053,"url":"http://patchwork.ozlabs.org/api/1.0/people/91053/?format=json","name":"Vivian Wang","email":"wangruikang@iscas.ac.cn"},"series":[{"id":499239,"url":"http://patchwork.ozlabs.org/api/1.0/series/499239/?format=json","date":"2026-04-09T06:40:10","name":"hw: Fix unit addresses of FDT CPU nodes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499239/mbox/"}],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frr1w4Lymz1yHG\n\tfor ; Thu, 09 Apr 2026 16:41:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAj4T-0007t4-3u; Thu, 09 Apr 2026 02:40:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAj4N-0007qv-PY; Thu, 09 Apr 2026 02:40:52 -0400","from smtp81.cstnet.cn ([159.226.251.81] helo=cstnet.cn)\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAj4H-0004PU-DK; Thu, 09 Apr 2026 02:40:50 -0400","from [127.0.0.2] (unknown [36.110.52.2])\n by APP-03 (Coremail) with SMTP id rQCowABnht3aSddpeI91DQ--.34096S2;\n Thu, 09 Apr 2026 14:40:27 +0800 (CST)"],"From":"Vivian Wang ","Subject":"[PATCH 0/5] hw: Fix unit addresses of FDT CPU nodes","Date":"Thu, 09 Apr 2026 14:40:10 +0800","Message-Id":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-B4-Tracking":"v=1; b=H4sIAMpJ12kC/y2N2wrCMBAFf6Xss1u2MXjpr0iFNF11hV7MpkUI/\n Xej9XFgzpwEykFYoS4SBF5EZRwyVLsC/MMNd0bpMoMhcyBLZ7zJG+dBIrquC6yKxnjaW3L2SCf\n Isylwdn7JS7Oxzu2Tffx2/kbg15y/4qZB65TRj30vsS6WqiqpJAzeXNMKzbp+AA5FGqimAAAA","X-Change-ID":"20260409-fix-unit-address-22c0340a4708","To":"qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org,\n Vivian Wang ","X-Mailer":"b4 0.15.1","X-CM-TRANSID":"rQCowABnht3aSddpeI91DQ--.34096S2","X-Coremail-Antispam":"1UD129KBjvJXoW7Aw4xKw18tw48Cw18KF1kAFb_yoW8CryrpF\n WxCFW5tryDKry7XanrXFsrXrWayFZ5Wa47KrnFkw4Fkw45XF17AFZak345XryYgr18GF4a\n yFnag3WkXFn5ZFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDU0xBIdaVrnRJUUU9Y14x267AKxVW5JVWrJwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02\n 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j\n 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc\n CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E\n 2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV\n W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2\n Y2ka0xkIwI1lc7CjxVAaw2AFwI0_GFv_Wryl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x\n 0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2\n zVAF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF\n 4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU\n CwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCT\n nIWIevJa73UjIFyTuYvjTRZDGYDUUUU","X-Originating-IP":"[36.110.52.2]","X-CM-SenderInfo":"pzdqw2pxlnt03j6l2u1dvotugofq/","Received-SPF":"pass client-ip=159.226.251.81;\n envelope-from=wangruikang@iscas.ac.cn; helo=cstnet.cn","X-Spam_score_int":"-41","X-Spam_score":"-4.2","X-Spam_bar":"----","X-Spam_report":"(-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Apply some pendantry to the node unit addresses of /cpus/cpu@*:\n\n / {\n cpus {\n cpu@??? /* <- here */ {\n reg = <10>; /* Equivalently, <0xa> */\n }\n };\n };\n\nAccording to de facto convention, as confirmed by DTSpec maintainers,\nthese unit addresses should be in hexadecimal [2], i.e. cpu@a instead of\ncpu@10. Currently apparently everything uses decimal which is wrong.\n\nhw/arm/{sbsa-ref,virt} have an additional problem where the unit address\ndoesn't match up with the reg value. Fix that also.\n\nI've tried to use the types of existing variables / return values, hence\nthe slightly different patterns in these patches:\n\n int cpu; -> \"cpu@%x\", (unsigned)cpu [easy case]\n uint64_t mpidr; -> \"cpu@%\" PRIx64, mpidr\n uint32_t hartid_base; int cpu; -> \"cpu@%\" PRIx32, hartid_base + (uint32_t)cpu\n\n[1]: https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst#devicetree-structure-and-conventions\n[2]: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/\n\n---\nVivian Wang (5):\n hw/arm: Fix unit addresses of FDT CPU nodes\n hw/loongarch: Use hex unit addresses in FDT CPU nodes\n hw/mips: Use hex unit addresses in FDT CPU nodes\n hw/or1k: Use hex unit addresses in FDT CPU nodes\n hw/riscv: Use hex unit addresses in FDT CPU nodes\n\n hw/arm/sbsa-ref.c | 4 ++--\n hw/arm/virt.c | 7 +++++--\n hw/loongarch/virt-fdt-build.c | 4 ++--\n hw/mips/boston.c | 2 +-\n hw/or1k/or1k-sim.c | 2 +-\n hw/or1k/virt.c | 2 +-\n hw/riscv/sifive_u.c | 9 +++++----\n hw/riscv/spike.c | 4 ++--\n hw/riscv/virt.c | 4 ++--\n 9 files changed, 21 insertions(+), 17 deletions(-)\n---\nbase-commit: b6a7d06213e5d2f7d124d16418bc289c4a8a4b82\nchange-id: 20260409-fix-unit-address-22c0340a4708\n\nBest regards,\n-- \nVivian \"dramforever\" Wang"}