{"id":2220118,"url":"http://patchwork.ozlabs.org/api/1.0/covers/2220118/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260406115247.4879-1-armenon@redhat.com>","date":"2026-04-06T11:52:45","name":"[0/2] migration/vmstate: Add VMState support to safely migrate GByteArray","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.0/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"series":[{"id":498846,"url":"http://patchwork.ozlabs.org/api/1.0/series/498846/?format=json","date":"2026-04-06T11:52:45","name":"migration/vmstate: Add VMState support to safely migrate GByteArray","version":1,"mbox":"http://patchwork.ozlabs.org/series/498846/mbox/"}],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Q3rW8pnQ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=ogyaT7oO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fq75J3NJqz1y2d\n\tfor ; Mon, 06 Apr 2026 21:53:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w9iVs-0002UY-2O; Mon, 06 Apr 2026 07:53:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9iVq-0002T0-38\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 07:53:02 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9iVn-0002Lq-K7\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 07:53:01 -0400","from mail-pf1-f200.google.com (mail-pf1-f200.google.com\n [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-112-gi1fMrRRPzSu0XsmP1ljvw-1; Mon, 06 Apr 2026 07:52:56 -0400","by mail-pf1-f200.google.com with SMTP id\n d2e1a72fcca58-82cf0130d17so2311820b3a.3\n for ; Mon, 06 Apr 2026 04:52:56 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([152.59.100.215])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82d12218738sm11547849b3a.21.2026.04.06.04.52.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 04:52:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775476377;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=zThpZTEm2BOIXiICjqzxb0BZkmkd4/Oeo2wTkaOtud8=;\n b=Q3rW8pnQ5kISM6VKzexpdc0hAdD6O7qrWtMHn2nXoo+NJXww3er4zwNpyQZfnyjbb5ZFvr\n 1PnbCbcSxxNDpNMs7Mb+xhGL+npZsxyJqVczpPurLbMQi9hCY2vxjlm2kPZOSGvYArrHoR\n mS6SoGAdQ+RXXx+yjPGnmtRKU+atZ+Q=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775476375; x=1776081175; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=zThpZTEm2BOIXiICjqzxb0BZkmkd4/Oeo2wTkaOtud8=;\n b=ogyaT7oOd7yNVPDuBhEbe3VsuTVBh0ndMr9BdRH1l4iQNhuXJbUUzrraSgF+JA0kKU\n lWQwDdTiE3OfJ0/pH/HCeaZenVAH1HRCu4LJmIBw1QHr1+0hW9cDBLKEpgvFqkxcfRGV\n XKvjtY+VW4bGfjMWrgkZ/Jdcss95RE1oAbjVNL0zD8S2ObT9ihOj3Gi2FV3rP3vwY4Kg\n zex1UXV/KqGPUmFX+uOCy06ht+Usm1tkjo7KwKrUeWwmY3LQ0Bxg+8+qIjSuAUm8oSho\n 9YMCj/346wqphbDZFGmMETHnGxaKXv1a+zJjBMZ9rB6PaK/8/PQ7Dz185SEdBEiXYGLY\n MmKg=="],"X-MC-Unique":"gi1fMrRRPzSu0XsmP1ljvw-1","X-Mimecast-MFC-AGG-ID":"gi1fMrRRPzSu0XsmP1ljvw_1775476375","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775476375; x=1776081175;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zThpZTEm2BOIXiICjqzxb0BZkmkd4/Oeo2wTkaOtud8=;\n b=aMC7uErfKV7A3RdXnRRxJr4YGZdpAkM+i/hH/CZfPmR3hFXauyh6hP2nFTrlVoanwE\n Wr58TZyNgckKGs/pCxyhnGPACLyh7Gz0UjqRBdn24SCK7zIkEI1IK2BJ16eun3iYRMQc\n ynFZOqIOBPdEQ+zbQSnaxHBH0rcR4ku0gRBi9NkBqiGxnxgyOqR/WDtfyLUuKH9Rm4yG\n WpjOInr6iCsL/j1j7Q/5mYLg0XhGQD6Ka3dSwBAuHO+bFUOhbMWsWEM9H1PQttfCl5DW\n gBmuXRczePsBk1NsmLuE8yN9GQ+/XOHquZQo+QWfZbm7f92I/AWE93GiIuH5/wBKl1qh\n LXjQ==","X-Gm-Message-State":"AOJu0YyWCosiUCzp+MAiTgvk/qny65Ic5jhbGmlG4YqJBKNc8m57Lv9N\n HQQ7D9bINRhnnlbI1C84CwcS8TQ5XyX3usV8Bu5YXb/xqHaqI6Lay2cGJe7IzyHfFm7Jl33Ufzj\n DUdMYK+JxRo4zTN6Njxalpgv9LB7Mpt2AsQdXYHw6dKUtNIvdMv6JhLRhmr3JvHCi/VPVpLIfrp\n 5ciMRnBMw+9NtFGGKFzdKeShngrv59HCp7klkHzSA=","X-Gm-Gg":"AeBDieuHuLFe01HhQoFst/+sBJDk78jaEn2zMjt4xbTwIXJSwXFHlkohCUpCOmMmrrQ\n 8YfTr8HnSu7brMXM4+KowO2spb1PsPvivmjfUHKelkGSY42twO3VDEGovgul71ICqg7R5W80R4U\n Ys3uNMqg7vcg0gOsxXSeF8si+Ap/OQxWOCacWdIKUi9VYwaroAKkb5uZIeK2D2LTYik3iWSHPit\n m5VTKe6iBtLF80heXAQMxpXtC91zoV18liPa3DlAxoP4qZ5jnG4k8zq89byhJNEmyMqCOZPgcWK\n 8rSBVa1wajv1NtbeAOGBMAnEg+utYkVUggcSzTvw1UW+QZwFQXOuugCu0OFq8o6mnx0eUzC4ab5\n QBg+aKnU5952uPusAqeoiTybwwLo+H9ev546yKv47exWM0v5OIZzgfwfGBGGTqX2ZN3ks","X-Received":["by 2002:a05:6a00:2d12:b0:82a:6166:3a9c with SMTP id\n d2e1a72fcca58-82d0db71f37mr11762546b3a.29.1775476374950;\n Mon, 06 Apr 2026 04:52:54 -0700 (PDT)","by 2002:a05:6a00:2d12:b0:82a:6166:3a9c with SMTP id\n d2e1a72fcca58-82d0db71f37mr11762511b3a.29.1775476374327;\n Mon, 06 Apr 2026 04:52:54 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Fabiano Rosas ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Arun Menon ","Subject":"[PATCH 0/2] migration/vmstate: Add VMState support to safely migrate\n GByteArray","Date":"Mon, 6 Apr 2026 17:22:45 +0530","Message-ID":"<20260406115247.4879-1-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In GLib, GByteArray is an object managed by the library. Currently,\nmigrating a GByteArray requires treating it as a raw C struct and using\nVMSTATE_VBUFFER_ALLOC_UINT32. For example, see vmstate_vdba in\nui/vdagent.c\n\nQEMU cannot pretend that GByteArray is a C struct and simply use\nVMS_ALLOC to g_malloc() the buffer. This is because, VMS_ALLOC blindly\noverwrites the data pointer with a newly allocated buffer, thereby\nleaking the previous memory. Besides, GLib tracks the array's capacity\nin a hidden alloc field. Bypassing GLib APIs leave this capacity out of\nsync with the newly allocated buffer, potentially leading to heap buffer\noverflows during subsequent g_byte_array_append() calls.\n\nThis series adds a new VMState called VMSTATE_GBYTEARRAY, which will\ndirectly use GLib library API calls to create, or resize the object.\nThis is then used in ui/vdaagent.c replacing the use of\nVMSTATE_VBUFFER_ALLOC_UINT32.\n\nArun Menon (2):\n migration/vmstate: Add VMState support for GByteArray\n ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate outbuf\n\n include/migration/vmstate.h | 10 ++++++++++\n migration/vmstate-types.c | 37 +++++++++++++++++++++++++++++++++++++\n ui/vdagent.c | 13 +------------\n 3 files changed, 48 insertions(+), 12 deletions(-)"}