{"id":2196935,"url":"http://patchwork.ozlabs.org/api/1.0/covers/2196935/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216160349.3079657-1-peter.maydell@linaro.org>","date":"2026-02-16T16:03:47","name":"[0/2] target/arm: Don't use HELPER_H in non-tcg files","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.0/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"series":[{"id":492324,"url":"http://patchwork.ozlabs.org/api/1.0/series/492324/?format=json","date":"2026-02-16T16:03:48","name":"target/arm: Don't use HELPER_H in non-tcg files","version":1,"mbox":"http://patchwork.ozlabs.org/series/492324/mbox/"}],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bzBU40EZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF70D0Cdqz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 03:05:16 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vs14y-00029M-K7; Mon, 16 Feb 2026 11:04:09 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1vs14l-00027S-6J\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 11:03:56 -0500","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1vs14j-0005n1-3c\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 11:03:54 -0500","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-48069a48629so31818125e9.0\n for <qemu-devel@nongnu.org>; Mon, 16 Feb 2026 08:03:52 -0800 (PST)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4835d92267bsm661713185e9.0.2026.02.16.08.03.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 16 Feb 2026 08:03:50 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771257831; x=1771862631; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=dJImaBRf1UQRC+k31lYt80mk2JUrwPwtKKmyLVRtziA=;\n b=bzBU40EZZZz7YLGYGl2psVSkoDoyfgw8qG0t9eBSEkHu/H2QLzU6jA/K2hw03DgY5n\n BT6CitBO2MrpALiDqWEhO78oYYCf72MYnaMsUMVeXtCsACJQqYx0Sn9jkeBmekA4cR3a\n zoUnrulQ0eIRUpDC7bKrg5H28oSDQsDCA5xLnHHzffntXp5T7DtS7dUF/Q4vCN2Kssmn\n Y/uD4awQ8/SI/VG/oWgcAWM1akw8GVLgZ6L9KSayRCpFFWrUmysohsziJxuN4XkLoLZU\n Rv3kWRo4+auReR1Q8BJfY4aogSiiccGxpNPuKvBj8mAgB+dutM17qiYVeqTpSuCG4wjV\n Jr2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771257831; x=1771862631;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dJImaBRf1UQRC+k31lYt80mk2JUrwPwtKKmyLVRtziA=;\n b=axrTbOonXyUz0MrtrQEOA52cbRp1Bke+mli7JTxRZIWVyzWApnVmSJ+lUCyaWo+L2w\n PhADxAKalRZ6eRZVMze6hE96Vi1bdOmscDdGeN6c3VgrNRfnYu9SWH8wNxM6zQhfVm8p\n M6s8BUAK1ogEEYCZ5RkgqkUl1rNXgyNGY5+8jryGq7hwQHCF6XaJhFSrlzf3H2U6l0z7\n qRS2IioZDbooaIvTXcSZ240dxW98wo+EglB6MCgwRYXAyBvRHlX+AWBuqvhD7pJUyoC9\n cgA+m5/3wPl+xYYdKU5StfHADp3q0Pwh8EkHi6JZ/FYDaAnO6J/qNPS6JJ2stpjU3S2a\n DuPw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWjPm98ady63DrWb90IlpUq23tXrMdioZs7lpmKyzfdqJ9tidSMWqNekBgfU0XO7NTKtD4jfw8abK1x@nongnu.org","X-Gm-Message-State":"AOJu0YxnpQtbzwOEc/mUKhFWINzPII5mTOIoOXAzFR5cJW0kg/LCPkiX\n gvSQudJPR07LtjsNq45S/mnZMDEWXwsSb9E7ZQUiPTxVjjpKlE0yfvDjJHkzbrLDg40=","X-Gm-Gg":"AZuq6aK00PkZdxZHySmOhxFPftypQMz1KlDEzdSfQpwrreH9YWa4EOkKjNgvu7Sa/4m\n tHozPD51+1WrYE7MvBrMHy8VScR4VHRBcZrLWUuJNOdhv8SSMWjVmchYsAjyd5+76UeLWdtKKZn\n 7mvZGvldgXeLnNgArb3mXMeHiFQiXQDzfS71j1x3Qhq7Vq81WwZ0qiAxk4/4aMWZnAFyr012Gvh\n E+UpATeYsaRTCJONR0SHCn2SjqSYmQZYRuptema07sxgOZS7gb0/2cGhYNMUK/c5Knv/dZnTL7C\n LMcd9aB6DJp1Z2811s0m+eiBvak3GGk4o92Cm0CIizXd+drUsh2DPenaYgCv/MtcuwzBf/yOXdV\n b8uKzBnuv/ZV0LjH8a1WWRk0pb2tyhfD1I57w2a7y17toW2odBVQfiNnn0zKrYdUZrzwIWqHE+A\n DCSvZwLgYRu7xW1CnPYuElIhACa5x1SZx0zPMN3Vk2PFWsizyGivQxL8ogj8fxWKeEBZWvBoZZD\n 4B8adzVddcYv9pRsi7128DCrzpGiVo=","X-Received":"by 2002:a05:600c:3e87:b0:480:32da:f338 with SMTP id\n 5b1f17b1804b1-48373a0f961mr165584795e9.14.1771257831360;\n Mon, 16 Feb 2026 08:03:51 -0800 (PST)","From":"Peter Maydell <peter.maydell@linaro.org>","To":"qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","Cc":"Pierrick Bouvier <pierrick.bouvier@linaro.org>","Subject":"[PATCH 0/2] target/arm: Don't use HELPER_H in non-tcg files","Date":"Mon, 16 Feb 2026 16:03:47 +0000","Message-ID":"<20260216160349.3079657-1-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This patchset gets rid of a couple of uses of HELPER_H to pull in the\nTCG helper function prototypes in files that aren't in\ntarget/arm/tcg:\n\n - debug_helper.c has a lot of TCG only code that can\n   happily live in a new tcg/debug.c file instead, and only\n   the CONFIG_TCG code was using the helper prototypes\n - helper.c was calling exactly one TCG helper function\n   directly, and can be made to call a different function\n   instead for the same effect\n\nPierrick: these might be helpful for you with getting the target/arm\nsingle-binary series to compile when TCG is disabled.  I think it\nmight be best to avoid having a single helper.h that gives both the\nhelper_foo and the gen_helper_foo prototypes, though: even if it\ndoesn't cause compilation failures, only translate*.c need all the\ninline definitions of gen_helper_foo. If you take that approach\nthen it would fix the compile errors without needing these patches.\n\n(I did wonder if we could move target/arm/helper.h into the\ntcg/ subdirectory, since it really is TCG-specific, but it looks\nlike the machinery in include/exec/helper* assumes that the target\nhas a helper.h in its top level directory.)\n\nthanks\n-- PMM\n\nPeter Maydell (2):\n  target/arm: Move TCG-specific code out of debug_helper.c\n  target/arm: Don't require helper prototypes in helper.c\n\n target/arm/debug_helper.c                  | 769 ---------------------\n target/arm/helper.c                        |   5 +-\n target/arm/{debug_helper.c => tcg/debug.c} | 542 +--------------\n target/arm/tcg/meson.build                 |   2 +\n 4 files changed, 4 insertions(+), 1314 deletions(-)\n copy target/arm/{debug_helper.c => tcg/debug.c} (53%)"}