From patchwork Thu Mar 28 14:32:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 1068276 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="r0xfSWoo"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44VS522mKxz9sRG for ; Fri, 29 Mar 2019 01:32:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbfC1Och (ORCPT ); Thu, 28 Mar 2019 10:32:37 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:58392 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbfC1Och (ORCPT ); Thu, 28 Mar 2019 10:32:37 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2SEOLjN056694; Thu, 28 Mar 2019 14:32:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=yXPNHjCTuGhXAM1dp2v6KQFQi8vaetS8PzVQ4oL8PEU=; b=r0xfSWooUZeyIVjCS+9iR63+CtEJi7FtgE3nNrKUxC0LJkbuf7zYPAwBa1T1pW4T/Vr0 GcCiBBakWaPSlUU0+R0BnnpCDIdZDcWzmI7NFf1ApLB0vTO9irsSto0UNI1HKnA35ntj sS3Y+SyOJ7qXsmvYdEsr8WgSIEF8uOieqSQrptfVwdsR8K7lcSdYFpKbnTAFkgzVW5qI QO+iKoAP/8wnQicB5Novoo9cC0ylB3Eeyt39FoJiTNjq+TuxHQFeNqSWUYTDaQbEA4TL KCJDEKHLmdzdaniiIF9JqvVBz3mE7QAJLgqNMXgFiu6ktkkTSXhzl5yOMkNogbw2KcjI Ng== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2re6djq0w8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2019 14:32:32 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2SEWVnf023191 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2019 14:32:31 GMT Received: from abhmp0022.oracle.com (abhmp0022.oracle.com [141.146.116.28]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2SEWUTw008844; Thu, 28 Mar 2019 14:32:30 GMT Received: from kadam (/41.202.241.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 28 Mar 2019 07:32:30 -0700 Date: Thu, 28 Mar 2019 17:32:15 +0300 From: Dan Carpenter To: JC Kuo Cc: Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] phy: tegra: xusb: testing the wrong variable in probe() Message-ID: <20190328143214.GP32590@kadam> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9208 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903280098 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org The "usb2->clk" pointer is not an error pointer. We meant to test "priv->usb2_trk_clk" instead. Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support") Signed-off-by: Dan Carpenter --- drivers/phy/tegra/xusb-tegra186.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c index 11ad6e4e4711..a627fe0b8e54 100644 --- a/drivers/phy/tegra/xusb-tegra186.c +++ b/drivers/phy/tegra/xusb-tegra186.c @@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl, } priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk"); - if (IS_ERR(usb2->clk)) { - err = PTR_ERR(usb2->clk); + if (IS_ERR(priv->usb2_trk_clk)) { + err = PTR_ERR(priv->usb2_trk_clk); dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err); goto unregister; }