From patchwork Sat Mar 23 22:33:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 1062645 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="BagOUe1t"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44Rb0m26KSz9sSq for ; Sun, 24 Mar 2019 09:34:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727628AbfCWWdr (ORCPT ); Sat, 23 Mar 2019 18:33:47 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:33972 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726823AbfCWWdr (ORCPT ); Sat, 23 Mar 2019 18:33:47 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id E58ABCE6 for ; Sat, 23 Mar 2019 22:33:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ocXf7_YLDeOq for ; Sat, 23 Mar 2019 17:33:45 -0500 (CDT) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id BC916CB8 for ; Sat, 23 Mar 2019 17:33:45 -0500 (CDT) Received: by mail-io1-f70.google.com with SMTP id b199so4880443iof.14 for ; Sat, 23 Mar 2019 15:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=Psj+9E0ZGFt1heJVKpqtu9ZsCWPx1khP7AIh+OGqXtE=; b=BagOUe1tyzkSzznenoK/C0wGDpzYl7eEpW/6VFkmj2RHxXkNEV4Crchekq6U2ySgte YIgLO8mVDBlBw4fqXnOCTa+QLNNCecwWUwQKoOf88KGE0mEBgyYYlQoFMiP/pn3u4vyA GKtAwZROhZIdEai1eyUN9ZbFVZfQe2LDbnYcSnxXCsrsAZo1qpXQ2yMA1Tz8QWdFWBBZ t5pPVTAv2gc17X7m3tRup9lTM1sfYLIyN8J7s+GfGN9mHEd8Du41rgxKtDbXDKea5Zr/ 4JhBAmGXFfYZX8A3c0tO++GiObJpGal51opOO4t5AtdNPT2Fd5itRDuR9tt+DdcNq+/X r1vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Psj+9E0ZGFt1heJVKpqtu9ZsCWPx1khP7AIh+OGqXtE=; b=EWTUW/zcLCi6sogxURXAAxFXuQXbmIfb5ELbHGyE4nkrNbgRnIMezBQafMC7Md0LSc I2l/hksJUXOBQAJhnP4OfhChtmLlZkOETbK3MFFNOtyWsDxY97fTMA8e4WqAD6oW1+Gx 0zJItxERqdwf5i7yW0s7yLytEZo2N/UWlhF0CSwIA9eVnfCkGF+S0+kymR7i6bvI34bP fLnN1m0UFOHpyDBi8I6RM6aeVZTJeipzyfwEhAUycyJmU5M5MR/w8AxFesngUFgD/Z4M g+OSwZa5e+qttD5CN4x1RqEUWIUCHZK7FT2z5ZqBxFb20asM4FuPnNxYWWKn2i1BbcPp A7AQ== X-Gm-Message-State: APjAAAV9jqcCauEWW6owo0Xlf4zVu3ZJybQp7fuvH9E1Osbjt0pIIj4r JKmQSefPqZIreRDR9JgQCNUzS+IMotrggBuwt+pso7OF9m13l1+TOGvtJJCDN9YWS3/tREXN01L 1jWxTdXamkwIG7lxZMb65 X-Received: by 2002:a24:9a86:: with SMTP id l128mr3362043ite.12.1553380425316; Sat, 23 Mar 2019 15:33:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwI92qwFiQVbGu3E57gI4WuOC3+XyW1LN6US+lDwUzzD62LTxJtB9AQCjhnPPyp2GAt79tBow== X-Received: by 2002:a24:9a86:: with SMTP id l128mr3362028ite.12.1553380424978; Sat, 23 Mar 2019 15:33:44 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id 71sm3443185itm.31.2019.03.23.15.33.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 15:33:43 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Amitkumar Karwar , Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: mwifiex: fix a missing check of ssid Date: Sat, 23 Mar 2019 17:33:39 -0500 Message-Id: <20190323223339.13703-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org sme->ssid may be invalid and thus should be checked. The fix adds such a check and returns an error if it is invalid. Signed-off-by: Kangjie Lu --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index c46f0a54a0c7..a46820cf609f 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -2343,6 +2343,12 @@ mwifiex_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev, struct mwifiex_adapter *adapter = priv->adapter; int ret; + if (!sme->ssid) { + mwifiex_dbg(adapter, ERROR, + "%s: Invalid ssid\n", dev->name); + return -EOPNOTSUPP; + } + if (GET_BSS_ROLE(priv) != MWIFIEX_BSS_ROLE_STA) { mwifiex_dbg(adapter, ERROR, "%s: reject infra assoc request in non-STA role\n",