From patchwork Sat Mar 23 18:48:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1062427 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oG+dFl0g"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44RV1606Qfz9sSk for ; Sun, 24 Mar 2019 05:48:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727680AbfCWSs4 (ORCPT ); Sat, 23 Mar 2019 14:48:56 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41917 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727482AbfCWSs4 (ORCPT ); Sat, 23 Mar 2019 14:48:56 -0400 Received: by mail-pg1-f196.google.com with SMTP id k11so3675102pgb.8 for ; Sat, 23 Mar 2019 11:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZZjcTW3892nsIa6VKnxtwVlhxl6xMKmpBHtDput5NkM=; b=oG+dFl0gGf1YQCJCQoWGMiGTQxGP1j0k6k6RTTruHlEuksls/IBgfPrKNn3uUMFTxN J5Z4y7Gv/kww3/jSKkDg3JqxHbixFrPgVKL/SDzlcUuJKVZCywpYtmUJL0dzESvo5pXO SmwjFlbi/RDmdxY48OhtY/REgQBti0ddgE9KncwSfQiUtGKiQzyyOYnBEHnSLjLqvN8G yN2FhNRBGOx69caRLvwaXalb1Rv35O0S13rUzCCRwXGFLQFirGiS1gnQYhhCSPu3KaH7 r7Lb8sVcJTP0dEZO/ewmgaGu/cyTSaPQLSRsrrKiA27ZlhiiePXvE5NpsQbo0DAr6/+5 65CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZZjcTW3892nsIa6VKnxtwVlhxl6xMKmpBHtDput5NkM=; b=hIgDuqbAnfjwDqFsusfLRBER40U+iDvbvqsRdcSyizp51nyfmCuj/JBJaONbPMrTnj kEVv7HPrFrE6b9LnI5hUK0cEH1//Hz5TgKqmq10Xkl8zk3WNGQL8cmJrKFWaeMUlbkIj E9tLiOIXEmkR1b998gvjKCT3OTOLzELW3r6GLVQMqQvfqGhTdw+sqIbyzOrGxBvckXM8 DMtSgtQptoiu47md4r5BZ3oVDkJ+ATJXLfpX3W0euu9HvBliwArNhztgu5Rq/+Tz+TIs O3yDSZDbfiwIehHR/eur13G0V+TpUnCH4oh1jPM7Fi9rnpLd0oJzPoaUJ6gAs2yadVjJ DGFg== X-Gm-Message-State: APjAAAXvBwbJYnA+U2HprdfrxqYNMRusZjg6tTgZBVo1Xt/Zqecscfzn XtXVi8pWbho3dUmsRw2a2IQ= X-Google-Smtp-Source: APXvYqytrQZs5VISae5I6SLp50+hO4Hl3lJnTn4RCcu5wrvjLNOIDHGBGAwkq4U053/TdNjTbCBCVg== X-Received: by 2002:a62:70c9:: with SMTP id l192mr15824331pfc.207.1553366935352; Sat, 23 Mar 2019 11:48:55 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:3696:3444:cc23:4d6e:cb11:535b]) by smtp.gmail.com with ESMTPSA id m3sm12784688pgp.85.2019.03.23.11.48.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 11:48:54 -0700 (PDT) From: Leslie Monis To: stephen@networkplumber.org Cc: netdev@vger.kernel.org, Leslie Monis Subject: [PATCH iproute2 1/2] tc: pie: change maximum integer value of tc_pie_xstats->prob Date: Sun, 24 Mar 2019 00:18:34 +0530 Message-Id: <20190323184835.20456-2-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190323184835.20456-1-lesliemonis@gmail.com> References: <20190323184835.20456-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org tc_pie_xstats->prob has a maximum value of (2^64 - 1). Signed-off-by: Leslie Monis --- tc/q_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_pie.c b/tc/q_pie.c index f7924ef5..6566ca10 100644 --- a/tc/q_pie.c +++ b/tc/q_pie.c @@ -198,7 +198,7 @@ static int pie_print_xstats(struct qdisc_util *qu, FILE *f, st = RTA_DATA(xstats); /*prob is returned as a fracion of maximum integer value */ fprintf(f, "prob %f delay %uus avg_dq_rate %u\n", - (double)st->prob / (double)0xffffffff, st->delay, + (double)st->prob / (double)0xffffffffffffffff, st->delay, st->avg_dq_rate); fprintf(f, "pkts_in %u overlimit %u dropped %u maxq %u ecn_mark %u\n", st->packets_in, st->overlimit, st->dropped, st->maxq, From patchwork Sat Mar 23 18:48:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1062428 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hgwYGHcT"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44RV1C28dxz9sST for ; Sun, 24 Mar 2019 05:49:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727713AbfCWStA (ORCPT ); Sat, 23 Mar 2019 14:49:00 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:37388 "EHLO mail-pg1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727482AbfCWSs7 (ORCPT ); Sat, 23 Mar 2019 14:48:59 -0400 Received: by mail-pg1-f172.google.com with SMTP id q206so3691832pgq.4 for ; Sat, 23 Mar 2019 11:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iiryz0ELfumuLArCGTnnhiqYK/oau0SyEDffDSyhiSc=; b=hgwYGHcTKIXe+uuVjk3tKuEAnsPIrfwYFrfd2cW5EAsB/WJwgXO4JZuA7wAO9xIE91 WsxuBSZRx8S4cfdo+cuyFAJlxpTJuuqL98PVON5GwExwNsKTq2+vX8kKTeZOUz3+d82a m6A7wJ3WKK3Xk0SPunDNvHPj/0awF17YirYPpNUwn+gcdF6ZOhR4I9sr6KO992RNOGjQ ZBx9R23TkRbOfD8Q2/JHvCVNkfcSY59liiiKT3EvVw9PL9fj+qeyzjqreILbu5flR6VA +f79nqpIas6EaVx6quz/vpoZqeGI6xbq+WWCUTGAc0ZU39juHvYLo3ET2K8K5t6/VoO2 IHrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iiryz0ELfumuLArCGTnnhiqYK/oau0SyEDffDSyhiSc=; b=nufNLxj/xbV39ptQ3TUnNmZYrc/ujMCAed/8AA1+sHi8TtvQ1eGAN6ua+eLOz23Ib5 +GWhmE74fhXBAECzz+FWvm4x0RD+dZcXGyOSOfZAMu9IhTqsJUL1stzqiU/fo+UZ7cqp iuUlaEh3pJEVsO+n6yRSZBdrACKbbxK8ZpKkZOstKklM6x0qjBLlyUmhaNnwhHlfp3Wg 9nv9kx1bD6nHyOyxg5kJ8+kAMC+dr/HBb3ub7GpEc25GuR9t8kO1SOCKghc8qNvZCqbm px1Xby1Hwuu7d77brsBZeivTzVZIzIyGXCVkJkUgUwPS2qQIqlggdr6NukEClSDeOb6b 8BRw== X-Gm-Message-State: APjAAAVn9LKwGnKv9a0uKA9kuZ2qGuKeu7XNWyBT8JypXR86FkTE9Jng sYXJTTjqovm7LCz/syZBG68= X-Google-Smtp-Source: APXvYqzHKHfls3QJ1aXlH/vtV/8m6YKDTiuCZ76kLE/eEWKZIpemc6qjIbbd5B/mME5UHxzSnOYJuQ== X-Received: by 2002:a62:cd8c:: with SMTP id o134mr15571213pfg.84.1553366938826; Sat, 23 Mar 2019 11:48:58 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:3696:3444:cc23:4d6e:cb11:535b]) by smtp.gmail.com with ESMTPSA id m3sm12784688pgp.85.2019.03.23.11.48.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 11:48:58 -0700 (PDT) From: Leslie Monis To: stephen@networkplumber.org Cc: netdev@vger.kernel.org, Leslie Monis Subject: [PATCH iproute2 2/2] tc: pie: update man page Date: Sun, 24 Mar 2019 00:18:35 +0530 Message-Id: <20190323184835.20456-3-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190323184835.20456-1-lesliemonis@gmail.com> References: <20190323184835.20456-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Update man page to reflect the changes made in Linux. Signed-off-by: Leslie Monis --- man/man8/tc-pie.8 | 40 ++++++++++++++++++---------------------- man/man8/tc.8 | 1 + 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/man/man8/tc-pie.8 b/man/man8/tc-pie.8 index 278293bd..a302132f 100644 --- a/man/man8/tc-pie.8 +++ b/man/man8/tc-pie.8 @@ -60,10 +60,10 @@ limit on the queue size in packets. Incoming packets are dropped when this limit is reached. Default is 1000 packets. .SS target -is the expected queue delay. The default target delay is 20ms. +is the expected queue delay. The default target delay is 15ms. .SS tupdate -is the frequency at which the system drop probability is calculated. The default is 30ms. +is the frequency at which the system drop probability is calculated. The default is 15ms. .SS alpha .SS beta @@ -91,29 +91,27 @@ is turned off. .SH EXAMPLES # tc qdisc add dev eth0 root pie # tc -s qdisc show - qdisc pie 8034: dev eth0 root refcnt 2 limit 200p target 19000us tupdate 29000us alpha 2 beta 20 - Sent 7443524 bytes 7204 pkt (dropped 900, overlimits 0 requeues 0) - backlog 38998b 37p requeues 0 - prob 0.123384 delay 25000us avg_dq_rate 1464840 - pkts_in 7241 overlimit 900 dropped 0 maxq 186 ecn_mark 0 + qdisc pie 8036: dev eth0 root refcnt 2 limit 1000p target 15.0ms tupdate 16.0ms alpha 2 beta 20 + Sent 31216108 bytes 20800 pkt (dropped 80, overlimits 0 requeues 0) + backlog 16654b 11p requeues 0 + prob 0.006161 delay 15666us avg_dq_rate 1159667 + pkts_in 20811 overlimit 0 dropped 80 maxq 50 ecn_mark 0 # tc qdisc add dev eth0 root pie limit 100 target 20ms tupdate 30ms ecn # tc -s qdisc show - qdisc pie 8036: dev eth0 root refcnt 2 limit 200p target 19000 tupdate 29000 alpha 2 beta 20 ecn - Sent 2491922 bytes 2507 pkt (dropped 214, overlimits 0 requeues 0) - backlog 33728b 32p requeues 0 - prob 0.102262 delay 24000us avg_dq_rate 1464840 - pkts_in 2468 overlimit 214 dropped 0 maxq 192 ecn_mark 71 - + qdisc pie 8036: dev eth0 root refcnt 2 limit 100p target 20.0ms tupdate 32.0ms alpha 2 beta 20 ecn + Sent 6591724 bytes 4442 pkt (dropped 27, overlimits 0 requeues 0) + backlog 18168b 12p requeues 0 + prob 0.008845 delay 11348us avg_dq_rate 1342773 + pkts_in 4454 overlimit 0 dropped 27 maxq 65 ecn_mark 0 # tc qdisc add dev eth0 root pie limit 100 target 50ms tupdate 30ms bytemode # tc -s qdisc show - qdisc pie 8036: dev eth0 root refcnt 2 limit 200p target 19000 tupdate 29000 alpha 2 beta 20 ecn - Sent 2491922 bytes 2507 pkt (dropped 214, overlimits 0 requeues 0) - backlog 33728b 32p requeues 0 - prob 0.102262 delay 24000us avg_dq_rate 1464840 - pkts_in 2468 overlimit 214 dropped 0 maxq 192 ecn_mark 71 - + qdisc pie 8036: dev eth0 root refcnt 2 limit 100p target 50.0ms tupdate 32.0ms alpha 2 beta 20 bytemode + Sent 1616274 bytes 1137 pkt (dropped 0, overlimits 0 requeues 0) + backlog 13626b 9p requeues 0 + prob 0.000000 delay 0us avg_dq_rate 0 + pkts_in 1146 overlimit 0 dropped 0 maxq 23 ecn_mark 0 .SH SEE ALSO .BR tc (8), @@ -121,9 +119,7 @@ is turned off. .BR tc-red (8) .SH SOURCES - o IETF draft submission is at http://tools.ietf.org/html/draft-pan-tsvwg-pie-00 - o IEEE Conference on High Performance Switching and Routing 2013 : "PIE: A -Lightweight Control Scheme to Address the Bufferbloat Problem" + o RFC 8033: https://tools.ietf.org/html/rfc8033 .SH AUTHORS PIE was implemented by Vijay Subramanian and Mythili Prabhu, also the authors of diff --git a/man/man8/tc.8 b/man/man8/tc.8 index f98398a3..ab0bad8a 100644 --- a/man/man8/tc.8 +++ b/man/man8/tc.8 @@ -848,6 +848,7 @@ was written by Alexey N. Kuznetsov and added in Linux 2.2. .BR tc-mqprio (8), .BR tc-pfifo (8), .BR tc-pfifo_fast (8), +.BR tc-pie (8), .BR tc-red (8), .BR tc-route (8), .BR tc-sfb (8),