From patchwork Sun Mar 17 09:34:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 1057494 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44MZ0m74wxz9s9N for ; Sun, 17 Mar 2019 20:35:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbfCQJe4 (ORCPT ); Sun, 17 Mar 2019 05:34:56 -0400 Received: from sauhun.de ([88.99.104.3]:52538 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726333AbfCQJe4 (ORCPT ); Sun, 17 Mar 2019 05:34:56 -0400 Received: from localhost (ip-109-41-130-14.web.vodafone.de [109.41.130.14]) by pokefinder.org (Postfix) with ESMTPSA id 62E752C27DA; Sun, 17 Mar 2019 10:34:53 +0100 (CET) From: Wolfram Sang To: linux-pci@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Marek Vasut , Phil Edworthy , Wolfram Sang Subject: [PATCH] PCI: rcar: don't shadow the 'irq' variable Date: Sun, 17 Mar 2019 10:34:45 +0100 Message-Id: <20190317093445.7746-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org sparse rightfully says: drivers/pci/controller/pcie-rcar.c:741:30: warning: symbol 'irq' shadows an earlier one It doesn't affect the current code. But fix it now to avoid future surprises and for good coding style. Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman --- Only build tested. drivers/pci/controller/pcie-rcar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c index 7002e9ad0b81..f513058e3a70 100644 --- a/drivers/pci/controller/pcie-rcar.c +++ b/drivers/pci/controller/pcie-rcar.c @@ -738,15 +738,15 @@ static irqreturn_t rcar_pcie_msi_irq(int irq, void *data) while (reg) { unsigned int index = find_first_bit(®, 32); - unsigned int irq; + unsigned int msi_irq; /* clear the interrupt */ rcar_pci_write_reg(pcie, 1 << index, PCIEMSIFR); - irq = irq_find_mapping(msi->domain, index); - if (irq) { + msi_irq = irq_find_mapping(msi->domain, index); + if (msi_irq) { if (test_bit(index, msi->used)) - generic_handle_irq(irq); + generic_handle_irq(msi_irq); else dev_info(dev, "unhandled MSI\n"); } else {